From 4c89e3622b32d798eb78c6dc140d22101681a76a Mon Sep 17 00:00:00 2001 From: David Eads Date: Fri, 17 Jan 2020 15:25:37 -0500 Subject: [PATCH] pods that are no longer running can still have logs --- pkg/cli/admin/inspect/pod.go | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/pkg/cli/admin/inspect/pod.go b/pkg/cli/admin/inspect/pod.go index 32bcd25b24..9f0e424fb4 100644 --- a/pkg/cli/admin/inspect/pod.go +++ b/pkg/cli/admin/inspect/pod.go @@ -17,11 +17,6 @@ import ( ) func (o *InspectOptions) gatherPodData(destDir, namespace string, pod *corev1.Pod) error { - if pod.Status.Phase != corev1.PodRunning { - klog.V(1).Infof(" Skipping container data collection for pod %q: Pod not running\n", pod.Name) - return nil - } - // ensure destination path exists if err := os.MkdirAll(destDir, os.ModePerm); err != nil { return err @@ -34,14 +29,6 @@ func (o *InspectOptions) gatherPodData(destDir, namespace string, pod *corev1.Po errs := []error{} - // skip gathering container data if containers are no longer running - if running, err := PodRunningReady(pod); err != nil { - return err - } else if !running { - klog.V(1).Infof(" Skipping container data collection for pod %q: Pod not running\n", pod.Name) - return nil - } - // gather data for each container in the given pod for _, container := range pod.Spec.Containers { if err := o.gatherContainerInfo(path.Join(destDir, "/"+container.Name), pod, container); err != nil {