add -eou pipefail to remaining job templates

Author: bparees

ci-operator/templates/openshift/endurance/endurance-install.yaml

@@ -80,7 +80,8 @@ objects:
       - /bin/bash
       - -c
       - |
-        #!/bin/bash -x
+        #!/bin/bash
+        set -euo pipefail
         
         # fetch the oc binary so we can talk to the cluster.  
         export PATH=$PATH:/tmp/shared/bin
@@ -153,7 +154,8 @@ objects:
       - /bin/bash
       - -c
       - |
-        #!/bin/bash -x
+        #!/bin/bash
+        set -euo pipefail
 
         export PATH=$PATH:/tmp/shared/bin
 
@@ -377,7 +379,8 @@ objects:
       - /bin/sh
       - -c
       - |
-        #!/bin/sh -x
+        #!/bin/bash
+        set -euo pipefail
 
         export PATH=$PATH:/tmp/shared/bin
 

ci-operator/templates/openshift/installer/cluster-launch-installer-custom-test-image.yaml

@@ -380,8 +380,8 @@ objects:
       - /bin/bash
       - -c
       - |
-        #!/bin/sh
-        set -e
+        #!/bin/bash
+        set -euo pipefail
 
         trap 'rc=$?; if test "${rc}" -eq 0; then touch /tmp/setup-success; else touch /tmp/exit /tmp/setup-failed; fi; exit "${rc}"' EXIT
         trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM
@@ -660,6 +660,8 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
+
         function queue() {
           local TARGET="${1}"
           shift

ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml

@@ -385,7 +385,7 @@ objects:
       - /bin/bash
       - -c
       - |
-        #!/bin/sh
+        #!/bin/bash
         set -euo pipefail
 
         trap 'rc=$?; if test "${rc}" -eq 0; then touch /tmp/setup-success; else touch /tmp/exit /tmp/setup-failed; fi; exit "${rc}"' EXIT
@@ -731,6 +731,8 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
+
         function queue() {
           local TARGET="${1}"
           shift

ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml

@@ -185,8 +185,9 @@ objects:
       - /bin/sh
       - -c
       - |
-        #!/bin/sh
+        #!/bin/bash
         set -euo pipefail
+
         trap 'rc=$?; if test "${rc}" -eq 0; then touch "${HOME}"/setup-success; else touch "${HOME}"/exit; fi; exit "${rc}"' EXIT
         trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM
         cat  > "${HOME}"/run-tests.sh << 'EOF'

ci-operator/templates/openshift/installer/cluster-launch-installer-metal-e2e.yaml

@@ -226,8 +226,10 @@ objects:
       - /bin/sh
       - -c
       - |
-        #!/bin/sh
-        set -ex
+        #!/bin/bash
+        set -euo pipefail
+        set -x
+        
         trap 'rc=$?; if test "${rc}" -eq 0; then touch /tmp/setup-success; else touch /tmp/exit /tmp/setup-failed; fi; exit "${rc}"' EXIT
         trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM
 
@@ -515,6 +517,8 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
+
         function queue() {
           local TARGET="${1}"
           shift

ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml

@@ -445,6 +445,8 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
+
         function queue() {
           local TARGET="${1}"
           shift

ci-operator/templates/openshift/installer/cluster-launch-installer-ovirt-e2e.yaml

@@ -323,7 +323,9 @@ objects:
       - /bin/sh
       - -c
       - |
-        #!/bin/sh
+        #!/bin/bash
+        set -euo pipefail
+
         trap 'rc=$?; if test "${rc}" -eq 0; then touch /tmp/setup-success; else touch /tmp/exit; fi; exit "${rc}"' EXIT
         trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM
         # Wait untill lease is acquired
@@ -449,6 +451,8 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
+
         function queue() {
           local TARGET="${1}"
           shift

ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml

@@ -243,7 +243,7 @@ objects:
       - /bin/bash
       - -c
       - |
-        #!/bin/sh
+        #!/bin/bash
         set -euo pipefail
 
         trap 'rc=$?; if test "${rc}" -eq 0; then touch /tmp/setup-success; else touch /tmp/exit /tmp/setup-failed; fi; exit "${rc}"' EXIT
@@ -566,6 +566,8 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
+
         function queue() {
           local TARGET="${1}"
           shift

ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml

@@ -338,8 +338,9 @@ objects:
       - /bin/sh
       - -c
       - |
-        #!/bin/sh
+        #!/bin/bash
         set -euo pipefail
+
         trap 'rc=$?; if test "${rc}" -eq 0; then touch /tmp/setup-success; else touch /tmp/exit /tmp/setup-failed; fi; exit "${rc}"' EXIT
         trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM
 
@@ -1855,6 +1856,7 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
 
         function queue() {
           local TARGET="${1}"

ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml

@@ -333,8 +333,9 @@ objects:
       - /bin/sh
       - -c
       - |
-        #!/bin/sh
-        set -e
+        #!/bin/bash
+        set -euo pipefail
+        
         trap 'rc=$?; if test "${rc}" -eq 0; then touch /tmp/setup-success; else touch /tmp/exit /tmp/setup-failed; fi; exit "${rc}"' EXIT
         trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM
 
@@ -1073,6 +1074,7 @@ objects:
       - -c
       - |
         #!/bin/bash
+        set -euo pipefail
 
         function queue() {
           local TARGET="${1}"