Conversation
- add required auth to all necessary methods - implement mocks for provider Since some Keystone endpoints have different auth requirements it cannot be handled in the middleware and should be instead processed with extractors. Access to the state from extractor is not supporting state with generics. Due to that it is required to again rework the state, but now we finally have the proper mock support.
|
Bencher Report| Branch | dev |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| fernet token/project | 📈 view plot 🚷 view threshold | 9.86(+0.43%)Baseline: 9.82 | 11.16 (88.41%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some Keystone endpoints have different auth requirements it cannot
be handled in the middleware and should be instead processed with
extractors. Access to the state from extractor is not supporting state
with generics. Due to that it is required to again rework the state, but
now we finally have the proper mock support.