Closed
Conversation
ibraheem-abe
approved these changes
May 15, 2024
Contributor
|
This maybe a wasted effort, since Python 3.9 has https://peps.python.org/pep-0585/ i.e. list[...] is encouraged over List[...] in all python version after 3.8, and 3.8 hits End of life soon https://devguide.python.org/versions/ . Since bittensor projects are very much focused on constant development, for bittensor community it maybe better to drop python 3.8 already instead of investing development time in supporting something that is being abandoned by the python community at large. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to support https://docs.python.org/3.8/library/typing.html#typing.List