From 5a799c1e61d2fde7b2b9f92f22641aeaf9db4f80 Mon Sep 17 00:00:00 2001 From: Roman Date: Wed, 21 May 2025 12:28:41 -0700 Subject: [PATCH 1/2] sign_with="hotkey" to `publish_metadata` --- bittensor/core/extrinsics/asyncex/serving.py | 1 + bittensor/core/extrinsics/serving.py | 1 + 2 files changed, 2 insertions(+) diff --git a/bittensor/core/extrinsics/asyncex/serving.py b/bittensor/core/extrinsics/asyncex/serving.py index b942a88dc1..6fd5410838 100644 --- a/bittensor/core/extrinsics/asyncex/serving.py +++ b/bittensor/core/extrinsics/asyncex/serving.py @@ -282,6 +282,7 @@ async def publish_metadata( success, message = await subtensor.sign_and_send_extrinsic( call=call, wallet=wallet, + sign_with="hotkey", wait_for_inclusion=wait_for_inclusion, wait_for_finalization=wait_for_finalization, period=period, diff --git a/bittensor/core/extrinsics/serving.py b/bittensor/core/extrinsics/serving.py index b49196bf89..88da8997bc 100644 --- a/bittensor/core/extrinsics/serving.py +++ b/bittensor/core/extrinsics/serving.py @@ -278,6 +278,7 @@ def publish_metadata( success, message = subtensor.sign_and_send_extrinsic( call=call, wallet=wallet, + sign_with="hotkey", wait_for_inclusion=wait_for_inclusion, wait_for_finalization=wait_for_finalization, period=period, From f82317f2071f2e4b79a7a8699b4bcabfab29efaf Mon Sep 17 00:00:00 2001 From: Roman Date: Wed, 21 May 2025 12:39:50 -0700 Subject: [PATCH 2/2] improve unit test --- tests/unit_tests/extrinsics/test_serving.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/unit_tests/extrinsics/test_serving.py b/tests/unit_tests/extrinsics/test_serving.py index c1688fd3d4..7095ea0bc1 100644 --- a/tests/unit_tests/extrinsics/test_serving.py +++ b/tests/unit_tests/extrinsics/test_serving.py @@ -355,7 +355,7 @@ def test_publish_metadata( patch.object(mock_subtensor.substrate, "compose_call"), patch.object( mock_subtensor, "sign_and_send_extrinsic", return_value=response_success - ), + ) as mocked_sign_and_send_extrinsic, ): # Act result = serving.publish_metadata( @@ -369,3 +369,11 @@ def test_publish_metadata( ) # Assert assert result == expected_result, f"Test ID: {test_id}" + mocked_sign_and_send_extrinsic.assert_called_once_with( + call=mock_subtensor.substrate.compose_call.return_value, + wallet=mock_wallet, + sign_with="hotkey", + wait_for_inclusion=wait_for_inclusion, + wait_for_finalization=wait_for_finalization, + period=None, + )