From 9bfdae467981bcbd48e92d9e34b45ef8ede7f9a5 Mon Sep 17 00:00:00 2001 From: Roman Date: Thu, 29 May 2025 11:53:22 -0700 Subject: [PATCH 1/2] replace `transfer_allow_death` with `transfer_keep_alive` --- bittensor/core/async_subtensor.py | 2 +- bittensor/core/extrinsics/asyncex/transfer.py | 2 +- bittensor/core/extrinsics/transfer.py | 2 +- bittensor/core/subtensor.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bittensor/core/async_subtensor.py b/bittensor/core/async_subtensor.py index 9b2c7d2f00..da7d75a82f 100644 --- a/bittensor/core/async_subtensor.py +++ b/bittensor/core/async_subtensor.py @@ -2322,7 +2322,7 @@ async def get_transfer_fee( call = await self.substrate.compose_call( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": dest, "value": value.rao}, ) diff --git a/bittensor/core/extrinsics/asyncex/transfer.py b/bittensor/core/extrinsics/asyncex/transfer.py index a1c781310c..e98e234307 100644 --- a/bittensor/core/extrinsics/asyncex/transfer.py +++ b/bittensor/core/extrinsics/asyncex/transfer.py @@ -45,7 +45,7 @@ async def _do_transfer( """ call = await subtensor.substrate.compose_call( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": destination, "value": amount.rao}, ) diff --git a/bittensor/core/extrinsics/transfer.py b/bittensor/core/extrinsics/transfer.py index 03624097d0..a2ac8df11d 100644 --- a/bittensor/core/extrinsics/transfer.py +++ b/bittensor/core/extrinsics/transfer.py @@ -44,7 +44,7 @@ def _do_transfer( """ call = subtensor.substrate.compose_call( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": destination, "value": amount.rao}, ) diff --git a/bittensor/core/subtensor.py b/bittensor/core/subtensor.py index 6f292d6551..406295e330 100644 --- a/bittensor/core/subtensor.py +++ b/bittensor/core/subtensor.py @@ -1831,7 +1831,7 @@ def get_transfer_fee(self, wallet: "Wallet", dest: str, value: Balance) -> Balan value = check_and_convert_to_balance(value) call = self.substrate.compose_call( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": dest, "value": value.rao}, ) From e12b20f4eeb9c15255a0c50b9b6ee9a010e261c9 Mon Sep 17 00:00:00 2001 From: Roman Date: Thu, 29 May 2025 11:53:32 -0700 Subject: [PATCH 2/2] update tests --- tests/unit_tests/extrinsics/asyncex/test_transfer.py | 6 +++--- tests/unit_tests/extrinsics/test_transfer.py | 6 +++--- tests/unit_tests/test_async_subtensor.py | 2 +- tests/unit_tests/test_subtensor.py | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/unit_tests/extrinsics/asyncex/test_transfer.py b/tests/unit_tests/extrinsics/asyncex/test_transfer.py index 77fcd72f9f..95c5249b62 100644 --- a/tests/unit_tests/extrinsics/asyncex/test_transfer.py +++ b/tests/unit_tests/extrinsics/asyncex/test_transfer.py @@ -32,7 +32,7 @@ async def test_do_transfer_success(subtensor, fake_wallet, mocker): # Asserts subtensor.substrate.compose_call.assert_awaited_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": fake_destination, "value": fake_amount.rao}, ) @@ -77,7 +77,7 @@ async def test_do_transfer_failure(subtensor, fake_wallet, mocker): # Asserts subtensor.substrate.compose_call.assert_awaited_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": fake_destination, "value": fake_amount.rao}, ) @@ -124,7 +124,7 @@ async def test_do_transfer_no_waiting(subtensor, fake_wallet, mocker): # Asserts subtensor.substrate.compose_call.assert_awaited_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": fake_destination, "value": fake_amount.rao}, ) diff --git a/tests/unit_tests/extrinsics/test_transfer.py b/tests/unit_tests/extrinsics/test_transfer.py index fcd532e2d0..081a56ffae 100644 --- a/tests/unit_tests/extrinsics/test_transfer.py +++ b/tests/unit_tests/extrinsics/test_transfer.py @@ -26,7 +26,7 @@ def test_do_transfer_is_success_true(subtensor, fake_wallet, mocker): # Asserts subtensor.substrate.compose_call.assert_called_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": fake_dest, "value": fake_transfer_balance.rao}, ) subtensor.sign_and_send_extrinsic.assert_called_once_with( @@ -64,7 +64,7 @@ def test_do_transfer_is_success_false(subtensor, fake_wallet, mocker): # Asserts subtensor.substrate.compose_call.assert_called_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": fake_dest, "value": fake_transfer_balance.rao}, ) subtensor.sign_and_send_extrinsic.assert_called_once_with( @@ -103,7 +103,7 @@ def test_do_transfer_no_waits(subtensor, fake_wallet, mocker): # Asserts subtensor.substrate.compose_call.assert_called_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": fake_dest, "value": fake_transfer_balance.rao}, ) subtensor.sign_and_send_extrinsic.assert_called_once_with( diff --git a/tests/unit_tests/test_async_subtensor.py b/tests/unit_tests/test_async_subtensor.py index 39e54284c3..a023be1c62 100644 --- a/tests/unit_tests/test_async_subtensor.py +++ b/tests/unit_tests/test_async_subtensor.py @@ -707,7 +707,7 @@ async def test_get_transfer_fee(subtensor, fake_wallet, mocker, balance): mocked_compose_call.assert_awaited_once() mocked_compose_call.assert_called_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={ "dest": fake_dest, "value": fake_value.rao, diff --git a/tests/unit_tests/test_subtensor.py b/tests/unit_tests/test_subtensor.py index c16fc98635..2499db8248 100644 --- a/tests/unit_tests/test_subtensor.py +++ b/tests/unit_tests/test_subtensor.py @@ -1877,7 +1877,7 @@ def test_get_transfer_fee(subtensor, fake_wallet, mocker): # Asserts subtensor.substrate.compose_call.assert_called_once_with( call_module="Balances", - call_function="transfer_allow_death", + call_function="transfer_keep_alive", call_params={"dest": fake_dest, "value": value.rao}, )