From b2d745ed50033c3a9dce31fd3eba582c788fdc39 Mon Sep 17 00:00:00 2001 From: Benjamin Himes Date: Thu, 15 May 2025 16:44:17 +0200 Subject: [PATCH 1/3] Prints failures that arise from subnet register in cases of non-json-output --- bittensor_cli/src/commands/subnets/subnets.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bittensor_cli/src/commands/subnets/subnets.py b/bittensor_cli/src/commands/subnets/subnets.py index fd050bd0a..5e043029f 100644 --- a/bittensor_cli/src/commands/subnets/subnets.py +++ b/bittensor_cli/src/commands/subnets/subnets.py @@ -1668,6 +1668,9 @@ async def register( ) if json_output: json_console.print(json.dumps({"success": success, "msg": msg})) + else: + if not success: + err_console.print(f"Failure: {msg}") # TODO: Confirm emissions, incentive, Dividends are to be fetched from subnet_state or keep NeuronInfo From e07fd6722500505a8388bd5956c4d61927e6aa78 Mon Sep 17 00:00:00 2001 From: Benjamin Himes Date: Thu, 15 May 2025 16:44:35 +0200 Subject: [PATCH 2/3] Passes prompt to register extrinsics --- bittensor_cli/src/commands/subnets/subnets.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bittensor_cli/src/commands/subnets/subnets.py b/bittensor_cli/src/commands/subnets/subnets.py index 5e043029f..260c132cb 100644 --- a/bittensor_cli/src/commands/subnets/subnets.py +++ b/bittensor_cli/src/commands/subnets/subnets.py @@ -1656,13 +1656,15 @@ async def register( return if netuid == 0: - success, msg = await root_register_extrinsic(subtensor, wallet=wallet) + success, msg = await root_register_extrinsic( + subtensor, wallet=wallet, prompt=prompt + ) else: success, msg = await burned_register_extrinsic( subtensor, wallet=wallet, netuid=netuid, - prompt=False, + prompt=prompt, old_balance=balance, era=era, ) From 6fc5c67b16bf32d9b5c7f42aaade596ca68489be Mon Sep 17 00:00:00 2001 From: Benjamin Himes Date: Thu, 15 May 2025 16:46:43 +0200 Subject: [PATCH 3/3] =?UTF-8?q?Removed=20`prompt`=20arg=20in=20`root=5Freg?= =?UTF-8?q?ister=5Fextrinsic`=20&=20`burned=5Fregister=5Fextrinsic`=20?= =?UTF-8?q?=E2=80=94=20it=20is=20already=20handled=20in=20`subnets.registe?= =?UTF-8?q?r`.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- bittensor_cli/src/bittensor/extrinsics/registration.py | 1 - bittensor_cli/src/bittensor/extrinsics/root.py | 1 - bittensor_cli/src/commands/subnets/subnets.py | 5 +---- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/bittensor_cli/src/bittensor/extrinsics/registration.py b/bittensor_cli/src/bittensor/extrinsics/registration.py index 2632a69de..c230f1134 100644 --- a/bittensor_cli/src/bittensor/extrinsics/registration.py +++ b/bittensor_cli/src/bittensor/extrinsics/registration.py @@ -678,7 +678,6 @@ async def burned_register_extrinsic( wait_for_inclusion: bool = True, wait_for_finalization: bool = True, era: Optional[int] = None, - prompt: bool = False, ) -> tuple[bool, str]: """Registers the wallet to chain by recycling TAO. diff --git a/bittensor_cli/src/bittensor/extrinsics/root.py b/bittensor_cli/src/bittensor/extrinsics/root.py index aca5f07d1..d8d4900aa 100644 --- a/bittensor_cli/src/bittensor/extrinsics/root.py +++ b/bittensor_cli/src/bittensor/extrinsics/root.py @@ -290,7 +290,6 @@ async def root_register_extrinsic( wallet: Wallet, wait_for_inclusion: bool = True, wait_for_finalization: bool = True, - prompt: bool = False, ) -> tuple[bool, str]: r"""Registers the wallet to root network. diff --git a/bittensor_cli/src/commands/subnets/subnets.py b/bittensor_cli/src/commands/subnets/subnets.py index 260c132cb..c8bba8436 100644 --- a/bittensor_cli/src/commands/subnets/subnets.py +++ b/bittensor_cli/src/commands/subnets/subnets.py @@ -1656,15 +1656,12 @@ async def register( return if netuid == 0: - success, msg = await root_register_extrinsic( - subtensor, wallet=wallet, prompt=prompt - ) + success, msg = await root_register_extrinsic(subtensor, wallet=wallet) else: success, msg = await burned_register_extrinsic( subtensor, wallet=wallet, netuid=netuid, - prompt=prompt, old_balance=balance, era=era, )