From 3d3657e53b13863696bf07b147c320abb536ee0e Mon Sep 17 00:00:00 2001 From: ibraheem-opentensor Date: Mon, 16 Jun 2025 12:24:39 -0700 Subject: [PATCH 1/6] logo_url params --- bittensor_cli/cli.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/bittensor_cli/cli.py b/bittensor_cli/cli.py index ecb936e7d..18cf5db6d 100755 --- a/bittensor_cli/cli.py +++ b/bittensor_cli/cli.py @@ -5025,6 +5025,9 @@ def subnets_create( description: Optional[str] = typer.Option( None, "--description", help="Description" ), + logo_url: Optional[str] = typer.Option( + None, "--logo-url", help="Logo URL" + ), additional_info: Optional[str] = typer.Option( None, "--additional-info", help="Additional information" ), @@ -5067,6 +5070,7 @@ def subnets_create( subnet_url=subnet_url, discord=discord, description=description, + logo_url=logo_url, additional=additional_info, ) self._run_command( @@ -5190,6 +5194,9 @@ def subnets_set_identity( description: Optional[str] = typer.Option( None, "--description", help="Description" ), + logo_url: Optional[str] = typer.Option( + None, "--logo-url", help="Logo URL" + ), additional_info: Optional[str] = typer.Option( None, "--additional-info", help="Additional information" ), @@ -5241,6 +5248,7 @@ def subnets_set_identity( subnet_url=subnet_url, discord=discord, description=description, + logo_url=logo_url, additional=additional_info, ) From 1fa0491afe60f294eb7a737f5328f3b3d7a41119 Mon Sep 17 00:00:00 2001 From: ibraheem-opentensor Date: Mon, 16 Jun 2025 12:28:27 -0700 Subject: [PATCH 2/6] adds logo_url support --- bittensor_cli/src/bittensor/chain_data.py | 2 ++ bittensor_cli/src/bittensor/utils.py | 8 ++++++++ bittensor_cli/src/commands/subnets/subnets.py | 6 ++++++ 3 files changed, 16 insertions(+) diff --git a/bittensor_cli/src/bittensor/chain_data.py b/bittensor_cli/src/bittensor/chain_data.py index 1f9401ce4..5749ada6f 100644 --- a/bittensor_cli/src/bittensor/chain_data.py +++ b/bittensor_cli/src/bittensor/chain_data.py @@ -630,6 +630,7 @@ class SubnetIdentity(InfoBase): subnet_url: str discord: str description: str + logo_url: str additional: str @classmethod @@ -641,6 +642,7 @@ def _fix_decoded(cls, decoded: dict) -> "SubnetIdentity": subnet_url=bytes(decoded["subnet_url"]).decode(), discord=bytes(decoded["discord"]).decode(), description=bytes(decoded["description"]).decode(), + logo_url=bytes(decoded["logo_url"]).decode(), additional=bytes(decoded["additional"]).decode(), ) diff --git a/bittensor_cli/src/bittensor/utils.py b/bittensor_cli/src/bittensor/utils.py index 31ca5ea61..d7e8da805 100644 --- a/bittensor_cli/src/bittensor/utils.py +++ b/bittensor_cli/src/bittensor/utils.py @@ -1167,6 +1167,7 @@ def prompt_for_subnet_identity( subnet_url: Optional[str], discord: Optional[str], description: Optional[str], + logo_url: Optional[str], additional: Optional[str], ): """ @@ -1227,6 +1228,13 @@ def prompt_for_subnet_identity( lambda x: x and len(x.encode("utf-8")) > 1024, "[red]Error:[/red] Description must be <= 1024 bytes.", ), + ( + "logo_url", + "[blue]Logo URL [dim](optional)[/blue]", + logo_url, + lambda x: x and len(x.encode("utf-8")) > 1024, + "[red]Error:[/red] Logo URL must be <= 1024 bytes.", + ), ( "additional", "[blue]Additional information [dim](optional)[/blue]", diff --git a/bittensor_cli/src/commands/subnets/subnets.py b/bittensor_cli/src/commands/subnets/subnets.py index 99a619d8e..e94402953 100644 --- a/bittensor_cli/src/commands/subnets/subnets.py +++ b/bittensor_cli/src/commands/subnets/subnets.py @@ -140,6 +140,9 @@ async def _find_event_attributes_in_extrinsic_receipt( "description": subnet_identity["description"].encode() if subnet_identity.get("description") else b"", + "logo_url": subnet_identity["logo_url"].encode() + if subnet_identity.get("logo_url") + else b"", "additional": subnet_identity["additional"].encode() if subnet_identity.get("additional") else b"", @@ -2207,6 +2210,7 @@ async def set_identity( "subnet_url": subnet_identity.get("subnet_url", ""), "discord": subnet_identity.get("discord", ""), "description": subnet_identity.get("description", ""), + "logo_url": subnet_identity.get("logo_url", ""), "additional": subnet_identity.get("additional", ""), } @@ -2252,6 +2256,7 @@ async def set_identity( "subnet_url", "discord", "description", + "logo_url", "additional", ]: value = getattr(identity, key, None) @@ -2301,6 +2306,7 @@ async def get_identity( "subnet_url", "discord", "description", + "logo_url", "additional", ]: value = getattr(identity, key, None) From 7dcf37bdd0e37bba9e5a9df2435ede15ce64a6d1 Mon Sep 17 00:00:00 2001 From: ibraheem-opentensor Date: Mon, 16 Jun 2025 12:28:56 -0700 Subject: [PATCH 3/6] updates tests --- tests/e2e_tests/test_staking_sudo.py | 13 ++++++++++--- tests/e2e_tests/test_unstaking.py | 4 ++++ tests/e2e_tests/test_wallet_interactions.py | 6 ++++++ 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/tests/e2e_tests/test_staking_sudo.py b/tests/e2e_tests/test_staking_sudo.py index 0a0984488..5315788ac 100644 --- a/tests/e2e_tests/test_staking_sudo.py +++ b/tests/e2e_tests/test_staking_sudo.py @@ -86,6 +86,8 @@ def test_staking(local_chain, wallet_setup): "A test subnet for e2e testing", "--additional-info", "Created by Alice", + "--logo-url", + "https://testsubnet.com/logo.png", "--no-prompt", "--json-output", ], @@ -121,6 +123,8 @@ def test_staking(local_chain, wallet_setup): "A test subnet for e2e testing", "--additional-info", "Created by Alice", + "--logo-url", + "https://testsubnet.com/logo.png", "--no-prompt", "--json-output", ], @@ -198,6 +202,8 @@ def test_staking(local_chain, wallet_setup): sn_discord := "alice#1234", "--description", sn_description := "A test subnet for e2e testing", + "--logo-url", + sn_logo_url := "https://testsubnet.com/logo.png", "--additional-info", sn_add_info := "Created by Alice", "--json-output", @@ -225,6 +231,7 @@ def test_staking(local_chain, wallet_setup): assert get_identity_output["subnet_url"] == sn_url assert get_identity_output["discord"] == sn_discord assert get_identity_output["description"] == sn_description + assert get_identity_output["logo_url"] == sn_logo_url assert get_identity_output["additional"] == sn_add_info # Start emissions on SNs @@ -508,9 +515,9 @@ def test_staking(local_chain, wallet_setup): ], ) change_yuma3_hyperparam_json = json.loads(change_yuma3_hyperparam.stdout) - assert change_yuma3_hyperparam_json["success"] is True, ( - change_yuma3_hyperparam.stdout - ) + assert ( + change_yuma3_hyperparam_json["success"] is True + ), change_yuma3_hyperparam.stdout changed_yuma3_hyperparam = exec_command_alice( command="sudo", diff --git a/tests/e2e_tests/test_unstaking.py b/tests/e2e_tests/test_unstaking.py index bfbb77e85..e28c54df6 100644 --- a/tests/e2e_tests/test_unstaking.py +++ b/tests/e2e_tests/test_unstaking.py @@ -83,6 +83,8 @@ def test_unstaking(local_chain, wallet_setup): "A test subnet for e2e testing", "--additional-info", "Test subnet", + "--logo-url", + "https://testsubnet.com/logo.png", "--no-prompt", ], ) @@ -115,6 +117,8 @@ def test_unstaking(local_chain, wallet_setup): "A test subnet for e2e testing", "--additional-info", "Test subnet", + "--logo-url", + "https://testsubnet.com/logo.png", "--no-prompt", ], ) diff --git a/tests/e2e_tests/test_wallet_interactions.py b/tests/e2e_tests/test_wallet_interactions.py index 08b2c73c4..cdd22c775 100644 --- a/tests/e2e_tests/test_wallet_interactions.py +++ b/tests/e2e_tests/test_wallet_interactions.py @@ -69,6 +69,8 @@ def test_wallet_overview_inspect(local_chain, wallet_setup): "test#1234", "--description", "A test subnet for e2e testing", + "--logo-url", + "https://testsubnet.com/logo.png", "--additional-info", "Test subnet", "--no-prompt", @@ -388,6 +390,8 @@ def test_wallet_identities(local_chain, wallet_setup): "A test subnet for e2e testing", "--additional-info", "Created by Alice", + "--logo-url", + "https://testsubnet.com/logo.png", "--no-prompt", ], ) @@ -427,6 +431,8 @@ def test_wallet_identities(local_chain, wallet_setup): alice_identity["discord"], "--description", alice_identity["description"], + # "--logo-url", + # alice_identity["logo_url"], "--additional", alice_identity["additional"], "--github", From 4077b98e2a2760fa1a49edd20b2a0f3a2b6842ca Mon Sep 17 00:00:00 2001 From: ibraheem-opentensor Date: Mon, 16 Jun 2025 12:34:49 -0700 Subject: [PATCH 4/6] cleanup --- tests/e2e_tests/test_wallet_interactions.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/e2e_tests/test_wallet_interactions.py b/tests/e2e_tests/test_wallet_interactions.py index cdd22c775..e6a4bb22d 100644 --- a/tests/e2e_tests/test_wallet_interactions.py +++ b/tests/e2e_tests/test_wallet_interactions.py @@ -431,8 +431,6 @@ def test_wallet_identities(local_chain, wallet_setup): alice_identity["discord"], "--description", alice_identity["description"], - # "--logo-url", - # alice_identity["logo_url"], "--additional", alice_identity["additional"], "--github", From 0611641cbbe79bce424f8d4cef47edbcccbe165a Mon Sep 17 00:00:00 2001 From: ibraheem-opentensor Date: Mon, 16 Jun 2025 12:36:23 -0700 Subject: [PATCH 5/6] ruff --- bittensor_cli/cli.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/bittensor_cli/cli.py b/bittensor_cli/cli.py index 18cf5db6d..c92ae2a18 100755 --- a/bittensor_cli/cli.py +++ b/bittensor_cli/cli.py @@ -5025,9 +5025,7 @@ def subnets_create( description: Optional[str] = typer.Option( None, "--description", help="Description" ), - logo_url: Optional[str] = typer.Option( - None, "--logo-url", help="Logo URL" - ), + logo_url: Optional[str] = typer.Option(None, "--logo-url", help="Logo URL"), additional_info: Optional[str] = typer.Option( None, "--additional-info", help="Additional information" ), @@ -5194,9 +5192,7 @@ def subnets_set_identity( description: Optional[str] = typer.Option( None, "--description", help="Description" ), - logo_url: Optional[str] = typer.Option( - None, "--logo-url", help="Logo URL" - ), + logo_url: Optional[str] = typer.Option(None, "--logo-url", help="Logo URL"), additional_info: Optional[str] = typer.Option( None, "--additional-info", help="Additional information" ), From 35b2d44e0171306add7b363f4760aab1f795a581 Mon Sep 17 00:00:00 2001 From: ibraheem-opentensor Date: Mon, 16 Jun 2025 12:40:20 -0700 Subject: [PATCH 6/6] ruff (again) --- tests/e2e_tests/test_staking_sudo.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/e2e_tests/test_staking_sudo.py b/tests/e2e_tests/test_staking_sudo.py index 5315788ac..c880fee4b 100644 --- a/tests/e2e_tests/test_staking_sudo.py +++ b/tests/e2e_tests/test_staking_sudo.py @@ -515,9 +515,9 @@ def test_staking(local_chain, wallet_setup): ], ) change_yuma3_hyperparam_json = json.loads(change_yuma3_hyperparam.stdout) - assert ( - change_yuma3_hyperparam_json["success"] is True - ), change_yuma3_hyperparam.stdout + assert change_yuma3_hyperparam_json["success"] is True, ( + change_yuma3_hyperparam.stdout + ) changed_yuma3_hyperparam = exec_command_alice( command="sudo",