From 00464d455d0cd5c8cd28860b6415a1be0bfadd9d Mon Sep 17 00:00:00 2001 From: John Reed <87283488+JohnReedV@users.noreply.github.com> Date: Tue, 23 Apr 2024 10:49:37 -0700 Subject: [PATCH 1/2] fix warning in issuance test --- pallets/subtensor/tests/root.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pallets/subtensor/tests/root.rs b/pallets/subtensor/tests/root.rs index 94ddc8da55..5e48f32ea5 100644 --- a/pallets/subtensor/tests/root.rs +++ b/pallets/subtensor/tests/root.rs @@ -784,7 +784,7 @@ fn test_get_emission_across_entire_issuance_range() { let total_supply: u64 = pallet_subtensor::TotalSupply::::get(); let original_emission: u64 = pallet_subtensor::DefaultBlockEmission::::get(); let halving_issuance: u64 = total_supply / 2; - let mut step: usize = original_emission as usize; + let step: usize = original_emission as usize; for issuance in (0..=total_supply).step_by(step) { SubtensorModule::set_total_issuance(issuance); @@ -805,7 +805,6 @@ fn test_get_emission_across_entire_issuance_range() { "Issuance: {}", issuance_f64 ); - step = expected_emission as usize; } }); } From 56e0185fce1a05638b8594d7bbc4d0dda126690c Mon Sep 17 00:00:00 2001 From: John Reed <87283488+JohnReedV@users.noreply.github.com> Date: Tue, 23 Apr 2024 11:34:45 -0700 Subject: [PATCH 2/2] reintroduce step --- pallets/subtensor/tests/root.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pallets/subtensor/tests/root.rs b/pallets/subtensor/tests/root.rs index 5e48f32ea5..f7dbae65e5 100644 --- a/pallets/subtensor/tests/root.rs +++ b/pallets/subtensor/tests/root.rs @@ -784,9 +784,11 @@ fn test_get_emission_across_entire_issuance_range() { let total_supply: u64 = pallet_subtensor::TotalSupply::::get(); let original_emission: u64 = pallet_subtensor::DefaultBlockEmission::::get(); let halving_issuance: u64 = total_supply / 2; - let step: usize = original_emission as usize; - for issuance in (0..=total_supply).step_by(step) { + let mut issuance = 0; + + // Issuance won't reach total supply. + while issuance <= 20_900_000_000_000_000 { SubtensorModule::set_total_issuance(issuance); let issuance_f64 = issuance as f64; @@ -805,6 +807,8 @@ fn test_get_emission_across_entire_issuance_range() { "Issuance: {}", issuance_f64 ); + + issuance += expected_emission; } }); }