From b96602072abee66b40e9deefebd72140187d0253 Mon Sep 17 00:00:00 2001 From: Eugene Date: Mon, 10 Jul 2023 12:27:22 -0700 Subject: [PATCH 1/4] diversity changes --- openvalidators/reward/diversity.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/openvalidators/reward/diversity.py b/openvalidators/reward/diversity.py index a7629a7..f425054 100644 --- a/openvalidators/reward/diversity.py +++ b/openvalidators/reward/diversity.py @@ -67,6 +67,7 @@ def get_embeddings( self, sentences: List[str] ) -> "torch.FloatTensor": Embedding for the message. """ # Tokenizing sentences + encoded_input = self.tokenizer( sentences, padding=True, @@ -86,7 +87,11 @@ def get_embeddings( self, sentences: List[str] ) -> "torch.FloatTensor": return sentence_embeddings def get_rewards( self, prompt: str, completions: List[str], name: str ) -> torch.FloatTensor: - + import pdb + pdb.set_trace() + if len(completions) == 0: + return None + # Get embeddings for all completions. embeddings = self.get_embeddings( completions ) From eb52324fccbe241b19eca460b012b042c3f3d171 Mon Sep 17 00:00:00 2001 From: Eugene Date: Mon, 10 Jul 2023 12:34:45 -0700 Subject: [PATCH 2/4] no rewards --- openvalidators/reward/diversity.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openvalidators/reward/diversity.py b/openvalidators/reward/diversity.py index f425054..cf61423 100644 --- a/openvalidators/reward/diversity.py +++ b/openvalidators/reward/diversity.py @@ -90,7 +90,7 @@ def get_rewards( self, prompt: str, completions: List[str], name: str ) -> torch import pdb pdb.set_trace() if len(completions) == 0: - return None + return torch.tensor([]) # Get embeddings for all completions. embeddings = self.get_embeddings( completions ) From ede34f512fe558b2a86e5e9f768b8ba32e29bdaf Mon Sep 17 00:00:00 2001 From: Eugene Date: Mon, 10 Jul 2023 12:42:01 -0700 Subject: [PATCH 3/4] remove trace --- openvalidators/reward/diversity.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/openvalidators/reward/diversity.py b/openvalidators/reward/diversity.py index cf61423..a64e6a0 100644 --- a/openvalidators/reward/diversity.py +++ b/openvalidators/reward/diversity.py @@ -87,8 +87,6 @@ def get_embeddings( self, sentences: List[str] ) -> "torch.FloatTensor": return sentence_embeddings def get_rewards( self, prompt: str, completions: List[str], name: str ) -> torch.FloatTensor: - import pdb - pdb.set_trace() if len(completions) == 0: return torch.tensor([]) From df1848b2afcf0cb1a6547ead5809aec22173dbb4 Mon Sep 17 00:00:00 2001 From: Eugene Date: Mon, 10 Jul 2023 12:54:56 -0700 Subject: [PATCH 4/4] adds 0 to diversity --- openvalidators/reward/diversity.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/openvalidators/reward/diversity.py b/openvalidators/reward/diversity.py index a64e6a0..52eebd5 100644 --- a/openvalidators/reward/diversity.py +++ b/openvalidators/reward/diversity.py @@ -87,6 +87,8 @@ def get_embeddings( self, sentences: List[str] ) -> "torch.FloatTensor": return sentence_embeddings def get_rewards( self, prompt: str, completions: List[str], name: str ) -> torch.FloatTensor: + + # Check if completions are empty, return 0 if so if len(completions) == 0: return torch.tensor([])