From 087955cdb926e8f808bc865560a42c2c36ae40e9 Mon Sep 17 00:00:00 2001 From: Polina Nguen Date: Wed, 18 Nov 2020 11:59:41 -0800 Subject: [PATCH 1/3] Fix LogLevel type to avoid compiler type error --- packages/optimizely-sdk/lib/index.d.ts | 2 +- packages/optimizely-sdk/lib/shared_types.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/optimizely-sdk/lib/index.d.ts b/packages/optimizely-sdk/lib/index.d.ts index d1775a566..0e2735355 100644 --- a/packages/optimizely-sdk/lib/index.d.ts +++ b/packages/optimizely-sdk/lib/index.d.ts @@ -205,7 +205,7 @@ declare module '@optimizely/optimizely-sdk/lib/plugins/logger' { import { LogHandler } from '@optimizely/js-sdk-logging'; export interface LoggerConfig { - logLevel?: enums.LOG_LEVEL; + logLevel?: enums.LOG_LEVEL | string; logToConsole?: boolean; prefix?: string; } diff --git a/packages/optimizely-sdk/lib/shared_types.ts b/packages/optimizely-sdk/lib/shared_types.ts index f7f361f4e..725fd0fc7 100644 --- a/packages/optimizely-sdk/lib/shared_types.ts +++ b/packages/optimizely-sdk/lib/shared_types.ts @@ -145,7 +145,7 @@ export interface SDKOptions { // flag to validate if this instance is valid isValidInstance: boolean; // level of logging i.e debug, info, error, warning etc - logLevel?: LogLevel; + logLevel?: LogLevel | string; // LogHandler object for logging logger?: LogHandler; // sdk key From 4b4c90120ef128d512ad1694aeb718898ed5a1c5 Mon Sep 17 00:00:00 2001 From: Polina Nguen Date: Wed, 18 Nov 2020 13:18:49 -0800 Subject: [PATCH 2/3] Add string type to Config logLevel --- packages/optimizely-sdk/lib/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/optimizely-sdk/lib/index.d.ts b/packages/optimizely-sdk/lib/index.d.ts index 0e2735355..d67063ee9 100644 --- a/packages/optimizely-sdk/lib/index.d.ts +++ b/packages/optimizely-sdk/lib/index.d.ts @@ -73,6 +73,7 @@ declare module '@optimizely/optimizely-sdk' { eventDispatcher?: EventDispatcher; logger?: LogHandler; logLevel?: + | string | enums.LOG_LEVEL.DEBUG | enums.LOG_LEVEL.ERROR | enums.LOG_LEVEL.INFO From 0099320e5b3779f9971ebdf9c4d2d31ed502194c Mon Sep 17 00:00:00 2001 From: Polina Nguen Date: Wed, 18 Nov 2020 13:25:54 -0800 Subject: [PATCH 3/3] Update changelog --- packages/optimizely-sdk/CHANGELOG.MD | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/optimizely-sdk/CHANGELOG.MD b/packages/optimizely-sdk/CHANGELOG.MD index f976232b5..2c3ed7dc6 100644 --- a/packages/optimizely-sdk/CHANGELOG.MD +++ b/packages/optimizely-sdk/CHANGELOG.MD @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - In `Optimizely` class, use `any` type when assigning the return value of `setTimeout`. This is to allow it to type check regardless of whether it uses the browser or Node version of `setTimeout` ([PR #623](https://github.com/optimizely/javascript-sdk/pull/623)), ([Issue #622](https://github.com/optimizely/javascript-sdk/issues/622)) +- Allow to pass string type `logLevel` to `createInstance`. ([Issue #614](https://github.com/optimizely/javascript-sdk/issues/614)) + ### New Features - Added `enabled` field to decision metadata structure to support upcoming application-controlled introduction of tracking for non-experiment Flag decisions ([#619](https://github.com/optimizely/javascript-sdk/pull/619))