From 63efaf8403256779ff8cdd15d044d7051031a9d5 Mon Sep 17 00:00:00 2001 From: aliabbasrizvi Date: Wed, 29 Aug 2018 10:30:24 -0700 Subject: [PATCH] Updating default event dispatcher to actually raise exceptions --- optimizely/event_dispatcher.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/optimizely/event_dispatcher.py b/optimizely/event_dispatcher.py index f263c988b..247a3e0a3 100644 --- a/optimizely/event_dispatcher.py +++ b/optimizely/event_dispatcher.py @@ -34,8 +34,11 @@ def dispatch_event(event): try: if event.http_verb == enums.HTTPVerbs.GET: - requests.get(event.url, params=event.params, timeout=REQUEST_TIMEOUT) + requests.get(event.url, params=event.params, timeout=REQUEST_TIMEOUT).raise_for_status() elif event.http_verb == enums.HTTPVerbs.POST: - requests.post(event.url, data=json.dumps(event.params), headers=event.headers, timeout=REQUEST_TIMEOUT) + requests.post( + event.url, data=json.dumps(event.params), headers=event.headers, timeout=REQUEST_TIMEOUT + ).raise_for_status() + except request_exception.RequestException as error: logging.error('Dispatch event failed. Error: %s' % str(error))