Skip to content

Commit ecf2d6e

Browse files
committed
log default interval message.
1 parent 87b1d61 commit ecf2d6e

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

lib/optimizely/event/batch_event_processor.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,12 @@ def initialize(
5151
@logger.log(Logger::DEBUG, "Setting to default batch_size: #{DEFAULT_BATCH_SIZE}.")
5252
DEFAULT_BATCH_SIZE
5353
end
54-
@flush_interval = positive_number?(flush_interval) ? flush_interval : DEFAULT_BATCH_INTERVAL
54+
@flush_interval = if positive_number?(flush_interval)
55+
flush_interval
56+
else
57+
@logger.log(Logger::DEBUG, "Setting to default flush_interval: #{DEFAULT_BATCH_INTERVAL} ms.")
58+
DEFAULT_BATCH_INTERVAL
59+
end
5560
@notification_center = notification_center
5661
@mutex = Mutex.new
5762
@received = ConditionVariable.new

spec/event/batch_event_processor_spec.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,18 +239,19 @@
239239
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher)
240240
expect(event_processor.flush_interval).to eq(30_000)
241241
event_processor.stop!
242-
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: 'test')
242+
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: 'test', logger: spy_logger)
243243
expect(event_processor.flush_interval).to eq(30_000)
244244
event_processor.stop!
245-
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: [])
245+
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: [], logger: spy_logger)
246246
expect(event_processor.flush_interval).to eq(30_000)
247247
event_processor.stop!
248-
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: 0)
248+
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: 0, logger: spy_logger)
249249
expect(event_processor.flush_interval).to eq(30_000)
250250
event_processor.stop!
251-
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: -5)
251+
event_processor = Optimizely::BatchEventProcessor.new(event_dispatcher: @event_dispatcher, flush_interval: -5, logger: spy_logger)
252252
expect(event_processor.flush_interval).to eq(30_000)
253253
event_processor.stop!
254+
expect(spy_logger).to have_received(:log).with(Logger::DEBUG, 'Setting to default flush_interval: 30000 ms.').exactly(4).times
254255
end
255256

256257
it 'should set flush interval when provided valid' do

0 commit comments

Comments
 (0)