Code review

Author: vjovanov

.github/workflows/checkstyle-skip.yml

@@ -3,7 +3,7 @@ name: "Check code style"
 on:
   pull_request:
     paths:
-      - 'docs/*'
+      - 'docs/**'
       - '**.md'
       - 'library-and-framework-list*.json'
 

.github/workflows/checkstyle.yml

@@ -3,13 +3,12 @@ name: "Check code style"
 on:
   pull_request:
     paths-ignore:
-      - 'docs/*'
+      - 'docs/**'
       - '**.md'
       - 'library-and-framework-list*.json'
 
 jobs:
   checkstyle:
-    if: github.repository == 'oracle/graalvm-reachability-metadata'
     name: "📋 Check style according to checkstyle.xml"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 15

.github/workflows/create-scheduled-release.yml

@@ -12,6 +12,7 @@ permissions:
 jobs:
   get-changed-metadata:
     name: "📋 Get a list of changed metadata"
+    if: github.repository == 'oracle/graalvm-reachability-metadata'
     runs-on: "ubuntu-22.04"
     timeout-minutes: 5
     outputs:

.github/workflows/library-and-framework-list-validation.yml

@@ -7,7 +7,6 @@ on:
 
 jobs:
   validate-library-and-framework-list-json:
-    if: github.repository == 'oracle/graalvm-reachability-metadata'
     name: "📋 Validate the JSON file"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 5

.github/workflows/scan-docker-images.yml

@@ -35,5 +35,5 @@ jobs:
         run: ./gradlew checkAllowedDockerImages --baseCommit=${{ github.event.pull_request.base.sha }} --newCommit=${{ github.event.pull_request.head.sha }}
 
       - name: "🔎 Check all docker images"
-        if: github.event_name != 'pull_request' && github.repository == 'oracle/graalvm-reachability-metadata'
+        if: github.event_name == 'schedule' && github.repository == 'oracle/graalvm-reachability-metadata'
         run: ./gradlew checkAllowedDockerImages

.github/workflows/test-all-metadata.yml

@@ -14,7 +14,7 @@ concurrency:
 
 jobs:
   get-all-metadata:
-    if: github.repository == 'oracle/graalvm-reachability-metadata'
+    if: github.event_name == 'workflow_dispatch' || github.repository == 'oracle/graalvm-reachability-metadata'
     name: "📋 Get list of all supported libraries"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 5
@@ -36,7 +36,6 @@ jobs:
           ./gradlew generateMatrixBatchedCoordinates -Pbatches=16
 
   test-all-metadata:
-    if: github.repository == 'oracle/graalvm-reachability-metadata'
     name: "🧪 ${{ matrix.coordinates }} (GraalVM for JDK ${{ matrix.version }} @ ${{ matrix.os }})"
     runs-on: ${{ matrix.os }}
     timeout-minutes: 120
@@ -78,7 +77,6 @@ jobs:
     name: "🧪 All metadata tests have passed"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 1
-    if: ${{ always() }} && github.repository == 'oracle/graalvm-reachability-metadata'
     needs: test-all-metadata
     steps:
       - name: "All tests passed"

.github/workflows/test-changed-infrastructure.yml

@@ -17,7 +17,6 @@ concurrency:
 
 jobs:
   get-changed-infrastructure:
-    if: github.repository == 'oracle/graalvm-reachability-metadata'
     name: "📋 Get a list of libraries to test for build-logic changes"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 5
@@ -90,7 +89,6 @@ jobs:
     name: "🧪 All build-logic triggered tests have passed"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 1
-    if: ${{ always() }} && github.repository == 'oracle/graalvm-reachability-metadata'
     needs: test-changed-infrastructure
     steps:
       - name: "All tests passed"

.github/workflows/test-changed-metadata.yml

@@ -5,16 +5,15 @@ on:
     branches:
       - master
     paths:
-      - 'metadata/*'
-      - 'tests/src/*'
+      - 'metadata/**'
+      - 'tests/src/**'
 
 concurrency:
   group: "workflow = ${{ github.workflow }}, ref = ${{ github.event.ref }}, pr = ${{ github.event.pull_request.id }}"
   cancel-in-progress: true
 
 jobs:
   get-changed-metadata:
-    if: github.repository == 'oracle/graalvm-reachability-metadata'
     name: "📋 Get a list of all changed libraries"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 5
@@ -85,7 +84,6 @@ jobs:
     name: "🧪 All metadata tests have passed"
     runs-on: "ubuntu-22.04"
     timeout-minutes: 1
-    if: ${{ always() }} && github.repository == 'oracle/graalvm-reachability-metadata'
     needs: test-changed-metadata
     steps:
       - name: "All tests passed"

.github/workflows/verify-new-library-version-compatibility.yml

@@ -16,6 +16,7 @@ concurrency:
 jobs:
   get-all-libraries:
     name: "📋 Get list of all supported libraries with newer versions"
+    # Opens PRs, with labels and assignees. Works only on the main repo.
     if: github.repository == 'oracle/graalvm-reachability-metadata'
     runs-on: ubuntu-22.04
     timeout-minutes: 5

docs/DEVELOPING.md

@@ -13,8 +13,8 @@ Always use the Gradle wrapper from the repository root:
 
 Prerequisites for most commands:
 - `JAVA_HOME` should be set to JDK 21 or later. GraalVM is recommended to match CI.
-- Docker (required for pulling/using allowed images during tests).
-- [`grype`](https://github.com/anchore/grype) version 0.104.0 for scanning docker images:
+- Docker (required for pulling/using allowed images during tests). Needs to work without `sudo`: `sudo usermod -aG docker $USER; sudo reboot`.
+- [`grype`](https://github.com/anchore/grype) version `0.104.0` for scanning docker images:
     ```console
     curl -sSfL https://get.anchore.io/grype/v0.104.0/install.sh | sudo sh -s -- -b /usr/local/bin
     ```