feat: add new dataflow analysis, replacing existing analysis for GitHub Actions #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
changed the title
…ub Actions. Signed-off-by: Nicholas Allen <nicholas.allen@oracle.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/macaron/code_analyzer/dataflow_analysis/run_analysis_standalone.py
Dismissed
Show dismissed
Hide dismissed
nicallen
force-pushed
the
nicallen/new-dataflow-analysis
branch
from
b6d423e to
0f120aa
Compare
Signed-off-by: Nicholas Allen <nicholas.allen@oracle.com>
Signed-off-by: Nicholas Allen <nicholas.allen@oracle.com>
behnazh-w
reviewed
Dec 4, 2025
Member
behnazh-w
left a comment
behnazh-w
left a comment
There was a problem hiding this comment.
You can suppress the Sphinx warnings in docs/source/conf.py:
suppress_warnings = [
'sphinx_autodoc_typehints.forward_reference', # Sphinx has issues with resolving forward references.
]| @@ -0,0 +1,836 @@ | |||
| # Copyright (c) 2024 - 2025, Oracle and/or its affiliates. All rights reserved. | |||
| # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/. | |||
| # Licensed under the Universal Permissive License v 1.0 as shown at https:#oss.oracle.com/licenses/upl/. | |||
Member
There was a problem hiding this comment.
There copyright header is duplicated.
| # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/. | ||
| # Licensed under the Universal Permissive License v 1.0 as shown at https:#oss.oracle.com/licenses/upl/. | ||
| # pylint: skip-file | ||
| # flake8: noqa |
Member
There was a problem hiding this comment.
What is the reason for disabling the linters for this file?
| from __future__ import annotations | ||
|
|
||
| from enum import Enum | ||
| from typing import Any, Literal, NotRequired, Optional, TypedDict, TypeGuard, Union |
Member
There was a problem hiding this comment.
Looks like Any and Optional are not used, but that was not picked up because the linters were disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new dataflow analysis implementation, which provides a framework for sophisticated static analysis of build pipeline specifications (including GitHub Actions workflows, Bash shell scripts). Replaces the existing analysis for callgraph and build command identification.
Description of changes
Adds new dataflow analysis implementation. Removes previous callgraph representation and analysis. Updates checks to use new analysis for identification of build commands. Updates unit tests to work with the changes. Adds two new dependencies: lark (parser library used to implement parsing of GitHub expression language) and frozendict (data structure library used within dataflow analysis where hashable dicts are needed).
Related issues
Checklist
verifiedlabel should appear next to all of your commits on GitHub.