Allowing bot write access allows bypass of security rules

[johnhoran]

Why are you starting this discussion?

Bug

What GitHub Actions topic or product is this about?

Misc

Discussion Details

I've been trying to setup a repository where we allow a bot to open pull requests, and this opens bypasses around the branch protection rules that I can't find a way to close.

If I have a repo that requires 1 review before merge, then I can push a branch that creates an action that gets the bot to approve my PR, and I can merge. I tried fixing this by requiring multiple reviews, 1 more than the number of bots, and then had the bots automatically approve whenever somebody else does. The idea being a user could still manipulate the bot, but they would still need to get at least one more review from another person as the bot can't approve its own PR.

However then I realised I could just get the bot to push to an open PR, and my approval would still be enough even with the option

Require approval of the most recent reviewable push 
Whether the most recent reviewable push must be approved by someone other than the person who pushed it. 

enabled. This is because approvals from the last person to push still count, they just can't be the only approval. This feels like an oversight.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐