remove get_groupby

Author: topper-123

pandas/core/frame.py

@@ -93,7 +93,7 @@
 from pandas.core.arrays.datetimelike import DatetimeLikeArrayMixin as DatetimeLikeArray
 from pandas.core.arrays.sparse import SparseFrameAccessor
 from pandas.core.generic import NDFrame, _shared_docs
-from pandas.core.groupby import generic as grp_generic
+from pandas.core.groupby import generic as groupby_generic
 from pandas.core.indexes import base as ibase
 from pandas.core.indexes.api import Index, ensure_index, ensure_index_from_sequences
 from pandas.core.indexes.datetimes import DatetimeIndex
@@ -5572,13 +5572,13 @@ def groupby(
         group_keys: bool = True,
         squeeze: bool = False,
         observed: bool = False,
-    ) -> "grp_generic.DataFrameGroupBy":
+    ) -> "groupby_generic.DataFrameGroupBy":
 
         if level is None and by is None:
             raise TypeError("You have to supply one of 'by' and 'level'")
         axis = self._get_axis_number(axis)
 
-        return grp_generic.DataFrameGroupBy(
+        return groupby_generic.DataFrameGroupBy(
             obj=self,
             keys=by,
             axis=axis,

pandas/core/groupby/generic.py

@@ -59,7 +59,6 @@
     GroupBy,
     _apply_docs,
     _transform_template,
-    get_groupby,
 )
 from pandas.core.indexes.api import Index, MultiIndex, all_indexes_same
 import pandas.core.indexes.base as ibase
@@ -1035,7 +1034,7 @@ def _cython_agg_blocks(
                     #  reductions; see GH#28949
                     obj = obj.iloc[:, 0]
 
-                s = get_groupby(obj, self.grouper)
+                s = obj.groupby(self.grouper)
                 try:
                     result = s.aggregate(lambda x: alt(x, axis=self.axis))
                 except TypeError:

pandas/core/groupby/groupby.py

@@ -2510,49 +2510,3 @@ def _reindex_output(
 
 
 GroupBy._add_numeric_operations()
-
-
-@Appender(GroupBy.__doc__)
-def get_groupby(
-    obj: NDFrame,
-    by: Optional[_KeysArgType] = None,
-    axis: int = 0,
-    level=None,
-    grouper: "Optional[ops.BaseGrouper]" = None,
-    exclusions=None,
-    selection=None,
-    as_index: bool = True,
-    sort: bool = True,
-    group_keys: bool = True,
-    squeeze: bool = False,
-    observed: bool = False,
-    mutated: bool = False,
-):
-
-    klass: Union[Type["SeriesGroupBy"], Type["DataFrameGroupBy"]]
-    if isinstance(obj, Series):
-        from pandas.core.groupby.generic import SeriesGroupBy
-
-        klass = SeriesGroupBy
-    elif isinstance(obj, DataFrame):
-        from pandas.core.groupby.generic import DataFrameGroupBy
-
-        klass = DataFrameGroupBy
-    else:
-        raise TypeError(f"invalid type: {obj}")
-
-    return klass(
-        obj=obj,
-        keys=by,
-        axis=axis,
-        level=level,
-        grouper=grouper,
-        exclusions=exclusions,
-        selection=selection,
-        as_index=as_index,
-        sort=sort,
-        group_keys=group_keys,
-        squeeze=squeeze,
-        observed=observed,
-        mutated=mutated,
-    )

pandas/core/resample.py

@@ -20,7 +20,7 @@
 from pandas.core.generic import _shared_docs
 from pandas.core.groupby.base import GroupByMixin
 from pandas.core.groupby.generic import SeriesGroupBy
-from pandas.core.groupby.groupby import GroupBy, _GroupBy, _pipe_template, get_groupby
+from pandas.core.groupby.groupby import GroupBy, _GroupBy, _pipe_template
 from pandas.core.groupby.grouper import Grouper
 from pandas.core.groupby.ops import BinGrouper
 from pandas.core.indexes.datetimes import DatetimeIndex, date_range
@@ -334,7 +334,7 @@ def _gotitem(self, key, ndim, subset=None):
         grouper = self.grouper
         if subset is None:
             subset = self.obj
-        grouped = get_groupby(subset, by=None, grouper=grouper, axis=self.axis)
+        grouped = subset.groupby(by=None, grouper=grouper, axis=self.axis)
 
         # try the key selection
         try:
@@ -353,7 +353,7 @@ def _groupby_and_aggregate(self, how, grouper=None, *args, **kwargs):
 
         obj = self._selected_obj
 
-        grouped = get_groupby(obj, by=None, grouper=grouper, axis=self.axis)
+        grouped = obj.groupby(by=None, grouper=grouper, axis=self.axis)
 
         try:
             if isinstance(obj, ABCDataFrame) and callable(how):

pandas/tests/window/test_grouper.py

@@ -3,7 +3,7 @@
 
 import pandas as pd
 from pandas import DataFrame, Series
-from pandas.core.groupby.groupby import get_groupby
+from pandas.core.groupby.generic import DataFrameGroupBy
 import pandas.util.testing as tm
 
 
@@ -19,13 +19,13 @@ def test_mutated(self):
             self.frame.groupby("A", foo=1)
 
         g = self.frame.groupby("A")
-        assert not g.mutated
-        g = get_groupby(self.frame, by="A", mutated=True)
-        assert g.mutated
+        assert g.mutated is False
+        g = DataFrameGroupBy(self.frame, keys="A", mutated=True)
+        assert g.mutated is True
 
     def test_getitem(self):
         g = self.frame.groupby("A")
-        g_mutated = get_groupby(self.frame, by="A", mutated=True)
+        g_mutated = DataFrameGroupBy(self.frame, keys="A", mutated=True)
 
         expected = g_mutated.B.apply(lambda x: x.rolling(2).mean())
 
@@ -46,7 +46,7 @@ def test_getitem_multiple(self):
         # GH 13174
         g = self.frame.groupby("A")
         r = g.rolling(2)
-        g_mutated = get_groupby(self.frame, by="A", mutated=True)
+        g_mutated = DataFrameGroupBy(self.frame, keys="A", mutated=True)
         expected = g_mutated.B.apply(lambda x: x.rolling(2).count())
 
         result = r.B.count()