Explicit LooseVersion comps (#18637)

Author: WillAyd

pandas/_libs/sparse.pyx

@@ -12,8 +12,8 @@ from distutils.version import LooseVersion
 
 # numpy versioning
 _np_version = np.version.short_version
-_np_version_under1p10 = LooseVersion(_np_version) < '1.10'
-_np_version_under1p11 = LooseVersion(_np_version) < '1.11'
+_np_version_under1p10 = LooseVersion(_np_version) < LooseVersion('1.10')
+_np_version_under1p11 = LooseVersion(_np_version) < LooseVersion('1.11')
 
 np.import_array()
 np.import_ufunc()

pandas/compat/__init__.py

@@ -399,7 +399,7 @@ def raise_with_traceback(exc, traceback=Ellipsis):
 # dateutil minimum version
 import dateutil
 
-if LooseVersion(dateutil.__version__) < '2.5':
+if LooseVersion(dateutil.__version__) < LooseVersion('2.5'):
     raise ImportError('dateutil 2.5.0 is the minimum required version')
 from dateutil import parser as _date_parser
 parse_date = _date_parser.parse

pandas/compat/numpy/__init__.py

@@ -9,12 +9,12 @@
 # numpy versioning
 _np_version = np.__version__
 _nlv = LooseVersion(_np_version)
-_np_version_under1p10 = _nlv < '1.10'
-_np_version_under1p11 = _nlv < '1.11'
-_np_version_under1p12 = _nlv < '1.12'
-_np_version_under1p13 = _nlv < '1.13'
-_np_version_under1p14 = _nlv < '1.14'
-_np_version_under1p15 = _nlv < '1.15'
+_np_version_under1p10 = _nlv < LooseVersion('1.10')
+_np_version_under1p11 = _nlv < LooseVersion('1.11')
+_np_version_under1p12 = _nlv < LooseVersion('1.12')
+_np_version_under1p13 = _nlv < LooseVersion('1.13')
+_np_version_under1p14 = _nlv < LooseVersion('1.14')
+_np_version_under1p15 = _nlv < LooseVersion('1.15')
 
 if _nlv < '1.9':
     raise ImportError('this version of pandas is incompatible with '

pandas/conftest.py

@@ -70,8 +70,8 @@ def ip():
 
 
 is_dateutil_le_261 = pytest.mark.skipif(
-    LooseVersion(dateutil.__version__) > '2.6.1',
+    LooseVersion(dateutil.__version__) > LooseVersion('2.6.1'),
     reason="dateutil api change version")
 is_dateutil_gt_261 = pytest.mark.skipif(
-    LooseVersion(dateutil.__version__) <= '2.6.1',
+    LooseVersion(dateutil.__version__) <= LooseVersion('2.6.1'),
     reason="dateutil stable version")

pandas/core/computation/check.py

@@ -6,7 +6,7 @@
 
 try:
     import numexpr as ne
-    ver = ne.__version__
+    ver = LooseVersion(ne.__version__)
     _NUMEXPR_INSTALLED = ver >= LooseVersion(_MIN_NUMEXPR_VERSION)
 
     if not _NUMEXPR_INSTALLED:

pandas/core/missing.py

@@ -347,7 +347,7 @@ def _from_derivatives(xi, yi, x, order=None, der=0, extrapolate=False):
     import scipy
     from scipy import interpolate
 
-    if LooseVersion(scipy.__version__) < '0.18.0':
+    if LooseVersion(scipy.__version__) < LooseVersion('0.18.0'):
         try:
             method = interpolate.piecewise_polynomial_interpolate
             return method(xi, yi.reshape(-1, 1), x,

pandas/io/feather_format.py

@@ -22,7 +22,7 @@ def _try_import():
                           "pip install -U feather-format\n")
 
     try:
-        feather.__version__ >= LooseVersion('0.3.1')
+        LooseVersion(feather.__version__) >= LooseVersion('0.3.1')
     except AttributeError:
         raise ImportError("the feather-format library must be >= "
                           "version 0.3.1\n"
@@ -106,7 +106,7 @@ def read_feather(path, nthreads=1):
     feather = _try_import()
     path = _stringify_path(path)
 
-    if feather.__version__ < LooseVersion('0.4.0'):
+    if LooseVersion(feather.__version__) < LooseVersion('0.4.0'):
         return feather.read_dataframe(path)
 
     return feather.read_dataframe(path, nthreads=nthreads)

pandas/io/html.py

@@ -684,7 +684,7 @@ def _parser_dispatch(flavor):
             raise ImportError(
                 "BeautifulSoup4 (bs4) not found, please install it")
         import bs4
-        if bs4.__version__ == LooseVersion('4.2.0'):
+        if LooseVersion(bs4.__version__) == LooseVersion('4.2.0'):
             raise ValueError("You're using a version"
                              " of BeautifulSoup4 (4.2.0) that has been"
                              " known to cause problems on certain"

pandas/io/parquet.py

@@ -50,16 +50,18 @@ def __init__(self):
                               "\nor via pip\n"
                               "pip install -U pyarrow\n")
 
-        if LooseVersion(pyarrow.__version__) < '0.4.1':
+        if LooseVersion(pyarrow.__version__) < LooseVersion('0.4.1'):
             raise ImportError("pyarrow >= 0.4.1 is required for parquet"
                               "support\n\n"
                               "you can install via conda\n"
                               "conda install pyarrow -c conda-forge\n"
                               "\nor via pip\n"
                               "pip install -U pyarrow\n")
 
-        self._pyarrow_lt_050 = LooseVersion(pyarrow.__version__) < '0.5.0'
-        self._pyarrow_lt_060 = LooseVersion(pyarrow.__version__) < '0.6.0'
+        self._pyarrow_lt_050 = (LooseVersion(pyarrow.__version__) <
+                                LooseVersion('0.5.0'))
+        self._pyarrow_lt_060 = (LooseVersion(pyarrow.__version__) <
+                                LooseVersion('0.6.0'))
         self.api = pyarrow
 
     def write(self, df, path, compression='snappy',
@@ -97,7 +99,7 @@ def __init__(self):
                               "\nor via pip\n"
                               "pip install -U fastparquet")
 
-        if LooseVersion(fastparquet.__version__) < '0.1.0':
+        if LooseVersion(fastparquet.__version__) < LooseVersion('0.1.0'):
             raise ImportError("fastparquet >= 0.1.0 is required for parquet "
                               "support\n\n"
                               "you can install via conda\n"

pandas/io/pytables.py

@@ -248,7 +248,7 @@ def _tables():
         _table_mod = tables
 
         # version requirements
-        if LooseVersion(tables.__version__) < '3.0.0':
+        if LooseVersion(tables.__version__) < LooseVersion('3.0.0'):
             raise ImportError("PyTables version >= 3.0.0 is required")
 
         # set the file open policy