TOSQUASH: TST: Improve Series test syntax

Author: Martin Journois

pandas/tests/series/test_api.py

@@ -234,38 +234,28 @@ def test_tab_completion(self):
         assert 'str' not in dir(s)
         assert 'dt' in dir(s)  # as it is a datetime categorical
 
-    def test_index_tab_completion(self):
+    @pytest.mark.parametrize("index", [
+        tm.makeUnicodeIndex(10),
+        tm.makeStringIndex(10),
+        tm.makeCategoricalIndex(10),
+        Index(['foo', 'bar', 'baz'] * 2),
+        tm.makeDateIndex(10),
+        tm.makePeriodIndex(10),
+        tm.makeTimedeltaIndex(10),
+        tm.makeIntIndex(10),
+        tm.makeUIntIndex(10),
+        tm.makeIntIndex(10),
+        tm.makeFloatIndex(10),
+        Index([True, False]),
+        pd.MultiIndex.from_tuples(lzip('ABCD', 'EFGH')),
+        pd.MultiIndex.from_tuples(lzip([0, 1, 2, 3], 'EFGH')), ])
+    def test_index_tab_completion(self, index):
         # dir contains string-like values of the Index.
-        for index in [tm.makeUnicodeIndex(10),
-                      tm.makeStringIndex(100),
-                      tm.makeCategoricalIndex(100),
-                      Index(['foo', 'foo',
-                             'bar', 'bar',
-                             'baz', 'baz']),
-                      tm.makeDateIndex(100),
-                      tm.makePeriodIndex(100),
-                      tm.makeTimedeltaIndex(100),
-                      tm.makeIntIndex(100),
-                      tm.makeUIntIndex(100),
-                      tm.makeIntIndex(100),
-                      tm.makeFloatIndex(100),
-                      Index([True, False]),
-                      ]:
-            s = pd.Series(index=index)
-            dir_s = dir(s)
-            for x in s.index:
-                assert (not isinstance(x, string_types) or
-                        not isidentifier(x) or x in dir_s)
-
-        # dir contains string-like values of the MultiIndex first level.
-        for index in [pd.MultiIndex.from_tuples(lzip('ABCD', 'EFGH')),
-                      pd.MultiIndex.from_tuples(lzip([0, 1, 2, 3], 'EFGH')),
-                      ]:
-            s = pd.Series(index=index)
-            dir_s = dir(s)
-            for x in s.index:
-                assert (not isinstance(x[0], string_types) or
-                        not isidentifier(x[0]) or x[0] in dir_s)
+        s = pd.Series(index=index)
+        dir_s = dir(s)
+        for x in s.index.get_level_values(0):
+            assert (not isinstance(x, string_types) or
+                    not isidentifier(x) or x in dir_s)
 
     def test_not_hashable(self):
         s_empty = Series()