remove fixture

Author: patrickmckenna

pandas/tests/scalar/conftest.py

@@ -22,6 +22,10 @@
 import pandas._testing as tm
 from pandas.core import ops
 
+TD_OVERFLOW_MSG = (
+    r"outside allowed range \[-9223372036854775807ns, 9223372036854775807ns\]"
+)
+
 
 class TestTimedeltaAdditionSubtraction:
     """
@@ -98,11 +102,11 @@ def test_td_add_datetimelike_scalar(self, op):
         result = op(td, NaT)
         assert result is NaT
 
-    def test_td_add_timestamp_overflow(self, td_overflow_msg: str):
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    def test_td_add_timestamp_overflow(self):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             Timestamp("1700-01-01") + Timedelta(13 * 19999, unit="D")
 
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             Timestamp("1700-01-01") + timedelta(days=13 * 19999)
 
     @pytest.mark.parametrize("op", [operator.add, ops.radd])

pandas/tests/scalar/timedelta/test_arithmetic.py

@@ -12,16 +12,20 @@
     to_timedelta,
 )
 
+TD_OVERFLOW_MSG = (
+    r"outside allowed range \[-9223372036854775807ns, 9223372036854775807ns\]"
+)
+
 
-def test_construct_from_td64_with_unit(td_overflow_msg: str):
+def test_construct_from_td64_with_unit():
     # ignore the unit, as it may cause silently overflows leading to incorrect
     #  results, and in non-overflow cases is irrelevant GH#46827
     obj = np.timedelta64(123456789, "h")
 
-    with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
         Timedelta(obj, unit="ns")
 
-    with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
         Timedelta(obj)
 
 
@@ -200,17 +204,17 @@ def test_td_from_repr_roundtrip(val):
     assert Timedelta(td._repr_base()) == td
 
 
-def test_overflow_on_construction(td_overflow_msg: str):
+def test_overflow_on_construction():
     # GH#3374
     value = Timedelta("1day").value * 20169940
-    with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
         Timedelta(value)
 
     # xref GH#17637
-    with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
         Timedelta(7 * 19999, unit="D")
 
-    with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
         Timedelta(timedelta(days=13 * 19999))
 
 
@@ -225,15 +229,15 @@ def test_overflow_on_construction(td_overflow_msg: str):
         (9223372037, "s", " seconds"),  # 44 seconds
     ],
 )
-def test_construction_out_of_bounds_td64(val, unit, name, td_overflow_msg: str):
+def test_construction_out_of_bounds_td64(val, unit, name):
     # TODO: parametrize over units just above/below the implementation bounds
     #  once GH#38964 is resolved
 
     # Timedelta.max is just under 106752 days
     td64 = np.timedelta64(val, unit)
     assert td64.astype("m8[ns]").view("i8") < 0  # i.e. naive astype will be wrong
 
-    with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
         Timedelta(td64)
 
     # But just back in bounds and we are OK
@@ -242,7 +246,7 @@ def test_construction_out_of_bounds_td64(val, unit, name, td_overflow_msg: str):
     td64 *= -1
     assert td64.astype("m8[ns]").view("i8") > 0  # i.e. naive astype will be wrong
 
-    with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+    with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
         Timedelta(td64)
 
     # But just back in bounds and we are OK

pandas/tests/scalar/timedelta/test_constructors.py

@@ -24,6 +24,10 @@
 )
 import pandas._testing as tm
 
+TD_OVERFLOW_MSG = (
+    r"outside allowed range \[-9223372036854775807ns, 9223372036854775807ns\]"
+)
+
 
 class TestNonNano:
     @pytest.fixture(params=[7, 8, 9])
@@ -647,7 +651,7 @@ def test_timedelta_hash_equality(self):
         ns_td = Timedelta(1, "ns")
         assert hash(ns_td) != hash(ns_td.to_pytimedelta())
 
-    def test_implementation_limits(self, td_overflow_msg: str):
+    def test_implementation_limits(self):
         min_td = Timedelta(Timedelta.min)
         max_td = Timedelta(Timedelta.max)
 
@@ -657,22 +661,22 @@ def test_implementation_limits(self, td_overflow_msg: str):
         assert max_td.value == lib.i8max
 
         # Beyond lower limit, a NAT before the Overflow
-        assert (min_td - Timedelta(1, "ns")) is NaT  # type: ignore[comparison-overlap]
+        assert (min_td - Timedelta(1, "ns")) is NaT
 
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             min_td - Timedelta(2, "ns")
 
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             max_td + Timedelta(1, "ns")
 
         # Same tests using the internal nanosecond values
         td = Timedelta(min_td.value - 1, "ns")
-        assert td is NaT  # type: ignore[comparison-overlap]
+        assert td is NaT
 
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             Timedelta(min_td.value - 2, "ns")
 
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             Timedelta(max_td.value + 1, "ns")
 
     def test_total_seconds_precision(self):

pandas/tests/scalar/timedelta/test_timedelta.py

@@ -17,6 +17,10 @@
 
 import pandas._testing as tm
 
+TD_OVERFLOW_MSG = (
+    r"outside allowed range \[-9223372036854775807ns, 9223372036854775807ns\]"
+)
+
 
 class TestTimestampArithmetic:
     def test_overflow_offset(self):
@@ -33,7 +37,7 @@ def test_overflow_offset(self):
         expected = Timestamp("1999/09/23")
         assert stamp - offset_no_overflow == expected
 
-    def test_overflow_offset_raises(self, td_overflow_msg: str):
+    def test_overflow_offset_raises(self):
         # xref https://github.com/statsmodels/statsmodels/issues/3374
         # ends up multiplying really large numbers which overflow
 
@@ -46,7 +50,7 @@ def test_overflow_offset_raises(self, td_overflow_msg: str):
         with pytest.raises(OverflowError, match=lmsg):
             stamp + offset_overflow
 
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             offset_overflow + stamp
 
         with pytest.raises(OverflowError, match=lmsg):
@@ -61,7 +65,7 @@ def test_overflow_offset_raises(self, td_overflow_msg: str):
         with pytest.raises(OverflowError, match=lmsg):
             stamp + offset_overflow
 
-        with pytest.raises(OutOfBoundsTimedelta, match=td_overflow_msg):
+        with pytest.raises(OutOfBoundsTimedelta, match=TD_OVERFLOW_MSG):
             offset_overflow + stamp
 
         with pytest.raises(OverflowError, match=lmsg):