pass through "mode" via compression args

Author: Skn0tt

pandas/core/generic.py

@@ -2345,7 +2345,6 @@ def to_json(
         default_handler: Callable[[Any], JSONSerializable] | None = None,
         lines: bool_t = False,
         compression: CompressionOptions = "infer",
-        mode: str = "w",
         index: bool_t = True,
         indent: int | None = None,
         storage_options: StorageOptions = None,
@@ -2607,7 +2606,6 @@ def to_json(
             default_handler=default_handler,
             lines=lines,
             compression=compression,
-            mode=mode,
             index=index,
             indent=indent,
             storage_options=storage_options,
@@ -2949,7 +2947,6 @@ def to_pickle(
         self,
         path,
         compression: CompressionOptions = "infer",
-        mode: str = "wb",
         protocol: int = pickle.HIGHEST_PROTOCOL,
         storage_options: StorageOptions = None,
     ) -> None:
@@ -3007,7 +3004,6 @@ def to_pickle(
             self,
             path,
             compression=compression,
-            mode=mode,
             protocol=protocol,
             storage_options=storage_options,
         )

pandas/io/common.py

@@ -763,10 +763,12 @@ def get_handle(
 
         # TAR Encoding
         elif compression == "tar":
+            if "mode" not in compression_args:
+                compression_args["mode"] = ioargs.mode
             if is_path:
-                handle = _BytesTarFile.open(name=handle, mode=ioargs.mode)
+                handle = _BytesTarFile.open(name=handle, **compression_args)
             else:
-                handle = _BytesTarFile.open(fileobj=handle, mode=ioargs.mode)
+                handle = _BytesTarFile.open(fileobj=handle, **compression_args)
             if handle.mode == "r":
                 handles.append(handle)
                 files = handle.getnames()

pandas/tests/io/test_compression.py

@@ -30,13 +30,11 @@ def flip(my_dict: dict):
 )
 @pytest.mark.parametrize("method", ["to_pickle", "to_json", "to_csv"])
 def test_compression_size(obj, method, compression_only):
-    kwargs = {}
-
     if compression_only == "tar":
-        kwargs["mode"] = "w:gz"
+        compression_only = {"method": "tar", "mode": "w:gz"}
 
     with tm.ensure_clean() as path:
-        getattr(obj, method)(path, compression=compression_only, **kwargs)
+        getattr(obj, method)(path, compression=compression_only)
         compressed_size = os.path.getsize(path)
         getattr(obj, method)(path, compression=None)
         uncompressed_size = os.path.getsize(path)