BUG: groupby cumsum with axis=1 computes cumprod

closes #13993

Author: agraboso <agraboso@gmail.com>

Closes #13994 from agraboso/fix-13993 and squashes the following commits:

56dc1c7 [agraboso] BUG: groupby cumsum with axis=1 computes cumprod

Author: agraboso

doc/source/whatsnew/v0.19.0.txt

@@ -855,6 +855,7 @@ Bug Fixes
 ~~~~~~~~~
 
 - Bug in ``groupby().shift()``, which could cause a segfault or corruption in rare circumstances when grouping by columns with missing values (:issue:`13813`)
+- Bug in ``groupby().cumsum()`` calculating ``cumprod`` when ``axis=1``. (:issue:`13994`)
 - Bug in ``pd.read_csv()``, which may cause a segfault or corruption when iterating in large chunks over a stream/file under rare circumstances (:issue:`13703`)
 - Bug in ``pd.read_csv()``, which caused BOM files to be incorrectly parsed by not ignoring the BOM (:issue:`4793`)
 - Bug in ``io.json.json_normalize()``, where non-ascii keys raised an exception (:issue:`13213`)

pandas/core/groupby.py

@@ -1397,7 +1397,7 @@ def cumsum(self, axis=0, *args, **kwargs):
         """Cumulative sum for each group"""
         nv.validate_groupby_func('cumsum', args, kwargs)
         if axis != 0:
-            return self.apply(lambda x: x.cumprod(axis=axis))
+            return self.apply(lambda x: x.cumsum(axis=axis))
 
         return self._cython_transform('cumsum')
 

pandas/tests/test_groupby.py

@@ -2973,6 +2973,14 @@ def test_cython_api2(self):
         result = df.groupby('A', as_index=False).cumsum()
         assert_frame_equal(result, expected)
 
+        # GH 13994
+        result = df.groupby('A').cumsum(axis=1)
+        expected = df.cumsum(axis=1)
+        assert_frame_equal(result, expected)
+        result = df.groupby('A').cumprod(axis=1)
+        expected = df.cumprod(axis=1)
+        assert_frame_equal(result, expected)
+
     def test_grouping_ndarray(self):
         grouped = self.df.groupby(self.df['A'].values)