BUG: #12624 where Panel.fillna() ignores inplace=True

Added if condition for fillna when ndim==3 (for Panel) Issue:
#12624

Author: Xbar <wishyx@gmail.com>

Closes #12633 from Xbar/master and squashes the following commits:

cfb3882 [Xbar] BUGFIX: fillNA for panel (ndim==3) Issue: 12624

Author: Xbar

doc/source/whatsnew/v0.18.1.txt

@@ -103,6 +103,7 @@ Bug Fixes
 
 
 - Bug in ``value_counts`` when ``normalize=True`` and ``dropna=True`` where nulls still contributed to the normalized count (:issue:`12558`)
+- Bug in ``Panel.fillna()`` ignoring ``inplace=True`` (:issue:`12633`)
 
 
 

pandas/core/generic.py

@@ -3124,13 +3124,17 @@ def fillna(self, value=None, method=None, axis=None, inplace=False,
                 # fill in 2d chunks
                 result = dict([(col, s.fillna(method=method, value=value))
                                for col, s in self.iteritems()])
-                return self._constructor.from_dict(result).__finalize__(self)
+                new_obj = self._constructor.\
+                    from_dict(result).__finalize__(self)
+                new_data = new_obj._data
 
-            # 2d or less
-            method = mis._clean_fill_method(method)
-            new_data = self._data.interpolate(method=method, axis=axis,
-                                              limit=limit, inplace=inplace,
-                                              coerce=True, downcast=downcast)
+            else:
+                # 2d or less
+                method = mis._clean_fill_method(method)
+                new_data = self._data.interpolate(method=method, axis=axis,
+                                                  limit=limit, inplace=inplace,
+                                                  coerce=True,
+                                                  downcast=downcast)
         else:
             if method is not None:
                 raise ValueError('cannot specify both a fill method and value')

pandas/tests/test_panel.py

@@ -1528,6 +1528,24 @@ def test_fillna(self):
         p.iloc[0:2, 0:2, 0:2] = np.nan
         self.assertRaises(NotImplementedError, lambda: p.fillna(999, limit=1))
 
+        # Test in place fillNA
+        # Expected result
+        expected = Panel([[[0, 1], [2, 1]], [[10, 11], [12, 11]]],
+                         items=['a', 'b'], minor_axis=['x', 'y'],
+                         dtype=np.float64)
+        # method='ffill'
+        p1 = Panel([[[0, 1], [2, np.nan]], [[10, 11], [12, np.nan]]],
+                   items=['a', 'b'], minor_axis=['x', 'y'],
+                   dtype=np.float64)
+        p1.fillna(method='ffill', inplace=True)
+        assert_panel_equal(p1, expected)
+
+        # method='bfill'
+        p2 = Panel([[[0, np.nan], [2, 1]], [[10, np.nan], [12, 11]]],
+                   items=['a', 'b'], minor_axis=['x', 'y'], dtype=np.float64)
+        p2.fillna(method='bfill', inplace=True)
+        assert_panel_equal(p2, expected)
+
     def test_ffill_bfill(self):
         assert_panel_equal(self.panel.ffill(),
                            self.panel.fillna(method='ffill'))