Address comments

Author: RjLi13

pandas/_libs/tslibs/strptime.pyx

@@ -638,13 +638,20 @@ cdef _calc_julian_from_U_or_W(int year, int week_of_year,
     the week, with week_start_day representing whether the week of the year
     assumes the week starts on Sunday or Monday (6 or 0).
 
-    :param year: the year
-    :param week_of_year: week taken from format U or W
-    :param day_of_week: weekday
-    :param week_starts_Mon: represent whether the week of the year
-                assumes the week starts on Sunday or Monday (6 or 0)
-    :returns: converted julian day.
-    :rtype: int
+    Parameters
+    ----------
+    year : int
+        the year
+    week_of_year : int
+        week taken from format U or W
+    week_starts_Mon : int
+        represents whether the week of the year
+        assumes the week starts on Sunday or Monday (6 or 0)
+
+    Returns
+    -------
+    int
+        converted julian day
     """
 
     cdef:
@@ -673,11 +680,19 @@ cdef _calc_julian_from_V(int iso_year, int iso_week, int iso_weekday):
     ISO weeks start on Mondays, with week 01 being the week containing 4 Jan.
     ISO week days range from 1 (Monday) to 7 (Sunday).
 
-    :param iso_year: the year taken from format %G
-    :param iso_week: the week taken from format %V
-    :param iso_weekday: weekday taken from format %u
-    :returns: the iso year and the Gregorian ordinal date / julian date
-    :rtype: (int, int)
+    Parameters
+    ----------
+    iso_year : int
+        the year taken from format %G
+    iso_week : int
+        the week taken from format %V
+    iso_weekday : int
+        weekday taken from format %u
+
+    Returns
+    -------
+    (int, int)
+        the iso year and the Gregorian ordinal date / julian date
     """
 
     cdef:

pandas/tests/indexes/datetimes/test_tools.py

@@ -291,10 +291,17 @@ def test_to_datetime_iso_week_year_format(self, s, _format, dt):
         ["ISO week directive '%V' must be used with the ISO year directive "
          "'%G' and a weekday directive '%A', '%a', '%w', or '%u'.", "20", "%V"]
     ])
-    def test_ValueError_iso_week_year(self, msg, s, _format):
+    def test_error_iso_week_year(self, msg, s, _format):
         # See GH#16607
-        if locale.getlocale() != ('zh_CN', 'UTF-8') and \
-           locale.getlocale() != ('it_IT', 'UTF-8'):
+        # This test checks for errors thrown when giving the wrong format
+        # However, as discussed on PR#25541, overriding the locale
+        # causes a different error to be thrown due to the format being
+        # locale specific, but the test data is in english.
+        # Thus, a hack I did was to only run this test if locale was not
+        # overwritten. This test will need to be updated if the Ci Builds
+        # test for locales other than these two and english.
+        if (locale.getlocale() != ('zh_CN', 'UTF-8') and
+           locale.getlocale() != ('it_IT', 'UTF-8')):
             with pytest.raises(ValueError, match=msg):
                 to_datetime(s, format=_format)