BUG: Fix groupby over a CategoricalIndex in axis=1

closes GH18432

Add multi-index columns test to test_groupby_categorical_columns_index()

Add whatsnew for GH18432 bug fix

Fix ValueError text for GH18432 bug fix

Update whatsnew text

Use kwargs instead of positional format params

Move test_groupby_categorical_columns_index() to pandas/tests/groupby/test_grouping.py

Author: Eric Kisslinger

doc/source/whatsnew/v0.21.1.txt

@@ -137,6 +137,7 @@ Categorical
 - Error messages in the testing module have been improved when items have different ``CategoricalDtype`` (:issue:`18069`)
 - ``CategoricalIndex`` can now correctly take a ``pd.api.types.CategoricalDtype`` as its dtype (:issue:`18116`)
 - Bug in ``Categorical.unique()`` returning read-only ``codes``  array when all categories were ``NaN`` (:issue:`18051`)
+- Bug in ``DataFrame.groupby(axis=1)`` with a ``CategoricalIndex`` (:issue:`18432`)
 
 String
 ^^^^^^

pandas/core/groupby.py

@@ -2859,9 +2859,11 @@ def is_in_obj(gpr):
         else:
             in_axis, name = False, None
 
-        if is_categorical_dtype(gpr) and len(gpr) != len(obj):
-            raise ValueError("Categorical dtype grouper must "
-                             "have len(grouper) == len(data)")
+        if is_categorical_dtype(gpr) and len(gpr) != obj.shape[axis]:
+            raise ValueError(
+                ("Length of grouper ({len_gpr}) and axis ({len_axis})"
+                 " must be same length"
+                 .format(len_gpr=len(gpr), len_axis=obj.shape[axis])))
 
         # create the Grouping
         # allow us to passing the actual Grouping as the gpr

pandas/tests/groupby/test_grouping.py

@@ -6,7 +6,7 @@
 
 from warnings import catch_warnings
 from pandas import (date_range, Timestamp,
-                    Index, MultiIndex, DataFrame, Series)
+                    Index, MultiIndex, DataFrame, Series, CategoricalIndex)
 from pandas.util.testing import (assert_panel_equal, assert_frame_equal,
                                  assert_series_equal, assert_almost_equal)
 from pandas.compat import lrange, long
@@ -251,6 +251,37 @@ def test_groupby_levels_and_columns(self):
         by_columns.columns = pd.Index(by_columns.columns, dtype=np.int64)
         tm.assert_frame_equal(by_levels, by_columns)
 
+    def test_groupby_categorical_index_and_columns(self):
+        # GH18432
+        columns = ['A', 'B', 'A', 'B']
+        categories = ['B', 'A']
+        cat_columns = CategoricalIndex(columns,
+                                       categories=categories,
+                                       ordered=True)
+        data = np.random.rand(5, len(columns))
+        df = DataFrame(data, columns=cat_columns)
+        result = df.groupby(axis=1, level=0).sum()
+        df = DataFrame(data, columns=columns)
+        expected = df.groupby(axis=1, level=0).sum()
+        expected_cat_columns = CategoricalIndex(expected.columns,
+                                                categories=categories,
+                                                ordered=True)
+        expected.columns = expected_cat_columns
+        expected = expected.sort_index(axis=1)
+        assert_frame_equal(result, expected)
+
+        # test transposed version
+        df = DataFrame(data.T, index=cat_columns)
+        result = df.groupby(axis=0, level=0).sum()
+        df = DataFrame(data.T, index=columns)
+        expected = df.groupby(axis=0, level=0).sum()
+        expected_cat_index = CategoricalIndex(expected.index,
+                                              categories=categories,
+                                              ordered=True)
+        expected.index = expected_cat_index
+        expected = expected.sort_index()
+        assert_frame_equal(result, expected)
+
     def test_grouper_getting_correct_binner(self):
 
         # GH 10063