CLN (feedback): revert needs_i8_conversion if/else clause

Author: arw2019

pandas/core/frame.py

@@ -114,6 +114,7 @@
     is_object_dtype,
     is_scalar,
     is_sequence,
+    needs_i8_conversion,
     pandas_dtype,
 )
 from pandas.core.dtypes.missing import isna, notna
@@ -6368,11 +6369,23 @@ def combine_first(self, other: DataFrame) -> DataFrame:
         """
         import pandas.core.computation.expressions as expressions
 
+        def extract_values(arr):
+            # get values if arr is Series or Index
+            arr = extract_array(arr, extract_numpy=True)
+
+            # convert datelike to i8
+            if needs_i8_conversion(arr.dtype):
+                if is_extension_array_dtype(arr.dtype):
+                    arr = arr.asi8
+                else:
+                    arr = arr.view("i8")
+            return arr
+
         def combiner(x, y):
             mask = extract_array(isna(x))
 
-            x_values = extract_array(x, to_numpy=True)
-            y_values = extract_array(y, to_numpy=True)
+            x_values = extract_values(x)
+            y_values = extract_values(y)
 
             # If the column y in other DataFrame is not in first DataFrame,
             # just return y_values.