STYLE: fix pylint consider-using-dict-items warnings (#49243)

Author: Moisan

pandas/conftest.py

@@ -650,7 +650,7 @@ def index(request):
 
 @pytest.fixture(
     params=[
-        key for key in indices_dict if not isinstance(indices_dict[key], MultiIndex)
+        key for key, value in indices_dict.items() if not isinstance(value, MultiIndex)
     ]
 )
 def index_flat(request):
@@ -668,12 +668,12 @@ def index_flat(request):
 @pytest.fixture(
     params=[
         key
-        for key in indices_dict
+        for key, value in indices_dict.items()
         if not (
             key in ["int", "uint", "range", "empty", "repeats", "bool-dtype"]
             or key.startswith("num_")
         )
-        and not isinstance(indices_dict[key], MultiIndex)
+        and not isinstance(value, MultiIndex)
     ]
 )
 def index_with_missing(request):

pandas/io/parsers/readers.py

@@ -1646,9 +1646,8 @@ def _clean_options(
 
         validate_header_arg(options["header"])
 
-        for arg in _deprecated_defaults.keys():
+        for arg, depr_default in _deprecated_defaults.items():
             parser_default = _c_parser_defaults.get(arg, parser_defaults[arg])
-            depr_default = _deprecated_defaults[arg]
             if result.get(arg, depr_default) != depr_default.default_value:
                 msg = (
                     f"The {arg} argument has been deprecated and will be "

pandas/io/stata.py

@@ -1853,8 +1853,8 @@ def _do_convert_missing(self, data: DataFrame, convert_missing: bool) -> DataFra
             replacements[colname] = replacement
 
         if replacements:
-            for col in replacements:
-                data[col] = replacements[col]
+            for col, value in replacements.items():
+                data[col] = value
         return data
 
     def _insert_strls(self, data: DataFrame) -> DataFrame:

pandas/tests/frame/methods/test_astype.py

@@ -301,7 +301,7 @@ def test_astype_categorical(self, dtype):
         d = {"A": list("abbc"), "B": list("bccd"), "C": list("cdde")}
         df = DataFrame(d)
         result = df.astype(dtype)
-        expected = DataFrame({k: Categorical(d[k], dtype=dtype) for k in d})
+        expected = DataFrame({k: Categorical(v, dtype=dtype) for k, v in d.items()})
         tm.assert_frame_equal(result, expected)
 
     @pytest.mark.parametrize("cls", [CategoricalDtype, DatetimeTZDtype, IntervalDtype])

pandas/tests/plotting/frame/test_frame.py

@@ -1827,11 +1827,11 @@ def test_memory_leak(self):
         # force a garbage collection
         gc.collect()
         msg = "weakly-referenced object no longer exists"
-        for key in results:
+        for result_value in results.values():
             # check that every plot was collected
             with pytest.raises(ReferenceError, match=msg):
                 # need to actually access something to get an error
-                results[key].lines
+                result_value.lines
 
     def test_df_gridspec_patterns(self):
         # GH 10819

pyproject.toml

@@ -80,7 +80,6 @@ disable = [
 
  # pylint type "C": convention, for programming standard violation
   "consider-iterating-dictionary",
-  "consider-using-dict-items",
   "consider-using-f-string",
   "disallowed-name",
   "import-outside-toplevel",