👌 simplify , use fixture in test

Author: Marco Gorelli

pandas/core/frame.py

@@ -6758,7 +6758,6 @@ def append(self, other, ignore_index=False, verify_integrity=False, sort=False):
                 )
 
             index = Index([other.name], name=self.index.name)
-
             idx_diff = other.index.difference(self.columns)
             try:
                 combined_columns = self.columns.append(idx_diff)
@@ -6767,8 +6766,8 @@ def append(self, other, ignore_index=False, verify_integrity=False, sort=False):
             other = (
                 other.reindex(combined_columns, copy=False)
                 .to_frame()
-                .T.rename_axis(index.names)
-                ._convert(datetime=True, timedelta=True)
+                .T.infer_objects()
+                .rename_axis(index.names)
             )
             if not self.columns.equals(combined_columns):
                 self = self.reindex(columns=combined_columns)

pandas/tests/frame/test_combine_concat.py

@@ -2,7 +2,6 @@
 
 import numpy as np
 import pytest
-import pytz
 
 import pandas as pd
 from pandas import DataFrame, Index, Series, Timestamp, date_range
@@ -290,17 +289,14 @@ def test_append_dtypes(self):
         tm.assert_frame_equal(result, expected)
 
     @pytest.mark.parametrize(
-        "timestamp, timezone",
-        [
-            ("2019-07-19 07:04:57+0100", pytz.FixedOffset(60)),
-            ("2019-07-19 07:04:57", None),
-        ],
+        "timestamp", ["2019-07-19 07:04:57+0100", "2019-07-19 07:04:57"]
     )
-    def test_append_timestamps_aware_or_naive(self, timestamp, timezone):
+    def test_append_timestamps_aware_or_naive(self, tz_naive_fixture, timestamp):
         # GH 30238
-        df = pd.DataFrame([pd.Timestamp(timestamp, tz=timezone)])
+        tz = tz_naive_fixture
+        df = pd.DataFrame([pd.Timestamp(timestamp, tz=tz)])
         result = df.append(df.iloc[0]).iloc[-1]
-        expected = pd.Series(pd.Timestamp(timestamp, tz=timezone), name=0)
+        expected = pd.Series(pd.Timestamp(timestamp, tz=tz), name=0)
         pd.testing.assert_series_equal(result, expected)
 
     def test_update(self):