refactor(trie-db): simplify DatabaseStorageRoot API #20104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the API by converting the extension trait into free functions and a type alias. This addresses the feedback from PR paradigmxyz#15742 where the reviewer suggested that and should not be part of the trait. Changes: - Replace trait with a type alias - Convert to free function - Convert to free function - Convert to free function - Update all call sites to use the new API Closes paradigmxyz#15479
Himess
requested review from
Rjected,
joshieDo,
mediocregopher,
rakita and
shekhirin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseStorageRootAPI by converting the extension trait into free functions and a type aliasChanges
Replace
DatabaseStorageRoottrait with a type aliasConvert
from_txtostorage_root_from_txfree functionConvert
from_tx_hashedtostorage_root_from_tx_hashedfree functionConvert
overlay_roottostorage_overlay_rootfree functionUpdate all call sites to use the new API
Closes Make DatabaseStorageRoot stateful #15479