feat: add --fdlimit flag #20168
feat: add --fdlimit flag #20168
Conversation
cuiweixie
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
hmm, undecided about this
| if fdlimit == 0 { | ||
| // Use system default (raise to maximum) | ||
| match fdlimit::raise_fd_limit() { |
There was a problem hiding this comment.
this will alter current behaviour and will likely be super annoying
There was a problem hiding this comment.
0 for old behavior may be okay.
| /// Raise the open file descriptor resource limit. | ||
| /// | ||
| /// Default: 0 (system default). When set to 0, uses the system's default file descriptor | ||
| /// limit. When set to a positive value, attempts to raise the limit to that value. | ||
| #[arg(long, value_name = "LIMIT", default_value_t = 0, global = true)] | ||
| pub fdlimit: u64, |
There was a problem hiding this comment.
not sure we really need this
imo always raising is appropriate
There was a problem hiding this comment.
Even if the system allows setting a higher file descriptor limit, the actual availability of resources such as memory and CPU can impact the stability and performance of the program. Setting the file descriptor limit too high can lead to resource exhaustion, which may cause the system or application to become unstable. This is because every open file descriptor consumes system resources, and if the number of file descriptors is increased significantly, it can strain the system's capacity to manage them effectively. Therefore, it's important to consider the overall resource usage and system capabilities when adjusting file descriptor limits.
we might still need this for reason like debug and some other reason.
|
2 participants
add flag