From e0a349bbaa6949c4bdab4599a1aace8864465e44 Mon Sep 17 00:00:00 2001 From: Juan Girini Date: Thu, 11 May 2023 12:30:32 +0200 Subject: [PATCH 1/3] Add FRAME Coders PR rule --- .github/pr-custom-review.yml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/.github/pr-custom-review.yml b/.github/pr-custom-review.yml index 3620f7e770674..e08bed5bba676 100644 --- a/.github/pr-custom-review.yml +++ b/.github/pr-custom-review.yml @@ -8,12 +8,24 @@ rules: check_type: changed_files condition: include: .* - # excluding files from 'CI team' rules - exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml + # excluding files from 'CI team' and 'FRAME coders' rules + exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml|^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beef|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) min_approvals: 2 teams: - core-devs + - name: FRAME coders + check_type: changed_files + condition: + include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beef|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) + all: + - min_approvals: 2 + teams: + - core-devs + - min_approvals: 1 + teams: + - frame-coders + - name: CI team check_type: changed_files condition: From 0afdbfe8b52f442dc48d37c03975ae2765934460 Mon Sep 17 00:00:00 2001 From: Juan Girini Date: Thu, 11 May 2023 12:40:13 +0200 Subject: [PATCH 2/3] change regexp rule from `beef` to `beefy` --- .github/pr-custom-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pr-custom-review.yml b/.github/pr-custom-review.yml index e08bed5bba676..8cb9a43bfc99d 100644 --- a/.github/pr-custom-review.yml +++ b/.github/pr-custom-review.yml @@ -9,7 +9,7 @@ rules: condition: include: .* # excluding files from 'CI team' and 'FRAME coders' rules - exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml|^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beef|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) + exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml|^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) min_approvals: 2 teams: - core-devs @@ -17,7 +17,7 @@ rules: - name: FRAME coders check_type: changed_files condition: - include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beef|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) + include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) all: - min_approvals: 2 teams: From 89669c367acff3754ce5ee073d4c1c7807d10b64 Mon Sep 17 00:00:00 2001 From: Juan Girini Date: Fri, 12 May 2023 10:24:32 +0200 Subject: [PATCH 3/3] exclude pallet-aura from frame coders rule --- .github/pr-custom-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pr-custom-review.yml b/.github/pr-custom-review.yml index 8cb9a43bfc99d..c10fb6df28885 100644 --- a/.github/pr-custom-review.yml +++ b/.github/pr-custom-review.yml @@ -9,7 +9,7 @@ rules: condition: include: .* # excluding files from 'CI team' and 'FRAME coders' rules - exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml|^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) + exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml|^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*)) min_approvals: 2 teams: - core-devs @@ -17,7 +17,7 @@ rules: - name: FRAME coders check_type: changed_files condition: - include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) + include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*)) all: - min_approvals: 2 teams: