From 4fb7edaeae0cef491d1822e1e658362e46e05160 Mon Sep 17 00:00:00 2001 From: Shawn Tabrizi Date: Wed, 5 Aug 2020 09:36:50 +0200 Subject: [PATCH 1/2] Warn when no events are being emitted for tests --- frame/system/src/lib.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/frame/system/src/lib.rs b/frame/system/src/lib.rs index 0852bdd253fe5..9cf0312216d28 100644 --- a/frame/system/src/lib.rs +++ b/frame/system/src/lib.rs @@ -937,7 +937,13 @@ impl Module { pub fn deposit_event_indexed(topics: &[T::Hash], event: T::Event) { let block_number = Self::block_number(); // Don't populate events on genesis. - if block_number.is_zero() { return } + if block_number.is_zero() { + // Print a message only in tests warning users about this behavior. + #[cfg(test)] + println!("The block number is zero, so events are not being deposited.") + + return + } let phase = ExecutionPhase::get().unwrap_or_default(); let event = EventRecord { From 50b7660a868089d723f3492418c865109fe4d56a Mon Sep 17 00:00:00 2001 From: Shawn Tabrizi Date: Wed, 5 Aug 2020 09:37:13 +0200 Subject: [PATCH 2/2] oops --- frame/system/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frame/system/src/lib.rs b/frame/system/src/lib.rs index 9cf0312216d28..bb551818be8c3 100644 --- a/frame/system/src/lib.rs +++ b/frame/system/src/lib.rs @@ -940,7 +940,7 @@ impl Module { if block_number.is_zero() { // Print a message only in tests warning users about this behavior. #[cfg(test)] - println!("The block number is zero, so events are not being deposited.") + println!("The block number is zero, so events are not being deposited."); return }