From cd58fa5cbac2943349cae063c2b9b31236b7e4f2 Mon Sep 17 00:00:00 2001 From: Maximilian <787658+mfranzke@users.noreply.github.com> Date: Sat, 29 Jan 2022 21:52:06 +0100 Subject: [PATCH 1/3] fix(annotations): hiding them correctly --- .../src/sass/scss/04-components/_annotations.scss | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss b/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss index 2ff41dda6..0939ab8d4 100644 --- a/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss +++ b/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss @@ -39,7 +39,9 @@ * annotation attached to it. */ .pl-c-annotation-tip { - display: flex; + &:not([hidden]) { + display: flex; + } align-items: center; justify-content: center; width: 24px !important; From 5fbdced5b23c4b3850a44cc145bd604ef43dd01d Mon Sep 17 00:00:00 2001 From: Maximilian <787658+mfranzke@users.noreply.github.com> Date: Sat, 29 Jan 2022 22:06:37 +0100 Subject: [PATCH 2/3] fix(annotations): hiding them correctly --- .../dist/css/pattern-scaffolding.css | 3 +++ .../src/sass/scss/04-components/_annotations.scss | 8 +++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css b/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css index ce8c29d4d..a7e88f530 100644 --- a/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css +++ b/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css @@ -313,5 +313,8 @@ position: absolute; z-index: 100; } +.pl-c-annotation-tip[hidden] { + visibility: hidden; +} /*# sourceMappingURL=pattern-scaffolding.css.map */ diff --git a/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss b/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss index 0939ab8d4..f0d201083 100644 --- a/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss +++ b/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss @@ -39,9 +39,7 @@ * annotation attached to it. */ .pl-c-annotation-tip { - &:not([hidden]) { - display: flex; - } + display: flex; align-items: center; justify-content: center; width: 24px !important; @@ -54,4 +52,8 @@ font-size: 16px !important; position: absolute; z-index: 100; + + &[hidden] { + visibility: hidden; + } } From a7dab23067c8e8485d93c788748cf6849b17e902 Mon Sep 17 00:00:00 2001 From: Maximilian <787658+mfranzke@users.noreply.github.com> Date: Sat, 29 Jan 2022 22:24:17 +0100 Subject: [PATCH 3/3] refactor: optimized this even further --- .../dist/css/pattern-scaffolding.css | 5 ++--- .../src/sass/scss/04-components/_annotations.scss | 8 +++----- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css b/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css index a7e88f530..b3cd246df 100644 --- a/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css +++ b/packages/starterkit-handlebars-demo/dist/css/pattern-scaffolding.css @@ -299,7 +299,6 @@ * annotation attached to it. */ .pl-c-annotation-tip { - display: flex; align-items: center; justify-content: center; width: 24px !important; @@ -313,8 +312,8 @@ position: absolute; z-index: 100; } -.pl-c-annotation-tip[hidden] { - visibility: hidden; +.pl-c-annotation-tip:not([hidden]) { + display: flex; } /*# sourceMappingURL=pattern-scaffolding.css.map */ diff --git a/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss b/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss index f0d201083..0939ab8d4 100644 --- a/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss +++ b/packages/uikit-workshop/src/sass/scss/04-components/_annotations.scss @@ -39,7 +39,9 @@ * annotation attached to it. */ .pl-c-annotation-tip { - display: flex; + &:not([hidden]) { + display: flex; + } align-items: center; justify-content: center; width: 24px !important; @@ -52,8 +54,4 @@ font-size: 16px !important; position: absolute; z-index: 100; - - &[hidden] { - visibility: hidden; - } }