From 673ec4152f6982d3ec0aae611d5ab42f6d1d413c Mon Sep 17 00:00:00 2001 From: Salem Ghoweri Date: Sun, 9 Dec 2018 14:07:02 -0500 Subject: [PATCH] fix: workaround to address the long-running view-all issues when PL Node compiles standalone markdown files in top-level pattern folders; addresses #890 and #970 --- packages/core/src/lib/ui_builder.js | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/packages/core/src/lib/ui_builder.js b/packages/core/src/lib/ui_builder.js index 96229e08c..ddbbea263 100644 --- a/packages/core/src/lib/ui_builder.js +++ b/packages/core/src/lib/ui_builder.js @@ -143,26 +143,29 @@ const ui_builder = function() { * @returns the found or created pattern object */ function injectDocumentationBlock(pattern, patternlab, isSubtypePattern) { - //first see if loadPattern processed one already - let docPattern = + // check to see if loadPattern has processed one already (to re-use some bits of pattern data) however still create an empty pattern -- just reuse the pattern description info for existing docs patterns; workaround to address #890 and #970. + const existingDocPattern = patternlab.subtypePatterns[ pattern.patternGroup + (isSubtypePattern ? '-' + pattern.patternSubGroup : '') ]; - if (docPattern) { - docPattern.isDocPattern = true; - docPattern.order = -Number.MAX_SAFE_INTEGER; - return docPattern; - } - //if not, create one now - docPattern = new Pattern.createEmpty( + // assign default patternDesc data based on whether or not pattern docs have already been generated. + const patternDescription = + existingDocPattern !== undefined + ? existingDocPattern.patternDesc !== undefined + ? existingDocPattern.patternDesc + : '' + : ''; + + // always create a new empty pattern; workaround to address #890 and #970. + const docPattern = new Pattern.createEmpty( { name: pattern.flatPatternPath, patternName: isSubtypePattern ? pattern.patternSubGroup : pattern.patternGroup, - patternDesc: '', + patternDesc: patternDescription, patternPartial: 'viewall-' + pattern.patternGroup +