fix(core): tabs aria controller overwrites user aria-labelledby

bennypowers · bennypowers · commit 0d19f9963a85 · 2024-03-06T10:16:05.000+02:00
diff --git a/core/pfe-core/controllers/tabs-aria-controller.ts b/core/pfe-core/controllers/tabs-aria-controller.ts
@@ -73,9 +73,7 @@ export class TabsAriaController<
 
   hostUpdated() {
     for (const [tab, panel] of this.#tabPanelMap) {
-      if (!panel.hasAttribute('aria-labelledby')) {
-        panel.setAttribute('aria-labelledby', tab.id);
-      }
+      panel.setAttribute('aria-labelledby', tab.id);
       tab.setAttribute('aria-controls', panel.id);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -73,9 +73,7 @@ export class TabsAriaController<`
`73`	`73`
`74`	`74`	`hostUpdated() {`
`75`	`75`	`for (const [tab, panel] of this.#tabPanelMap) {`
`76`		`- if (!panel.hasAttribute('aria-labelledby')) {`
`77`		`- panel.setAttribute('aria-labelledby', tab.id);`
`78`		`- }`
	`76`	`+ panel.setAttribute('aria-labelledby', tab.id);`
`79`	`77`	`tab.setAttribute('aria-controls', panel.id);`
`80`	`78`	`}`
`81`	`79`	`}`