Skip to content

Commit 18bfc7e

Browse files
authored
adding ability to disable a pfe-collapse-toggle button (#518)
Fixes #516
1 parent 5142c60 commit 18bfc7e

File tree

3 files changed

+36
-0
lines changed

3 files changed

+36
-0
lines changed

elements/pfe-collapse/demo/index.html

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,16 @@ <h2>Standalone Toggle without a Panel</h2>
6969
Toggle without a panel
7070
</pfe-collapse-toggle>
7171

72+
<hr>
73+
74+
<h2>Disabled Toggle</h2>
75+
<pfe-collapse>
76+
<pfe-collapse-toggle disabled="disabled">Disabled Toggle</pfe-collapse-toggle>
77+
<pfe-collapse-panel>
78+
<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
79+
</pfe-collapse-panel>
80+
</pfe-collapse>
81+
7282
<script>
7383
var collapse = document.querySelector("pfe-collapse");
7484
var panel = collapse.querySelector("pfe-collapse-panel");

elements/pfe-collapse/src/pfe-collapse.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ class PfeCollapseToggle extends PFElement {
108108
}
109109

110110
toggle() {
111+
if (this.hasAttribute("disabled")) {
112+
return;
113+
}
114+
111115
this.expanded = !this.expanded;
112116

113117
if (this.controlledPanel) {

elements/pfe-collapse/test/pfe-collapse_test.html

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@
3636
</pfe-collapse>
3737
</div>
3838

39+
<div id="disabled">
40+
<pfe-collapse>
41+
<pfe-collapse-toggle disabled="disabled">Toggle</pfe-collapse-toggle>
42+
<pfe-collapse-panel>Panel</pfe-collapse-panel>
43+
</pfe-collapse>
44+
</div>
45+
3946
<script>
4047
suite("<pfe-collapse>", () => {
4148
test("it should upgrade", () => {
@@ -241,6 +248,21 @@
241248
`pfe-collapse-toggle: This toggle doesn't have a panel associated with it`
242249
);
243250
});
251+
252+
test("it should not open the panel if the toggle has been disabled", done => {
253+
const collapse = document.querySelector('#disabled pfe-collapse');
254+
const toggle = collapse.querySelector('pfe-collapse-toggle');
255+
const panel = collapse.querySelector("pfe-collapse-panel");
256+
257+
toggle.click();
258+
259+
flush(() => {
260+
assert.equal(toggle.getAttribute("aria-expanded"), "false");
261+
assert.isTrue(!panel.hasAttribute("pfe-expanded"));
262+
263+
done();
264+
});
265+
});
244266
});
245267
</script>
246268
</body>

0 commit comments

Comments
 (0)