From baa09a73b6d5b29edf04983606c68ce304f154c4 Mon Sep 17 00:00:00 2001 From: Steven Spriggs Date: Thu, 15 Jun 2023 10:48:46 -0400 Subject: [PATCH 1/3] fix(tabs): style regression when no icon is present --- elements/pf-tabs/pf-tab.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/elements/pf-tabs/pf-tab.css b/elements/pf-tabs/pf-tab.css index 8b89b5b964..d36f3990f6 100644 --- a/elements/pf-tabs/pf-tab.css +++ b/elements/pf-tabs/pf-tab.css @@ -127,6 +127,10 @@ button:active { display: flex !important; } +[part="icon"][hidden] { + display: none !important; +} + :host([disabled][border-bottom="false"]) button, :host([aria-disabled="true"][border-bottom="false"]) button { --pf-c-tabs__link--before--BorderBottomWidth: 0; From 938a89cf0ca1feef72dca23303198b0993e3f0b9 Mon Sep 17 00:00:00 2001 From: Steven Spriggs Date: Thu, 15 Jun 2023 10:53:53 -0400 Subject: [PATCH 2/3] chore(tabs): add changeset --- .changeset/few-hotels-punch.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/few-hotels-punch.md diff --git a/.changeset/few-hotels-punch.md b/.changeset/few-hotels-punch.md new file mode 100644 index 0000000000..ea80848b25 --- /dev/null +++ b/.changeset/few-hotels-punch.md @@ -0,0 +1,5 @@ +--- +"@patternfly/elements": patch +--- + +``: fixed style regression on tab when no icon is present From 3be9b7715d9aa9f07b2996f8a46196255d2ad0a3 Mon Sep 17 00:00:00 2001 From: Steven Spriggs Date: Thu, 15 Jun 2023 10:56:07 -0400 Subject: [PATCH 3/3] chore(tabs): update changeset --- .changeset/few-hotels-punch.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/few-hotels-punch.md b/.changeset/few-hotels-punch.md index ea80848b25..0397c062f4 100644 --- a/.changeset/few-hotels-punch.md +++ b/.changeset/few-hotels-punch.md @@ -2,4 +2,4 @@ "@patternfly/elements": patch --- -``: fixed style regression on tab when no icon is present +``: fixed style regression on tab when a slotted icon is not present