From 3d3e6ccb3d2315b6cdbe6f187da2cb7fe1d89ccb Mon Sep 17 00:00:00 2001 From: Kendall Totten Date: Thu, 17 Oct 2019 15:14:39 -0400 Subject: [PATCH 1/4] add prefix to schema, update JS --- elements/pfe-card/src/pfe-card.js | 2 +- elements/pfe-card/src/pfe-card.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/elements/pfe-card/src/pfe-card.js b/elements/pfe-card/src/pfe-card.js index b2662f5801..d2dfc86b24 100644 --- a/elements/pfe-card/src/pfe-card.js +++ b/elements/pfe-card/src/pfe-card.js @@ -100,7 +100,7 @@ class PfeCard extends PFElement { get backgroundColor() { return ( - this.getAttribute("pfe-color") || this.getAttribute("color") || "base" + this.getAttribute("pfe-color") || this.getAttribute("pfe-color") || "base" ); } diff --git a/elements/pfe-card/src/pfe-card.json b/elements/pfe-card/src/pfe-card.json index d0f1e3a858..a741c21d1b 100644 --- a/elements/pfe-card/src/pfe-card.json +++ b/elements/pfe-card/src/pfe-card.json @@ -76,6 +76,7 @@ "accent" ], "default": "base", + "prefixed": true, "observer": "_colorChanged" }, "img-src": { From 17c69d810ffb36bdf819e71103f1e953b32648f7 Mon Sep 17 00:00:00 2001 From: Kendall Totten Date: Thu, 17 Oct 2019 16:13:44 -0400 Subject: [PATCH 2/4] fix background color function so it does not eval T/F --- elements/pfe-card/src/pfe-card.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/elements/pfe-card/src/pfe-card.js b/elements/pfe-card/src/pfe-card.js index d2dfc86b24..e6f18ea8a1 100644 --- a/elements/pfe-card/src/pfe-card.js +++ b/elements/pfe-card/src/pfe-card.js @@ -99,9 +99,7 @@ class PfeCard extends PFElement { } get backgroundColor() { - return ( - this.getAttribute("pfe-color") || this.getAttribute("pfe-color") || "base" - ); + return this.getAttribute("pfe-color") || this.getAttribute("pfe-color") || "base"; } static get observedAttributes() { From 484058ed5b04b5dcb1c1c9218e7540537a8cdcae Mon Sep 17 00:00:00 2001 From: Kendall Totten Date: Mon, 21 Oct 2019 09:19:04 -0400 Subject: [PATCH 3/4] Update elements/pfe-card/src/pfe-card.js Co-Authored-By: [ Cassondra ] --- elements/pfe-card/src/pfe-card.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elements/pfe-card/src/pfe-card.js b/elements/pfe-card/src/pfe-card.js index e6f18ea8a1..09d5a672e5 100644 --- a/elements/pfe-card/src/pfe-card.js +++ b/elements/pfe-card/src/pfe-card.js @@ -99,7 +99,7 @@ class PfeCard extends PFElement { } get backgroundColor() { - return this.getAttribute("pfe-color") || this.getAttribute("pfe-color") || "base"; + return this.getAttribute("pfe-color") || "base"; } static get observedAttributes() { From eff86026cc5d87dece4d22494861fb4297e644ea Mon Sep 17 00:00:00 2001 From: castastrophe Date: Mon, 21 Oct 2019 13:10:35 -0400 Subject: [PATCH 4/4] [dev]: Update changelog --- CHANGELOG-prerelease.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG-prerelease.md b/CHANGELOG-prerelease.md index 71c9de8de4..001527ff40 100644 --- a/CHANGELOG-prerelease.md +++ b/CHANGELOG-prerelease.md @@ -9,7 +9,11 @@ Tag: [v1.0.0-prerelease.26](https://github.com/patternfly/patternfly-elements/re - [6b5db77](https://github.com/patternfly/patternfly-elements/commit/6b5db77c20358499f78b66811b73ea6be309318b) Update documentation - [d4600dd](https://github.com/patternfly/patternfly-elements/commit/d4600dd1c6e2abfcf8918d06b4eaacb8fb62d208) Add automatic Sass globbing to pfe-sass - [27a97e1](https://github.com/patternfly/patternfly-elements/commit/27a97e135986de37ede55504a1630bf974de0e0c) pfe-cta: fix functions & IE11 accessibility -- []() Upgrade to latest version of storybook #366 +- [9a39ae3](https://github.com/patternfly/patternfly-elements/commit/9a39ae3b7d0b8d129a3aea3b58e71dab5013c721) fix: Adding object-fit to resolve image distortion in cards, #417 +- [980203b](https://github.com/patternfly/patternfly-elements/commit/980203b2768d1d9d8813f386bb0f0bf37d3732ab) feat: Upgrade to latest version of storybook (#366) +- [ab5bc0e](https://github.com/patternfly/patternfly-elements/commit/ab5bc0e66b1e0f2f4ba180ff80d24b84d0db3260) feat: added sm md and xl sizes for pfe-progress-indicator (#575) +- [fc51ba](https://github.com/patternfly/patternfly-elements/commit/fc51baf1cb4313ca117cc505ba9c0e99dd44d0e9) feat: Add pfe-number schema (#576) +- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-card: storybook issue with incorrect attribute (#573) ## Prerelease 25 ( 2019-09-10 )