From 9c8b065af3278507ed6e693989d35bfc031db397 Mon Sep 17 00:00:00 2001 From: Joachim Schuler Date: Tue, 6 Sep 2022 16:51:38 -0400 Subject: [PATCH 1/2] add react-dropzone for type checking --- packages/documentation-framework/scripts/md/typecheck.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/documentation-framework/scripts/md/typecheck.js b/packages/documentation-framework/scripts/md/typecheck.js index 416aa4da6c..acf8ab8a22 100644 --- a/packages/documentation-framework/scripts/md/typecheck.js +++ b/packages/documentation-framework/scripts/md/typecheck.js @@ -38,6 +38,7 @@ const defaultImports = [ 'react', '@reach/router', '@patternfly/react-core/next', + 'react-dropzone', ]; const files = { 'imports.ts': defaultImports From a58dc3738bb85f862a5df5a05fa01cb700fcbd26 Mon Sep 17 00:00:00 2001 From: Joachim Schuler Date: Fri, 30 Sep 2022 11:37:20 -0400 Subject: [PATCH 2/2] Return null for none-preprendered pages --- .../scripts/webpack/getHtmlWebpackPlugins.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/documentation-framework/scripts/webpack/getHtmlWebpackPlugins.js b/packages/documentation-framework/scripts/webpack/getHtmlWebpackPlugins.js index 1189e99db8..3ec243b756 100644 --- a/packages/documentation-framework/scripts/webpack/getHtmlWebpackPlugins.js +++ b/packages/documentation-framework/scripts/webpack/getHtmlWebpackPlugins.js @@ -20,7 +20,7 @@ async function getHtmlWebpackPlugin({ templateParameters: { title: getTitle(title), // Don't prerender fullscreen pages (expensive!) - prerendering: (isProd && !isFullscreen && !url.includes('extensions')) ? await prerender(url, pathPrefix) : 'Loading...', + prerendering: (isProd && !isFullscreen && !url.includes('extensions')) ? await prerender(url, pathPrefix) : null, // Don't use GA in dev mode googleAnalyticsID: isProd ? googleAnalyticsID : false, algolia