Skip to content

Commit a848842

Browse files
committed
fix(nvmrc): remove nvmrc checks and reenable node6 support
1 parent e4cdf7d commit a848842

File tree

115 files changed

+450
-461
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

115 files changed

+450
-461
lines changed

.eslintrc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
{
22
"rules": {
3-
"prettier/prettier": ["error", { "singleQuote": true, "trailingComma": "all" }]
3+
"prettier/prettier": [
4+
"error",
5+
{ "singleQuote": true, "trailingComma": "none" }
6+
]
47
},
58
"extends": [
69
"standard",
@@ -19,9 +22,6 @@
1922
"jsx": true,
2023
"experimentalObjectRestSpread": true
2124
},
22-
"plugins": [
23-
"prettier",
24-
"react"
25-
],
25+
"plugins": ["prettier", "react"],
2626
"parser": "babel-eslint"
2727
}

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ notifications:
1414
email: false
1515
node_js:
1616
- '8'
17+
- '6'
1718
before_script:
1819
- npm prune
1920
script:

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ As an alernative to consuming the `patternfly-react.css` file (found in `dist/cs
2020

2121
## Node Environment
2222

23-
To build you **must** use Node 8. If you are not using Node 8, you will get an error at `npm install` time. Please install and use via:
23+
This project currently supports Node [Active LTS](https://github.com/nodejs/Release#release-schedule) releases. Please stay current with Node Active LTS when developing patternfly-react.
24+
25+
For example, to develop with Node 8, use the following:
2426
```
2527
nvm install 8
2628
nvm use 8
2729
```
2830

29-
Run `npm install` again. If you then get an error with `Node Sass`, remove the `node_modules` and `npm install` again (to pull the correct version of node-sass).
30-
3131
## Storybook UI Development
3232
This project uses [React Storybook](https://getstorybook.io/) to test and demo new React UI components. You can view our current storybook [here](https://rawgit.com/patternfly/patternfly-react/gh-pages/index.html).
3333

0 commit comments

Comments
 (0)