diff --git a/eslint.config-md.mjs b/eslint.config-md.mjs index 9fcc90a813d..da009687858 100644 --- a/eslint.config-md.mjs +++ b/eslint.config-md.mjs @@ -30,7 +30,19 @@ export default [ 'react/jsx-uses-react': 'error', 'react/jsx-uses-vars': 'error', 'react/no-unknown-property': 'error', - 'react/jsx-no-undef': 'error' + 'react/jsx-no-undef': 'error', + 'no-restricted-imports': [ + 'error', + { + paths: [ + { + name: 'react', + importNames: ['default'], + message: 'Please use named imports when importing from React.' + } + ] + } + ] } } ]; diff --git a/eslint.config.mjs b/eslint.config.mjs index 49dea9f6ac1..ecf67b4e756 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -101,7 +101,7 @@ export default [ 'no-new-wrappers': 'error', 'no-prototype-builtins': 'off', 'no-restricted-imports': [ - 'warn', + 'error', { paths: [ { diff --git a/packages/react-charts/src/victory/components/Chart/Chart.test.tsx b/packages/react-charts/src/victory/components/Chart/Chart.test.tsx index 160c3bfb7c7..e7ec1c59d35 100644 --- a/packages/react-charts/src/victory/components/Chart/Chart.test.tsx +++ b/packages/react-charts/src/victory/components/Chart/Chart.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from './Chart'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/Chart/Chart.tsx b/packages/react-charts/src/victory/components/Chart/Chart.tsx index ef10fcd2d87..d6d2094ac79 100644 --- a/packages/react-charts/src/victory/components/Chart/Chart.tsx +++ b/packages/react-charts/src/victory/components/Chart/Chart.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Children, cloneElement, isValidElement, useEffect } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; /* eslint-disable camelcase */ @@ -30,7 +30,6 @@ import { getComputedLegend, getLegendItemsExtraHeight, getLegendMaxTextWidth } f import { getPaddingForSide } from '../ChartUtils/chart-padding'; import { getPatternDefs, mergePatternData, useDefaultPatternProps } from '../ChartUtils/chart-patterns'; import { getChartTheme } from '../ChartUtils/chart-theme-types'; -import { useEffect } from 'react'; import { ChartLabel } from '../ChartLabel/ChartLabel'; import { ChartPoint } from '../ChartPoint/ChartPoint'; import { ChartThemeColor } from '../ChartTheme/ChartThemeColor'; @@ -69,7 +68,7 @@ export interface ChartProps extends VictoryChartProps { * The backgroundComponent prop takes a component instance which will be responsible for rendering a background if the * Chart's style component includes background styles. The new element created from the passed backgroundComponent * will be provided with the following properties calculated by Chart: height, polar, scale, style, x, y, width. - * All of these props on Background should take prececence over what VictoryChart is trying to set. + * All of these props on Background should take precedence over what VictoryChart is trying to set. */ backgroundComponent?: React.ReactElement; /** @@ -152,7 +151,7 @@ export interface ChartProps extends VictoryChartProps { * events. The eventKey may optionally be used to select a single element by index rather than * an entire set. The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -513,7 +512,7 @@ export const Chart: React.FunctionComponent = ({ containerComponent.props.labelComponent && containerComponent.props.labelComponent.type.displayName === 'ChartLegendTooltip' ) { - labelComponent = React.cloneElement(containerComponent.props.labelComponent, { + labelComponent = cloneElement(containerComponent.props.labelComponent, { theme, ...(defaultPatternScale && { patternScale: defaultPatternScale }), ...containerComponent.props.labelComponent.props @@ -521,7 +520,7 @@ export const Chart: React.FunctionComponent = ({ } // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { desc: ariaDesc, title: ariaTitle, theme, @@ -536,7 +535,7 @@ export const Chart: React.FunctionComponent = ({ legendXOffset = getLegendMaxTextWidth(legendData, theme); } - const legend = React.cloneElement(legendComponent, { + const legend = cloneElement(legendComponent, { data: legendData, ...(name && { name: `${name}-${(legendComponent as any).type.displayName}` }), orientation: legendOrientation, @@ -544,14 +543,14 @@ export const Chart: React.FunctionComponent = ({ themeColor, ...(legendDirection === 'rtl' && { dataComponent: legendComponent.props.dataComponent ? ( - React.cloneElement(legendComponent.props.dataComponent, { transform: `translate(${legendXOffset})` }) + cloneElement(legendComponent.props.dataComponent, { transform: `translate(${legendXOffset})` }) ) : ( ) }), ...(legendDirection === 'rtl' && { labelComponent: legendComponent.props.labelComponent ? ( - React.cloneElement(legendComponent.props.labelComponent, { direction: 'rtl', dx: legendXOffset - 30 }) + cloneElement(legendComponent.props.labelComponent, { direction: 'rtl', dx: legendXOffset - 30 }) ) : ( ) @@ -570,7 +569,7 @@ export const Chart: React.FunctionComponent = ({ let legendTitleHeight = legend.props.title ? 10 : 0; // Adjust for axis label - React.Children.toArray(children).map((child: any) => { + Children.toArray(children).map((child: any) => { if (child.type.role === 'axis' && child.props.label && child.props.fixAxisLabelHeight) { xAxisLabelHeight = getLabelTextSize({ text: child.props.label, theme }).height + 10; legendTitleHeight = 0; @@ -608,10 +607,10 @@ export const Chart: React.FunctionComponent = ({ // Render children const renderChildren = () => - React.Children.toArray(children).map((child, index) => { - if (React.isValidElement(child)) { + Children.toArray(children).map((child, index) => { + if (isValidElement(child)) { const { ...childProps } = child.props; - return React.cloneElement(child, { + return cloneElement(child, { colorScale, ...(defaultPatternScale && { patternScale: defaultPatternScale }), ...(name && diff --git a/packages/react-charts/src/victory/components/ChartArea/ChartArea.test.tsx b/packages/react-charts/src/victory/components/ChartArea/ChartArea.test.tsx index ee1cc9fc1a6..cec3c0c45ef 100644 --- a/packages/react-charts/src/victory/components/ChartArea/ChartArea.test.tsx +++ b/packages/react-charts/src/victory/components/ChartArea/ChartArea.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartArea } from '../ChartArea/ChartArea'; diff --git a/packages/react-charts/src/victory/components/ChartArea/ChartArea.tsx b/packages/react-charts/src/victory/components/ChartArea/ChartArea.tsx index b093f358cff..2c431291f89 100644 --- a/packages/react-charts/src/victory/components/ChartArea/ChartArea.tsx +++ b/packages/react-charts/src/victory/components/ChartArea/ChartArea.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -129,7 +129,7 @@ export interface ChartAreaProps extends VictoryAreaProps { * Since ChartArea only renders a single element, the eventKey property is not used. * The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -433,7 +433,7 @@ export const ChartArea: React.FunctionComponent = ({ ...rest }: ChartAreaProps) => { // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { theme, ...containerComponent.props }); diff --git a/packages/react-charts/src/victory/components/ChartArea/examples/ChartArea.md b/packages/react-charts/src/victory/components/ChartArea/examples/ChartArea.md index ca653b02301..375bd825d49 100644 --- a/packages/react-charts/src/victory/components/ChartArea/examples/ChartArea.md +++ b/packages/react-charts/src/victory/components/ChartArea/examples/ChartArea.md @@ -11,7 +11,7 @@ propComponents: [ ] hideDarkMode: true --- - +import { createRef } from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartThreshold, ChartThemeColor, ChartLegendTooltip, ChartVoronoiContainer, createContainer } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; @@ -23,7 +23,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic with right aligned legend ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; // import '@patternfly/patternfly/patternfly-charts.css'; // Required for mix-blend-mode CSS property @@ -88,7 +87,6 @@ import { Chart, ChartArea, ChartAxis, ChartGroup, ChartVoronoiContainer } from ' This demonstrates how to combine cursor and voronoi containers to display tooltips along with a cursor. ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartThemeColor, ChartLegendTooltip, createContainer } from '@patternfly/react-charts/victory'; // import '@patternfly/patternfly/patternfly-charts.css'; // Required for mix-blend-mode CSS property @@ -172,7 +170,6 @@ class BottomAlignedLegend extends React.Component { ### Multi-color (unordered) bottom-left aligned legend and responsive container ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; // import '@patternfly/patternfly/patternfly-charts.css'; // Required for mix-blend-mode CSS property @@ -180,7 +177,7 @@ import { getResizeObserver } from '@patternfly/react-core'; class MultiColorChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 diff --git a/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.test.tsx b/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.test.tsx index dc4eae0592f..1e85ca81f32 100644 --- a/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.test.tsx +++ b/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from '../Chart/Chart'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.tsx b/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.tsx index 8fa73d3996f..4a35625036a 100644 --- a/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.tsx +++ b/packages/react-charts/src/victory/components/ChartAxis/ChartAxis.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -117,7 +117,7 @@ export interface ChartAxisProps extends VictoryAxisProps { * single element by index rather than an entire set. The eventHandlers object * should be given as an object whose keys are standard event names (i.e. onClick) * and whose values are event callbacks. The return value of an event handler - * be used to modify other elemnts. The return value should be given as an object or + * be used to modify other elements. The return value should be given as an object or * an array of objects with optional target and eventKey keys, and a mutation * key whose value is a function. The target and eventKey keys will default to those * corresponding to the element the event handler was attached to. The mutation @@ -458,13 +458,13 @@ export const ChartAxis: React.FunctionComponent = ({ const componentTheme = getComponentTheme(themeColor); // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { theme, ...containerComponent.props }); const getAxisLabelComponent = () => - React.cloneElement(axisLabelComponent, { + cloneElement(axisLabelComponent, { ...(name && { id: () => `${name}-${(axisLabelComponent as any).type.displayName}` }), @@ -473,7 +473,7 @@ export const ChartAxis: React.FunctionComponent = ({ }); const getTickLabelComponent = () => - React.cloneElement(tickLabelComponent, { + cloneElement(tickLabelComponent, { ...(name && { id: (props: any) => `${name}-${(tickLabelComponent as any).type.displayName}-${props.index}` }), diff --git a/packages/react-charts/src/victory/components/ChartBar/ChartBar.test.tsx b/packages/react-charts/src/victory/components/ChartBar/ChartBar.test.tsx index 99b54355d0c..3a1fee8d1b3 100644 --- a/packages/react-charts/src/victory/components/ChartBar/ChartBar.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBar/ChartBar.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from '../Chart/Chart'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartBar/ChartBar.tsx b/packages/react-charts/src/victory/components/ChartBar/ChartBar.tsx index 6285b0d4052..f6b79b1efca 100644 --- a/packages/react-charts/src/victory/components/ChartBar/ChartBar.tsx +++ b/packages/react-charts/src/victory/components/ChartBar/ChartBar.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -169,7 +169,7 @@ export interface ChartBarProps extends VictoryBarProps { * The eventKey may optionally be used to select a single element by index rather than an entire * set. The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -471,7 +471,7 @@ export const ChartBar: React.FunctionComponent = ({ ...rest }: ChartBarProps) => { // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { theme, ...containerComponent.props }); diff --git a/packages/react-charts/src/victory/components/ChartBar/examples/ChartBar.md b/packages/react-charts/src/victory/components/ChartBar/examples/ChartBar.md index 6466d22dbc7..2d4b0a9385a 100644 --- a/packages/react-charts/src/victory/components/ChartBar/examples/ChartBar.md +++ b/packages/react-charts/src/victory/components/ChartBar/examples/ChartBar.md @@ -22,7 +22,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ### Basic with right aligned legend ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartGroup, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -92,7 +91,6 @@ import { Chart, ChartAxis, ChartBar, ChartGroup, ChartVoronoiContainer } from '@ This demonstrates an alternate way of applying tooltips using data labels. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartGroup, ChartThemeColor, ChartTooltip } from '@patternfly/react-charts/victory'; class EmbeddedLegend extends React.Component { @@ -170,7 +168,6 @@ class EmbeddedLegend extends React.Component { This demonstrates zoom for both the x and y axis. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartGroup, ChartThemeColor } from '@patternfly/react-charts/victory'; import { VictoryZoomContainer } from 'victory-zoom-container'; @@ -236,7 +233,6 @@ import { VictoryZoomContainer } from 'victory-zoom-container'; ### Single with right aligned legend ```js -import React from 'react'; import { Chart, ChartBar, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -278,7 +274,6 @@ import { Chart, ChartBar, ChartVoronoiContainer } from '@patternfly/react-charts A gnatt-like chart using `y` and `y0` data properties for alert start/end dates ```js -import React from 'react'; import { Chart, ChartAxis, diff --git a/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.test.tsx b/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.test.tsx index 9a478999000..72a7b5c80d6 100644 --- a/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from '../Chart/Chart'; import { ChartBoxPlot } from './ChartBoxPlot'; diff --git a/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.tsx b/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.tsx index a27aeb2c0e6..49660a60e25 100644 --- a/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.tsx +++ b/packages/react-charts/src/victory/components/ChartBoxPlot/ChartBoxPlot.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -157,7 +157,7 @@ export interface ChartBoxPlotProps extends VictoryBoxPlotProps { * The eventKey may optionally be used to select a single element by index rather than an entire * set. The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -685,7 +685,7 @@ export const ChartBoxPlot: React.FunctionComponent = ({ ...rest }: ChartBoxPlotProps) => { // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { theme, ...containerComponent.props }); diff --git a/packages/react-charts/src/victory/components/ChartBoxPlot/examples/ChartBoxPlot.md b/packages/react-charts/src/victory/components/ChartBoxPlot/examples/ChartBoxPlot.md index ee8e3822fca..cac766f7b20 100644 --- a/packages/react-charts/src/victory/components/ChartBoxPlot/examples/ChartBoxPlot.md +++ b/packages/react-charts/src/victory/components/ChartBoxPlot/examples/ChartBoxPlot.md @@ -25,7 +25,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic with right aligned legend ```js -import React from 'react'; import { Chart, ChartAxis, ChartBoxPlot, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -67,7 +66,6 @@ import { Chart, ChartAxis, ChartBoxPlot, ChartThemeColor } from '@patternfly/rea This demonstrates how to display labels. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBoxPlot, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -114,7 +112,6 @@ import { Chart, ChartAxis, ChartBoxPlot, ChartThemeColor } from '@patternfly/rea This demonstrates how to embed a legend within a tooltip. Combining cursor and voronoi containers is required to display tooltips with a vertical cursor. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBoxPlot, ChartLegendTooltip, ChartThemeColor, ChartThreshold, createContainer } from '@patternfly/react-charts/victory'; import chart_color_orange_300 from '@patternfly/react-tokens/dist/esm/chart_color_orange_300'; @@ -216,7 +213,6 @@ class EmbeddedLegend extends React.Component { This demonstrates how to embed HTML within a tooltip. Combining cursor and voronoi containers is required to display tooltips with a vertical cursor. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBoxPlot, ChartCursorTooltip, ChartThemeColor, createContainer } from '@patternfly/react-charts/victory'; class EmbeddedHtml extends React.Component { diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.test.tsx index c7986881558..d46d659c501 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartAxis } from '../ChartAxis/ChartAxis'; import { ChartLabel } from '../ChartLabel/ChartLabel'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.tsx index fd79bc04547..dc146b522b9 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBullet.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment, useEffect } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { DataGetterPropType, DomainPropType, PaddingProps } from 'victory-core'; import { VictoryChart } from 'victory-chart'; @@ -28,7 +28,6 @@ import { ChartBulletQualitativeRange } from './ChartBulletQualitativeRange'; import { getBulletDomain } from './utils/chart-bullet-domain'; import { getBulletThemeWithLegendColorScale } from './utils/chart-bullet-theme'; import { getPaddingForSide } from '../ChartUtils/chart-padding'; -import { useEffect } from 'react'; import { ChartPoint } from '../ChartPoint/ChartPoint'; import { ChartLabel } from '../ChartLabel/ChartLabel'; @@ -588,7 +587,7 @@ export const ChartBullet: React.FunctionComponent = ({ }; // Bullet group title - const bulletGroupTitle = React.cloneElement(groupTitleComponent, { + const bulletGroupTitle = cloneElement(groupTitleComponent, { height, ...(name && { name: `${name}-${(groupTitleComponent as any).type.displayName}` }), standalone: false, @@ -600,7 +599,7 @@ export const ChartBullet: React.FunctionComponent = ({ }); // Bullet title - const bulletTitle = React.cloneElement(titleComponent, { + const bulletTitle = cloneElement(titleComponent, { height, horizontal, legendPosition, @@ -617,7 +616,7 @@ export const ChartBullet: React.FunctionComponent = ({ }); // Comparative error measure - const comparativeErrorMeasure = React.cloneElement(comparativeErrorMeasureComponent, { + const comparativeErrorMeasure = cloneElement(comparativeErrorMeasureComponent, { allowTooltip, barWidth: getComparativeMeasureErrorWidth({ height: chartSize.height, @@ -641,7 +640,7 @@ export const ChartBullet: React.FunctionComponent = ({ }); // Comparative warning measure - const comparativeWarningMeasure = React.cloneElement(comparativeWarningMeasureComponent, { + const comparativeWarningMeasure = cloneElement(comparativeWarningMeasureComponent, { allowTooltip, barWidth: getComparativeMeasureWarningWidth({ height: chartSize.height, @@ -665,7 +664,7 @@ export const ChartBullet: React.FunctionComponent = ({ }); // Comparative zero measure - const comparativeZeroMeasure = React.cloneElement(comparativeZeroMeasureComponent, { + const comparativeZeroMeasure = cloneElement(comparativeZeroMeasureComponent, { barWidth: getComparativeMeasureWidth({ height: chartSize.height, horizontal, themeColor, width: chartSize.width }), data: [{ y: 0 }], domain, @@ -693,7 +692,7 @@ export const ChartBullet: React.FunctionComponent = ({ } // Legend - const legend = React.cloneElement(legendComponent, { + const legend = cloneElement(legendComponent, { data: [ ...(primaryDotMeasureLegendData ? primaryDotMeasureLegendData : []), ...(primarySegmentedMeasureLegendData ? primarySegmentedMeasureLegendData : []), @@ -709,14 +708,14 @@ export const ChartBullet: React.FunctionComponent = ({ themeColor, ...(legendDirection === 'rtl' && { dataComponent: legendComponent.props.dataComponent ? ( - React.cloneElement(legendComponent.props.dataComponent, { transform: `translate(${legendXOffset})` }) + cloneElement(legendComponent.props.dataComponent, { transform: `translate(${legendXOffset})` }) ) : ( ) }), ...(legendDirection === 'rtl' && { labelComponent: legendComponent.props.labelComponent ? ( - React.cloneElement(legendComponent.props.labelComponent, { + cloneElement(legendComponent.props.labelComponent, { direction: 'rtl', dx: legendXOffset - 30 }) @@ -728,7 +727,7 @@ export const ChartBullet: React.FunctionComponent = ({ }); // Primary dot measure - const primaryDotMeasure = React.cloneElement(primaryDotMeasureComponent, { + const primaryDotMeasure = cloneElement(primaryDotMeasureComponent, { allowTooltip, constrainToVisibleArea, data: primaryDotMeasureData, @@ -748,7 +747,7 @@ export const ChartBullet: React.FunctionComponent = ({ }); // Primary segmented measure - const primarySegmentedMeasure = React.cloneElement(primarySegmentedMeasureComponent, { + const primarySegmentedMeasure = cloneElement(primarySegmentedMeasureComponent, { allowTooltip, constrainToVisibleArea, barWidth: getPrimarySegmentedMeasureWidth({ @@ -773,7 +772,7 @@ export const ChartBullet: React.FunctionComponent = ({ }); // Qualitative range - const qualitativeRange = React.cloneElement(qualitativeRangeComponent, { + const qualitativeRange = cloneElement(qualitativeRangeComponent, { allowTooltip, constrainToVisibleArea, barWidth: getQualitativeRangeBarWidth({ height: chartSize.height, horizontal, themeColor, width: chartSize.width }), @@ -878,7 +877,7 @@ export const ChartBullet: React.FunctionComponent = ({ }; // Axis component for custom tick values - const axis = React.cloneElement(axisComponent, { + const axis = cloneElement(axisComponent, { dependentAxis: horizontal ? false : true, domain: !horizontal ? domain @@ -902,7 +901,7 @@ export const ChartBullet: React.FunctionComponent = ({ const computedLegend = getLegend(); const bulletChart = ( - + {axis} {bulletGroupTitle} {bulletTitle} @@ -913,7 +912,7 @@ export const ChartBullet: React.FunctionComponent = ({ {comparativeWarningMeasure} {getComparativeZeroMeasure()} {computedLegend} - + ); // Callback to compliment legendAllowWrap @@ -934,7 +933,7 @@ export const ChartBullet: React.FunctionComponent = ({ {bulletChart} ) : ( - {bulletChart} + {bulletChart} ); }; ChartBullet.displayName = 'ChartBullet'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.test.tsx index ee2e3468e30..0888ac5c552 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletComparativeErrorMeasure } from './ChartBulletComparativeErrorMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.tsx index 9e90749308b..60ad1770418 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeErrorMeasure.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { DataGetterPropType, DomainPropType, NumberOrCallback, PaddingProps } from 'victory-core'; import { VictoryBar } from 'victory-bar'; @@ -186,7 +186,7 @@ export const ChartBulletComparativeErrorMeasure: React.FunctionComponent { // Comparative measure component - const measure = React.cloneElement(measureComponent, { + const measure = cloneElement(measureComponent, { allowTooltip, ariaDesc, ariaTitle, @@ -212,7 +212,7 @@ export const ChartBulletComparativeErrorMeasure: React.FunctionComponent ) : ( - {measure} + {measure} ); }; ChartBulletComparativeErrorMeasure.displayName = 'ChartBulletComparativeErrorMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.test.tsx index 065596c6bb9..e26dfffb9da 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletComparativeMeasure } from './ChartBulletComparativeMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.tsx index 40b45a68f59..0ef3a57b904 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeMeasure.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { DataGetterPropType, DomainPropType, NumberOrCallback, PaddingProps } from 'victory-core'; import { VictoryBar } from 'victory-bar'; @@ -197,7 +197,7 @@ export const ChartBulletComparativeMeasure: React.FunctionComponent { if (horizontal) { @@ -218,7 +218,7 @@ export const ChartBulletComparativeMeasure: React.FunctionComponent - React.cloneElement(measureComponent, { + cloneElement(measureComponent, { barWidth, data: [{ ...dataPoint }], domain, @@ -241,7 +241,7 @@ export const ChartBulletComparativeMeasure: React.FunctionComponent ) : ( - {measure} + {measure} ); }; ChartBulletComparativeMeasure.displayName = 'ChartBulletComparativeMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.test.tsx index b1bb81c26f4..83b8fbfde6a 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletComparativeWarningMeasure } from './ChartBulletComparativeWarningMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.tsx index 8ddf308cc92..3dc5b08329c 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletComparativeWarningMeasure.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { DataGetterPropType, DomainPropType, NumberOrCallback, PaddingProps } from 'victory-core'; import { VictoryBar } from 'victory-bar'; @@ -188,7 +188,7 @@ export const ChartBulletComparativeWarningMeasure: React.FunctionComponent< width = theme.bar.width }: ChartBulletComparativeWarningMeasureProps) => { // Comparative measure component - const measure = React.cloneElement(measureComponent, { + const measure = cloneElement(measureComponent, { allowTooltip, ariaDesc, ariaTitle, @@ -214,7 +214,7 @@ export const ChartBulletComparativeWarningMeasure: React.FunctionComponent< {measure} ) : ( - {measure} + {measure} ); }; ChartBulletComparativeWarningMeasure.displayName = 'ChartBulletComparativeWarningMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.test.tsx index 68e7213ac81..6894adecf04 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletGroupTitle } from './ChartBulletGroupTitle'; import { ChartLabel } from '../ChartLabel/ChartLabel'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.tsx index 82d622c5b7b..17a9b1db978 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletGroupTitle.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import { PaddingProps, Line, StringOrNumberOrCallback } from 'victory-core'; import { ChartContainer } from '../ChartContainer/ChartContainer'; import { ChartLabel } from '../ChartLabel/ChartLabel'; @@ -154,7 +154,7 @@ export const ChartBulletGroupTitle: React.FunctionComponent `${name}-${(titleComponent as any).type.displayName}` }), style: [ChartBulletStyles.label.groupTitle, ChartBulletStyles.label.subTitle], @@ -191,10 +191,10 @@ export const ChartBulletGroupTitle: React.FunctionComponent + {getTitle()} {getDivider()} - + ); return standalone ? ( @@ -202,7 +202,7 @@ export const ChartBulletGroupTitle: React.FunctionComponent ) : ( - {groupTitle} + {groupTitle} ); }; ChartBulletGroupTitle.displayName = 'ChartBulletGroupTitle'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.test.tsx index c795926f137..42e88fe96a4 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletPrimaryDotMeasure } from './ChartBulletPrimaryDotMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.tsx index 2c105d600ee..9ee7e48a6d0 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimaryDotMeasure.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { DataGetterPropType, DomainPropType, PaddingProps } from 'victory-core'; import { VictoryScatter } from 'victory-scatter'; @@ -208,7 +208,7 @@ export const ChartBulletPrimaryDotMeasure: React.FunctionComponent - React.cloneElement(measureComponent, { + cloneElement(measureComponent, { data: [{ ...dataPoint }], domain, height, @@ -245,7 +245,7 @@ export const ChartBulletPrimaryDotMeasure: React.FunctionComponent ) : ( - {measure} + {measure} ); }; ChartBulletPrimaryDotMeasure.displayName = 'ChartBulletPrimaryDotMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.test.tsx index 80b09370953..f5cef6f4737 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletPrimarySegmentedMeasure } from './ChartBulletPrimarySegmentedMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx index f640058ebc7..14372952dc8 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { DataGetterPropType, DomainPropType, NumberOrCallback, PaddingProps } from 'victory-core'; import { VictoryBar } from 'victory-bar'; @@ -229,7 +229,7 @@ export const ChartBulletPrimarySegmentedMeasure: React.FunctionComponent { if (horizontal) { @@ -250,7 +250,7 @@ export const ChartBulletPrimarySegmentedMeasure: React.FunctionComponent - React.cloneElement(measureComponent, { + cloneElement(measureComponent, { barWidth, data: [{ ...dataPoint }], domain, @@ -278,7 +278,7 @@ export const ChartBulletPrimarySegmentedMeasure: React.FunctionComponent ) : ( - {measure} + {measure} ); }; ChartBulletPrimarySegmentedMeasure.displayName = 'ChartBulletPrimarySegmentedMeasure'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.test.tsx index 7eba951db01..eb895307124 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletQualitativeRange } from './ChartBulletQualitativeRange'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.tsx index 03568b89ef4..857e847226b 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletQualitativeRange.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { DataGetterPropType, DomainPropType, NumberOrCallback, PaddingProps } from 'victory-core'; import { VictoryBar } from 'victory-bar'; @@ -217,7 +217,7 @@ export const ChartBulletQualitativeRange: React.FunctionComponent { if (horizontal) { @@ -238,7 +238,7 @@ export const ChartBulletQualitativeRange: React.FunctionComponent - React.cloneElement(measureComponent, { + cloneElement(measureComponent, { barWidth, data: [{ ...dataPoint }], domain, @@ -266,7 +266,7 @@ export const ChartBulletQualitativeRange: React.FunctionComponent ) : ( - {measure} + {measure} ); }; ChartBulletQualitativeRange.displayName = 'ChartBulletQualitativeRange'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.test.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.test.tsx index a7574058146..884f20e163c 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.test.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartBulletTitle } from './ChartBulletTitle'; import { ChartLabel } from '../ChartLabel/ChartLabel'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.tsx b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.tsx index d2d6f595a68..aeb0635c2b7 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.tsx +++ b/packages/react-charts/src/victory/components/ChartBullet/ChartBulletTitle.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import { PaddingProps, StringOrNumberOrCallback } from 'victory-core'; import { ChartContainer } from '../ChartContainer/ChartContainer'; import { ChartLabel } from '../ChartLabel/ChartLabel'; @@ -190,7 +190,7 @@ export const ChartBulletTitle: React.FunctionComponent = // The x and y calculations below are used to adjust the position of the title, based on padding and scale. // This ensures that when padding is adjusted, the title moves along with the chart's position. - return React.cloneElement(titleComponent, { + return cloneElement(titleComponent, { ...(showBoth && { capHeight }), ...(name && { id: () => `${name}-${(titleComponent as any).type.displayName}` }), style: [ChartBulletStyles.label.title, ChartBulletStyles.label.subTitle], @@ -227,7 +227,7 @@ export const ChartBulletTitle: React.FunctionComponent = {getTitle()} ) : ( - {getTitle()} + {getTitle()} ); }; ChartBulletTitle.displayName = 'ChartBulletTitle'; diff --git a/packages/react-charts/src/victory/components/ChartBullet/examples/ChartBullet.md b/packages/react-charts/src/victory/components/ChartBullet/examples/ChartBullet.md index 821add11443..f3c0a03ca8c 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/examples/ChartBullet.md +++ b/packages/react-charts/src/victory/components/ChartBullet/examples/ChartBullet.md @@ -9,6 +9,7 @@ propComponents: [ hideDarkMode: true --- +import { createRef } from 'react'; import { ChartAxis, ChartBullet, ChartContainer, ChartThemeColor } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; @@ -20,7 +21,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -42,7 +42,6 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; ### Segmented primary measure ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -78,14 +77,13 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; This demonstrates a responsive legend which wraps when items are wider than its container. ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class BulletChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { extraHeight: 0, @@ -156,7 +154,6 @@ class BulletChart extends React.Component { ### Primary measure dot ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -192,7 +189,6 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; This is a green bullet chart with error measure and custom axis ticks with 3 legend items per row. ```js -import React from 'react'; import { ChartAxis, ChartBullet, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -232,7 +228,6 @@ import { ChartAxis, ChartBullet, ChartThemeColor } from '@patternfly/react-chart This is a yellow bullet chart with primary measure greater than max range. ```js -import React from 'react'; import { ChartBullet, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -270,7 +265,6 @@ import { ChartBullet, ChartThemeColor } from '@patternfly/react-charts/victory'; This bullet chart with negative primary measure is for measures considered to be bad when they are low. ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -307,7 +301,6 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; This reversed bullet chart with right aligned legend is for measures considered to be good when they are low. ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -347,7 +340,6 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; This bullet chart with negative and positive primary measures has 4 legend items per row. ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -382,7 +374,6 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; ### Vertical with segmented primary measure ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -416,7 +407,6 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; ### Vertical primary measure outside max range ```js -import React from 'react'; import { ChartBullet, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -452,7 +442,6 @@ import { ChartBullet, ChartThemeColor } from '@patternfly/react-charts/victory'; ### Custom labels ```js -import React from 'react'; import { ChartAxis, ChartBullet } from '@patternfly/react-charts/victory';
@@ -493,7 +482,6 @@ import { ChartAxis, ChartBullet } from '@patternfly/react-charts/victory'; ### Custom size ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory';
@@ -509,7 +497,7 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; name="chart13" padding={{ bottom: 50, - left: 150, // Adjusted to accomodate labels + left: 150, // Adjusted to accommodate labels right: 50, top: 50 }} @@ -526,7 +514,6 @@ import { ChartBullet } from '@patternfly/react-charts/victory'; ### Horizontal group ```js -import React from 'react'; import { ChartBullet, ChartContainer } from '@patternfly/react-charts/victory';
@@ -624,7 +611,6 @@ import { ChartBullet, ChartContainer } from '@patternfly/react-charts/victory'; ### Vertical group ```js -import React from 'react'; import { ChartBullet, ChartContainer } from '@patternfly/react-charts/victory';
@@ -726,7 +712,6 @@ import { ChartBullet, ChartContainer } from '@patternfly/react-charts/victory'; ### Horizontal group with title ```js -import React from 'react'; import { ChartBullet, ChartContainer } from '@patternfly/react-charts/victory';
@@ -826,7 +811,6 @@ import { ChartBullet, ChartContainer } from '@patternfly/react-charts/victory'; ### Vertical group with title ```js -import React from 'react'; import { ChartBullet, ChartContainer } from '@patternfly/react-charts/victory';
diff --git a/packages/react-charts/src/victory/components/ChartBullet/utils/chart-bullet-domain.ts b/packages/react-charts/src/victory/components/ChartBullet/utils/chart-bullet-domain.ts index a7e42a72de1..45aaedc0337 100644 --- a/packages/react-charts/src/victory/components/ChartBullet/utils/chart-bullet-domain.ts +++ b/packages/react-charts/src/victory/components/ChartBullet/utils/chart-bullet-domain.ts @@ -1,4 +1,3 @@ -import * as React from 'react'; import { ChartDomain, getDomains } from '../../ChartUtils/chart-domain'; interface ChartBulletDomainInterface { diff --git a/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.test.tsx b/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.test.tsx index 6cf8caa96ac..ddc3ab1ad9c 100644 --- a/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.test.tsx +++ b/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartLegend } from '../ChartLegend/ChartLegend'; import { ChartLabel } from '../ChartLabel/ChartLabel'; diff --git a/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.tsx b/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.tsx index 39de6c243a1..f4d9054e2f7 100644 --- a/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.tsx +++ b/packages/react-charts/src/victory/components/ChartContainer/ChartContainer.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { OriginType, VictoryContainer, VictoryContainerProps } from 'victory-core'; import { ChartThemeDefinition } from '../ChartTheme/ChartTheme'; @@ -38,7 +37,7 @@ export interface ChartContainerProps extends VictoryContainerProps { * the description, the more usable it will be for people using screen readers. * This prop defaults to an empty string. * - * @example "Golden retreivers make up 30%, Labs make up 25%, and other dog breeds are + * @example "Golden retrievers make up 30%, Labs make up 25%, and other dog breeds are * not represented above 5% each." */ desc?: string; diff --git a/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.test.tsx b/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.test.tsx index d85e03bda7d..09896c2eb72 100644 --- a/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.test.tsx +++ b/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartArea } from '../ChartArea/ChartArea'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.tsx b/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.tsx index f25bffb868e..4c459828991 100644 --- a/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.tsx +++ b/packages/react-charts/src/victory/components/ChartCursorContainer/ChartCursorContainer.tsx @@ -1,7 +1,6 @@ /* eslint-disable camelcase */ +import { cloneElement } from 'react'; import chart_global_label_Fill from '@patternfly/react-tokens/dist/esm/chart_global_label_Fill'; - -import * as React from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { LineSegment, OriginType, ValueOrAccessor, VictoryLabelProps } from 'victory-core'; import { @@ -89,7 +88,7 @@ export interface ChartCursorContainerProps extends VictoryCursorContainerProps { * the description, the more usable it will be for people using screen readers. * This prop defaults to an empty string. * - * @example "Golden retreivers make up 30%, Labs make up 25%, and other dog breeds are + * @example "Golden retrievers make up 30%, Labs make up 25%, and other dog breeds are * not represented above 5% each." */ desc?: string; @@ -212,14 +211,14 @@ export const ChartCursorContainer: React.FunctionComponent { const componentTheme = getComponentTheme(themeColor); const chartClassName = getClassName({ className }); - const chartCursorLabelComponent = React.cloneElement(cursorLabelComponent, { + const chartCursorLabelComponent = cloneElement(cursorLabelComponent, { theme, ...cursorLabelComponent.props, ...(componentTheme?.label && componentTheme.label) // override backgroundStyle }); // Clone so users can override cursor container props - const cursor = React.cloneElement(cursorComponent, { + const cursor = cloneElement(cursorComponent, { style: { strokeColor: chart_global_label_Fill.var }, diff --git a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.test.tsx b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.test.tsx index 0e182fab261..0891b5eb8a6 100644 --- a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.test.tsx +++ b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartArea } from '../ChartArea/ChartArea'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.tsx b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.tsx index 75356069836..a4af55aa015 100644 --- a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.tsx +++ b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorFlyout.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import { Helpers, OrientationTypes, Path, VictoryCommonPrimitiveProps } from 'victory-core'; import isPlainObject from 'lodash/isPlainObject'; @@ -118,7 +118,7 @@ const ChartCursorFlyout = (props: ChartCursorFlyoutProps) => { ...props }); - return React.cloneElement(props.pathComponent, { + return cloneElement(props.pathComponent, { ...props.events, style: props.style, d: getFlyoutPath(props), diff --git a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.test.tsx b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.test.tsx index 840690fa7cc..45c1fcfe6c9 100644 --- a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.test.tsx +++ b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartArea } from '../ChartArea/ChartArea'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.tsx b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.tsx index 83e600ad0a5..f1456fba3d9 100644 --- a/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.tsx +++ b/packages/react-charts/src/victory/components/ChartCursorTooltip/ChartCursorTooltip.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { Helpers, @@ -291,7 +291,7 @@ export const ChartCursorTooltip: React.FunctionComponent = ({ }); } return ( - + {getTitle({ titles: title, dy: centerSubTitle ? -8 : 0 })} {getSubTitle({ textComponent: subTitleComponent, dy: centerSubTitle ? 15 : 0 })} - + ); }; @@ -641,7 +641,7 @@ export const ChartDonut: React.FunctionComponent = ({ } const subTitleProps = textComponent.props ? textComponent.props : {}; - return React.cloneElement(textComponent, { + return cloneElement(textComponent, { ...(name && { id: `${name}-${(textComponent as any).type.displayName}-subTitle` }), key: 'pf-chart-donut-subtitle', style: ChartDonutStyles.label.subTitle, @@ -674,7 +674,7 @@ export const ChartDonut: React.FunctionComponent = ({ } const titleProps = titleComponent ? titleComponent.props : {}; - return React.cloneElement(titleComponent, { + return cloneElement(titleComponent, { ...(Array.isArray(titles) && { capHeight }), // Use capHeight with multiple labels ...(name && { id: `${name}-${(titleComponent as any).type.displayName}-title` }), key: 'pf-chart-donut-title', @@ -722,7 +722,7 @@ export const ChartDonut: React.FunctionComponent = ({ ); // Clone so users can override container props - const container = React.cloneElement( + const container = cloneElement( containerComponent, { desc: ariaDesc, @@ -736,12 +736,12 @@ export const ChartDonut: React.FunctionComponent = ({ ); return standalone ? ( - {container} + {container} ) : ( - + {chart} {getAllTitles()} - + ); }; ChartDonut.displayName = 'ChartDonut'; diff --git a/packages/react-charts/src/victory/components/ChartDonut/examples/ChartDonut.md b/packages/react-charts/src/victory/components/ChartDonut/examples/ChartDonut.md index 63e2917cad9..5d488eb093f 100644 --- a/packages/react-charts/src/victory/components/ChartDonut/examples/ChartDonut.md +++ b/packages/react-charts/src/victory/components/ChartDonut/examples/ChartDonut.md @@ -17,7 +17,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
@@ -36,7 +35,6 @@ import { ChartDonut } from '@patternfly/react-charts/victory'; ### Right aligned legend ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
@@ -65,7 +63,6 @@ import { ChartDonut } from '@patternfly/react-charts/victory'; ### Multi-color (ordered) with right aligned legend ```js -import React from 'react'; import { ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -95,7 +92,6 @@ import { ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory'; ### Bottom aligned legend ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
@@ -126,7 +122,6 @@ import { ChartDonut } from '@patternfly/react-charts/victory'; ### Small ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
@@ -147,7 +142,6 @@ import { ChartDonut } from '@patternfly/react-charts/victory'; ### Small with right aligned legend ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
@@ -177,7 +171,6 @@ import { ChartDonut } from '@patternfly/react-charts/victory'; ### Small with bottom aligned subtitle ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
@@ -208,7 +201,6 @@ import { ChartDonut } from '@patternfly/react-charts/victory'; ### Small with right aligned subtitle ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
diff --git a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.test.tsx b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.test.tsx index 913f69b374e..44642d5fd7f 100644 --- a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.test.tsx +++ b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartDonutThreshold } from './ChartDonutThreshold'; diff --git a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.tsx b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.tsx index 0f890ca31c6..62c16641768 100644 --- a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.tsx +++ b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutThreshold.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Children, cloneElement, Fragment, isValidElement } from 'react'; import { AnimatePropTypeInterface, CategoryPropType, @@ -147,7 +147,7 @@ export interface ChartDonutThresholdProps extends ChartDonutProps { * * Note: Overridden by containerComponent * - * @example "Golden retreivers make up 30%, Labs make up 25%, and other dog breeds are + * @example "Golden retrievers make up 30%, Labs make up 25%, and other dog breeds are * not represented above 5% each." */ desc?: string; @@ -170,7 +170,7 @@ export interface ChartDonutThresholdProps extends ChartDonutProps { * events. The eventKey may optionally be used to select a single element by index rather than * an entire set. The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -500,12 +500,12 @@ export const ChartDonutThreshold: React.FunctionComponent - React.Children.toArray(children).map((child, index) => { - if (React.isValidElement(child)) { + Children.toArray(children).map((child, index) => { + if (isValidElement(child)) { const { data: childData, ...childProps } = child.props; const datum = Data.formatData([childData], childProps, ['x', 'y']); // Format child data independently of this component's props const dynamicTheme = childProps.theme || getDonutThresholdDynamicTheme(childProps.themeColor || themeColor); - return React.cloneElement(child, { + return cloneElement(child, { ...(hasPatterns && { hasPatterns: true }), // Enable ChartDonutUtilization patterns constrainToVisibleArea, data: childData, @@ -554,7 +554,7 @@ export const ChartDonutThreshold: React.FunctionComponent{container} + {container} ) : ( - + {chart} {renderChildren()} - + ); }; ChartDonutThreshold.displayName = 'ChartDonutThreshold'; diff --git a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.test.tsx b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.test.tsx index 82e564ed53c..5cb9efefbfe 100644 --- a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.test.tsx +++ b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartDonutUtilization } from './ChartDonutUtilization'; diff --git a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.tsx b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.tsx index 66ffc28dccb..655783fa874 100644 --- a/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.tsx +++ b/packages/react-charts/src/victory/components/ChartDonutUtilization/ChartDonutUtilization.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import orderBy from 'lodash/orderBy'; import { @@ -146,7 +146,7 @@ export interface ChartDonutUtilizationProps extends ChartDonutProps { * * Note: Overridden by containerComponent * - * @example "Golden retreivers make up 30%, Labs make up 25%, and other dog breeds are + * @example "Golden retrievers make up 30%, Labs make up 25%, and other dog breeds are * not represented above 5% each." */ desc?: string; @@ -169,7 +169,7 @@ export interface ChartDonutUtilizationProps extends ChartDonutProps { * events. The eventKey may optionally be used to select a single element by index rather than * an entire set. The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -695,7 +695,7 @@ export const ChartDonutUtilization: React.FunctionComponent{container} : {chart}; + return standalone ? {container} : {chart}; }; ChartDonutUtilization.displayName = 'ChartDonutUtilization'; diff --git a/packages/react-charts/src/victory/components/ChartDonutUtilization/examples/ChartDonutUtilization.md b/packages/react-charts/src/victory/components/ChartDonutUtilization/examples/ChartDonutUtilization.md index c92e0521a57..408c0e23e27 100644 --- a/packages/react-charts/src/victory/components/ChartDonutUtilization/examples/ChartDonutUtilization.md +++ b/packages/react-charts/src/victory/components/ChartDonutUtilization/examples/ChartDonutUtilization.md @@ -18,7 +18,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Donut utilization examples ### Basic ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -37,7 +36,6 @@ import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; ### Right aligned legend ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; class DonutUtilizationChart extends React.Component { @@ -96,7 +94,6 @@ class DonutUtilizationChart extends React.Component { ### Inverted with right aligned legend ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; class InvertedDonutUtilizationChart extends React.Component { @@ -156,7 +153,6 @@ class InvertedDonutUtilizationChart extends React.Component { ### Right aligned vertical legend ```js -import React from 'react'; import { ChartDonutUtilization, ChartThemeColor } from '@patternfly/react-charts/victory'; class VerticalLegendUtilizationChart extends React.Component { @@ -218,7 +214,6 @@ class VerticalLegendUtilizationChart extends React.Component { ### Bottom aligned legend ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -248,7 +243,6 @@ import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; ### Small ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -269,7 +263,6 @@ import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; ### Small with right aligned legend ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; class UtilizationChart extends React.Component { @@ -332,7 +325,6 @@ class UtilizationChart extends React.Component { This is a small donut utilization chart with bottom aligned legend and right aligned subtitle. ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -363,7 +355,6 @@ import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; ### Small with right aligned subtitle ```js -import React from 'react'; import { ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -395,7 +386,6 @@ import { ChartDonutUtilization } from '@patternfly/react-charts/victory'; ## Donut utilization threshold examples ### Static thresholds ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -419,7 +409,6 @@ import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-ch ### Static thresholds with right aligned legend ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory'; class ThresholdChart extends React.Component { @@ -478,7 +467,6 @@ class ThresholdChart extends React.Component { ### Inverted static thresholds with right aligned legend ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory'; class InvertedThresholdChart extends React.Component { @@ -543,7 +531,6 @@ class InvertedThresholdChart extends React.Component { ### Static thresholds with custom legend ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization, ChartThemeColor } from '@patternfly/react-charts/victory'; class CustomLegendThresholdChart extends React.Component { @@ -605,7 +592,6 @@ class CustomLegendThresholdChart extends React.Component { ### Static thresholds with bottom aligned legend ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -639,7 +625,6 @@ import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-ch ### Small with static thresholds ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -665,7 +650,6 @@ import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-ch ### Small with static thresholds and right aligned legend ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory'; class ThresholdChart extends React.Component { @@ -728,7 +712,6 @@ class ThresholdChart extends React.Component { This is a small donut utilization chart with static thresholds with right aligned legend and bottom aligned subtitle. ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory';
@@ -764,7 +747,6 @@ import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-ch ### Small with thresholds and right aligned subtitle ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory';
diff --git a/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.test.tsx b/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.test.tsx index 7b800771eba..5d3c972ff67 100644 --- a/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.test.tsx +++ b/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartArea } from '../ChartArea/ChartArea'; import { ChartGroup } from './ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.tsx b/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.tsx index 6bb01abb496..35aa3975936 100644 --- a/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.tsx +++ b/packages/react-charts/src/victory/components/ChartGroup/ChartGroup.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -152,7 +152,7 @@ export interface ChartGroupProps extends VictoryGroupProps { * Since ChartGroup only renders a single element, the eventKey property is not used. * The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -479,7 +479,7 @@ export const ChartGroup: React.FunctionComponent = ({ ...rest }: ChartGroupProps) => { // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { desc: ariaDesc, title: ariaTitle, theme, diff --git a/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.test.tsx b/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.test.tsx index 6915a7cbf69..1f9e3f3b461 100644 --- a/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.test.tsx +++ b/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartLabel } from './ChartLabel'; diff --git a/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.tsx b/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.tsx index 00359976b9c..58c283ff22c 100644 --- a/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.tsx +++ b/packages/react-charts/src/victory/components/ChartLabel/ChartLabel.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import defaults from 'lodash/defaults'; import { @@ -54,7 +53,7 @@ export interface ChartLabelProps extends VictoryLabelProps { */ className?: string; /** - * Labels that apply to an entire data series will recieve the entire series as `data` instead of an individual datum + * Labels that apply to an entire data series will receive the entire series as `data` instead of an individual datum * prop. */ data?: any[]; @@ -111,7 +110,7 @@ export interface ChartLabelProps extends VictoryLabelProps { /** * The labelPlacement prop is used to specify the placement of labels relative to the data point they represent. * This prop may be given as “vertical”, “parallel” or “perpendicular”. This props is particularly useful in polar - * charts, where it may be desireable to position a label either parallel or perpendicular to its corresponding angle. + * charts, where it may be desirable to position a label either parallel or perpendicular to its corresponding angle. * When this prop is not set, perpendicular label placement will be used for polar charts, and vertical label * placement will be used for cartesian charts. * diff --git a/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.test.tsx b/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.test.tsx index fa40554fc4f..9f42835b0c6 100644 --- a/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.test.tsx +++ b/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartLegend } from './ChartLegend'; import { ChartLabel } from '../ChartLabel/ChartLabel'; diff --git a/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.tsx b/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.tsx index c2af1359289..d6c76c3a24f 100644 --- a/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.tsx +++ b/packages/react-charts/src/victory/components/ChartLegend/ChartLegend.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { BlockProps, @@ -45,7 +45,7 @@ export interface ChartLegendProps extends VictoryLegendProps { /** * The borderPadding specifies the amount of padding that should * be added between the legend items and the border. This prop may be given as - * a number, or asanobject with values specified for top, bottom, left, and right. + * a number, or as an object with values specified for top, bottom, left, and right. * Please note that the default width and height calculated for the border * component is based on approximated text measurements, so padding may need to be adjusted. * @@ -343,21 +343,21 @@ export const ChartLegend: React.FunctionComponent = ({ }; // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { responsive, theme, ...containerComponent.props }); const getLabelComponent = () => - React.cloneElement(labelComponent, { + cloneElement(labelComponent, { ...(name && { id: (props: any) => `${name}-${(labelComponent as any).type.displayName}-${props.index}` }), ...labelComponent.props, ...(componentTheme?.label && componentTheme.label) // override backgroundStyle }); const getTitleComponent = () => - React.cloneElement(titleComponent, { + cloneElement(titleComponent, { // Victory doesn't appear to call the id function here, but it's valid for label components ...(name && { id: () => `${name}-${(titleComponent as any).type.displayName}` }), ...titleComponent.props, diff --git a/packages/react-charts/src/victory/components/ChartLegend/examples/ChartLegend.md b/packages/react-charts/src/victory/components/ChartLegend/examples/ChartLegend.md index 4db4cccb351..d75660d145a 100644 --- a/packages/react-charts/src/victory/components/ChartLegend/examples/ChartLegend.md +++ b/packages/react-charts/src/victory/components/ChartLegend/examples/ChartLegend.md @@ -20,6 +20,7 @@ propComponents: [ hideDarkMode: true --- +import { cloneElement, createRef, useEffect, useRef, useState } from 'react'; import { Chart, ChartArea, @@ -53,7 +54,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic with right aligned legend ```js -import React from 'react'; import { ChartDonut } from '@patternfly/react-charts/victory';
@@ -82,7 +82,6 @@ import { ChartDonut } from '@patternfly/react-charts/victory'; ### Bottom aligned legend ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartGroup, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -121,14 +120,13 @@ import { Chart, ChartAxis, ChartBar, ChartGroup, ChartThemeColor, ChartVoronoiCo This demonstrates a responsive legend which wraps when items are wider than its container. ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class BulletChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { extraHeight: 0, @@ -202,7 +200,6 @@ class BulletChart extends React.Component { This demonstrates a standalone legend vs. using the `legendData` property. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLegend, ChartLine, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -278,7 +275,6 @@ import { Chart, ChartAxis, ChartGroup, ChartLegend, ChartLine, ChartThemeColor, This demonstrates how to add an interactive legend using events such as `onMouseOver`, `onMouseOut`, and `onClick`. ```js -import React from 'react'; import { Chart, ChartArea, @@ -296,9 +292,9 @@ import { getResizeObserver } from '@patternfly/react-core'; // import '@patternfly/patternfly/patternfly-charts.css'; // For mixed blend mode const InteractiveLegendChart = () => { - const containerRef = React.useRef(null); - const [hiddenSeries, setHiddenSeries] = React.useState(new Set()); - const [width, setWidth] = React.useState(0); + const containerRef = useRef(null); + const [hiddenSeries, setHiddenSeries] = useState(new Set()); + const [width, setWidth] = useState(0); const series = [ { @@ -361,7 +357,7 @@ const InteractiveLegendChart = () => { const isDataAvailable = () => hiddenSeries.size !== series.length; // Set chart width per current window size - React.useEffect(() => { + useEffect(() => { const observer = getResizeObserver(containerRef.current, () => { if (containerRef.current?.clientWidth) { setWidth(containerRef.current.clientWidth); @@ -440,7 +436,6 @@ const InteractiveLegendChart = () => { This demonstrates how to add an interactive legend to a pie chart using events such as `onMouseOver`, `onMouseOut`, and `onClick`. ```js -import React from 'react'; import { Chart, ChartLegend, @@ -558,7 +553,6 @@ class InteractivePieLegendChart extends React.Component { This demonstrates an approach for applying tooltips to a legend using a custom label component. These tooltips are keyboard navigable. ```js -import React from 'react'; import { ChartLabel, ChartLegend, ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; import { Tooltip } from '@patternfly/react-core'; @@ -569,7 +563,7 @@ class TooltipPieChart extends React.Component { // Custom legend label component // Note: Tooltip wraps children with a div tag, so we use a reference to ChartLabel instead this.LegendLabel = ({datum, ...rest}) => { - const ref = React.createRef(); + const ref = createRef(); return ( @@ -624,14 +618,13 @@ class TooltipPieChart extends React.Component { This demonstrates an approach for applying links to a legend using a custom label component. These links are keyboard navigable. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLabel, ChartLegend, ChartLine, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; class LegendLinkPieChart extends React.Component { constructor(props) { super(props); - // Custom legend label compoenent + // Custom legend label component this.LegendLabel = ({datum, ...rest}) => ( @@ -727,7 +720,6 @@ class LegendLinkPieChart extends React.Component { This demonstrates an approach for applying a different legend layout and styles using a custom label component. ```js -import React from 'react'; import { ChartLabel, ChartLegend, ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory'; import { Tooltip } from '@patternfly/react-core'; @@ -735,7 +727,7 @@ class LegendLayoutPieChart extends React.Component { constructor(props) { super(props); - // Custom legend label compoenent + // Custom legend label component this.LegendLabel = ({values, ...rest}) => ( - React.cloneElement(labelComponent, { + cloneElement(labelComponent, { center, flyoutHeight: flyoutHeight || getFlyoutHeight(props), flyoutWidth: flyoutWidth || getFlyoutWidth(props), @@ -388,7 +388,7 @@ export const ChartLegendTooltip: React.FunctionComponent : ; - return React.cloneElement(tooltipComponent, { + return cloneElement(tooltipComponent, { activePoints, center, datum, diff --git a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.test.tsx b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.test.tsx index 480a43e19b0..b1ed7c10a4b 100644 --- a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.test.tsx +++ b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartLegendTooltipContent } from './ChartLegendTooltipContent'; diff --git a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.tsx b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.tsx index d0e75a72afc..624f05d0f59 100644 --- a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.tsx +++ b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipContent.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { Helpers, NumberOrCallback, StringOrNumberOrCallback } from 'victory-core'; import { VictoryLegend } from 'victory-legend'; @@ -272,7 +272,7 @@ export const ChartLegendTooltipContent: React.FunctionComponent - React.cloneElement(labelComponent, { + cloneElement(labelComponent, { datum, dx: maxLegendDimensions.width - minLegendDimensions.width, legendData: visibleLegendData, @@ -283,7 +283,7 @@ export const ChartLegendTooltipContent: React.FunctionComponent { const _title = title instanceof Function ? title(datum) : title; - return React.cloneElement(titleComponent, { + return cloneElement(titleComponent, { style: { fill: ChartLegendTooltipStyles.label.fill, fontWeight: ChartLegendTooltipStyles.label.fontWeight @@ -298,7 +298,7 @@ export const ChartLegendTooltipContent: React.FunctionComponent - React.cloneElement(legendComponent, { + cloneElement(legendComponent, { data: getLegendTooltipVisibleData({ activePoints, colorScale: legendProps.colorScale, @@ -319,10 +319,10 @@ export const ChartLegendTooltipContent: React.FunctionComponent + {getTitleComponent()} {getLegendComponent()} - + ); }; ChartLegendTooltipContent.displayName = 'ChartLegendTooltipContent'; diff --git a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.test.tsx b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.test.tsx index 3fec86c52fa..6b6733b9b4e 100644 --- a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.test.tsx +++ b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartLegendTooltipLabel } from './ChartLegendTooltipLabel'; import { ChartLabel } from '../ChartLabel/ChartLabel'; diff --git a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.tsx b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.tsx index 5fb9c4bd58b..f5969fb2d1c 100644 --- a/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.tsx +++ b/packages/react-charts/src/victory/components/ChartLegendTooltip/ChartLegendTooltipLabel.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import defaults from 'lodash/defaults'; import { @@ -56,7 +56,7 @@ export interface ChartLegendTooltipLabelProps extends VictoryLabelProps { */ className?: string; /** - * Labels that apply to an entire data series will recieve the entire series as `data` instead of an individual datum + * Labels that apply to an entire data series will receive the entire series as `data` instead of an individual datum * prop. */ data?: any[]; @@ -109,7 +109,7 @@ export interface ChartLegendTooltipLabelProps extends VictoryLabelProps { /** * The labelPlacement prop is used to specify the placement of labels relative to the data point they represent. * This prop may be given as “vertical”, “parallel” or “perpendicular”. This props is particularly useful in polar - * charts, where it may be desireable to position a label either parallel or perpendicular to its corresponding angle. + * charts, where it may be desirable to position a label either parallel or perpendicular to its corresponding angle. * When this prop is not set, perpendicular label placement will be used for polar charts, and vertical label * placement will be used for cartesian charts. * @@ -263,7 +263,7 @@ export const ChartLegendTooltipLabel: React.FunctionComponent { const label = legendData && legendData.length ? legendData[index as any].name : undefined; - return React.cloneElement(legendLabelComponent, { + return cloneElement(legendLabelComponent, { style: getStyle({}), text: label, textAnchor: 'start', @@ -275,7 +275,7 @@ export const ChartLegendTooltipLabel: React.FunctionComponent { const _x = x + (Helpers.evaluateProp(dx, undefined) as number); - return React.cloneElement(valueLabelComponent, { + return cloneElement(valueLabelComponent, { style: getStyle(style), text, textAnchor, @@ -288,10 +288,10 @@ export const ChartLegendTooltipLabel: React.FunctionComponent + {legendLabel} {valueLabel} - + ); }; ChartLegendTooltipLabel.displayName = 'ChartLegendTooltipLabel'; diff --git a/packages/react-charts/src/victory/components/ChartLine/ChartLine.test.tsx b/packages/react-charts/src/victory/components/ChartLine/ChartLine.test.tsx index 2ac5f0cc718..aabebe15844 100644 --- a/packages/react-charts/src/victory/components/ChartLine/ChartLine.test.tsx +++ b/packages/react-charts/src/victory/components/ChartLine/ChartLine.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from '../Chart/Chart'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartLine/ChartLine.tsx b/packages/react-charts/src/victory/components/ChartLine/ChartLine.tsx index 993e682ea48..091ee3b9c5a 100644 --- a/packages/react-charts/src/victory/components/ChartLine/ChartLine.tsx +++ b/packages/react-charts/src/victory/components/ChartLine/ChartLine.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -128,7 +128,7 @@ export interface ChartLineProps extends VictoryLineProps { * Since ChartLine only renders a single element, the eventKey property is not used. * The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -434,7 +434,7 @@ export const ChartLine: React.FunctionComponent = ({ ...rest }: ChartLineProps) => { // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { theme, ...containerComponent.props }); diff --git a/packages/react-charts/src/victory/components/ChartLine/examples/ChartLine.md b/packages/react-charts/src/victory/components/ChartLine/examples/ChartLine.md index c4f4294940d..83e8fd3e6b3 100644 --- a/packages/react-charts/src/victory/components/ChartLine/examples/ChartLine.md +++ b/packages/react-charts/src/victory/components/ChartLine/examples/ChartLine.md @@ -11,6 +11,7 @@ propComponents: [ hideDarkMode: true --- +import { createRef } from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor, ChartLegendTooltip, ChartVoronoiContainer, createContainer } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; import { VictoryZoomContainer } from 'victory-zoom-container'; @@ -23,7 +24,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic with right aligned legend ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -96,7 +96,6 @@ import { Chart, ChartAxis, ChartGroup, ChartLine, ChartVoronoiContainer } from ' This demonstrates how to combine cursor and voronoi containers to display tooltips along with a cursor. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor, ChartLegendTooltip, createContainer } from '@patternfly/react-charts/victory'; class BottomAlignedLegend extends React.Component { @@ -192,7 +191,6 @@ class BottomAlignedLegend extends React.Component { This demonstrates zoom for the x axis only. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; import { VictoryZoomContainer } from 'victory-zoom-container'; @@ -200,7 +198,7 @@ import { VictoryZoomContainer } from 'victory-zoom-container'; class MultiColorChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 diff --git a/packages/react-charts/src/victory/components/ChartPie/ChartPie.test.tsx b/packages/react-charts/src/victory/components/ChartPie/ChartPie.test.tsx index 03406cfeb54..0a56a343fb7 100644 --- a/packages/react-charts/src/victory/components/ChartPie/ChartPie.test.tsx +++ b/packages/react-charts/src/victory/components/ChartPie/ChartPie.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartPie } from './ChartPie'; diff --git a/packages/react-charts/src/victory/components/ChartPie/ChartPie.tsx b/packages/react-charts/src/victory/components/ChartPie/ChartPie.tsx index bcf31af1be3..6f11821009a 100644 --- a/packages/react-charts/src/victory/components/ChartPie/ChartPie.tsx +++ b/packages/react-charts/src/victory/components/ChartPie/ChartPie.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement, Fragment, useEffect } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -32,7 +32,6 @@ import { getComputedLegend, getLegendItemsExtraHeight, getLegendMaxTextWidth } f import { getPaddingForSide } from '../ChartUtils/chart-padding'; import { getPatternDefs, useDefaultPatternProps } from '../ChartUtils/chart-patterns'; import { getTheme } from '../ChartUtils/chart-theme'; -import { useEffect } from 'react'; import { ChartPoint } from '../ChartPoint/ChartPoint'; import { ChartLabel } from '../ChartLabel/ChartLabel'; @@ -159,7 +158,7 @@ export interface ChartPieProps extends VictoryPieProps { * events. The eventKey may optionally be used to select a single element by index rather than * an entire set. The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -586,7 +585,7 @@ export const ChartPie: React.FunctionComponent = ({ legendXOffset = getLegendMaxTextWidth(legendData, theme); } - const legend = React.cloneElement(legendComponent, { + const legend = cloneElement(legendComponent, { colorScale, data: legendData, ...(name && { name: `${name}-${(legendComponent as any).type.displayName}` }), @@ -596,14 +595,14 @@ export const ChartPie: React.FunctionComponent = ({ themeColor, ...(legendDirection === 'rtl' && { dataComponent: legendComponent.props.dataComponent ? ( - React.cloneElement(legendComponent.props.dataComponent, { transform: `translate(${legendXOffset})` }) + cloneElement(legendComponent.props.dataComponent, { transform: `translate(${legendXOffset})` }) ) : ( ) }), ...(legendDirection === 'rtl' && { labelComponent: legendComponent.props.labelComponent ? ( - React.cloneElement(legendComponent.props.labelComponent, { direction: 'rtl', dx: legendXOffset - 30 }) + cloneElement(legendComponent.props.labelComponent, { direction: 'rtl', dx: legendXOffset - 30 }) ) : ( ) @@ -631,7 +630,7 @@ export const ChartPie: React.FunctionComponent = ({ // Clone so users can override container props const container = standalone - ? React.cloneElement( + ? cloneElement( containerComponent, { desc: ariaDesc, @@ -664,13 +663,13 @@ export const ChartPie: React.FunctionComponent = ({ }, [computedLegend, legendAllowWrap, theme, width]); return standalone ? ( - {container} + {container} ) : ( - + {chart} {computedLegend} {isPatternDefs && getPatternDefs({ patternId, colorScale: defaultColorScale, patternUnshiftIndex })} - + ); }; ChartPie.displayName = 'ChartPie'; diff --git a/packages/react-charts/src/victory/components/ChartPie/examples/ChartPie.md b/packages/react-charts/src/victory/components/ChartPie/examples/ChartPie.md index 41fb26fd255..8fb03c3ea8f 100644 --- a/packages/react-charts/src/victory/components/ChartPie/examples/ChartPie.md +++ b/packages/react-charts/src/victory/components/ChartPie/examples/ChartPie.md @@ -18,7 +18,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic with right aligned legend ```js -import React from 'react'; import { ChartPie } from '@patternfly/react-charts/victory';
@@ -46,7 +45,6 @@ import { ChartPie } from '@patternfly/react-charts/victory'; ### Multi-color (ordered) with bottom aligned legend ```js -import React from 'react'; import { ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -77,7 +75,6 @@ import { ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; This demonstrates how to apply a custom color scale. ```js -import React from 'react'; import { ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; import chart_theme_blue_ColorScale_100 from '@patternfly/react-tokens/dist/esm/chart_theme_blue_ColorScale_100'; import chart_theme_yellow_ColorScale_100 from '@patternfly/react-tokens/dist/esm/chart_theme_yellow_ColorScale_100'; diff --git a/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.test.tsx b/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.test.tsx index 7ffa84bef7a..a478e918757 100644 --- a/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.test.tsx +++ b/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartLabel } from '../ChartLabel/ChartLabel'; import { ChartLegend } from '../ChartLegend/ChartLegend'; diff --git a/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.tsx b/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.tsx index 8768f990c66..5bbe892c1cb 100644 --- a/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.tsx +++ b/packages/react-charts/src/victory/components/ChartPoint/ChartPoint.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import { Helpers, Path } from 'victory-core'; import { PathHelpers, PathHelpersInterface } from './path-helpers'; @@ -166,7 +166,7 @@ export const ChartPoint: React.FunctionComponent = ({ ...rest }; - return React.cloneElement(pathComponent, { + return cloneElement(pathComponent, { className, clipPath, d: getPath(props), diff --git a/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.test.tsx b/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.test.tsx index 841d25a4c67..765735b6623 100644 --- a/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.test.tsx +++ b/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from '../Chart/Chart'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.tsx b/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.tsx index 0727ccb175c..c746aae3576 100644 --- a/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.tsx +++ b/packages/react-charts/src/victory/components/ChartScatter/ChartScatter.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -131,7 +131,7 @@ export interface ChartScatterProps extends VictoryScatterProps { * Since ChartScatter only renders a single element, the eventKey property is not used. * The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. @@ -449,7 +449,7 @@ export const ChartScatter: React.FunctionComponent = ({ ...rest }: ChartScatterProps) => { // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { theme, ...containerComponent.props }); diff --git a/packages/react-charts/src/victory/components/ChartScatter/examples/ChartScatter.md b/packages/react-charts/src/victory/components/ChartScatter/examples/ChartScatter.md index 6feb3210e7c..3c8f4d304d1 100644 --- a/packages/react-charts/src/victory/components/ChartScatter/examples/ChartScatter.md +++ b/packages/react-charts/src/victory/components/ChartScatter/examples/ChartScatter.md @@ -13,6 +13,7 @@ propComponents: [ hideDarkMode: true --- +import { createRef } from 'react'; import { Chart, ChartArea, @@ -33,7 +34,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartScatter, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -73,14 +73,13 @@ import { Chart, ChartAxis, ChartGroup, ChartScatter, ChartVoronoiContainer } fro This demonstrates how to add interactive data points to a line chart. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartScatter, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class ScatterLineChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 @@ -211,7 +210,6 @@ class ScatterLineChart extends React.Component { This demonstrates how to add interactive data points to an area chart. ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartScatter, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; // import '@patternfly/patternfly/patternfly-charts.css'; // For mixed blend mode @@ -219,7 +217,7 @@ import { getResizeObserver } from '@patternfly/react-core'; class ScatterAreaChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 diff --git a/packages/react-charts/src/victory/components/ChartStack/ChartStack.test.tsx b/packages/react-charts/src/victory/components/ChartStack/ChartStack.test.tsx index 4f546e8900b..0b36c2836f1 100644 --- a/packages/react-charts/src/victory/components/ChartStack/ChartStack.test.tsx +++ b/packages/react-charts/src/victory/components/ChartStack/ChartStack.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from '../Chart/Chart'; import { ChartBar } from '../ChartBar/ChartBar'; diff --git a/packages/react-charts/src/victory/components/ChartStack/ChartStack.tsx b/packages/react-charts/src/victory/components/ChartStack/ChartStack.tsx index c22c9dec967..02beb0ae97b 100644 --- a/packages/react-charts/src/victory/components/ChartStack/ChartStack.tsx +++ b/packages/react-charts/src/victory/components/ChartStack/ChartStack.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { AnimatePropTypeInterface, @@ -61,7 +61,7 @@ export interface ChartStackProps extends VictoryStackProps { * these values for x and y. When categories are not given as an object * When this prop is set on a wrapper component, it will dictate the categories of * its the children. If this prop is not set, any categories on child component - * or catigorical data, will be merged to create a shared set of categories. + * or categorical data, will be merged to create a shared set of categories. * * @propType string[] | { x: string[], y: string[] } * @example ["dogs", "cats", "mice"] @@ -138,7 +138,7 @@ export interface ChartStackProps extends VictoryStackProps { * may optionally be used to select a single element by index or eventKey rather than * an entire set. The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey and childName keys, * and a mutation key whose value is a function. The target and eventKey and childName keys * will default to those corresponding to the element the event handler was attached to. @@ -417,7 +417,7 @@ export const ChartStack: React.FunctionComponent = ({ ...rest }: ChartStackProps) => { // Clone so users can override container props - const container = React.cloneElement(containerComponent, { + const container = cloneElement(containerComponent, { desc: ariaDesc, title: ariaTitle, theme, diff --git a/packages/react-charts/src/victory/components/ChartStack/examples/ChartStack.md b/packages/react-charts/src/victory/components/ChartStack/examples/ChartStack.md index 20340f2ef4d..dc0a428cbe8 100644 --- a/packages/react-charts/src/victory/components/ChartStack/examples/ChartStack.md +++ b/packages/react-charts/src/victory/components/ChartStack/examples/ChartStack.md @@ -11,6 +11,7 @@ propComponents: [ hideDarkMode: true --- +import { createRef } from 'react'; import { Chart, ChartArea, @@ -33,7 +34,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic with right aligned legend ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartStack, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -69,7 +69,6 @@ import { Chart, ChartAxis, ChartBar, ChartStack, ChartVoronoiContainer } from '@ ### Horizontal with bottom aligned legend ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartStack, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -108,7 +107,6 @@ import { Chart, ChartAxis, ChartBar, ChartStack, ChartThemeColor, ChartVoronoiCo This demonstrates an alternate way of applying tooltips using data labels. ```js -import React from 'react'; import { Chart, ChartBar, ChartAxis, ChartStack, ChartThemeColor, ChartTooltip } from '@patternfly/react-charts/victory';
@@ -175,14 +173,13 @@ import { Chart, ChartBar, ChartAxis, ChartStack, ChartThemeColor, ChartTooltip } ### Monthly data with responsive container ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartStack, ChartTooltip } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class MonthlyResponsiveStack extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 @@ -297,14 +294,13 @@ class MonthlyResponsiveStack extends React.Component { This demonstrates monthly data with a bottom aligned legend and responsiveness for mobile. ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartStack, ChartLegendTooltip, ChartThemeColor, createContainer } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class MultiColorChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 diff --git a/packages/react-charts/src/victory/components/ChartTheme/examples/ChartTheme.md b/packages/react-charts/src/victory/components/ChartTheme/examples/ChartTheme.md index 9d7458c9f6f..ace17ecb49d 100644 --- a/packages/react-charts/src/victory/components/ChartTheme/examples/ChartTheme.md +++ b/packages/react-charts/src/victory/components/ChartTheme/examples/ChartTheme.md @@ -37,7 +37,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s This demonstrates how to apply basic theme colors. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -110,7 +109,6 @@ import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor, ChartVoronoiC This demonstrates how to apply theme colors for ordered charts like bar, donut, pie, and stack. ```js -import React from 'react'; import { ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -143,7 +141,6 @@ import { ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory'; This demonstrates how to apply theme colors for unordered charts like area, line, and sparkline. ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -208,7 +205,6 @@ import { Chart, ChartArea, ChartAxis, ChartGroup, ChartThemeColor, ChartVoronoiC This demonstrates an alternate way of applying a custom color scale and fill colors to individual charts. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartLegend, ChartStack, ChartThemeColor, ChartTooltip } from '@patternfly/react-charts/victory'; import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_blue_300'; import chart_color_green_300 from '@patternfly/react-tokens/dist/esm/chart_color_green_300'; @@ -311,7 +307,6 @@ import chart_color_purple_300 from '@patternfly/react-tokens/dist/esm/chart_colo This demonstrates an alternate way of applying custom stroke and fill colors to a threshold chart. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor, ChartThreshold, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_blue_300'; @@ -391,7 +386,6 @@ import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_ This demonstrates custom theme properties, which may be applied across multiple charts. ```js -import React from 'react'; import { Chart, ChartBar, ChartAxis, ChartGroup, ChartThemeColor, ChartVoronoiContainer, getCustomTheme } from '@patternfly/react-charts/victory'; import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_blue_300'; import chart_color_green_300 from '@patternfly/react-tokens/dist/esm/chart_color_green_300'; diff --git a/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.test.tsx b/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.test.tsx index d1f90945439..314240ba9e0 100644 --- a/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.test.tsx +++ b/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { Chart } from '../Chart/Chart'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.tsx b/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.tsx index 9d6566d8a3d..2eb9541cf76 100644 --- a/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.tsx +++ b/packages/react-charts/src/victory/components/ChartThreshold/ChartThreshold.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import cloneDeep from 'lodash/cloneDeep'; import { @@ -126,7 +125,7 @@ export interface ChartThresholdProps extends VictoryLineProps { * Since ChartLine only renders a single element, the eventKey property is not used. * The eventHandlers object should be given as an object whose keys are standard * event names (i.e. onClick) and whose values are event callbacks. The return value - * of an event handler is used to modify elemnts. The return value should be given + * of an event handler is used to modify elements. The return value should be given * as an object or an array of objects with optional target and eventKey keys, * and a mutation key whose value is a function. The target and eventKey keys * will default to those corresponding to the element the event handler was attached to. diff --git a/packages/react-charts/src/victory/components/ChartThreshold/examples/ChartThreshold.md b/packages/react-charts/src/victory/components/ChartThreshold/examples/ChartThreshold.md index b76b8781ca7..4459735062b 100644 --- a/packages/react-charts/src/victory/components/ChartThreshold/examples/ChartThreshold.md +++ b/packages/react-charts/src/victory/components/ChartThreshold/examples/ChartThreshold.md @@ -11,6 +11,7 @@ propComponents: [ hideDarkMode: true --- +import { createRef } from 'react'; import { Chart, ChartArea, @@ -35,7 +36,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Multi-color (unordered) with responsive container ```js -import React from 'react'; import { Chart, ChartArea, @@ -53,7 +53,7 @@ import chart_color_orange_300 from '@patternfly/react-tokens/dist/esm/chart_colo class MultiColorChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 diff --git a/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.test.tsx b/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.test.tsx index 26a9fdc80ef..136b898918c 100644 --- a/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.test.tsx +++ b/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartArea } from '../ChartArea/ChartArea'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.tsx b/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.tsx index 05a890bea57..eb8b6de4df6 100644 --- a/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.tsx +++ b/packages/react-charts/src/victory/components/ChartTooltip/ChartTooltip.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { NumberOrCallback, @@ -272,7 +272,7 @@ export const ChartTooltip: React.FunctionComponent = ({ theme = getTheme(themeColor), ...rest }: ChartTooltipProps) => { - const chartLabelComponent = React.cloneElement(labelComponent, { + const chartLabelComponent = cloneElement(labelComponent, { textAnchor: labelTextAnchor, theme, ...labelComponent.props diff --git a/packages/react-charts/src/victory/components/ChartTooltip/examples/ChartTooltip.md b/packages/react-charts/src/victory/components/ChartTooltip/examples/ChartTooltip.md index 9e82556c344..b798f2e6498 100644 --- a/packages/react-charts/src/victory/components/ChartTooltip/examples/ChartTooltip.md +++ b/packages/react-charts/src/victory/components/ChartTooltip/examples/ChartTooltip.md @@ -5,6 +5,7 @@ propComponents: ['ChartTooltip'] hideDarkMode: true --- +import { createRef } from 'react'; import { Chart, ChartArea, @@ -48,7 +49,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s This demonstrates how to use a voronoi container to display tooltips. ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -112,7 +112,6 @@ import { Chart, ChartArea, ChartAxis, ChartGroup, ChartVoronoiContainer } from ' This demonstrates how to combine cursor and voronoi containers to display tooltips along with a vertical cursor. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor, createContainer } from '@patternfly/react-charts/victory'; class CombinedCursorVoronoiContainer extends React.Component { @@ -202,7 +201,6 @@ class CombinedCursorVoronoiContainer extends React.Component { This demonstrates how to embed a legend within a tooltip. Combining cursor and voronoi containers is required to display tooltips with a vertical cursor. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLegendTooltip, ChartLine, ChartThemeColor, createContainer } from '@patternfly/react-charts/victory'; class EmbeddedLegend extends React.Component { @@ -298,7 +296,6 @@ class EmbeddedLegend extends React.Component { This demonstrates how to embed HTML within a tooltip. Combining cursor and voronoi containers is required to display tooltips with a vertical cursor. ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartCursorTooltip, ChartGroup, ChartPoint, ChartThemeColor, createContainer } from '@patternfly/react-charts/victory'; class EmbeddedHtml extends React.Component { @@ -445,7 +442,6 @@ class EmbeddedHtml extends React.Component { This demonstrates how to embed a legend within a tooltip, but with a custom font size. Combining cursor and voronoi containers is required to display tooltips with a vertical cursor. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLegendTooltip, ChartLegend, ChartLine, ChartLegendTooltipContent, ChartLegendTooltipLabel, ChartThemeColor, createContainer } from '@patternfly/react-charts/victory'; class EmbeddedLegendAlt extends React.Component { @@ -545,7 +541,6 @@ class EmbeddedLegendAlt extends React.Component { This demonstrates an alternate way of applying tooltips using data labels. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartStack, ChartThemeColor, ChartTooltip } from '@patternfly/react-charts/victory';
@@ -613,7 +608,6 @@ import { Chart, ChartAxis, ChartBar, ChartStack, ChartThemeColor, ChartTooltip } ### Fixed tooltip This demonstrates how to adjust the tooltip position and label radius ```js -import React from 'react'; import { ChartDonut, ChartThemeColor, ChartTooltip } from '@patternfly/react-charts/victory';
@@ -640,7 +634,6 @@ import { ChartDonut, ChartThemeColor, ChartTooltip } from '@patternfly/react-cha This demonstrates an approach for applying tooltips to a legend using a custom legend label component. ```js -import React from 'react'; import { ChartLabel, ChartLegend, ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; import { Tooltip } from '@patternfly/react-core'; @@ -651,7 +644,7 @@ class TooltipPieChart extends React.Component { // Custom legend label component // Note: Tooltip wraps children with a div tag, so we add a reference to ChartLabel instead this.LegendLabel = ({datum, ...rest}) => { - const ref = React.createRef(); + const ref = createRef(); return ( @@ -706,7 +699,6 @@ class TooltipPieChart extends React.Component { This demonstrates how to customize tooltip label alignment using theme properties. ```js -import React from 'react'; import { Chart, ChartAxis, ChartGroup, ChartLine, ChartThemeColor, ChartVoronoiContainer, getCustomTheme } from '@patternfly/react-charts/victory'; class TooltipThemeChart extends React.Component { @@ -807,7 +799,6 @@ class TooltipThemeChart extends React.Component { This demonstrates an alternate way of applying tooltips using CSS overflow instead of constrainToVisibleArea. ```js -import React from 'react'; import { ChartArea, ChartGroup, ChartLabel, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; // Workaround for documentation-framework issue https://github.com/patternfly/patternfly-react/issues/11455 @@ -852,7 +843,6 @@ sheet.insertRule(".ws-react-charts-tooltip-overflow svg { overflow: visible; }", This demonstrates an alternate way of applying tooltips by wrapping charts with the Tooltip component. ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization } from '@patternfly/react-charts/victory'; import { Button, Tooltip, TooltipPosition } from '@patternfly/react-core'; diff --git a/packages/react-charts/src/victory/components/ChartUtils/chart-domain.ts b/packages/react-charts/src/victory/components/ChartUtils/chart-domain.ts index d180d3e3c8d..23a4a186a2c 100644 --- a/packages/react-charts/src/victory/components/ChartUtils/chart-domain.ts +++ b/packages/react-charts/src/victory/components/ChartUtils/chart-domain.ts @@ -1,4 +1,3 @@ -import * as React from 'react'; import { Data, DataGetterPropType } from 'victory-core'; interface DomainInterface { diff --git a/packages/react-charts/src/victory/components/ChartUtils/chart-legend.ts b/packages/react-charts/src/victory/components/ChartUtils/chart-legend.ts index b241eddd89b..d195cfa3ff4 100644 --- a/packages/react-charts/src/victory/components/ChartUtils/chart-legend.ts +++ b/packages/react-charts/src/victory/components/ChartUtils/chart-legend.ts @@ -1,3 +1,4 @@ +import { cloneElement } from 'react'; import defaults from 'lodash/defaults'; import { Helpers, TextSize } from 'victory-core'; import { ElementPadding } from 'victory-core/src/victory-util/helpers'; @@ -7,8 +8,6 @@ import { ChartCommonStyles } from '../ChartTheme/ChartStyles'; import { ChartThemeDefinition } from '../ChartTheme/ChartTheme'; import { getLabelTextSize } from '../ChartUtils/chart-label'; import { getPieOrigin } from './chart-origin'; -import * as React from 'react'; - interface ChartLegendInterface { allowWrap?: boolean; // Allow legend items to wrap to the next line chartType?: string; // The type of chart (e.g., pie) to lookup for props @@ -149,7 +148,7 @@ export const getComputedLegend = ({ x: legendX > 0 ? legendX : 0, y: legendY > 0 ? legendY : 0 }); - return React.cloneElement(legendComponent, legendProps); + return cloneElement(legendComponent, legendProps); }; /** diff --git a/packages/react-charts/src/victory/components/ChartUtils/chart-patterns.tsx b/packages/react-charts/src/victory/components/ChartUtils/chart-patterns.tsx index 4eb229483b1..8e95fd8ae0f 100644 --- a/packages/react-charts/src/victory/components/ChartUtils/chart-patterns.tsx +++ b/packages/react-charts/src/victory/components/ChartUtils/chart-patterns.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Children, cloneElement, Fragment, isValidElement, useMemo } from 'react'; import uniqueId from 'lodash/uniqueId'; interface PatternPropsInterface { @@ -248,7 +248,7 @@ export const getPatternDefs = ({ // This is wrapped in an empty tag so Victory does not apply child props to defs const defs = ( - + {colorScale.map((color: string, index: number) => { const { @@ -266,7 +266,7 @@ export const getPatternDefs = ({ ); })} - + ); return defs; }; @@ -332,7 +332,7 @@ export const useDefaultPatternProps = ({ const defaultColorScale = getDefaultColorScale(colorScale, themeColorScale); let defaultPatternScale = patternScale; let isPatternDefs = !patternScale && hasPatterns !== undefined; - const patternId = React.useMemo(() => (isPatternDefs ? getPatternId() : undefined), [isPatternDefs]); + const patternId = useMemo(() => (isPatternDefs ? getPatternId() : undefined), [isPatternDefs]); if (isPatternDefs) { defaultPatternScale = getDefaultPatternScale({ @@ -361,8 +361,8 @@ export const useDefaultPatternProps = ({ * @private */ export const renderChildrenWithPatterns = ({ children, patternScale, themeColor }: PatternPropsInterface) => - React.Children.toArray(children).map((child, index) => { - if (React.isValidElement(child)) { + Children.toArray(children).map((child, index) => { + if (isValidElement(child)) { const { ...childProps } = child.props; const style = childProps.style ? { ...childProps.style } : {}; @@ -374,7 +374,7 @@ export const renderChildrenWithPatterns = ({ children, patternScale, themeColor ...style.data }; } - const _child = React.cloneElement(child, { + const _child = cloneElement(child, { ...(patternScale && { patternScale }), ...(themeColor && { themeColor }), ...childProps, diff --git a/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoContainer.test.tsx b/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoContainer.test.tsx index 0938c334dee..33bd35b5ad4 100644 --- a/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoContainer.test.tsx +++ b/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoContainer.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { ChartArea } from '../ChartArea/ChartArea'; import { ChartGroup } from '../ChartGroup/ChartGroup'; diff --git a/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoiContainer.tsx b/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoiContainer.tsx index deb4629f477..ae94991e722 100644 --- a/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoiContainer.tsx +++ b/packages/react-charts/src/victory/components/ChartVoronoiContainer/ChartVoronoiContainer.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { cloneElement } from 'react'; import hoistNonReactStatics from 'hoist-non-react-statics'; import { OriginType } from 'victory-core'; import { VictoryVoronoiContainer, VictoryVoronoiContainerProps } from 'victory-voronoi-container'; @@ -63,7 +63,7 @@ export interface ChartVoronoiContainerProps extends VictoryVoronoiContainerProps * the description, the more usable it will be for people using screen readers. * This prop defaults to an empty string. * - * @example "Golden retreivers make up 30%, Labs make up 25%, and other dog breeds are + * @example "Golden retrievers make up 30%, Labs make up 25%, and other dog breeds are * not represented above 5% each." */ desc?: string; @@ -236,7 +236,7 @@ export const ChartVoronoiContainer: React.FunctionComponent { const chartClassName = getClassName({ className }); - const chartLabelComponent = React.cloneElement(labelComponent, { + const chartLabelComponent = cloneElement(labelComponent, { constrainToVisibleArea, theme, ...labelComponent.props diff --git a/packages/react-charts/src/victory/components/Patterns/examples/patterns.md b/packages/react-charts/src/victory/components/Patterns/examples/patterns.md index 22b8200dd75..28c29d55fe5 100644 --- a/packages/react-charts/src/victory/components/Patterns/examples/patterns.md +++ b/packages/react-charts/src/victory/components/Patterns/examples/patterns.md @@ -20,6 +20,7 @@ propComponents: [ hideDarkMode: true --- +import { cloneElement, createRef } from 'react'; import { Chart, ChartArea, @@ -56,7 +57,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic pie chart ```js -import React from 'react'; import { ChartPie } from '@patternfly/react-charts/victory';
@@ -85,7 +85,6 @@ import { ChartPie } from '@patternfly/react-charts/victory'; ### Bar chart ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartGroup, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -122,7 +121,6 @@ import { Chart, ChartAxis, ChartBar, ChartGroup, ChartThemeColor, ChartVoronoiCo ### Stack chart ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartStack, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -160,7 +158,6 @@ import { Chart, ChartAxis, ChartBar, ChartStack, ChartThemeColor, ChartVoronoiCo ### Donut chart ```js -import React from 'react'; import { ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -194,7 +191,6 @@ import { ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory'; This demonstrates how to hide a pattern for the static, unused portion of the donut utilization chart. ```js -import React from 'react'; import { ChartDonutUtilization, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -229,7 +225,6 @@ import { ChartDonutUtilization, ChartThemeColor } from '@patternfly/react-charts This demonstrates how to apply patterns to thresholds. ```js -import React from 'react'; import { ChartDonutThreshold, ChartDonutUtilization, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -268,7 +263,6 @@ import { ChartDonutThreshold, ChartDonutUtilization, ChartThemeColor } from '@pa This demonstrates how to add an interactive legend to a pie chart using events such as `onMouseOver`, `onMouseOut`, and `onClick`. ```js -import React from 'react'; import { Chart, ChartLegend, @@ -387,7 +381,6 @@ class InteractivePieLegendChart extends React.Component { This demonstrates how to add an interactive legend using events such as `onMouseOver`, `onMouseOut`, and `onClick`. ```js -import React from 'react'; import { Chart, ChartArea, @@ -407,7 +400,7 @@ import { getResizeObserver } from '@patternfly/react-core'; class InteractiveLegendChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { hiddenSeries: new Set(), @@ -530,7 +523,7 @@ class InteractiveLegendChart extends React.Component { render() { const { hiddenSeries, width } = this.state; - const container = React.cloneElement( + const container = cloneElement( this.cursorVoronoiContainer, { disable: !this.isDataAvailable() @@ -599,7 +592,6 @@ class InteractiveLegendChart extends React.Component { This demonstrates how to omit patterns from pie chart segments. ```js -import React from 'react'; import { ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory';
@@ -632,7 +624,6 @@ import { ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; This demonstrates how to apply a custom color scale to patterns. ```js -import React from 'react'; import { ChartPie } from '@patternfly/react-charts/victory'; import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_blue_300'; import chart_color_yellow_300 from '@patternfly/react-tokens/dist/esm/chart_color_yellow_300'; @@ -668,7 +659,6 @@ import chart_color_green_300 from '@patternfly/react-tokens/dist/esm/chart_color This demonstrates how to create custom patterns. ```js -import React from 'react'; import { ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_blue_300'; import chart_color_green_300 from '@patternfly/react-tokens/dist/esm/chart_color_green_300'; @@ -710,14 +700,13 @@ import chart_color_green_300 from '@patternfly/react-tokens/dist/esm/chart_color ### All patterns ```js -import React from 'react'; import { ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class PatternsPie extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { extraHeight: 0, diff --git a/packages/react-charts/src/victory/components/ResizeObserver/examples/resizeObserver.md b/packages/react-charts/src/victory/components/ResizeObserver/examples/resizeObserver.md index 2c260a5b053..af0649bf7d8 100644 --- a/packages/react-charts/src/victory/components/ResizeObserver/examples/resizeObserver.md +++ b/packages/react-charts/src/victory/components/ResizeObserver/examples/resizeObserver.md @@ -17,6 +17,7 @@ propComponents: [ hideDarkMode: true --- +import { createRef } from 'react'; import { Chart, ChartArea, @@ -52,14 +53,13 @@ the parent container may be set to the same height and/or width. This demonstrates how to use a `ResizeObserver` to update the chart's width, while its height remains fixed. The `legendAllowWrap` prop is used to automatically wrap legend items. ```js -import React from 'react'; import { ChartBullet } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class BulletChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { extraHeight: 0, @@ -133,7 +133,6 @@ class BulletChart extends React.Component { This demonstrates how to use a `ResizeObserver` to update the chart's width, while its height remains fixed. In this example, `itemsPerRow` is used to wrap legend items manually. ```js -import React from 'react'; import { Chart, ChartArea, @@ -151,7 +150,7 @@ import chart_color_orange_300 from '@patternfly/react-tokens/dist/esm/chart_colo class MultiColorChart extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { extraHeight: 0, @@ -294,14 +293,13 @@ class MultiColorChart extends React.Component { This demonstrates how to use a `ResizeObserver` to update the chart's width, while its height remains fixed. In this example, `fixLabelOverlap` is used to dynamically adjust the number of axis tick labels. ```js -import React from 'react'; import { Chart, ChartAxis, ChartBar, ChartStack, ChartTooltip } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; class MonthlyResponsiveStack extends React.Component { constructor(props) { super(props); - this.containerRef = React.createRef(); + this.containerRef = createRef(); this.observer = () => {}; this.state = { width: 0 diff --git a/packages/react-charts/src/victory/components/Skeletons/examples/skeletons.md b/packages/react-charts/src/victory/components/Skeletons/examples/skeletons.md index f76f1c9f409..a96990356b2 100644 --- a/packages/react-charts/src/victory/components/Skeletons/examples/skeletons.md +++ b/packages/react-charts/src/victory/components/Skeletons/examples/skeletons.md @@ -24,6 +24,7 @@ hideDarkMode: true beta: true --- +import { useState } from 'react'; import { Chart, ChartArea, ChartAxis, ChartBar, ChartBoxPlot, ChartBullet, ChartDonut, ChartDonutThreshold, ChartDonutUtilization, ChartLegend, ChartLine, ChartGroup, ChartPie, ChartScatter, ChartStack, ChartThemeColor, ChartThreshold, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; import { getResizeObserver } from '@patternfly/react-core'; import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_blue_300'; @@ -36,12 +37,11 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Area chart ```js -import React from 'react'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; import { Switch } from '@patternfly/react-core'; export const ChartAreaSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -117,12 +117,11 @@ export const ChartAreaSkeleton: React.FunctionComponent = () => { ### Bar chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartBar, ChartAxis, ChartGroup, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; export const ChartBarSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -174,12 +173,11 @@ export const ChartBarSkeleton: React.FunctionComponent = () => { ### Box plot chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core' import { Chart, ChartAxis, ChartBoxPlot, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartBoxPlotSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -232,12 +230,11 @@ export const ChartBoxPlotSkeleton: React.FunctionComponent = () => { ### Bullet chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartAxis, ChartBullet, ChartLegend, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartBulletSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -286,12 +283,11 @@ export const ChartBulletSkeleton: React.FunctionComponent = () => { ### Donut chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartAxis, ChartDonut, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartDonutSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -325,12 +321,11 @@ export const ChartDonutSkeleton: React.FunctionComponent = () => { ### Donut utilization chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartAxis, ChartDonutUtilization, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartDonutUtilizationSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -374,12 +369,11 @@ export const ChartDonutUtilizationSkeleton: React.FunctionComponent = () => { ### Donut utilization threshold ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartAxis, ChartDonutThreshold, ChartDonutUtilization, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartDonutUtilizationSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -418,12 +412,11 @@ export const ChartDonutUtilizationSkeleton: React.FunctionComponent = () => { ### Line chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartVoronoiContainer, ChartGroup, ChartAxis, ChartLine, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartLineSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -508,12 +501,11 @@ export const ChartLineSkeleton: React.FunctionComponent = () => { ### Pie chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartAxis, ChartPie, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartPieSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -556,12 +548,11 @@ export const ChartPieSkeleton: React.FunctionComponent = () => { ### Scatter chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartVoronoiContainer, ChartGroup, ChartAxis, ChartScatter, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartScatterSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -613,12 +604,11 @@ export const ChartScatterSkeleton: React.FunctionComponent = () => { ### Stack chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartVoronoiContainer, ChartAxis, ChartStack, ChartBar, ChartThemeColor } from '@patternfly/react-charts/victory'; export const ChartStackSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -669,13 +659,12 @@ export const ChartStackSkeleton: React.FunctionComponent = () => { ### Threshold chart ```js -import React from 'react'; import { Switch } from '@patternfly/react-core'; import { Chart, ChartArea, ChartAxis, ChartGroup, ChartLegend, ChartThemeColor, ChartThreshold, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; import chart_color_blue_300 from '@patternfly/react-tokens/dist/esm/chart_color_blue_300'; export const ChartThresholdSkeleton: React.FunctionComponent = () => { - const [isChecked, setIsChecked] = React.useState(true); + const [isChecked, setIsChecked] = useState(true); const handleChange = (_event: React.FormEvent, checked: boolean) => { setIsChecked(checked); @@ -715,7 +704,7 @@ export const ChartThresholdSkeleton: React.FunctionComponent = () => { } height={250} padding={{ - bottom: 100, // Adjusted to accomodate legend + bottom: 100, // Adjusted to accommodate legend left: 50, right: 50, top: 50 diff --git a/packages/react-charts/src/victory/components/Sparkline/examples/sparkline.md b/packages/react-charts/src/victory/components/Sparkline/examples/sparkline.md index a80b59b68c5..ec28ab0d7fd 100644 --- a/packages/react-charts/src/victory/components/Sparkline/examples/sparkline.md +++ b/packages/react-charts/src/victory/components/Sparkline/examples/sparkline.md @@ -25,7 +25,6 @@ PatternFly React charts are based on the [Victory](https://formidable.com/open-s ## Examples ### Basic ```js -import React from 'react'; import { ChartArea, ChartContainer, ChartGroup, ChartLabel, ChartVoronoiContainer } from '@patternfly/react-charts/victory';
@@ -61,7 +60,6 @@ import { ChartArea, ChartContainer, ChartGroup, ChartLabel, ChartVoronoiContaine This demonstrates an alternate way of applying tooltips using CSS overflow ```js -import React from 'react'; import { ChartArea, ChartContainer, ChartGroup, ChartLabel, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts/victory'; // Workaround for documentation-framework issue https://github.com/patternfly/patternfly-react/issues/11455 diff --git a/packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx b/packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx index 00567f95cca..cb514436578 100644 --- a/packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Component, createRef, Fragment } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/CodeEditor/code-editor'; import fileUploadStyles from '@patternfly/react-styles/css/components/FileUpload/file-upload'; @@ -236,11 +236,11 @@ interface CodeEditorState { copied: boolean; } -class CodeEditor extends React.Component { +class CodeEditor extends Component { static displayName = 'CodeEditor'; private editor: editor.IStandaloneCodeEditor | null = null; - private wrapperRef = React.createRef(); - private ref = React.createRef(); + private wrapperRef = createRef(); + private ref = createRef(); private timer: number | null = null; private observer = () => {}; @@ -576,7 +576,7 @@ class CodeEditor extends React.Component { !!shortcutsPopoverProps.bodyContent; const editorHeaderContent = ( - +
{isCopyEnabled && (!showEmptyState || !!value) && ( @@ -622,7 +622,7 @@ class CodeEditor extends React.Component {
)} -
+ ); const editorHeader = ( diff --git a/packages/react-code-editor/src/components/CodeEditor/CodeEditorControl.tsx b/packages/react-code-editor/src/components/CodeEditor/CodeEditorControl.tsx index d6fff968d92..aa9f716d0b3 100644 --- a/packages/react-code-editor/src/components/CodeEditor/CodeEditorControl.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/CodeEditorControl.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { useContext } from 'react'; import { Button, ButtonProps } from '@patternfly/react-core/dist/esm/components/Button'; import { Tooltip } from '@patternfly/react-core/dist/esm/components/Tooltip'; import { CodeEditorContext } from './CodeEditorUtils'; @@ -31,7 +31,7 @@ export const CodeEditorControl: React.FunctionComponent tooltipProps = {}, ...props }: CodeEditorControlProps) => { - const context = React.useContext(CodeEditorContext); + const context = useContext(CodeEditorContext); const onCustomClick = (event: React.MouseEvent) => { onClick(context.code, event); diff --git a/packages/react-code-editor/src/components/CodeEditor/CodeEditorUtils.ts b/packages/react-code-editor/src/components/CodeEditor/CodeEditorUtils.ts index cfcf938eef6..e1eb224db79 100644 --- a/packages/react-code-editor/src/components/CodeEditor/CodeEditorUtils.ts +++ b/packages/react-code-editor/src/components/CodeEditor/CodeEditorUtils.ts @@ -1,7 +1,7 @@ -import * as React from 'react'; +import { createContext } from 'react'; interface CodeEditorContext { code: string; } -export const CodeEditorContext = React.createContext(null); +export const CodeEditorContext = createContext(null); diff --git a/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx b/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx index ebdfe4c053c..7ceb91c02d5 100644 --- a/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen, act } from '@testing-library/react'; import { CodeEditor, Language } from '../CodeEditor'; import styles from '@patternfly/react-styles/css/components/CodeEditor/code-editor'; diff --git a/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditorControl.test.tsx b/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditorControl.test.tsx index 754d0bb296d..1534638dfb4 100644 --- a/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditorControl.test.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditorControl.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { CodeEditorControl } from '../CodeEditorControl'; diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md index 0b5aea6d89a..a6c980ab71a 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md @@ -7,6 +7,7 @@ propComponents: ['CodeEditor', 'CodeEditorControl', 'Popover'] Note: Code editor lives in its own package at [@patternfly/react-code-editor](https://www.npmjs.com/package/@patternfly/react-code-editor) and has [**required peer deps**](https://github.com/patternfly/patternfly-react/blob/main/packages/react-code-editor/package.json). +import { Fragment, useState } from 'react'; import { CodeEditor, CodeEditorControl, Language } from '@patternfly/react-code-editor'; import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorBasic.tsx b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorBasic.tsx index 8dd7f5a9730..b31bc694360 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorBasic.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorBasic.tsx @@ -1,12 +1,12 @@ -import React from 'react'; +import { useState } from 'react'; import { CodeEditor, Language } from '@patternfly/react-code-editor'; import { Checkbox } from '@patternfly/react-core'; export const CodeEditorBasic: React.FunctionComponent = () => { - const [isDarkTheme, setIsDarkTheme] = React.useState(false); - const [isLineNumbersVisible, setIsLineNumbersVisible] = React.useState(true); - const [isReadOnly, setIsReadOnly] = React.useState(false); - const [isMinimapVisible, setIsMinimapVisible] = React.useState(false); + const [isDarkTheme, setIsDarkTheme] = useState(false); + const [isLineNumbersVisible, setIsLineNumbersVisible] = useState(true); + const [isReadOnly, setIsReadOnly] = useState(false); + const [isMinimapVisible, setIsMinimapVisible] = useState(false); const toggleDarkTheme = (checked) => { setIsDarkTheme(checked); diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorCustomControl.tsx b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorCustomControl.tsx index e72a7c19668..fe470c3f3da 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorCustomControl.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorCustomControl.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { useState } from 'react'; import { CodeEditor, CodeEditorControl } from '@patternfly/react-code-editor'; import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; export const CodeEditorCustomControl: React.FunctionComponent = () => { - const [code, setCode] = React.useState('Some example content'); + const [code, setCode] = useState('Some example content'); const onChange = (code) => { setCode(code); diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorFullHeight.tsx b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorFullHeight.tsx index 7326455f40f..760fa00ea84 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorFullHeight.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorFullHeight.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { CodeEditor, Language } from '@patternfly/react-code-editor'; export const CodeEditorFullHeight: React.FunctionComponent = () => { diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorShortcutMainHeader.tsx b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorShortcutMainHeader.tsx index 9abfe68e0cc..5d996e38385 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorShortcutMainHeader.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorShortcutMainHeader.tsx @@ -1,11 +1,11 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { CodeEditor, Language } from '@patternfly/react-code-editor'; import { Grid, GridItem, Label, Radio } from '@patternfly/react-core'; export const CodeEditorShortcutMainHeader: React.FunctionComponent = () => { type ShortcutMode = 'PC' | 'Mac'; - const [currentShortcutMode, setCurrentShortcutMode] = React.useState('PC'); + const [currentShortcutMode, setCurrentShortcutMode] = useState('PC'); const onEditorDidMount = (editor, monaco) => { editor.layout(); @@ -51,7 +51,7 @@ export const CodeEditorShortcutMainHeader: React.FunctionComponent = () => { bodyContent: ( {shortcuts.map((shortcut, index) => ( - + {shortcut[currentShortcutMode] .map((key) => ( @@ -64,7 +64,7 @@ export const CodeEditorShortcutMainHeader: React.FunctionComponent = () => { ))} {shortcut.description} - + ))} ), diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorSizeToFit.tsx b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorSizeToFit.tsx index 330ff275219..cc1ba11ccd7 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorSizeToFit.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorSizeToFit.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { CodeEditor, Language } from '@patternfly/react-code-editor'; export const CodeEditorSizeToFit: React.FunctionComponent = () => { diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorWithActions.tsx b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorWithActions.tsx index bc0b4a4ecd2..3b530303cde 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorWithActions.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorWithActions.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { CodeEditor } from '@patternfly/react-code-editor'; export const CodeEditorWithActions: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/AboutModal/AboutModal.tsx b/packages/react-core/src/components/AboutModal/AboutModal.tsx index 8b077697215..62c4c617a4f 100644 --- a/packages/react-core/src/components/AboutModal/AboutModal.tsx +++ b/packages/react-core/src/components/AboutModal/AboutModal.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import backgroundImage from '@patternfly/react-tokens/dist/esm/c_about_modal_box_BackgroundImage'; import { AboutModalBoxContent } from './AboutModalBoxContent'; diff --git a/packages/react-core/src/components/AboutModal/AboutModalBox.tsx b/packages/react-core/src/components/AboutModal/AboutModalBox.tsx index 18810ca5184..d9ad123f792 100644 --- a/packages/react-core/src/components/AboutModal/AboutModalBox.tsx +++ b/packages/react-core/src/components/AboutModal/AboutModalBox.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/AboutModalBox/about-modal-box'; diff --git a/packages/react-core/src/components/AboutModal/AboutModalBoxBrand.tsx b/packages/react-core/src/components/AboutModal/AboutModalBoxBrand.tsx index b39299dfd49..a948f7d9ab5 100644 --- a/packages/react-core/src/components/AboutModal/AboutModalBoxBrand.tsx +++ b/packages/react-core/src/components/AboutModal/AboutModalBoxBrand.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/AboutModalBox/about-modal-box'; diff --git a/packages/react-core/src/components/AboutModal/AboutModalBoxCloseButton.tsx b/packages/react-core/src/components/AboutModal/AboutModalBoxCloseButton.tsx index 68612db3851..49de0ae2b10 100644 --- a/packages/react-core/src/components/AboutModal/AboutModalBoxCloseButton.tsx +++ b/packages/react-core/src/components/AboutModal/AboutModalBoxCloseButton.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/AboutModalBox/about-modal-box'; import { Button } from '../Button'; diff --git a/packages/react-core/src/components/AboutModal/AboutModalBoxContent.tsx b/packages/react-core/src/components/AboutModal/AboutModalBoxContent.tsx index e5b029e006b..5c0dd191e74 100644 --- a/packages/react-core/src/components/AboutModal/AboutModalBoxContent.tsx +++ b/packages/react-core/src/components/AboutModal/AboutModalBoxContent.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/AboutModalBox/about-modal-box'; import contentStyles from '@patternfly/react-styles/css/components/Content/content'; diff --git a/packages/react-core/src/components/AboutModal/AboutModalBoxHeader.tsx b/packages/react-core/src/components/AboutModal/AboutModalBoxHeader.tsx index 7634e34c136..4fe01e51cee 100644 --- a/packages/react-core/src/components/AboutModal/AboutModalBoxHeader.tsx +++ b/packages/react-core/src/components/AboutModal/AboutModalBoxHeader.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/AboutModalBox/about-modal-box'; import { Title } from '../Title'; diff --git a/packages/react-core/src/components/AboutModal/__tests__/AboutModal.test.tsx b/packages/react-core/src/components/AboutModal/__tests__/AboutModal.test.tsx index e3804acdb91..5d1b01522b5 100644 --- a/packages/react-core/src/components/AboutModal/__tests__/AboutModal.test.tsx +++ b/packages/react-core/src/components/AboutModal/__tests__/AboutModal.test.tsx @@ -1,5 +1,3 @@ -import * as React from 'react'; - import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; diff --git a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBox.test.tsx b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBox.test.tsx index 9587eb1a531..89a6245289b 100644 --- a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBox.test.tsx +++ b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBox.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { AboutModalBox } from '../AboutModalBox'; diff --git a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxBrand.test.tsx b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxBrand.test.tsx index a764474aaab..2e6ac73621f 100644 --- a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxBrand.test.tsx +++ b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxBrand.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { AboutModalBoxBrand } from '../AboutModalBoxBrand'; diff --git a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxCloseButton.test.tsx b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxCloseButton.test.tsx index 817b526a15b..75c84237b15 100644 --- a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxCloseButton.test.tsx +++ b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxCloseButton.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { AboutModalBoxCloseButton } from '../AboutModalBoxCloseButton'; diff --git a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxContent.test.tsx b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxContent.test.tsx index 62bf982fae7..e1a8d24b687 100644 --- a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxContent.test.tsx +++ b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxContent.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { AboutModalBoxContent } from '../AboutModalBoxContent'; diff --git a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxHeader.test.tsx b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxHeader.test.tsx index 5e12a89f70f..a3650189a94 100644 --- a/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxHeader.test.tsx +++ b/packages/react-core/src/components/AboutModal/__tests__/AboutModalBoxHeader.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render } from '@testing-library/react'; import { AboutModalBoxHeader } from '../AboutModalBoxHeader'; diff --git a/packages/react-core/src/components/AboutModal/examples/AboutModal.md b/packages/react-core/src/components/AboutModal/examples/AboutModal.md index a4ff40d4f69..b6f8635336a 100644 --- a/packages/react-core/src/components/AboutModal/examples/AboutModal.md +++ b/packages/react-core/src/components/AboutModal/examples/AboutModal.md @@ -4,6 +4,7 @@ section: components cssPrefix: pf-v6-c-about-modal-box propComponents: ['AboutModal'] --- +import { Fragment, useState } from 'react'; import brandImg from '../../assets/PF-IconLogo.svg'; import bgImg from '../../assets/pf-background.svg'; import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing'; diff --git a/packages/react-core/src/components/AboutModal/examples/AboutModalBasic.tsx b/packages/react-core/src/components/AboutModal/examples/AboutModalBasic.tsx index fd3fee9073c..a8b5754f452 100644 --- a/packages/react-core/src/components/AboutModal/examples/AboutModalBasic.tsx +++ b/packages/react-core/src/components/AboutModal/examples/AboutModalBasic.tsx @@ -1,16 +1,16 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { AboutModal, Button, Content } from '@patternfly/react-core'; import brandImg from '../../assets/PF-IconLogo.svg'; export const AboutModalBasic: React.FunctionComponent = () => { - const [isModalOpen, setIsModalOpen] = React.useState(false); + const [isModalOpen, setIsModalOpen] = useState(false); const toggleModal = (_event: React.MouseEvent | KeyboardEvent | MouseEvent) => { setIsModalOpen(!isModalOpen); }; return ( - + @@ -42,6 +42,6 @@ export const AboutModalBasic: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/AboutModal/examples/AboutModalComplexUserPositionedContent.tsx b/packages/react-core/src/components/AboutModal/examples/AboutModalComplexUserPositionedContent.tsx index 70a6fee69a7..45e0d9ce159 100644 --- a/packages/react-core/src/components/AboutModal/examples/AboutModalComplexUserPositionedContent.tsx +++ b/packages/react-core/src/components/AboutModal/examples/AboutModalComplexUserPositionedContent.tsx @@ -1,17 +1,17 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { AboutModal, Alert, Button, Content } from '@patternfly/react-core'; import brandImg from '../../assets/PF-IconLogo.svg'; import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing'; export const AboutModalComplexUserPositionedContent: React.FunctionComponent = () => { - const [isModalOpen, setIsModalOpen] = React.useState(false); + const [isModalOpen, setIsModalOpen] = useState(false); const toggleModal = (_event: React.MouseEvent | KeyboardEvent | MouseEvent) => { setIsModalOpen(!isModalOpen); }; return ( - + @@ -49,6 +49,6 @@ export const AboutModalComplexUserPositionedContent: React.FunctionComponent = ( - + ); }; diff --git a/packages/react-core/src/components/AboutModal/examples/AboutModalWithoutProductName.tsx b/packages/react-core/src/components/AboutModal/examples/AboutModalWithoutProductName.tsx index 0835aa257b2..c9073da724c 100644 --- a/packages/react-core/src/components/AboutModal/examples/AboutModalWithoutProductName.tsx +++ b/packages/react-core/src/components/AboutModal/examples/AboutModalWithoutProductName.tsx @@ -1,16 +1,16 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { AboutModal, Button, Content } from '@patternfly/react-core'; import brandImg from '../../assets/PF-IconLogo.svg'; export const AboutModalWithoutProductName: React.FunctionComponent = () => { - const [isModalOpen, setIsModalOpen] = React.useState(false); + const [isModalOpen, setIsModalOpen] = useState(false); const toggleModal = (_event: React.MouseEvent | KeyboardEvent | MouseEvent) => { setIsModalOpen(!isModalOpen); }; return ( - + @@ -42,6 +42,6 @@ export const AboutModalWithoutProductName: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/Accordion/Accordion.tsx b/packages/react-core/src/components/Accordion/Accordion.tsx index fedc1e21ee0..53096f97c2e 100644 --- a/packages/react-core/src/components/Accordion/Accordion.tsx +++ b/packages/react-core/src/components/Accordion/Accordion.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Accordion/accordion'; import { AccordionContext } from './AccordionContext'; diff --git a/packages/react-core/src/components/Accordion/AccordionContent.tsx b/packages/react-core/src/components/Accordion/AccordionContent.tsx index f7f5b052f0a..afb495f5988 100644 --- a/packages/react-core/src/components/Accordion/AccordionContent.tsx +++ b/packages/react-core/src/components/Accordion/AccordionContent.tsx @@ -1,4 +1,5 @@ -import * as React from 'react'; +import { useContext, useEffect, useRef, useState } from 'react'; + import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Accordion/accordion'; import { AccordionContext, AccordionItemContext } from './AccordionContext'; @@ -37,11 +38,11 @@ export const AccordionContent: React.FunctionComponent = contentBodyProps, ...props }: AccordionContentProps) => { - const [hasScrollbar, setHasScrollbar] = React.useState(false); - const containerRef = React.useRef(null); - const { isExpanded } = React.useContext(AccordionItemContext); + const [hasScrollbar, setHasScrollbar] = useState(false); + const containerRef = useRef(null); + const { isExpanded } = useContext(AccordionItemContext); - React.useEffect(() => { + useEffect(() => { if (containerRef?.current && isFixed && isExpanded) { const { offsetHeight, scrollHeight } = containerRef.current; diff --git a/packages/react-core/src/components/Accordion/AccordionContext.ts b/packages/react-core/src/components/Accordion/AccordionContext.ts index e92abd418b1..c476f15898e 100644 --- a/packages/react-core/src/components/Accordion/AccordionContext.ts +++ b/packages/react-core/src/components/Accordion/AccordionContext.ts @@ -1,5 +1,4 @@ -import * as React from 'react'; - +import { createContext } from 'react'; interface AccordionContextProps { ContentContainer: React.ElementType; ToggleContainer: React.ElementType; @@ -10,5 +9,5 @@ interface AccordionItemContextProps { isExpanded?: boolean; } -export const AccordionContext = React.createContext>({}); -export const AccordionItemContext = React.createContext({} as AccordionItemContextProps); +export const AccordionContext = createContext>({}); +export const AccordionItemContext = createContext({} as AccordionItemContextProps); diff --git a/packages/react-core/src/components/Accordion/AccordionExpandableContentBody.tsx b/packages/react-core/src/components/Accordion/AccordionExpandableContentBody.tsx index 386c837bf36..ad04610d16a 100644 --- a/packages/react-core/src/components/Accordion/AccordionExpandableContentBody.tsx +++ b/packages/react-core/src/components/Accordion/AccordionExpandableContentBody.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Accordion/accordion'; diff --git a/packages/react-core/src/components/Accordion/AccordionItem.tsx b/packages/react-core/src/components/Accordion/AccordionItem.tsx index d4ca465ed9e..07c1d7ab16e 100644 --- a/packages/react-core/src/components/Accordion/AccordionItem.tsx +++ b/packages/react-core/src/components/Accordion/AccordionItem.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Accordion/accordion'; import { AccordionItemContext } from './AccordionContext'; diff --git a/packages/react-core/src/components/Accordion/AccordionToggle.tsx b/packages/react-core/src/components/Accordion/AccordionToggle.tsx index 1cb178e640d..64bdc846455 100644 --- a/packages/react-core/src/components/Accordion/AccordionToggle.tsx +++ b/packages/react-core/src/components/Accordion/AccordionToggle.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { useContext } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Accordion/accordion'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; @@ -29,7 +29,7 @@ export const AccordionToggle: React.FunctionComponent = ({ ); - const { isExpanded } = React.useContext(AccordionItemContext); + const { isExpanded } = useContext(AccordionItemContext); return ( diff --git a/packages/react-core/src/components/Accordion/__tests__/Accordion.test.tsx b/packages/react-core/src/components/Accordion/__tests__/Accordion.test.tsx index 4d347f5d0eb..c6260e3f8cd 100644 --- a/packages/react-core/src/components/Accordion/__tests__/Accordion.test.tsx +++ b/packages/react-core/src/components/Accordion/__tests__/Accordion.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { Accordion } from '../Accordion'; diff --git a/packages/react-core/src/components/Accordion/__tests__/AccordionContent.test.tsx b/packages/react-core/src/components/Accordion/__tests__/AccordionContent.test.tsx index 2008005acf8..84f5ef02d43 100644 --- a/packages/react-core/src/components/Accordion/__tests__/AccordionContent.test.tsx +++ b/packages/react-core/src/components/Accordion/__tests__/AccordionContent.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { AccordionContent } from '../AccordionContent'; diff --git a/packages/react-core/src/components/Accordion/__tests__/AccordionExpandedContentBody.test.tsx b/packages/react-core/src/components/Accordion/__tests__/AccordionExpandedContentBody.test.tsx index 1257a00d99c..3070148b556 100644 --- a/packages/react-core/src/components/Accordion/__tests__/AccordionExpandedContentBody.test.tsx +++ b/packages/react-core/src/components/Accordion/__tests__/AccordionExpandedContentBody.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { AccordionExpandableContentBody } from '../AccordionExpandableContentBody'; diff --git a/packages/react-core/src/components/Accordion/__tests__/AccordionItem.test.tsx b/packages/react-core/src/components/Accordion/__tests__/AccordionItem.test.tsx index ec3f94b4019..f48a5cfedbe 100644 --- a/packages/react-core/src/components/Accordion/__tests__/AccordionItem.test.tsx +++ b/packages/react-core/src/components/Accordion/__tests__/AccordionItem.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { AccordionItem } from '../AccordionItem'; import styles from '@patternfly/react-styles/css/components/Accordion/accordion'; diff --git a/packages/react-core/src/components/Accordion/__tests__/AccordionToggle.test.tsx b/packages/react-core/src/components/Accordion/__tests__/AccordionToggle.test.tsx index ca45a0b2c0d..ff59083ec4f 100644 --- a/packages/react-core/src/components/Accordion/__tests__/AccordionToggle.test.tsx +++ b/packages/react-core/src/components/Accordion/__tests__/AccordionToggle.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { AccordionToggle } from '../AccordionToggle'; diff --git a/packages/react-core/src/components/Accordion/examples/AccordionBordered.tsx b/packages/react-core/src/components/Accordion/examples/AccordionBordered.tsx index 448b124eccd..7cd0a01ba40 100644 --- a/packages/react-core/src/components/Accordion/examples/AccordionBordered.tsx +++ b/packages/react-core/src/components/Accordion/examples/AccordionBordered.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Accordion, AccordionItem, diff --git a/packages/react-core/src/components/Accordion/examples/AccordionDefinitionList.tsx b/packages/react-core/src/components/Accordion/examples/AccordionDefinitionList.tsx index d91573f53ce..938877aa888 100644 --- a/packages/react-core/src/components/Accordion/examples/AccordionDefinitionList.tsx +++ b/packages/react-core/src/components/Accordion/examples/AccordionDefinitionList.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Accordion, AccordionItem, AccordionContent, AccordionToggle } from '@patternfly/react-core'; export const AccordionDefinitionList: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Accordion/examples/AccordionFixedWithMultipleExpandBehavior.tsx b/packages/react-core/src/components/Accordion/examples/AccordionFixedWithMultipleExpandBehavior.tsx index e0375c1056d..b4f68eba239 100644 --- a/packages/react-core/src/components/Accordion/examples/AccordionFixedWithMultipleExpandBehavior.tsx +++ b/packages/react-core/src/components/Accordion/examples/AccordionFixedWithMultipleExpandBehavior.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Accordion, AccordionItem, AccordionContent, AccordionToggle } from '@patternfly/react-core'; export const AccordionFixedWithMultipleExpandBehavior: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Accordion/examples/AccordionSingleExpandBehavior.tsx b/packages/react-core/src/components/Accordion/examples/AccordionSingleExpandBehavior.tsx index 17359cc4c0d..a39ebad4578 100644 --- a/packages/react-core/src/components/Accordion/examples/AccordionSingleExpandBehavior.tsx +++ b/packages/react-core/src/components/Accordion/examples/AccordionSingleExpandBehavior.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Accordion, AccordionItem, AccordionContent, AccordionToggle } from '@patternfly/react-core'; export const AccordionSingleExpandBehavior: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Accordion/examples/AccordionToggleIconAtStart.tsx b/packages/react-core/src/components/Accordion/examples/AccordionToggleIconAtStart.tsx index c347feade96..4da46e0f1d2 100644 --- a/packages/react-core/src/components/Accordion/examples/AccordionToggleIconAtStart.tsx +++ b/packages/react-core/src/components/Accordion/examples/AccordionToggleIconAtStart.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Accordion, AccordionItem, AccordionContent, AccordionToggle } from '@patternfly/react-core'; export const AccordionToggleIconAtStart: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/ActionList/ActionList.tsx b/packages/react-core/src/components/ActionList/ActionList.tsx index 8dd82ea57eb..08f0b57ed5c 100644 --- a/packages/react-core/src/components/ActionList/ActionList.tsx +++ b/packages/react-core/src/components/ActionList/ActionList.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/ActionList/action-list'; diff --git a/packages/react-core/src/components/ActionList/ActionListGroup.tsx b/packages/react-core/src/components/ActionList/ActionListGroup.tsx index 1e36985b9f7..8e5a22cb3b0 100644 --- a/packages/react-core/src/components/ActionList/ActionListGroup.tsx +++ b/packages/react-core/src/components/ActionList/ActionListGroup.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/ActionList/action-list'; diff --git a/packages/react-core/src/components/ActionList/ActionListItem.tsx b/packages/react-core/src/components/ActionList/ActionListItem.tsx index 2cc829848a3..d6827ff3801 100644 --- a/packages/react-core/src/components/ActionList/ActionListItem.tsx +++ b/packages/react-core/src/components/ActionList/ActionListItem.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/ActionList/action-list'; diff --git a/packages/react-core/src/components/ActionList/__tests__/ActionList.test.tsx b/packages/react-core/src/components/ActionList/__tests__/ActionList.test.tsx index 6512ebdb138..c1ed3bb8d47 100644 --- a/packages/react-core/src/components/ActionList/__tests__/ActionList.test.tsx +++ b/packages/react-core/src/components/ActionList/__tests__/ActionList.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { ActionList } from '../ActionList'; import styles from '@patternfly/react-styles/css/components/ActionList/action-list'; diff --git a/packages/react-core/src/components/ActionList/__tests__/ActionListGroup.test.tsx b/packages/react-core/src/components/ActionList/__tests__/ActionListGroup.test.tsx index baf4d2a4515..66a2c8fcb25 100644 --- a/packages/react-core/src/components/ActionList/__tests__/ActionListGroup.test.tsx +++ b/packages/react-core/src/components/ActionList/__tests__/ActionListGroup.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { ActionListGroup } from '../ActionListGroup'; import styles from '@patternfly/react-styles/css/components/ActionList/action-list'; diff --git a/packages/react-core/src/components/ActionList/__tests__/ActionListItem.test.tsx b/packages/react-core/src/components/ActionList/__tests__/ActionListItem.test.tsx index 18b1949d80a..6c14466d16c 100644 --- a/packages/react-core/src/components/ActionList/__tests__/ActionListItem.test.tsx +++ b/packages/react-core/src/components/ActionList/__tests__/ActionListItem.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { ActionListItem } from '../ActionListItem'; import styles from '@patternfly/react-styles/css/components/ActionList/action-list'; diff --git a/packages/react-core/src/components/ActionList/examples/ActionList.md b/packages/react-core/src/components/ActionList/examples/ActionList.md index 34f1cc9e18d..ff1e7fb698e 100644 --- a/packages/react-core/src/components/ActionList/examples/ActionList.md +++ b/packages/react-core/src/components/ActionList/examples/ActionList.md @@ -5,6 +5,7 @@ cssPrefix: pf-v6-c-action-list propComponents: ['ActionList', 'ActionListGroup', 'ActionListItem'] --- +import { Fragment } from 'react'; import TimesIcon from '@patternfly/react-icons/dist/js/icons/times-icon'; import CheckIcon from '@patternfly/react-icons/dist/js/icons/check-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; diff --git a/packages/react-core/src/components/ActionList/examples/ActionListMultipleGroups.tsx b/packages/react-core/src/components/ActionList/examples/ActionListMultipleGroups.tsx index 1ea62325003..b9f3ecec657 100644 --- a/packages/react-core/src/components/ActionList/examples/ActionListMultipleGroups.tsx +++ b/packages/react-core/src/components/ActionList/examples/ActionListMultipleGroups.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ActionList, ActionListGroup, ActionListItem, Button } from '@patternfly/react-core'; export const ActionListMultipleGroups: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ActionList/examples/ActionListSingleGroup.tsx b/packages/react-core/src/components/ActionList/examples/ActionListSingleGroup.tsx index 8b9e42d6edc..9d4ca00a6dc 100644 --- a/packages/react-core/src/components/ActionList/examples/ActionListSingleGroup.tsx +++ b/packages/react-core/src/components/ActionList/examples/ActionListSingleGroup.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { ActionList, ActionListGroup, @@ -45,7 +45,7 @@ export const ActionListSingleGroup: React.FunctionComponent = () => { ); return ( - + @@ -95,6 +95,6 @@ export const ActionListSingleGroup: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/ActionList/examples/ActionListWithCancelButton.tsx b/packages/react-core/src/components/ActionList/examples/ActionListWithCancelButton.tsx index e8cc63d8763..cbcec892798 100644 --- a/packages/react-core/src/components/ActionList/examples/ActionListWithCancelButton.tsx +++ b/packages/react-core/src/components/ActionList/examples/ActionListWithCancelButton.tsx @@ -1,8 +1,8 @@ -import React from 'react'; +import { Fragment } from 'react'; import { ActionList, ActionListGroup, ActionListItem, Button } from '@patternfly/react-core'; export const ActionListWithCancelButton: React.FunctionComponent = () => ( - + In modals, forms, data lists @@ -41,5 +41,5 @@ export const ActionListWithCancelButton: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/ActionList/examples/ActionListWithIcons.tsx b/packages/react-core/src/components/ActionList/examples/ActionListWithIcons.tsx index e2de3ea44b7..362a7e5b680 100644 --- a/packages/react-core/src/components/ActionList/examples/ActionListWithIcons.tsx +++ b/packages/react-core/src/components/ActionList/examples/ActionListWithIcons.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ActionList, ActionListGroup, ActionListItem, Button } from '@patternfly/react-core'; import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon'; import CheckIcon from '@patternfly/react-icons/dist/esm/icons/check-icon'; diff --git a/packages/react-core/src/components/Alert/Alert.tsx b/packages/react-core/src/components/Alert/Alert.tsx index 4ac3057fc12..f14cdee9e51 100644 --- a/packages/react-core/src/components/Alert/Alert.tsx +++ b/packages/react-core/src/components/Alert/Alert.tsx @@ -1,5 +1,4 @@ -import * as React from 'react'; -import { useState, type JSX } from 'react'; +import { Fragment, useEffect, useRef, useState, type JSX } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Alert/alert'; import { AlertIcon } from './AlertIcon'; @@ -115,18 +114,18 @@ export const Alert: React.FunctionComponent = ({ }: AlertProps) => { const ouiaProps = useOUIAProps(Alert.displayName, ouiaId, ouiaSafe, variant); const getHeadingContent = ( - + {variantLabel} {title} - + ); - const titleRef = React.useRef(null); + const titleRef = useRef(null); const TitleComponent = component as any; - const divRef = React.useRef(undefined); + const divRef = useRef(undefined); const [isTooltipVisible, setIsTooltipVisible] = useState(false); - React.useEffect(() => { + useEffect(() => { if (!titleRef.current || !truncateTitle) { return; } @@ -142,14 +141,14 @@ export const Alert: React.FunctionComponent = ({ const [isMouseOver, setIsMouseOver] = useState(); const [containsFocus, setContainsFocus] = useState(); const dismissed = timedOut && timedOutAnimation && !isMouseOver && !containsFocus; - React.useEffect(() => { + useEffect(() => { const calculatedTimeout = timeout === true ? 8000 : Number(timeout); if (calculatedTimeout > 0) { const timer = setTimeout(() => setTimedOut(true), calculatedTimeout); return () => clearTimeout(timer); } }, [timeout]); - React.useEffect(() => { + useEffect(() => { const onDocumentFocus = () => { if (divRef.current) { if (divRef.current.contains(document.activeElement)) { @@ -165,13 +164,13 @@ export const Alert: React.FunctionComponent = ({ return () => document.removeEventListener('focus', onDocumentFocus, true); }, [containsFocus]); - React.useEffect(() => { + useEffect(() => { if (containsFocus === false || isMouseOver === false) { const timer = setTimeout(() => setTimedOutAnimation(true), timeoutAnimation); return () => clearTimeout(timer); } }, [containsFocus, isMouseOver, timeoutAnimation]); - React.useEffect(() => { + useEffect(() => { dismissed && onTimeout(); }, [dismissed, onTimeout]); diff --git a/packages/react-core/src/components/Alert/AlertActionCloseButton.tsx b/packages/react-core/src/components/Alert/AlertActionCloseButton.tsx index a42090f8918..bc9e6c81d45 100644 --- a/packages/react-core/src/components/Alert/AlertActionCloseButton.tsx +++ b/packages/react-core/src/components/Alert/AlertActionCloseButton.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { Button, ButtonVariant, ButtonProps } from '../Button'; import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon'; import { AlertContext } from './AlertContext'; diff --git a/packages/react-core/src/components/Alert/AlertActionLink.tsx b/packages/react-core/src/components/Alert/AlertActionLink.tsx index b881e861fd9..14ee1169d39 100644 --- a/packages/react-core/src/components/Alert/AlertActionLink.tsx +++ b/packages/react-core/src/components/Alert/AlertActionLink.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { Button, ButtonVariant, ButtonProps } from '../Button'; /** Renders buttons styled as links beneath the alert title and description when this sub-component diff --git a/packages/react-core/src/components/Alert/AlertContext.ts b/packages/react-core/src/components/Alert/AlertContext.ts index cbda82bb4a0..8dcb84c14a0 100644 --- a/packages/react-core/src/components/Alert/AlertContext.ts +++ b/packages/react-core/src/components/Alert/AlertContext.ts @@ -1,8 +1,7 @@ -import * as React from 'react'; - +import { createContext } from 'react'; interface AlertContext { title: React.ReactNode; variantLabel?: string; } -export const AlertContext = React.createContext(null); +export const AlertContext = createContext(null); diff --git a/packages/react-core/src/components/Alert/AlertGroup.tsx b/packages/react-core/src/components/Alert/AlertGroup.tsx index 12c99aa8daf..798e0313aa4 100644 --- a/packages/react-core/src/components/Alert/AlertGroup.tsx +++ b/packages/react-core/src/components/Alert/AlertGroup.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Component } from 'react'; import * as ReactDOM from 'react-dom'; import { canUseDOM } from '../../helpers'; import { AlertGroupInline } from './AlertGroupInline'; @@ -26,7 +26,7 @@ interface AlertGroupState { container: HTMLElement; } -class AlertGroup extends React.Component { +class AlertGroup extends Component { static displayName = 'AlertGroup'; state = { container: undefined @@ -64,7 +64,7 @@ class AlertGroup extends React.Component { overflowMessage, 'aria-label': ariaLabel, // eslint-disable-next-line @typescript-eslint/no-unused-vars - appendTo, // dont pass down to ul + appendTo, // do not pass down to ul ...props } = this.props; const alertGroup = ( diff --git a/packages/react-core/src/components/Alert/AlertGroupInline.tsx b/packages/react-core/src/components/Alert/AlertGroupInline.tsx index 3d1ab2e058d..b8c2084d992 100644 --- a/packages/react-core/src/components/Alert/AlertGroupInline.tsx +++ b/packages/react-core/src/components/Alert/AlertGroupInline.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Children } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Alert/alert-group'; import { AlertGroupProps } from './AlertGroup'; @@ -20,7 +20,7 @@ export const AlertGroupInline: React.FunctionComponent = ({ className={css(styles.alertGroup, className, isToast ? styles.modifiers.toast : '')} {...rest} > - {React.Children.toArray(children).map((alert, index) => ( + {Children.toArray(children).map((alert, index) => (
  • ).props?.id || index}>{alert}
  • ))} {overflowMessage && ( diff --git a/packages/react-core/src/components/Alert/AlertIcon.tsx b/packages/react-core/src/components/Alert/AlertIcon.tsx index 04539a9c84c..e907f573fe9 100644 --- a/packages/react-core/src/components/Alert/AlertIcon.tsx +++ b/packages/react-core/src/components/Alert/AlertIcon.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Alert/alert'; import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon'; diff --git a/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx b/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx index 44cc37d9c37..e43692e77f1 100644 --- a/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx +++ b/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { useContext } from 'react'; import { Button, ButtonProps, ButtonVariant } from '../Button'; import { AlertContext } from './AlertContext'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; @@ -23,7 +23,7 @@ export const AlertToggleExpandButton: React.FunctionComponent { - const { title, variantLabel: alertVariantLabel } = React.useContext(AlertContext); + const { title, variantLabel: alertVariantLabel } = useContext(AlertContext); return ( ; diff --git a/packages/react-core/src/components/Button/examples/ButtonCallToAction.tsx b/packages/react-core/src/components/Button/examples/ButtonCallToAction.tsx index 3c3887a478e..c46056cbafc 100644 --- a/packages/react-core/src/components/Button/examples/ButtonCallToAction.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonCallToAction.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; import ArrowRightIcon from '@patternfly/react-icons/dist/esm/icons/arrow-right-icon'; diff --git a/packages/react-core/src/components/Button/examples/ButtonCustomComponent.tsx b/packages/react-core/src/components/Button/examples/ButtonCustomComponent.tsx index b99e659df41..c7b5fa9ebb9 100644 --- a/packages/react-core/src/components/Button/examples/ButtonCustomComponent.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonCustomComponent.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button } from '@patternfly/react-core'; export const ButtonCustomComponent: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Button/examples/ButtonDisabled.tsx b/packages/react-core/src/components/Button/examples/ButtonDisabled.tsx index e04c6158958..3483b7074d4 100644 --- a/packages/react-core/src/components/Button/examples/ButtonDisabled.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonDisabled.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; diff --git a/packages/react-core/src/components/Button/examples/ButtonInlineSpanLink.tsx b/packages/react-core/src/components/Button/examples/ButtonInlineSpanLink.tsx index 131607eb0c8..cd0a38d490d 100644 --- a/packages/react-core/src/components/Button/examples/ButtonInlineSpanLink.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonInlineSpanLink.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Button, KeyTypes } from '@patternfly/react-core'; const handleKeydown = (event: React.KeyboardEvent) => { @@ -13,7 +13,7 @@ const handleKeydown = (event: React.KeyboardEvent) => { }; export const ButtonInlineSpanLink: React.FunctionComponent = () => ( - +

    Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pressing the Enter or Space keys on the inline link as span above demonstrates this by triggering an alert.

    -
    + ); diff --git a/packages/react-core/src/components/Button/examples/ButtonLinks.tsx b/packages/react-core/src/components/Button/examples/ButtonLinks.tsx index 5a6ec5a1ead..1bd930e6b61 100644 --- a/packages/react-core/src/components/Button/examples/ButtonLinks.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonLinks.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; export const ButtonLinks: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Button/examples/ButtonPlainHasNoPadding.tsx b/packages/react-core/src/components/Button/examples/ButtonPlainHasNoPadding.tsx index 4d46c396d14..c806c367e7c 100644 --- a/packages/react-core/src/components/Button/examples/ButtonPlainHasNoPadding.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonPlainHasNoPadding.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button } from '@patternfly/react-core'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; diff --git a/packages/react-core/src/components/Button/examples/ButtonProgress.tsx b/packages/react-core/src/components/Button/examples/ButtonProgress.tsx index 39fb0ca3f47..44b07f44e3b 100644 --- a/packages/react-core/src/components/Button/examples/ButtonProgress.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonProgress.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; import UploadIcon from '@patternfly/react-icons/dist/esm/icons/upload-icon'; diff --git a/packages/react-core/src/components/Button/examples/ButtonSmall.tsx b/packages/react-core/src/components/Button/examples/ButtonSmall.tsx index 2fea0b9be89..e031f4ffaed 100644 --- a/packages/react-core/src/components/Button/examples/ButtonSmall.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonSmall.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; export const ButtonSmall: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Button/examples/ButtonStateful.tsx b/packages/react-core/src/components/Button/examples/ButtonStateful.tsx index cb26da9b8f1..b6e3094f883 100644 --- a/packages/react-core/src/components/Button/examples/ButtonStateful.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonStateful.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon'; diff --git a/packages/react-core/src/components/Button/examples/ButtonTypes.tsx b/packages/react-core/src/components/Button/examples/ButtonTypes.tsx index fb2fd288835..c07934d7918 100644 --- a/packages/react-core/src/components/Button/examples/ButtonTypes.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonTypes.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; export const ButtonTypes: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Button/examples/ButtonVariations.tsx b/packages/react-core/src/components/Button/examples/ButtonVariations.tsx index 5f2e69de722..e765e4d302e 100644 --- a/packages/react-core/src/components/Button/examples/ButtonVariations.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonVariations.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, Flex } from '@patternfly/react-core'; import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; diff --git a/packages/react-core/src/components/Button/examples/ButtonWithCount.tsx b/packages/react-core/src/components/Button/examples/ButtonWithCount.tsx index 644ef31dfd2..e56340ffb5f 100644 --- a/packages/react-core/src/components/Button/examples/ButtonWithCount.tsx +++ b/packages/react-core/src/components/Button/examples/ButtonWithCount.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { BadgeCountObject, Button, Flex } from '@patternfly/react-core'; export const ButtonWithCount: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx b/packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx index 0d672d87021..08f75672704 100644 --- a/packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx +++ b/packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx @@ -1,4 +1,4 @@ -import React, { useEffect, type JSX } from 'react'; +import { useEffect, useMemo, useRef, useState, type JSX } from 'react'; import { TextInput } from '../TextInput'; import { Button } from '../Button'; import { Select, SelectList, SelectOption } from '../Select'; @@ -148,7 +148,7 @@ export const CalendarMonth = ({ const longMonths = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11] .map((monthNum) => new Date(1990, monthNum)) .map(monthFormat); - const [isSelectOpen, setIsSelectOpen] = React.useState(false); + const [isSelectOpen, setIsSelectOpen] = useState(false); const getInitialDate = () => { if (isValidDate(dateProp)) { @@ -160,18 +160,18 @@ export const CalendarMonth = ({ return today; }; const initialDate = getInitialDate(); - const [focusedDate, setFocusedDate] = React.useState(initialDate); + const [focusedDate, setFocusedDate] = useState(initialDate); // Must be numeric given current header design const yearFormat = (date: Date) => date.getFullYear(); // const yearFormatted = yearFormat(focusedDate); - const [yearInput, setYearInput] = React.useState(yearFormatted.toString()); + const [yearInput, setYearInput] = useState(yearFormatted.toString()); - const [hoveredDate, setHoveredDate] = React.useState(undefined); - const focusRef = React.useRef(undefined); - const [hiddenMonthId] = React.useState(getUniqueId('hidden-month-span')); - const [shouldFocus, setShouldFocus] = React.useState(false); + const [hoveredDate, setHoveredDate] = useState(undefined); + const focusRef = useRef(undefined); + const [hiddenMonthId] = useState(getUniqueId('hidden-month-span')); + const [shouldFocus, setShouldFocus] = useState(false); const isValidated = (date: Date) => validators.every((validator) => validator(date)); const focusedDateValidated = isValidated(focusedDate); @@ -266,7 +266,7 @@ export const CalendarMonth = ({ const nextMonth = addMonth(1); const focusedYear = focusedDate.getFullYear(); const focusedMonth = focusedDate.getMonth(); - const calendar = React.useMemo( + const calendar = useMemo( () => buildCalendar(focusedYear, focusedMonth, weekStart, validators), [focusedYear, focusedMonth, weekStart, validators] ); diff --git a/packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx b/packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx index f94e4af16a0..28afa2b5c62 100644 --- a/packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx +++ b/packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { CalendarMonth } from '../CalendarMonth'; diff --git a/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthDateRange.tsx b/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthDateRange.tsx index 1bdfd79ea46..a2654d98e11 100644 --- a/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthDateRange.tsx +++ b/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthDateRange.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { CalendarMonth, Title, CalendarMonthInlineProps } from '@patternfly/react-core'; export const CalendarMonthDateRange: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthSelectableDate.tsx b/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthSelectableDate.tsx index cde7097ffa5..0e9d49a1065 100644 --- a/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthSelectableDate.tsx +++ b/packages/react-core/src/components/CalendarMonth/examples/CalendarMonthSelectableDate.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { CalendarMonth, Title, CalendarMonthInlineProps } from '@patternfly/react-core'; export const CalendarMonthSelectableDate: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Card/Card.tsx b/packages/react-core/src/components/Card/Card.tsx index 7dcd6e79d90..d78c9b40544 100644 --- a/packages/react-core/src/components/Card/Card.tsx +++ b/packages/react-core/src/components/Card/Card.tsx @@ -1,10 +1,8 @@ -import * as React from 'react'; +import { createContext, type JSX } from 'react'; import styles from '@patternfly/react-styles/css/components/Card/card'; import { css } from '@patternfly/react-styles'; import { useOUIAProps, OUIAProps } from '../../helpers'; -import type { JSX } from 'react'; - export interface CardProps extends React.HTMLProps, OUIAProps { /** Content rendered inside the Card */ children?: React.ReactNode; @@ -56,7 +54,7 @@ interface CardContextProps { isDisabled: boolean; } -export const CardContext = React.createContext>({ +export const CardContext = createContext>({ cardId: '', isExpanded: false, isClickable: false, diff --git a/packages/react-core/src/components/Card/CardActions.tsx b/packages/react-core/src/components/Card/CardActions.tsx index 2fbe418dc6b..5732439ea0d 100644 --- a/packages/react-core/src/components/Card/CardActions.tsx +++ b/packages/react-core/src/components/Card/CardActions.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Card/card'; diff --git a/packages/react-core/src/components/Card/CardBody.tsx b/packages/react-core/src/components/Card/CardBody.tsx index 67397e61e9f..da14d0fe16c 100644 --- a/packages/react-core/src/components/Card/CardBody.tsx +++ b/packages/react-core/src/components/Card/CardBody.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Card/card'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Card/CardExpandableContent.tsx b/packages/react-core/src/components/Card/CardExpandableContent.tsx index 9f9c538ebc9..9def7cebfba 100644 --- a/packages/react-core/src/components/Card/CardExpandableContent.tsx +++ b/packages/react-core/src/components/Card/CardExpandableContent.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Card/card'; import { css } from '@patternfly/react-styles'; import { CardContext } from './Card'; diff --git a/packages/react-core/src/components/Card/CardFooter.tsx b/packages/react-core/src/components/Card/CardFooter.tsx index 4bf7559bc2a..09078bd8931 100644 --- a/packages/react-core/src/components/Card/CardFooter.tsx +++ b/packages/react-core/src/components/Card/CardFooter.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Card/card'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Card/CardHeader.tsx b/packages/react-core/src/components/Card/CardHeader.tsx index 18e61f0ae25..06df4a1f045 100644 --- a/packages/react-core/src/components/Card/CardHeader.tsx +++ b/packages/react-core/src/components/Card/CardHeader.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Card/card'; import { CardContext } from './Card'; diff --git a/packages/react-core/src/components/Card/CardHeaderMain.tsx b/packages/react-core/src/components/Card/CardHeaderMain.tsx index 759bb18d47b..e7f4b6d25d8 100644 --- a/packages/react-core/src/components/Card/CardHeaderMain.tsx +++ b/packages/react-core/src/components/Card/CardHeaderMain.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Card/card'; diff --git a/packages/react-core/src/components/Card/CardSelectableActions.tsx b/packages/react-core/src/components/Card/CardSelectableActions.tsx index 3b86314bdc9..5a2d2d0e8f2 100644 --- a/packages/react-core/src/components/Card/CardSelectableActions.tsx +++ b/packages/react-core/src/components/Card/CardSelectableActions.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Card/card'; diff --git a/packages/react-core/src/components/Card/CardTitle.tsx b/packages/react-core/src/components/Card/CardTitle.tsx index 1d2f5448593..f5b48e82953 100644 --- a/packages/react-core/src/components/Card/CardTitle.tsx +++ b/packages/react-core/src/components/Card/CardTitle.tsx @@ -1,10 +1,8 @@ -import * as React from 'react'; +import { useContext, type JSX } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Card/card'; import { CardContext } from './Card'; -import type { JSX } from 'react'; - export interface CardTitleProps extends React.HTMLProps { /** Content rendered inside the CardTitle */ children?: React.ReactNode; @@ -20,7 +18,7 @@ export const CardTitle: React.FunctionComponent = ({ component = 'div', ...props }: CardTitleProps) => { - const { cardId } = React.useContext(CardContext); + const { cardId } = useContext(CardContext); const Component = component as any; const titleId = cardId ? `${cardId}-title` : ''; diff --git a/packages/react-core/src/components/Card/__tests__/Card.test.tsx b/packages/react-core/src/components/Card/__tests__/Card.test.tsx index 6cb6196dc3a..fa73fbbed70 100644 --- a/packages/react-core/src/components/Card/__tests__/Card.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/Card.test.tsx @@ -1,4 +1,4 @@ -import React, { type JSX } from 'react'; +import { type JSX } from 'react'; import { render, screen } from '@testing-library/react'; import '@testing-library/jest-dom'; diff --git a/packages/react-core/src/components/Card/__tests__/CardBody.test.tsx b/packages/react-core/src/components/Card/__tests__/CardBody.test.tsx index f60d6b46128..41e176eef5a 100644 --- a/packages/react-core/src/components/Card/__tests__/CardBody.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/CardBody.test.tsx @@ -1,4 +1,4 @@ -import React, { type JSX } from 'react'; +import { type JSX } from 'react'; import { render, screen } from '@testing-library/react'; import { CardBody } from '../CardBody'; diff --git a/packages/react-core/src/components/Card/__tests__/CardExpandableContent.test.tsx b/packages/react-core/src/components/Card/__tests__/CardExpandableContent.test.tsx index 72316947730..77b27e573a0 100644 --- a/packages/react-core/src/components/Card/__tests__/CardExpandableContent.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/CardExpandableContent.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { CardContext } from '../Card'; import { CardExpandableContent } from '../CardExpandableContent'; import { render } from '@testing-library/react'; diff --git a/packages/react-core/src/components/Card/__tests__/CardFooter.test.tsx b/packages/react-core/src/components/Card/__tests__/CardFooter.test.tsx index 8d81add62c6..1b2c44ed4a7 100644 --- a/packages/react-core/src/components/Card/__tests__/CardFooter.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/CardFooter.test.tsx @@ -1,4 +1,4 @@ -import React, { type JSX } from 'react'; +import { type JSX } from 'react'; import { render, screen } from '@testing-library/react'; import { CardFooter } from '../CardFooter'; diff --git a/packages/react-core/src/components/Card/__tests__/CardHeader.test.tsx b/packages/react-core/src/components/Card/__tests__/CardHeader.test.tsx index 996f024b0ec..7c7d2643629 100644 --- a/packages/react-core/src/components/Card/__tests__/CardHeader.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/CardHeader.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { CardHeader } from '../CardHeader'; diff --git a/packages/react-core/src/components/Card/__tests__/CardHeaderMain.test.tsx b/packages/react-core/src/components/Card/__tests__/CardHeaderMain.test.tsx index e72ed722d70..dd393d0d845 100644 --- a/packages/react-core/src/components/Card/__tests__/CardHeaderMain.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/CardHeaderMain.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { CardHeaderMain } from '../CardHeaderMain'; diff --git a/packages/react-core/src/components/Card/__tests__/CardSelectableActions.test.tsx b/packages/react-core/src/components/Card/__tests__/CardSelectableActions.test.tsx index 7d591ac5ddf..3f9798629cf 100644 --- a/packages/react-core/src/components/Card/__tests__/CardSelectableActions.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/CardSelectableActions.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { CardSelectableActions } from '../CardSelectableActions'; diff --git a/packages/react-core/src/components/Card/__tests__/CardTitle.test.tsx b/packages/react-core/src/components/Card/__tests__/CardTitle.test.tsx index 0aa55985b51..b198310d73f 100644 --- a/packages/react-core/src/components/Card/__tests__/CardTitle.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/CardTitle.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { CardTitle } from '../CardTitle'; diff --git a/packages/react-core/src/components/Card/__tests__/Generated/CardActions.test.tsx b/packages/react-core/src/components/Card/__tests__/Generated/CardActions.test.tsx index 9bd416885cc..5275d6e1a45 100644 --- a/packages/react-core/src/components/Card/__tests__/Generated/CardActions.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/Generated/CardActions.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { CardActions } from '../../CardActions'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/Card/examples/Card.md b/packages/react-core/src/components/Card/examples/Card.md index ef2946b0a30..11928543aee 100644 --- a/packages/react-core/src/components/Card/examples/Card.md +++ b/packages/react-core/src/components/Card/examples/Card.md @@ -16,6 +16,7 @@ propComponents: ouia: true --- +import { Fragment } from 'react'; import pfLogo from '../../assets/PF-HorizontalLogo-Color.svg'; import pfLogoSmall from '../../assets/PF-IconLogo.svg'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; diff --git a/packages/react-core/src/components/Card/examples/CardBasic.tsx b/packages/react-core/src/components/Card/examples/CardBasic.tsx index f56f572ed66..142d7e9bbb2 100644 --- a/packages/react-core/src/components/Card/examples/CardBasic.tsx +++ b/packages/react-core/src/components/Card/examples/CardBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardTitle, CardBody, CardFooter } from '@patternfly/react-core'; export const CardBasic: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardClickable.tsx b/packages/react-core/src/components/Card/examples/CardClickable.tsx index 3c0ef1c1bfd..654d8736202 100644 --- a/packages/react-core/src/components/Card/examples/CardClickable.tsx +++ b/packages/react-core/src/components/Card/examples/CardClickable.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, CardTitle, CardBody, Checkbox, Gallery } from '@patternfly/react-core'; export const CardClickable: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Card/examples/CardClickableSelectable.tsx b/packages/react-core/src/components/Card/examples/CardClickableSelectable.tsx index c72516ff21f..0e2c57537ae 100644 --- a/packages/react-core/src/components/Card/examples/CardClickableSelectable.tsx +++ b/packages/react-core/src/components/Card/examples/CardClickableSelectable.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, CardTitle, CardBody, Button, Checkbox, Gallery } from '@patternfly/react-core'; export const CardClickable: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Card/examples/CardExpandable.tsx b/packages/react-core/src/components/Card/examples/CardExpandable.tsx index 7ddbd946ed3..39378dfe660 100644 --- a/packages/react-core/src/components/Card/examples/CardExpandable.tsx +++ b/packages/react-core/src/components/Card/examples/CardExpandable.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Card, CardHeader, @@ -90,7 +90,7 @@ export const CardExpandable: React.FunctionComponent = () => { ); return ( - +
    { Footer - + ); }; diff --git a/packages/react-core/src/components/Card/examples/CardExpandableWithIcon.tsx b/packages/react-core/src/components/Card/examples/CardExpandableWithIcon.tsx index 7dc038535c2..fb3a227622a 100644 --- a/packages/react-core/src/components/Card/examples/CardExpandableWithIcon.tsx +++ b/packages/react-core/src/components/Card/examples/CardExpandableWithIcon.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, diff --git a/packages/react-core/src/components/Card/examples/CardHeaderInCardHead.tsx b/packages/react-core/src/components/Card/examples/CardHeaderInCardHead.tsx index ac2e7f4c062..59ce8254bcc 100644 --- a/packages/react-core/src/components/Card/examples/CardHeaderInCardHead.tsx +++ b/packages/react-core/src/components/Card/examples/CardHeaderInCardHead.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, diff --git a/packages/react-core/src/components/Card/examples/CardOnlyActionsInCardHead.tsx b/packages/react-core/src/components/Card/examples/CardOnlyActionsInCardHead.tsx index 3e97f2561e4..e955f1c5c18 100644 --- a/packages/react-core/src/components/Card/examples/CardOnlyActionsInCardHead.tsx +++ b/packages/react-core/src/components/Card/examples/CardOnlyActionsInCardHead.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Checkbox, Card, diff --git a/packages/react-core/src/components/Card/examples/CardSecondary.tsx b/packages/react-core/src/components/Card/examples/CardSecondary.tsx index 7efa4fd9c2e..451bd36ce56 100644 --- a/packages/react-core/src/components/Card/examples/CardSecondary.tsx +++ b/packages/react-core/src/components/Card/examples/CardSecondary.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardTitle, CardBody, CardFooter } from '@patternfly/react-core'; export const CardSecondary: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardSelectable.tsx b/packages/react-core/src/components/Card/examples/CardSelectable.tsx index 83aac5c128f..26c3aca9393 100644 --- a/packages/react-core/src/components/Card/examples/CardSelectable.tsx +++ b/packages/react-core/src/components/Card/examples/CardSelectable.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, CardTitle, CardBody, Checkbox, Gallery } from '@patternfly/react-core'; export const SelectableCard: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Card/examples/CardSingleSelectable.tsx b/packages/react-core/src/components/Card/examples/CardSingleSelectable.tsx index 63db53153e8..f6073dd47de 100644 --- a/packages/react-core/src/components/Card/examples/CardSingleSelectable.tsx +++ b/packages/react-core/src/components/Card/examples/CardSingleSelectable.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, CardTitle, CardBody, Gallery } from '@patternfly/react-core'; export const SingleSelectableCard: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Card/examples/CardTile.tsx b/packages/react-core/src/components/Card/examples/CardTile.tsx index 9fdbadaacea..24f0f41c0ec 100644 --- a/packages/react-core/src/components/Card/examples/CardTile.tsx +++ b/packages/react-core/src/components/Card/examples/CardTile.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, CardBody, Gallery, Flex } from '@patternfly/react-core'; import PlusIcon from '@patternfly/react-icons/dist/esm/icons/plus-icon'; diff --git a/packages/react-core/src/components/Card/examples/CardTileMulti.tsx b/packages/react-core/src/components/Card/examples/CardTileMulti.tsx index 87a453ad1d5..310e037dd1e 100644 --- a/packages/react-core/src/components/Card/examples/CardTileMulti.tsx +++ b/packages/react-core/src/components/Card/examples/CardTileMulti.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardHeader, CardBody, Gallery, Flex } from '@patternfly/react-core'; import PlusIcon from '@patternfly/react-icons/dist/esm/icons/plus-icon'; diff --git a/packages/react-core/src/components/Card/examples/CardWithBodySectionFills.tsx b/packages/react-core/src/components/Card/examples/CardWithBodySectionFills.tsx index 646df9fd57f..2706d01ef60 100644 --- a/packages/react-core/src/components/Card/examples/CardWithBodySectionFills.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithBodySectionFills.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardTitle, CardBody, CardFooter } from '@patternfly/react-core'; export const CardWithBodySectionFills: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardWithDividers.tsx b/packages/react-core/src/components/Card/examples/CardWithDividers.tsx index 4d15e87dd44..376196a6c90 100644 --- a/packages/react-core/src/components/Card/examples/CardWithDividers.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithDividers.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardTitle, CardBody, CardFooter, Divider } from '@patternfly/react-core'; export const CardWithDividers: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardWithHeadingElement.tsx b/packages/react-core/src/components/Card/examples/CardWithHeadingElement.tsx index ef4154376e3..2ff37314632 100644 --- a/packages/react-core/src/components/Card/examples/CardWithHeadingElement.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithHeadingElement.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardTitle, CardBody, CardFooter } from '@patternfly/react-core'; export const CardWithHeadingElement: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardWithImageAndActions.tsx b/packages/react-core/src/components/Card/examples/CardWithImageAndActions.tsx index 66a265be827..de361622506 100644 --- a/packages/react-core/src/components/Card/examples/CardWithImageAndActions.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithImageAndActions.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Brand, Card, diff --git a/packages/react-core/src/components/Card/examples/CardWithModifiers.tsx b/packages/react-core/src/components/Card/examples/CardWithModifiers.tsx index 7332ace1036..9b18185f07d 100644 --- a/packages/react-core/src/components/Card/examples/CardWithModifiers.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithModifiers.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Card, CardTitle, CardBody, CardFooter, Checkbox } from '@patternfly/react-core'; export const CardWithModifiers: React.FunctionComponent = () => { @@ -6,7 +6,7 @@ export const CardWithModifiers: React.FunctionComponent = () => { const [modifiers, setModifiers] = React.useState({}); return ( - +
    {mods.map((mod) => ( { Footer
    -
    + ); }; diff --git a/packages/react-core/src/components/Card/examples/CardWithMultipleBodySections.tsx b/packages/react-core/src/components/Card/examples/CardWithMultipleBodySections.tsx index 96781013019..3986a2aeb26 100644 --- a/packages/react-core/src/components/Card/examples/CardWithMultipleBodySections.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithMultipleBodySections.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardTitle, CardBody, CardFooter } from '@patternfly/react-core'; export const CardWithMultipleBodySections: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardWithNoFooter.tsx b/packages/react-core/src/components/Card/examples/CardWithNoFooter.tsx index 08fb95bc5fe..f5ee1a6634b 100644 --- a/packages/react-core/src/components/Card/examples/CardWithNoFooter.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithNoFooter.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardTitle, CardBody } from '@patternfly/react-core'; export const CardWithNoFooter: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardWithNoHeader.tsx b/packages/react-core/src/components/Card/examples/CardWithNoHeader.tsx index d817259f10d..fa99eb0902f 100644 --- a/packages/react-core/src/components/Card/examples/CardWithNoHeader.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithNoHeader.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardBody, CardFooter } from '@patternfly/react-core'; export const CardWithNoHeader: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Card/examples/CardWithOnlyBodySection.tsx b/packages/react-core/src/components/Card/examples/CardWithOnlyBodySection.tsx index 85a412e1c09..622cf9d24b7 100644 --- a/packages/react-core/src/components/Card/examples/CardWithOnlyBodySection.tsx +++ b/packages/react-core/src/components/Card/examples/CardWithOnlyBodySection.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Card, CardBody } from '@patternfly/react-core'; export const CardWithOnlyBodySection: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Checkbox/Checkbox.tsx b/packages/react-core/src/components/Checkbox/Checkbox.tsx index ee301a73c22..cbd488ce62d 100644 --- a/packages/react-core/src/components/Checkbox/Checkbox.tsx +++ b/packages/react-core/src/components/Checkbox/Checkbox.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Component } from 'react'; import styles from '@patternfly/react-styles/css/components/Check/check'; import { css } from '@patternfly/react-styles'; import { PickOptional } from '../../helpers/typeUtils'; @@ -54,7 +54,7 @@ interface CheckboxState { ouiaStateId: string; } -class Checkbox extends React.Component { +class Checkbox extends Component { static displayName = 'Checkbox'; static defaultProps: PickOptional = { className: '', diff --git a/packages/react-core/src/components/Checkbox/__tests__/Checkbox.test.tsx b/packages/react-core/src/components/Checkbox/__tests__/Checkbox.test.tsx index f2136c936e3..cdd5f3ab289 100644 --- a/packages/react-core/src/components/Checkbox/__tests__/Checkbox.test.tsx +++ b/packages/react-core/src/components/Checkbox/__tests__/Checkbox.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; diff --git a/packages/react-core/src/components/Checkbox/examples/Checkbox.md b/packages/react-core/src/components/Checkbox/examples/Checkbox.md index 58854597a55..c7a87545404 100644 --- a/packages/react-core/src/components/Checkbox/examples/Checkbox.md +++ b/packages/react-core/src/components/Checkbox/examples/Checkbox.md @@ -6,6 +6,8 @@ cssPrefix: pf-v6-c-check propComponents: ['Checkbox'] --- +import { Fragment } from 'react'; + ## Examples ### Controlled diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx index 3881eaf0700..d91da501c2a 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxControlled: React.FunctionComponent = () => { @@ -42,7 +42,7 @@ export const CheckboxControlled: React.FunctionComponent = () => { }, [isChecked2, isChecked3]); return ( - + { id="controlled-check-4" name="check4" /> - + ); }; diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxDisabled.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxDisabled.tsx index 79e388cfc27..55c22ac1f33 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxDisabled.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxDisabled.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxDisabled: React.FunctionComponent = () => ( - + - + ); diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxLabelWraps.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxLabelWraps.tsx index 256d9de82b7..0560cbe48f8 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxLabelWraps.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxLabelWraps.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxLabelWraps: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxRequired.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxRequired.tsx index 48cf9afd72a..44c7cd6f0f0 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxRequired.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxRequired.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxRequired: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxReversed.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxReversed.tsx index e6d16ed5c85..6f72e13c6fe 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxReversed.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxReversed.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxReversed: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxStandaloneInput.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxStandaloneInput.tsx index c594162b8a4..7aaef07f619 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxStandaloneInput.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxStandaloneInput.tsx @@ -1,6 +1,5 @@ -import React from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxStandaloneInput: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxUncontrolled.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxUncontrolled.tsx index fbc92cd5623..618edc5d80a 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxUncontrolled.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxUncontrolled.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxUncontrolled: React.FunctionComponent = () => ( - + - + ); diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxWithBody.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxWithBody.tsx index c660431cae7..680103124a8 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxWithBody.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxWithBody.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxWithBody: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescription.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescription.tsx index 2b7b7517357..6100ee03638 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescription.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescription.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxWithDescription: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescriptionBody.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescriptionBody.tsx index faa13944140..47a276c7d62 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescriptionBody.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxWithDescriptionBody.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Checkbox } from '@patternfly/react-core'; export const CheckboxWithDescriptionBody: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx index b4d973f5d06..99a0cca901e 100644 --- a/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx +++ b/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Component, Fragment } from 'react'; import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy'; import { css } from '@patternfly/react-styles'; import { PickOptional } from '../../helpers/typeUtils'; @@ -98,7 +98,7 @@ export interface ClipboardCopyProps extends Omit ouiaSafe?: boolean; } -class ClipboardCopy extends React.Component { +class ClipboardCopy extends Component { static displayName = 'ClipboardCopy'; timer = null as number; constructor(props: ClipboardCopyProps) { @@ -206,7 +206,7 @@ class ClipboardCopy extends React.Component {(id) => ( - + {!isCode && ( {this.state.text} @@ -240,14 +240,14 @@ class ClipboardCopy extends React.Component {additionalActions && additionalActions} - + )} )} {variant !== 'inline-compact' && ( {(id) => ( - +
    {variant === 'expansion' && ( )} - + )} )} diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyAction.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyAction.tsx index 231c1713052..8128bb2c220 100644 --- a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyAction.tsx +++ b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyAction.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx index 5400b45049b..d5d0e83385e 100644 --- a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx +++ b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { createRef } from 'react'; import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon'; import { Button } from '../Button'; import { Tooltip, TooltipPosition } from '../Tooltip'; @@ -63,7 +63,7 @@ export const ClipboardCopyButton: React.FunctionComponent { - const triggerRef = React.createRef(); + const triggerRef = createRef(); return ( { +class ClipboardCopyExpanded extends Component { static displayName = 'ClipboardCopyExpanded'; constructor(props: any) { super(props); diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyToggle.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyToggle.tsx index de8bbff13d8..481d9f28f23 100644 --- a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyToggle.tsx +++ b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyToggle.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy'; import { css } from '@patternfly/react-styles'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; diff --git a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopy.test.tsx b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopy.test.tsx index e7441dd2c03..b30d81937fb 100644 --- a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopy.test.tsx +++ b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopy.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { screen, render } from '@testing-library/react'; import { ClipboardCopy } from '../ClipboardCopy'; import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy'; diff --git a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyAction.test.tsx b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyAction.test.tsx index 0419477b26b..d1ba3895f57 100644 --- a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyAction.test.tsx +++ b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyAction.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { screen, render } from '@testing-library/react'; import { ClipboardCopyAction } from '../ClipboardCopyAction'; import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy'; diff --git a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyButton.test.tsx b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyButton.test.tsx index 1c071cc4d2b..18b3eeebcbe 100644 --- a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyButton.test.tsx +++ b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyButton.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { ClipboardCopyButton } from '../ClipboardCopyButton'; diff --git a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyExpanded.test.tsx b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyExpanded.test.tsx index d91426d6e17..d47a84ef276 100644 --- a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyExpanded.test.tsx +++ b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyExpanded.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { screen, render } from '@testing-library/react'; import { ClipboardCopyExpanded } from '../ClipboardCopyExpanded'; import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy'; diff --git a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyToggle.test.tsx b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyToggle.test.tsx index 49bc2b64c1b..a810ca6ee4e 100644 --- a/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyToggle.test.tsx +++ b/packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopyToggle.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { screen, render } from '@testing-library/react'; import { ClipboardCopyToggle } from '../ClipboardCopyToggle'; import userEvent from '@testing-library/user-event'; diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopy.md b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopy.md index 4b2fef0638c..e50d928bb8f 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopy.md +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopy.md @@ -6,6 +6,7 @@ propComponents: ['ClipboardCopy', 'ClipboardCopyButton'] ouia: true --- +import { Fragment, useEffect, useState } from 'react'; import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; ## Examples diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyBasic.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyBasic.tsx index b1a7d29316e..39dd099f746 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyBasic.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy } from '@patternfly/react-core'; export const ClipboardCopyBasic: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpanded.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpanded.tsx index c81d494cb5d..7d3555589c3 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpanded.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpanded.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy, ClipboardCopyVariant } from '@patternfly/react-core'; export const ClipboardCopyExpanded: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpandedWithArray.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpandedWithArray.tsx index 8eb3c1e6f58..88dc48ee5cf 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpandedWithArray.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyExpandedWithArray.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy, ClipboardCopyVariant } from '@patternfly/react-core'; const text = [ diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompact.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompact.tsx index bdb80f67c1e..66ddba33b16 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompact.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompact.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy } from '@patternfly/react-core'; export const ClipboardCopyInlineCompact: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactCode.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactCode.tsx index fa1ff0423ae..a8877535fba 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactCode.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactCode.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy } from '@patternfly/react-core'; export const ClipboardCopyInlineCompactCode: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactInSentence.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactInSentence.tsx index 2adab4eafd5..a6e39fb042f 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactInSentence.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactInSentence.tsx @@ -1,8 +1,8 @@ -import React from 'react'; +import { Fragment } from 'react'; import { ClipboardCopy } from '@patternfly/react-core'; export const ClipboardCopyInlineCompactInSentence: React.FunctionComponent = () => ( - + Basic
    Lorem ipsum{' '} @@ -32,5 +32,5 @@ export const ClipboardCopyInlineCompactInSentence: React.FunctionComponent = ()
    }{' '} Mauris luctus, libero nec dapibus ultricies, urna purus pretium mauris, ullamcorper pharetra lacus nibh vitae enim. - + ); diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactWithAdditionalAction.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactWithAdditionalAction.tsx index 9714cfc9cf4..1e5fad49a2d 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactWithAdditionalAction.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactWithAdditionalAction.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { useState } from 'react'; import { ClipboardCopy, ClipboardCopyAction, Button, Tooltip } from '@patternfly/react-core'; import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; export const ClipboardCopyInlineCompactWithAdditionalAction: React.FunctionComponent = () => { - const [isRunning, setisRunning] = React.useState(false); + const [isRunning, setisRunning] = useState(false); const runText: string = 'Run in web terminal'; const doneRunText: string = 'Running in web terminal'; return ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyJSONObject.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyJSONObject.tsx index 92a85a4c8f9..351537d8c90 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyJSONObject.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyJSONObject.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy, ClipboardCopyVariant } from '@patternfly/react-core'; export const ClipboardCopyJSONObject: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnly.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnly.tsx index 1d133b97364..b2f9d4dd1ef 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnly.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnly.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy } from '@patternfly/react-core'; export const ClipboardCopyReadOnly: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpanded.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpanded.tsx index 985919999dd..082f46cbf0a 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpanded.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpanded.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy, ClipboardCopyVariant } from '@patternfly/react-core'; export const ClipboardCopyReadOnlyExpanded: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpandedByDefault.tsx b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpandedByDefault.tsx index b7963fbb3c9..ac62d4776f8 100644 --- a/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpandedByDefault.tsx +++ b/packages/react-core/src/components/ClipboardCopy/examples/ClipboardCopyReadOnlyExpandedByDefault.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ClipboardCopy, ClipboardCopyVariant } from '@patternfly/react-core'; export const ClipboardCopyReadOnlyExpandedByDefault: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/CodeBlock/CodeBlock.tsx b/packages/react-core/src/components/CodeBlock/CodeBlock.tsx index f125a9c123c..114467cdfb4 100644 --- a/packages/react-core/src/components/CodeBlock/CodeBlock.tsx +++ b/packages/react-core/src/components/CodeBlock/CodeBlock.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/CodeBlock/code-block'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/CodeBlock/CodeBlockAction.tsx b/packages/react-core/src/components/CodeBlock/CodeBlockAction.tsx index 408f0aa5f00..133a19fae78 100644 --- a/packages/react-core/src/components/CodeBlock/CodeBlockAction.tsx +++ b/packages/react-core/src/components/CodeBlock/CodeBlockAction.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/CodeBlock/code-block'; diff --git a/packages/react-core/src/components/CodeBlock/CodeBlockCode.tsx b/packages/react-core/src/components/CodeBlock/CodeBlockCode.tsx index 274b23c6851..3ad683324a9 100644 --- a/packages/react-core/src/components/CodeBlock/CodeBlockCode.tsx +++ b/packages/react-core/src/components/CodeBlock/CodeBlockCode.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/CodeBlock/code-block'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/CodeBlock/__tests__/CodeBlock.test.tsx b/packages/react-core/src/components/CodeBlock/__tests__/CodeBlock.test.tsx index 9125aed8f4e..20ed69747f4 100644 --- a/packages/react-core/src/components/CodeBlock/__tests__/CodeBlock.test.tsx +++ b/packages/react-core/src/components/CodeBlock/__tests__/CodeBlock.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { CodeBlock } from '../CodeBlock'; import styles from '@patternfly/react-styles/css/components/CodeBlock/code-block'; diff --git a/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockAction.test.tsx b/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockAction.test.tsx index b51934acf9e..01ee459ef71 100644 --- a/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockAction.test.tsx +++ b/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockAction.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { CodeBlockAction } from '../CodeBlockAction'; import styles from '@patternfly/react-styles/css/components/CodeBlock/code-block'; diff --git a/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockCode.test.tsx b/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockCode.test.tsx index fce3584eb35..91a9573271c 100644 --- a/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockCode.test.tsx +++ b/packages/react-core/src/components/CodeBlock/__tests__/CodeBlockCode.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { CodeBlockCode } from '../CodeBlockCode'; import styles from '@patternfly/react-styles/css/components/CodeBlock/code-block'; diff --git a/packages/react-core/src/components/CodeBlock/examples/CodeBlock.md b/packages/react-core/src/components/CodeBlock/examples/CodeBlock.md index e14359a210e..da8e7bb5b1c 100644 --- a/packages/react-core/src/components/CodeBlock/examples/CodeBlock.md +++ b/packages/react-core/src/components/CodeBlock/examples/CodeBlock.md @@ -5,6 +5,7 @@ cssPrefix: pf-v6-c-code-block propComponents: ['CodeBlock', 'CodeBlockAction', 'CodeBlockCode'] --- +import { Fragment, useState } from 'react'; import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon'; import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; diff --git a/packages/react-core/src/components/CodeBlock/examples/CodeBlockBasic.tsx b/packages/react-core/src/components/CodeBlock/examples/CodeBlockBasic.tsx index 294cff82969..eb077a1d463 100644 --- a/packages/react-core/src/components/CodeBlock/examples/CodeBlockBasic.tsx +++ b/packages/react-core/src/components/CodeBlock/examples/CodeBlockBasic.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { CodeBlock, CodeBlockAction, @@ -10,8 +10,8 @@ import { import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; export const BasicCodeBlock: React.FunctionComponent = () => { - const [copied, setCopied] = React.useState(false); - const [isRunning, setisRunning] = React.useState(false); + const [copied, setCopied] = useState(false); + const [isRunning, setisRunning] = useState(false); const runText: string = 'Run in web terminal'; const doneRunText: string = 'Running in web terminal'; @@ -33,7 +33,7 @@ connectionConfig: url: https://raw.githubusercontent.com/Azure-Samples/helm-charts/master/docs`; const actions = ( - +
    - + ); return ( diff --git a/packages/react-core/src/components/CodeBlock/examples/CodeBlockExpandable.tsx b/packages/react-core/src/components/CodeBlock/examples/CodeBlockExpandable.tsx index d4c9851751a..8e7fde3b03d 100644 --- a/packages/react-core/src/components/CodeBlock/examples/CodeBlockExpandable.tsx +++ b/packages/react-core/src/components/CodeBlock/examples/CodeBlockExpandable.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { CodeBlock, CodeBlockAction, @@ -12,9 +12,9 @@ import { import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; export const ExpandableCodeBlock: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const [copied, setCopied] = React.useState(false); - const [isRunning, setisRunning] = React.useState(false); + const [isExpanded, setIsExpanded] = useState(false); + const [copied, setCopied] = useState(false); + const [isRunning, setisRunning] = useState(false); const runText: string = 'Run in web terminal'; const doneRunText: string = 'Running in web terminal'; @@ -48,7 +48,7 @@ connectionConfig: url: https://raw.githubusercontent.com/Azure-Samples/helm-charts/master/docs`; const actions = ( - + - + ); return ( diff --git a/packages/react-core/src/components/Content/Content.tsx b/packages/react-core/src/components/Content/Content.tsx index d60d07197b0..896f6a040ed 100644 --- a/packages/react-core/src/components/Content/Content.tsx +++ b/packages/react-core/src/components/Content/Content.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Content/content'; import { useOUIAProps, OUIAProps } from '../../helpers'; diff --git a/packages/react-core/src/components/Content/__tests__/Content.test.tsx b/packages/react-core/src/components/Content/__tests__/Content.test.tsx index b7e6255f4a5..445f7c1b49a 100644 --- a/packages/react-core/src/components/Content/__tests__/Content.test.tsx +++ b/packages/react-core/src/components/Content/__tests__/Content.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render, screen } from '@testing-library/react'; import { Content } from '../Content'; import styles from '@patternfly/react-styles/css/components/Content/content'; diff --git a/packages/react-core/src/components/Content/examples/ContentBody.tsx b/packages/react-core/src/components/Content/examples/ContentBody.tsx index b94e9e2c524..b239985220e 100644 --- a/packages/react-core/src/components/Content/examples/ContentBody.tsx +++ b/packages/react-core/src/components/Content/examples/ContentBody.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentBody: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentDescriptionList.tsx b/packages/react-core/src/components/Content/examples/ContentDescriptionList.tsx index 7742ca50f94..0199d09df33 100644 --- a/packages/react-core/src/components/Content/examples/ContentDescriptionList.tsx +++ b/packages/react-core/src/components/Content/examples/ContentDescriptionList.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentDescriptionList: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentEditorial.tsx b/packages/react-core/src/components/Content/examples/ContentEditorial.tsx index 14c4ff825f9..c1690072ca9 100644 --- a/packages/react-core/src/components/Content/examples/ContentEditorial.tsx +++ b/packages/react-core/src/components/Content/examples/ContentEditorial.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentEditorial: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentHeadings.tsx b/packages/react-core/src/components/Content/examples/ContentHeadings.tsx index f0a6f4b3c0e..4cde33a667e 100644 --- a/packages/react-core/src/components/Content/examples/ContentHeadings.tsx +++ b/packages/react-core/src/components/Content/examples/ContentHeadings.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentHeadings: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentOrderedList.tsx b/packages/react-core/src/components/Content/examples/ContentOrderedList.tsx index 24dd49c2c5d..bdb4fd73eec 100644 --- a/packages/react-core/src/components/Content/examples/ContentOrderedList.tsx +++ b/packages/react-core/src/components/Content/examples/ContentOrderedList.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentOrderedList: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentPlainList.tsx b/packages/react-core/src/components/Content/examples/ContentPlainList.tsx index e49e4512868..13433226326 100644 --- a/packages/react-core/src/components/Content/examples/ContentPlainList.tsx +++ b/packages/react-core/src/components/Content/examples/ContentPlainList.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentPlainList: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentUnorderedList.tsx b/packages/react-core/src/components/Content/examples/ContentUnorderedList.tsx index 356edfe1b0f..d3eade8d88e 100644 --- a/packages/react-core/src/components/Content/examples/ContentUnorderedList.tsx +++ b/packages/react-core/src/components/Content/examples/ContentUnorderedList.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentUnorderedList: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentVisited.tsx b/packages/react-core/src/components/Content/examples/ContentVisited.tsx index 56fe72aa1b1..82ac85ee812 100644 --- a/packages/react-core/src/components/Content/examples/ContentVisited.tsx +++ b/packages/react-core/src/components/Content/examples/ContentVisited.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentVisited: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Content/examples/ContentWrapper.tsx b/packages/react-core/src/components/Content/examples/ContentWrapper.tsx index e8ed09652c2..8e4be41b78a 100644 --- a/packages/react-core/src/components/Content/examples/ContentWrapper.tsx +++ b/packages/react-core/src/components/Content/examples/ContentWrapper.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Content, ContentVariants } from '@patternfly/react-core'; export const ContentWrapper: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/DataList/DataList.tsx b/packages/react-core/src/components/DataList/DataList.tsx index 6466e8d3aad..350b7480899 100644 --- a/packages/react-core/src/components/DataList/DataList.tsx +++ b/packages/react-core/src/components/DataList/DataList.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { createContext, forwardRef } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; @@ -48,7 +48,7 @@ interface DataListContextProps { onSelectableRowChange?: (event: React.FormEvent, id: string) => void; } -export const DataListContext = React.createContext>({ +export const DataListContext = createContext>({ isSelectable: false }); @@ -102,7 +102,7 @@ export const DataListBase: React.FunctionComponent = ({ DataListBase.displayName = 'DataListBase'; -export const DataList = React.forwardRef((props: DataListProps, ref: React.Ref) => ( +export const DataList = forwardRef((props: DataListProps, ref: React.Ref) => ( } {...props} /> )); diff --git a/packages/react-core/src/components/DataList/DataListAction.tsx b/packages/react-core/src/components/DataList/DataListAction.tsx index 9ab2c927d73..a511848d248 100644 --- a/packages/react-core/src/components/DataList/DataListAction.tsx +++ b/packages/react-core/src/components/DataList/DataListAction.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; import { formatBreakpointMods } from '../../helpers/util'; diff --git a/packages/react-core/src/components/DataList/DataListCell.tsx b/packages/react-core/src/components/DataList/DataListCell.tsx index 287fa91fa5a..b2961729402 100644 --- a/packages/react-core/src/components/DataList/DataListCell.tsx +++ b/packages/react-core/src/components/DataList/DataListCell.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; import { DataListWrapModifier } from './DataList'; diff --git a/packages/react-core/src/components/DataList/DataListCheck.tsx b/packages/react-core/src/components/DataList/DataListCheck.tsx index 6a19e058aaf..978521a738c 100644 --- a/packages/react-core/src/components/DataList/DataListCheck.tsx +++ b/packages/react-core/src/components/DataList/DataListCheck.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Fragment } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; import { Checkbox, CheckboxProps } from '../Checkbox'; @@ -67,10 +67,10 @@ export const DataListCheck: React.FunctionComponent = ({
    ); return ( - + {!otherControls &&
    {check}
    } {otherControls && check} -
    +
    ); }; DataListCheck.displayName = 'DataListCheck'; diff --git a/packages/react-core/src/components/DataList/DataListContent.tsx b/packages/react-core/src/components/DataList/DataListContent.tsx index 28e59ea9c31..e5738d6b686 100644 --- a/packages/react-core/src/components/DataList/DataListContent.tsx +++ b/packages/react-core/src/components/DataList/DataListContent.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; diff --git a/packages/react-core/src/components/DataList/DataListControl.tsx b/packages/react-core/src/components/DataList/DataListControl.tsx index 1a1fa9990fb..b44577d2042 100644 --- a/packages/react-core/src/components/DataList/DataListControl.tsx +++ b/packages/react-core/src/components/DataList/DataListControl.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; diff --git a/packages/react-core/src/components/DataList/DataListDragButton.tsx b/packages/react-core/src/components/DataList/DataListDragButton.tsx index 55000ed0d46..d24c326a334 100644 --- a/packages/react-core/src/components/DataList/DataListDragButton.tsx +++ b/packages/react-core/src/components/DataList/DataListDragButton.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; import GripVerticalIcon from '@patternfly/react-icons/dist/esm/icons/grip-vertical-icon'; diff --git a/packages/react-core/src/components/DataList/DataListItem.tsx b/packages/react-core/src/components/DataList/DataListItem.tsx index d5b15b0980c..cc06d019a9d 100644 --- a/packages/react-core/src/components/DataList/DataListItem.tsx +++ b/packages/react-core/src/components/DataList/DataListItem.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Children, Component, cloneElement, isValidElement } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; import { DataListContext } from './DataList'; @@ -24,7 +24,7 @@ export interface DataListItemChildProps { rowid: string; } -class DataListItem extends React.Component { +class DataListItem extends Component { static displayName = 'DataListItem'; static defaultProps: DataListItemProps = { isExpanded: false, @@ -99,11 +99,11 @@ class DataListItem extends React.Component { {...selectableInputAriaProps} /> )} - {React.Children.map( + {Children.map( children, (child) => - React.isValidElement(child) && - React.cloneElement(child as React.ReactElement, { + isValidElement(child) && + cloneElement(child as React.ReactElement, { rowid: ariaLabelledBy }) )} diff --git a/packages/react-core/src/components/DataList/DataListItemCells.tsx b/packages/react-core/src/components/DataList/DataListItemCells.tsx index 822eb2a7223..1cbf539de5f 100644 --- a/packages/react-core/src/components/DataList/DataListItemCells.tsx +++ b/packages/react-core/src/components/DataList/DataListItemCells.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; diff --git a/packages/react-core/src/components/DataList/DataListItemRow.tsx b/packages/react-core/src/components/DataList/DataListItemRow.tsx index bc216d07877..39e27829a00 100644 --- a/packages/react-core/src/components/DataList/DataListItemRow.tsx +++ b/packages/react-core/src/components/DataList/DataListItemRow.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Children, cloneElement, isValidElement } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; import { DataListWrapModifier } from './DataList'; @@ -22,11 +22,11 @@ export const DataListItemRow: React.FunctionComponent = ({ ...props }: DataListItemRowProps) => (
    - {React.Children.map( + {Children.map( children, (child) => - React.isValidElement(child) && - React.cloneElement(child as React.ReactElement, { + isValidElement(child) && + cloneElement(child as React.ReactElement, { rowid }) )} diff --git a/packages/react-core/src/components/DataList/DataListText.tsx b/packages/react-core/src/components/DataList/DataListText.tsx index 69341f792ea..795db78a857 100644 --- a/packages/react-core/src/components/DataList/DataListText.tsx +++ b/packages/react-core/src/components/DataList/DataListText.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { useState } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; import { Tooltip } from '../Tooltip'; @@ -30,7 +30,7 @@ export const DataListText: React.FunctionComponent = ({ }: DataListTextProps) => { const Component = component as any; - const [tooltip, setTooltip] = React.useState(''); + const [tooltip, setTooltip] = useState(''); const onMouseEnter = (event: any) => { if (event.target.offsetWidth < event.target.scrollWidth) { setTooltip(tooltipProp || event.target.innerHTML); diff --git a/packages/react-core/src/components/DataList/DataListToggle.tsx b/packages/react-core/src/components/DataList/DataListToggle.tsx index 71fda10f908..e26b6eb7731 100644 --- a/packages/react-core/src/components/DataList/DataListToggle.tsx +++ b/packages/react-core/src/components/DataList/DataListToggle.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; diff --git a/packages/react-core/src/components/DataList/__tests__/DataList.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataList.test.tsx index f28b8cd6f2c..bdb5b8263f4 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataList.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataList.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; @@ -40,7 +38,7 @@ test(`Renders ${styles.modifiers.compact} when isCompact = true`, () => { }); ['nowrap', 'truncate', 'breakWord'].forEach((wrap) => { - test(`Renders with class ${styles.modifiers[wrap]} when wrapModifier = ${wrap} is pased`, () => { + test(`Renders with class ${styles.modifiers[wrap]} when wrapModifier = ${wrap} is passed`, () => { render(); expect(screen.getByLabelText('list')).toHaveClass(styles.modifiers[wrap]); }); @@ -57,7 +55,7 @@ const gridBreakpointClasses = { }; ['none', 'always', 'sm', 'md', 'lg', 'xl', '2xl'].forEach((oneBreakpoint) => { - test(`Has breakpoint - ${oneBreakpoint} when gridBreakpoint is pased`, () => { + test(`Has breakpoint - ${oneBreakpoint} when gridBreakpoint is passed`, () => { render(); expect(screen.getByLabelText('list')).toHaveClass(gridBreakpointClasses[oneBreakpoint]); }); diff --git a/packages/react-core/src/components/DataList/__tests__/DataListAction.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListAction.test.tsx index 9171561fe3c..c6dbaf99c9c 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListAction.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListAction.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import '@testing-library/jest-dom'; diff --git a/packages/react-core/src/components/DataList/__tests__/DataListCell.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListCell.test.tsx index 6e55ada2648..36a55cbc3e6 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListCell.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListCell.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DataListCell } from '../DataListCell'; diff --git a/packages/react-core/src/components/DataList/__tests__/DataListCheck.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListCheck.test.tsx index 6b9833ec3f6..eff217f7f22 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListCheck.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListCheck.test.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { useState } from 'react'; import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { DataListCheck } from '../DataListCheck'; @@ -13,7 +13,7 @@ it('does not throw a "A component is changing an uncontrolled input of type chec const user = userEvent.setup(); const ControlledDataListCheck = () => { - const [checked, setChecked] = React.useState(false); + const [checked, setChecked] = useState(false); return ( setChecked(!checked)} aria-labelledby={'string'} /> diff --git a/packages/react-core/src/components/DataList/__tests__/DataListContent.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListContent.test.tsx index 912bb48f0de..63506fb6184 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListContent.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListContent.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DataListContent } from '../DataListContent'; diff --git a/packages/react-core/src/components/DataList/__tests__/DataListItem.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListItem.test.tsx index 54f358c8e83..19b0fb2d5da 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListItem.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListItem.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DataListItem } from '../DataListItem'; diff --git a/packages/react-core/src/components/DataList/__tests__/DataListItemCells.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListItemCells.test.tsx index e8419f2b361..c8d756b1985 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListItemCells.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListItemCells.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DataListItemCells } from '../DataListItemCells'; diff --git a/packages/react-core/src/components/DataList/__tests__/DataListItemRow.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListItemRow.test.tsx index 74ec2e6fafc..e86ec190661 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListItemRow.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListItemRow.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DataListItemRow } from '../DataListItemRow'; @@ -33,7 +32,7 @@ test(`Renders with spread props`, () => { }); ['nowrap', 'truncate', 'breakWord'].forEach((wrap) => { - test(`Renders with class ${styles.modifiers[wrap]} when wrapModifier = ${wrap} is pased`, () => { + test(`Renders with class ${styles.modifiers[wrap]} when wrapModifier = ${wrap} is passed`, () => { render( test diff --git a/packages/react-core/src/components/DataList/__tests__/DataListToggle.test.tsx b/packages/react-core/src/components/DataList/__tests__/DataListToggle.test.tsx index 8f7f8b4cd9b..af677b320b3 100644 --- a/packages/react-core/src/components/DataList/__tests__/DataListToggle.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/DataListToggle.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DataListToggle } from '../DataListToggle'; diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListAction.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListAction.test.tsx index 2f07cb48c8d..d6af1889bfe 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListAction.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListAction.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListAction } from '../../DataListAction'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListCell.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListCell.test.tsx index 8ef64961e43..9325da25c76 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListCell.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListCell.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListCell } from '../../DataListCell'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListCheck.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListCheck.test.tsx index 748738dbae0..81c1612e8b3 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListCheck.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListCheck.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListCheck } from '../../DataListCheck'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListContent.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListContent.test.tsx index 96d79ef0645..d56ee15d68e 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListContent.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListContent.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListContent } from '../../DataListContent'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListItem.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListItem.test.tsx index 1e18e943867..8ce3d07a96a 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListItem.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListItem.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListItem } from '../../DataListItem'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemCells.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemCells.test.tsx index 1f71eed7cc1..67438001e56 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemCells.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemCells.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListItemCells } from '../../DataListItemCells'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemRow.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemRow.test.tsx index acd0768a0bb..6179c72efde 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemRow.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListItemRow.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListItemRow } from '../../DataListItemRow'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/__tests__/Generated/DataListToggle.test.tsx b/packages/react-core/src/components/DataList/__tests__/Generated/DataListToggle.test.tsx index 9e1b0e3407a..e6fff7d3fbf 100644 --- a/packages/react-core/src/components/DataList/__tests__/Generated/DataListToggle.test.tsx +++ b/packages/react-core/src/components/DataList/__tests__/Generated/DataListToggle.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DataListToggle } from '../../DataListToggle'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/DataList/examples/DataList.md b/packages/react-core/src/components/DataList/examples/DataList.md index 131ee5943fe..b4e06fa735b 100644 --- a/packages/react-core/src/components/DataList/examples/DataList.md +++ b/packages/react-core/src/components/DataList/examples/DataList.md @@ -18,6 +18,7 @@ propComponents: ] --- +import { Fragment, useState } from 'react'; import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon'; import AngleDownIcon from '@patternfly/react-icons/dist/esm/icons/angle-down-icon'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; diff --git a/packages/react-core/src/components/DataList/examples/DataListActions.tsx b/packages/react-core/src/components/DataList/examples/DataListActions.tsx index 2606386482e..fe828173a4b 100644 --- a/packages/react-core/src/components/DataList/examples/DataListActions.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListActions.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { Button, DataList, @@ -16,8 +16,8 @@ import { import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; export const DataListActions: React.FunctionComponent = () => { - const [isOpen, setIsOpen] = React.useState(false); - const [isDeleted, setIsDeleted] = React.useState(false); + const [isOpen, setIsOpen] = useState(false); + const [isDeleted, setIsDeleted] = useState(false); const onToggle = () => { setIsOpen(!isOpen); @@ -28,7 +28,7 @@ export const DataListActions: React.FunctionComponent = () => { }; return ( - + {!isDeleted && ( @@ -111,6 +111,6 @@ export const DataListActions: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/DataList/examples/DataListBasic.tsx b/packages/react-core/src/components/DataList/examples/DataListBasic.tsx index 984511aa480..e4af45501e9 100644 --- a/packages/react-core/src/components/DataList/examples/DataListBasic.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DataList, DataListItem, DataListItemRow, DataListItemCells, DataListCell } from '@patternfly/react-core'; export const DataListBasic: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/DataList/examples/DataListCheckboxes.tsx b/packages/react-core/src/components/DataList/examples/DataListCheckboxes.tsx index 54cf46b7e76..5138ce37093 100644 --- a/packages/react-core/src/components/DataList/examples/DataListCheckboxes.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListCheckboxes.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { Button, DataList, @@ -17,9 +17,9 @@ import { import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; export const DataListCheckboxes: React.FunctionComponent = () => { - const [isOpen1, setIsOpen1] = React.useState(false); - const [isOpen2, setIsOpen2] = React.useState(false); - const [isOpen3, setIsOpen3] = React.useState(false); + const [isOpen1, setIsOpen1] = useState(false); + const [isOpen2, setIsOpen2] = useState(false); + const [isOpen3, setIsOpen3] = useState(false); const onToggle1 = () => { setIsOpen1(!isOpen1); diff --git a/packages/react-core/src/components/DataList/examples/DataListClickableRows.tsx b/packages/react-core/src/components/DataList/examples/DataListClickableRows.tsx index dcd36f28a01..a23bd1ad94f 100644 --- a/packages/react-core/src/components/DataList/examples/DataListClickableRows.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListClickableRows.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { DataList, DataListItem, @@ -15,9 +15,9 @@ import { import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; export const DataListClickableRows: React.FunctionComponent = () => { - const [isOpen1, setIsOpen1] = React.useState(false); - const [isOpen2, setIsOpen2] = React.useState(false); - const [selectedDataListItemId, setSelectedDataListItemId] = React.useState(''); + const [isOpen1, setIsOpen1] = useState(false); + const [isOpen2, setIsOpen2] = useState(false); + const [selectedDataListItemId, setSelectedDataListItemId] = useState(''); const onToggle1 = () => { setIsOpen1(!isOpen1); @@ -44,7 +44,7 @@ export const DataListClickableRows: React.FunctionComponent = () => { }; return ( - + { - + ); }; diff --git a/packages/react-core/src/components/DataList/examples/DataListCompact.tsx b/packages/react-core/src/components/DataList/examples/DataListCompact.tsx index 6232f30015b..23644d59371 100644 --- a/packages/react-core/src/components/DataList/examples/DataListCompact.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListCompact.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DataList, DataListItem, DataListItemRow, DataListItemCells, DataListCell } from '@patternfly/react-core'; export const DataListCompact: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/DataList/examples/DataListControllingText.tsx b/packages/react-core/src/components/DataList/examples/DataListControllingText.tsx index c8ced89d5fb..01d5adc3b73 100644 --- a/packages/react-core/src/components/DataList/examples/DataListControllingText.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListControllingText.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DataList, DataListItem, diff --git a/packages/react-core/src/components/DataList/examples/DataListExpandable.tsx b/packages/react-core/src/components/DataList/examples/DataListExpandable.tsx index d483c18b613..7b94d233115 100644 --- a/packages/react-core/src/components/DataList/examples/DataListExpandable.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListExpandable.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { DataList, DataListItem, @@ -18,10 +18,10 @@ import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-ico import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon'; export const DataListExpandable: React.FunctionComponent = () => { - const [isOpen1, setIsOpen1] = React.useState(false); - const [isOpen2, setIsOpen2] = React.useState(false); - const [isOpen3, setIsOpen3] = React.useState(false); - const [expanded, setExpanded] = React.useState(['ex-toggle1', 'ex-toggle3']); + const [isOpen1, setIsOpen1] = useState(false); + const [isOpen2, setIsOpen2] = useState(false); + const [isOpen3, setIsOpen3] = useState(false); + const [expanded, setExpanded] = useState(['ex-toggle1', 'ex-toggle3']); const onToggle1 = () => { setIsOpen1(!isOpen1); @@ -53,7 +53,7 @@ export const DataListExpandable: React.FunctionComponent = () => { setExpanded(newExpanded); }; return ( - + @@ -265,6 +265,6 @@ export const DataListExpandable: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/DataList/examples/DataListMixedExpandable.tsx b/packages/react-core/src/components/DataList/examples/DataListMixedExpandable.tsx index e3183ffc96a..fd6eac75bfa 100644 --- a/packages/react-core/src/components/DataList/examples/DataListMixedExpandable.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListMixedExpandable.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { DataList, DataListItem, @@ -18,10 +18,10 @@ import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-ico import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon'; export const DataListMixedExpandable: React.FunctionComponent = () => { - const [isOpen1, setIsOpen1] = React.useState(false); - const [isOpen2, setIsOpen2] = React.useState(false); - const [isOpen3, setIsOpen3] = React.useState(false); - const [expanded, setExpanded] = React.useState(['m-ex-toggle1', 'm-ex-toggle3']); + const [isOpen1, setIsOpen1] = useState(false); + const [isOpen2, setIsOpen2] = useState(false); + const [isOpen3, setIsOpen3] = useState(false); + const [expanded, setExpanded] = useState(['m-ex-toggle1', 'm-ex-toggle3']); const onToggle1 = () => { setIsOpen1(!isOpen1); @@ -55,7 +55,7 @@ export const DataListMixedExpandable: React.FunctionComponent = () => { }; return ( - + @@ -261,6 +261,6 @@ export const DataListMixedExpandable: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/DataList/examples/DataListSmGridBreakpoint.tsx b/packages/react-core/src/components/DataList/examples/DataListSmGridBreakpoint.tsx index 55d0023dd8c..9beb45d5788 100644 --- a/packages/react-core/src/components/DataList/examples/DataListSmGridBreakpoint.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListSmGridBreakpoint.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DataList, DataListItem, DataListItemRow, DataListItemCells, DataListCell } from '@patternfly/react-core'; export const DataListSmGridBreakpoint: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/DataList/examples/DataListWidthModifiers.tsx b/packages/react-core/src/components/DataList/examples/DataListWidthModifiers.tsx index 6d44d45ca2e..f7cde4ca06d 100644 --- a/packages/react-core/src/components/DataList/examples/DataListWidthModifiers.tsx +++ b/packages/react-core/src/components/DataList/examples/DataListWidthModifiers.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { Content, DataList, @@ -19,9 +19,9 @@ import { import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; export const DataListWidthModifiers: React.FunctionComponent = () => { - const [show, setShow] = React.useState(true); - const [isOpen1, setIsOpen1] = React.useState(false); - const [isOpen2, setIsOpen2] = React.useState(false); + const [show, setShow] = useState(true); + const [isOpen1, setIsOpen1] = useState(false); + const [isOpen2, setIsOpen2] = useState(false); const onToggle1 = () => { setIsOpen1(!isOpen1); diff --git a/packages/react-core/src/components/DatePicker/DatePicker.tsx b/packages/react-core/src/components/DatePicker/DatePicker.tsx index aa5d5ac62d7..4ae3a994d46 100644 --- a/packages/react-core/src/components/DatePicker/DatePicker.tsx +++ b/packages/react-core/src/components/DatePicker/DatePicker.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { forwardRef, useEffect, useImperativeHandle, useMemo, useRef, useState } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DatePicker/date-picker'; import calendarMonthStyles from '@patternfly/react-styles/css/components/CalendarMonth/calendar-month'; @@ -8,7 +8,6 @@ import { Popover, PopoverProps } from '../Popover/Popover'; import { InputGroup, InputGroupItem } from '../InputGroup'; import OutlinedCalendarAltIcon from '@patternfly/react-icons/dist/esm/icons/outlined-calendar-alt-icon'; import { CalendarMonth, CalendarFormat } from '../CalendarMonth'; -import { useImperativeHandle } from 'react'; import { KeyTypes } from '../../helpers'; import { isValidDate } from '../../helpers/datetimeUtils'; import { HelperText, HelperTextItem } from '../HelperText'; @@ -124,33 +123,33 @@ const DatePickerBase = ( }: DatePickerProps, ref: React.Ref ) => { - const [value, setValue] = React.useState(valueProp); - const [valueDate, setValueDate] = React.useState(dateParse(value)); - const [errorText, setErrorText] = React.useState(''); - const [popoverOpen, setPopoverOpen] = React.useState(false); - const [selectOpen, setSelectOpen] = React.useState(false); - const [pristine, setPristine] = React.useState(true); - const [textInputFocused, setTextInputFocused] = React.useState(false); - const widthChars = React.useMemo(() => Math.max(dateFormat(new Date()).length, placeholder.length), [dateFormat]); + const [value, setValue] = useState(valueProp); + const [valueDate, setValueDate] = useState(dateParse(value)); + const [errorText, setErrorText] = useState(''); + const [popoverOpen, setPopoverOpen] = useState(false); + const [selectOpen, setSelectOpen] = useState(false); + const [pristine, setPristine] = useState(true); + const [textInputFocused, setTextInputFocused] = useState(false); + const widthChars = useMemo(() => Math.max(dateFormat(new Date()).length, placeholder.length), [dateFormat]); const style = { [cssFormControlWidthChars.name]: widthChars, ...styleProps }; - const buttonRef = React.useRef(undefined); - const datePickerWrapperRef = React.useRef(undefined); - const triggerRef = React.useRef(undefined); + const buttonRef = useRef(undefined); + const datePickerWrapperRef = useRef(undefined); + const triggerRef = useRef(undefined); const dateIsRequired = requiredDateOptions?.isRequired || false; const emptyDateText = requiredDateOptions?.emptyDateText || 'Date cannot be blank'; - React.useEffect(() => { + useEffect(() => { setValue(valueProp); setValueDate(dateParse(valueProp)); }, [valueProp]); - React.useEffect(() => { + useEffect(() => { if (isValidDate(valueDate)) { applyValidators(valueDate); } }, [validators]); - React.useEffect(() => { + useEffect(() => { setPristine(!value); const newValueDate = dateParse(value); if (errorText && isValidDate(newValueDate)) { @@ -353,5 +352,5 @@ const DatePickerBase = ( ); }; -export const DatePicker = React.forwardRef(DatePickerBase); +export const DatePicker = forwardRef(DatePickerBase); DatePicker.displayName = 'DatePicker'; diff --git a/packages/react-core/src/components/DatePicker/__tests__/DatePicker.test.tsx b/packages/react-core/src/components/DatePicker/__tests__/DatePicker.test.tsx index bbb252c064e..9d6030c0eef 100644 --- a/packages/react-core/src/components/DatePicker/__tests__/DatePicker.test.tsx +++ b/packages/react-core/src/components/DatePicker/__tests__/DatePicker.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { screen, render } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; diff --git a/packages/react-core/src/components/DatePicker/examples/DatePicker.md b/packages/react-core/src/components/DatePicker/examples/DatePicker.md index 4dd8f28cbfd..84f79c38e3b 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePicker.md +++ b/packages/react-core/src/components/DatePicker/examples/DatePicker.md @@ -6,6 +6,8 @@ cssPrefix: pf-v6-c-date-picker propComponents: ['DatePicker', 'CalendarFormat', 'DatePickerRef', 'DatePickerRequiredObject'] --- +import { Fragment, useState, useRef } from 'react'; + ## Examples ### Basic diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerAmerican.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerAmerican.tsx index 54dba78291f..b41299b7368 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerAmerican.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerAmerican.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DatePicker } from '@patternfly/react-core'; export const DatePickerAmerican: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerBasic.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerBasic.tsx index 65e371fcc7b..3008b7dc715 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerBasic.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DatePicker } from '@patternfly/react-core'; export const DatePickerBasic: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerControlled.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerControlled.tsx index a4297e9265e..980df3fdf0f 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerControlled.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerControlled.tsx @@ -1,11 +1,11 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { Button, DatePicker, Flex, FlexItem } from '@patternfly/react-core'; export const DatePickerControlled: React.FunctionComponent = () => { const initialValue = '2020-03-17'; - const [value, setValue] = React.useState(initialValue); + const [value, setValue] = useState(initialValue); return ( - + setValue(value)} />

    @@ -17,6 +17,6 @@ export const DatePickerControlled: React.FunctionComponent = () => { -
    + ); }; diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerControlledCalendar.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerControlledCalendar.tsx index 89291a358c7..b7f7805fbf3 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerControlledCalendar.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerControlledCalendar.tsx @@ -1,19 +1,19 @@ -import React from 'react'; +import { Fragment, useRef } from 'react'; import { Button, DatePicker } from '@patternfly/react-core'; export const DatePickerControlledCalendar: React.FunctionComponent = () => { - const dateRef = React.useRef(null); + const dateRef = useRef(null); const onClick = () => { if (dateRef.current) { dateRef.current.toggleCalendar(); } }; return ( - +

    -
    + ); }; diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerControlledRequired.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerControlledRequired.tsx index 4ba5bf302da..dc66819a833 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerControlledRequired.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerControlledRequired.tsx @@ -1,11 +1,11 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { Button, DatePicker, Flex, FlexItem } from '@patternfly/react-core'; export const DatePickerControlled: React.FunctionComponent = () => { const initialValue = '2020-03-17'; - const [value, setValue] = React.useState(initialValue); + const [value, setValue] = useState(initialValue); return ( - + { - + ); }; diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerFrench.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerFrench.tsx index 1dc033ecb19..3006e3b235a 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerFrench.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerFrench.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DatePicker, Weekday } from '@patternfly/react-core'; export const DatePickerFrench: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerHelperText.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerHelperText.tsx index 854b922c1e2..55c280074fd 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerHelperText.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerHelperText.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DatePicker, HelperText, HelperTextItem } from '@patternfly/react-core'; export const DatePickerHelperText: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerMinMax.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerMinMax.tsx index 1253f5bab56..74f565bc37a 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerMinMax.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerMinMax.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DatePicker } from '@patternfly/react-core'; export const DatePickerMinMax: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/DatePicker/examples/DatePickerRequired.tsx b/packages/react-core/src/components/DatePicker/examples/DatePickerRequired.tsx index fbeb0f1febb..8571cd817d4 100644 --- a/packages/react-core/src/components/DatePicker/examples/DatePickerRequired.tsx +++ b/packages/react-core/src/components/DatePicker/examples/DatePickerRequired.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { DatePicker } from '@patternfly/react-core'; export const DatePickerRequired: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/DescriptionList/DescriptionList.tsx b/packages/react-core/src/components/DescriptionList/DescriptionList.tsx index 975e8e9e0d8..4edc1d5adb3 100644 --- a/packages/react-core/src/components/DescriptionList/DescriptionList.tsx +++ b/packages/react-core/src/components/DescriptionList/DescriptionList.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DescriptionList/description-list'; import { formatBreakpointMods } from '../../helpers'; diff --git a/packages/react-core/src/components/DescriptionList/DescriptionListDescription.tsx b/packages/react-core/src/components/DescriptionList/DescriptionListDescription.tsx index 205c0ea3268..cb37fdf71c6 100644 --- a/packages/react-core/src/components/DescriptionList/DescriptionListDescription.tsx +++ b/packages/react-core/src/components/DescriptionList/DescriptionListDescription.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/DescriptionList/description-list'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/DescriptionList/DescriptionListGroup.tsx b/packages/react-core/src/components/DescriptionList/DescriptionListGroup.tsx index 3828d225654..1d4b54a3529 100644 --- a/packages/react-core/src/components/DescriptionList/DescriptionListGroup.tsx +++ b/packages/react-core/src/components/DescriptionList/DescriptionListGroup.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/DescriptionList/description-list'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/DescriptionList/DescriptionListTerm.tsx b/packages/react-core/src/components/DescriptionList/DescriptionListTerm.tsx index 459edee63ce..3536e485dd8 100644 --- a/packages/react-core/src/components/DescriptionList/DescriptionListTerm.tsx +++ b/packages/react-core/src/components/DescriptionList/DescriptionListTerm.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/DescriptionList/description-list'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpText.tsx b/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpText.tsx index cf273a9d504..2a21d37b9a2 100644 --- a/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpText.tsx +++ b/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpText.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/DescriptionList/description-list'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpTextButton.tsx b/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpTextButton.tsx index d7c8508a94d..6950498d2e9 100644 --- a/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpTextButton.tsx +++ b/packages/react-core/src/components/DescriptionList/DescriptionListTermHelpTextButton.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { createRef } from 'react'; import styles from '@patternfly/react-styles/css/components/DescriptionList/description-list'; import { css } from '@patternfly/react-styles'; @@ -14,7 +14,7 @@ export const DescriptionListTermHelpTextButton: React.FunctionComponent { - const helpTextRef = React.createRef(); + const helpTextRef = createRef(); const handleKeys = (event: React.KeyboardEvent) => { if (!helpTextRef.current || helpTextRef.current !== (event.target as HTMLElement)) { diff --git a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionList.test.tsx b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionList.test.tsx index 9240e271c23..1bc061785ab 100644 --- a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionList.test.tsx +++ b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionList.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DescriptionList } from '../DescriptionList'; diff --git a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListDescription.test.tsx b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListDescription.test.tsx index 65367307167..e18009a2604 100644 --- a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListDescription.test.tsx +++ b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListDescription.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DescriptionListDescription } from '../DescriptionListDescription'; diff --git a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListGroup.test.tsx b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListGroup.test.tsx index 53e84b545ff..18e07ca68b9 100644 --- a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListGroup.test.tsx +++ b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListGroup.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DescriptionListGroup } from '../DescriptionListGroup'; diff --git a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListHelpTextButton.test.tsx b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListHelpTextButton.test.tsx index bb49c585450..120279c6fda 100644 --- a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListHelpTextButton.test.tsx +++ b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListHelpTextButton.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DescriptionListTermHelpTextButton } from '../DescriptionListTermHelpTextButton'; diff --git a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTerm.test.tsx b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTerm.test.tsx index 840db5199ea..173ba1bf4c0 100644 --- a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTerm.test.tsx +++ b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTerm.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DescriptionListTerm } from '../DescriptionListTerm'; diff --git a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTermHelpText.test.tsx b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTermHelpText.test.tsx index 1bd9779d379..27acbaf3d93 100644 --- a/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTermHelpText.test.tsx +++ b/packages/react-core/src/components/DescriptionList/__tests__/DescriptionListTermHelpText.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DescriptionListTermHelpText } from '../DescriptionListTermHelpText'; diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitBasic.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitBasic.tsx index 350ce0c3244..2ee115ea76d 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitBasic.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthModified.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthModified.tsx index a9a7f930f60..d161edf30fa 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthModified.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthModified.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthResponsive.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthResponsive.tsx index c6a6baf0967..e224b8c47af 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthResponsive.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthResponsive.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListBasic.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListBasic.tsx index 2e757d7c134..c7694925afa 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListBasic.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListColumnFill.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListColumnFill.tsx index 4130504079d..56a14f7c0fe 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListColumnFill.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListColumnFill.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompact.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompact.tsx index b88b87a1dce..a549dfc3f81 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompact.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompact.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompactHorizontal.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompactHorizontal.tsx index 9f830d4dc11..9d0861dd10a 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompactHorizontal.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListCompactHorizontal.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultAutoColumn.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultAutoColumn.tsx index faafefab01b..bc1940a8c0d 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultAutoColumn.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultAutoColumn.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultInlineGrid.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultInlineGrid.tsx index f7efc50cf19..01f5ca593a0 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultInlineGrid.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultInlineGrid.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultResponsiveColumns.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultResponsiveColumns.tsx index 62831bc0a1b..e88cebefbe2 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultResponsiveColumns.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultResponsiveColumns.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultThreeColLg.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultThreeColLg.tsx index 06e60b06979..c66e0fce3e2 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultThreeColLg.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultThreeColLg.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultTwoCol.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultTwoCol.tsx index a06a0d48aac..63c1caf52dd 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultTwoCol.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultTwoCol.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardHorizontalTermWidth.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardHorizontalTermWidth.tsx index 0c9a0ca430b..36b45683b7e 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardHorizontalTermWidth.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardHorizontalTermWidth.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, DescriptionListTerm, DescriptionListDescription, Card } from '@patternfly/react-core'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardThreeColumn.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardThreeColumn.tsx index a54c675e8e0..70947c5e2f8 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardThreeColumn.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListDisplaySizeAndCardThreeColumn.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, DescriptionListTerm, DescriptionListDescription, Card } from '@patternfly/react-core'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListFluidHorizontal.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListFluidHorizontal.tsx index 152d4142490..d2494e5dceb 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListFluidHorizontal.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListFluidHorizontal.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontal.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontal.tsx index 9ef28e516af..b08312c0523 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontal.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontal.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalAutoColumn.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalAutoColumn.tsx index 28c76e77467..2c495d4594d 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalAutoColumn.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalAutoColumn.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalCustomTermWidth.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalCustomTermWidth.tsx index 888cc033939..1974f1b0873 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalCustomTermWidth.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalCustomTermWidth.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalResponsiveColumns.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalResponsiveColumns.tsx index 22f77d4cabd..da0e109def4 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalResponsiveColumns.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalResponsiveColumns.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalThreeColLg.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalThreeColLg.tsx index a582b4dfaca..539f68c8608 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalThreeColLg.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalThreeColLg.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalTwoCol.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalTwoCol.tsx index 3e43bf50592..76a14345afa 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalTwoCol.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListHorizontalTwoCol.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListIconsOnTerms.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListIconsOnTerms.tsx index 98d896285f9..02010a4685c 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListIconsOnTerms.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListIconsOnTerms.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListResponsiveHoriVertGroup.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListResponsiveHoriVertGroup.tsx index e60d592fdf9..c97560a6125 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListResponsiveHoriVertGroup.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListResponsiveHoriVertGroup.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithCard.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithCard.tsx index 5e7a0c0ba80..63ad0076a42 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithCard.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithCard.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySize.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySize.tsx index dc673735d57..22e3962bf4f 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySize.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySize.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySizeAndCard.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySizeAndCard.tsx index 1d44868ae6e..238990874ea 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySizeAndCard.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithLargeDisplaySizeAndCard.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithTermHelpText.tsx b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithTermHelpText.tsx index 297995a4a2d..537e5a34180 100644 --- a/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithTermHelpText.tsx +++ b/packages/react-core/src/components/DescriptionList/examples/DescriptionListWithTermHelpText.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, DescriptionList, diff --git a/packages/react-core/src/components/Divider/Divider.tsx b/packages/react-core/src/components/Divider/Divider.tsx index 35ccaba4555..5b10b5b27af 100644 --- a/packages/react-core/src/components/Divider/Divider.tsx +++ b/packages/react-core/src/components/Divider/Divider.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Divider/divider'; import { formatBreakpointMods } from '../../helpers/util'; diff --git a/packages/react-core/src/components/Divider/__tests__/Divider.test.tsx b/packages/react-core/src/components/Divider/__tests__/Divider.test.tsx index 53192ed63a4..33384c6b455 100644 --- a/packages/react-core/src/components/Divider/__tests__/Divider.test.tsx +++ b/packages/react-core/src/components/Divider/__tests__/Divider.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render, screen } from '@testing-library/react'; import { Divider } from '../Divider'; import styles from '@patternfly/react-styles/css/components/Divider/divider'; diff --git a/packages/react-core/src/components/Divider/examples/DividerInsetMedium.tsx b/packages/react-core/src/components/Divider/examples/DividerInsetMedium.tsx index 281c786b590..23ac7a522fd 100644 --- a/packages/react-core/src/components/Divider/examples/DividerInsetMedium.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerInsetMedium.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider } from '@patternfly/react-core'; export const DividerInsetMedium: React.FunctionComponent = () => ; diff --git a/packages/react-core/src/components/Divider/examples/DividerInsetVariousBreakpoints.tsx b/packages/react-core/src/components/Divider/examples/DividerInsetVariousBreakpoints.tsx index 20f43d5dedc..32a706ec99b 100644 --- a/packages/react-core/src/components/Divider/examples/DividerInsetVariousBreakpoints.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerInsetVariousBreakpoints.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider } from '@patternfly/react-core'; export const DividerInsetVariousBreakpoints: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Divider/examples/DividerOrientationVariousBreakpoints.tsx b/packages/react-core/src/components/Divider/examples/DividerOrientationVariousBreakpoints.tsx index b182293baaf..da3b18a8337 100644 --- a/packages/react-core/src/components/Divider/examples/DividerOrientationVariousBreakpoints.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerOrientationVariousBreakpoints.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider, Flex, FlexItem } from '@patternfly/react-core'; export const DividerOrientationVariousBreakpoints: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Divider/examples/DividerUsingDiv.tsx b/packages/react-core/src/components/Divider/examples/DividerUsingDiv.tsx index fc16716c5f7..2db47de38eb 100644 --- a/packages/react-core/src/components/Divider/examples/DividerUsingDiv.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerUsingDiv.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider } from '@patternfly/react-core'; export const DividerUsingDiv: React.FunctionComponent = () => ; diff --git a/packages/react-core/src/components/Divider/examples/DividerUsingHr.tsx b/packages/react-core/src/components/Divider/examples/DividerUsingHr.tsx index 8ca86bcdee6..90b2418a27b 100644 --- a/packages/react-core/src/components/Divider/examples/DividerUsingHr.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerUsingHr.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider } from '@patternfly/react-core'; export const DividerUsingHr: React.FunctionComponent = () => ; diff --git a/packages/react-core/src/components/Divider/examples/DividerUsingLi.tsx b/packages/react-core/src/components/Divider/examples/DividerUsingLi.tsx index f8e0c4269ea..0d6e4584f65 100644 --- a/packages/react-core/src/components/Divider/examples/DividerUsingLi.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerUsingLi.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider } from '@patternfly/react-core'; export const DividerUsingLi: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Divider/examples/DividerVerticalFlex.tsx b/packages/react-core/src/components/Divider/examples/DividerVerticalFlex.tsx index 57054866cde..47a40933628 100644 --- a/packages/react-core/src/components/Divider/examples/DividerVerticalFlex.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerVerticalFlex.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider, Flex, FlexItem } from '@patternfly/react-core'; export const DividerVerticalFlex: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetSmall.tsx b/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetSmall.tsx index 95e93d151c1..0ad28729feb 100644 --- a/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetSmall.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetSmall.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider, Flex, FlexItem } from '@patternfly/react-core'; export const DividerVerticalFlexInsetSmall: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetVariousBreakpoints.tsx b/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetVariousBreakpoints.tsx index c47a605b781..7f1c67baca9 100644 --- a/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetVariousBreakpoints.tsx +++ b/packages/react-core/src/components/Divider/examples/DividerVerticalFlexInsetVariousBreakpoints.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Divider, Flex, FlexItem } from '@patternfly/react-core'; export const DividerVerticalFlexInsetVariousBreakpoints: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Drawer/Drawer.tsx b/packages/react-core/src/components/Drawer/Drawer.tsx index d8151d76780..c38effa6016 100644 --- a/packages/react-core/src/components/Drawer/Drawer.tsx +++ b/packages/react-core/src/components/Drawer/Drawer.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { createContext, useRef } from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; @@ -35,7 +35,7 @@ export interface DrawerContextProps { isInline: boolean; } -export const DrawerContext = React.createContext>({ +export const DrawerContext = createContext>({ isExpanded: false, isStatic: false, onExpand: () => {}, @@ -55,8 +55,8 @@ export const Drawer: React.FunctionComponent = ({ onExpand = () => {}, ...props }: DrawerProps) => { - const drawerRef = React.useRef(undefined); - const drawerContentRef = React.useRef(undefined); + const drawerRef = useRef(undefined); + const drawerContentRef = useRef(undefined); return ( diff --git a/packages/react-core/src/components/Drawer/DrawerActions.tsx b/packages/react-core/src/components/Drawer/DrawerActions.tsx index 85321d7c0ee..97d4367861c 100644 --- a/packages/react-core/src/components/Drawer/DrawerActions.tsx +++ b/packages/react-core/src/components/Drawer/DrawerActions.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Drawer/DrawerCloseButton.tsx b/packages/react-core/src/components/Drawer/DrawerCloseButton.tsx index fc6fff86dc6..14639244ac3 100644 --- a/packages/react-core/src/components/Drawer/DrawerCloseButton.tsx +++ b/packages/react-core/src/components/Drawer/DrawerCloseButton.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; import { Button } from '../Button'; diff --git a/packages/react-core/src/components/Drawer/DrawerContent.tsx b/packages/react-core/src/components/Drawer/DrawerContent.tsx index 4dda7972892..a489316842d 100644 --- a/packages/react-core/src/components/Drawer/DrawerContent.tsx +++ b/packages/react-core/src/components/Drawer/DrawerContent.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { useContext } from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; import { DrawerMain } from './DrawerMain'; @@ -28,7 +28,7 @@ export const DrawerContent: React.FunctionComponent = ({ colorVariant = DrawerContentColorVariant.default, ...props }: DrawerContentProps) => { - const { drawerContentRef } = React.useContext(DrawerContext); + const { drawerContentRef } = useContext(DrawerContext); return ( diff --git a/packages/react-core/src/components/Drawer/DrawerContentBody.tsx b/packages/react-core/src/components/Drawer/DrawerContentBody.tsx index b5d32fdba39..a522457b4a2 100644 --- a/packages/react-core/src/components/Drawer/DrawerContentBody.tsx +++ b/packages/react-core/src/components/Drawer/DrawerContentBody.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Drawer/DrawerHead.tsx b/packages/react-core/src/components/Drawer/DrawerHead.tsx index 16b634b0419..703531699ea 100644 --- a/packages/react-core/src/components/Drawer/DrawerHead.tsx +++ b/packages/react-core/src/components/Drawer/DrawerHead.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Drawer/DrawerMain.tsx b/packages/react-core/src/components/Drawer/DrawerMain.tsx index 095046a7302..1cda6baddab 100644 --- a/packages/react-core/src/components/Drawer/DrawerMain.tsx +++ b/packages/react-core/src/components/Drawer/DrawerMain.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Drawer/DrawerPanelBody.tsx b/packages/react-core/src/components/Drawer/DrawerPanelBody.tsx index b23ccca102f..9b6ca99e73e 100644 --- a/packages/react-core/src/components/Drawer/DrawerPanelBody.tsx +++ b/packages/react-core/src/components/Drawer/DrawerPanelBody.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Drawer/DrawerPanelContent.tsx b/packages/react-core/src/components/Drawer/DrawerPanelContent.tsx index 9822585e2a8..83cac16a3aa 100644 --- a/packages/react-core/src/components/Drawer/DrawerPanelContent.tsx +++ b/packages/react-core/src/components/Drawer/DrawerPanelContent.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Fragment, useCallback, useContext, useEffect, useRef, useState } from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; import { DrawerColorVariant, DrawerContext } from './Drawer'; @@ -47,7 +47,7 @@ export interface DrawerPanelContentProps extends Omit { - const panel = React.useRef(undefined); - const splitterRef = React.useRef(undefined); - const [separatorValue, setSeparatorValue] = React.useState(0); - const { position, isExpanded, isStatic, onExpand, drawerRef, drawerContentRef, isInline } = - React.useContext(DrawerContext); + const panel = useRef(undefined); + const splitterRef = useRef(undefined); + const [separatorValue, setSeparatorValue] = useState(0); + const { position, isExpanded, isStatic, onExpand, drawerRef, drawerContentRef, isInline } = useContext(DrawerContext); const hidden = isStatic ? false : !isExpanded; - const [isExpandedInternal, setIsExpandedInternal] = React.useState(!hidden); - const [isFocusTrapActive, setIsFocusTrapActive] = React.useState(false); - const previouslyFocusedElement = React.useRef(null); + const [isExpandedInternal, setIsExpandedInternal] = useState(!hidden); + const [isFocusTrapActive, setIsFocusTrapActive] = useState(false); + const previouslyFocusedElement = useRef(null); let currWidth: number = 0; let panelRect: DOMRect; let end: number; @@ -102,7 +101,7 @@ export const DrawerPanelContent: React.FunctionComponent { + useEffect(() => { if (!isStatic && isExpanded) { setIsExpandedInternal(isExpanded); } @@ -258,10 +257,10 @@ export const DrawerPanelContent: React.FunctionComponent { const isRTL = getLanguageDirection(panel.current) === 'rtl'; @@ -389,9 +388,9 @@ export const DrawerPanelContent: React.FunctionComponent {isExpandedInternal && ( - + {isResizable && ( - +
    {children}
    -
    + )} {!isResizable && children} - + )} ); diff --git a/packages/react-core/src/components/Drawer/DrawerPanelDescription.tsx b/packages/react-core/src/components/Drawer/DrawerPanelDescription.tsx index ac066f09b0a..7d044777f8d 100644 --- a/packages/react-core/src/components/Drawer/DrawerPanelDescription.tsx +++ b/packages/react-core/src/components/Drawer/DrawerPanelDescription.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Drawer/DrawerSection.tsx b/packages/react-core/src/components/Drawer/DrawerSection.tsx index 95e0a0662f6..011f2dde0b8 100644 --- a/packages/react-core/src/components/Drawer/DrawerSection.tsx +++ b/packages/react-core/src/components/Drawer/DrawerSection.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Drawer/drawer'; import { css } from '@patternfly/react-styles'; import { DrawerColorVariant } from './Drawer'; diff --git a/packages/react-core/src/components/Drawer/__tests__/Drawer.test.tsx b/packages/react-core/src/components/Drawer/__tests__/Drawer.test.tsx index c215634bb50..a7b0d8a8708 100644 --- a/packages/react-core/src/components/Drawer/__tests__/Drawer.test.tsx +++ b/packages/react-core/src/components/Drawer/__tests__/Drawer.test.tsx @@ -1,3 +1,4 @@ +import { createContext } from 'react'; import { Drawer, DrawerActions, @@ -9,7 +10,6 @@ import { DrawerPanelContent, DrawerColorVariant } from '../'; -import React from 'react'; import { render } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { KeyTypes } from '../../../helpers'; @@ -130,7 +130,7 @@ test(`Drawer has resizable callback and id`, () => { }); test('Resizeable DrawerPanelContent can be wrapped in a context without causing an error', async () => { - const TestContext = React.createContext({}); + const TestContext = createContext({}); const consoleError = jest.spyOn(console, 'error').mockImplementation(); diff --git a/packages/react-core/src/components/Drawer/__tests__/DrawerPanelContent.test.tsx b/packages/react-core/src/components/Drawer/__tests__/DrawerPanelContent.test.tsx index b1cd0fe850e..fd277778bf3 100644 --- a/packages/react-core/src/components/Drawer/__tests__/DrawerPanelContent.test.tsx +++ b/packages/react-core/src/components/Drawer/__tests__/DrawerPanelContent.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import { DrawerPanelContent } from '../DrawerPanelContent'; import { Drawer } from '../Drawer'; diff --git a/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerContent.test.tsx b/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerContent.test.tsx index a4f332fc05e..3ce691d8284 100644 --- a/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerContent.test.tsx +++ b/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerContent.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DrawerContent } from '../../DrawerContent'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerPanelContent.test.tsx b/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerPanelContent.test.tsx index ed8676d0943..34c66959937 100644 --- a/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerPanelContent.test.tsx +++ b/packages/react-core/src/components/Drawer/__tests__/Generated/DrawerPanelContent.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { DrawerPanelContent } from '../../DrawerPanelContent'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/Drawer/examples/Drawer.md b/packages/react-core/src/components/Drawer/examples/Drawer.md index 448970d8247..e9db8ac9e5b 100644 --- a/packages/react-core/src/components/Drawer/examples/Drawer.md +++ b/packages/react-core/src/components/Drawer/examples/Drawer.md @@ -17,7 +17,7 @@ propComponents: ] section: components --- - +import { Fragment, useRef, useState } from 'react'; import accessibility from '@patternfly/react-styles/css/utilities/Accessibility/accessibility'; ## Examples diff --git a/packages/react-core/src/components/Drawer/examples/DrawerAdditionalSectionAboveContent.tsx b/packages/react-core/src/components/Drawer/examples/DrawerAdditionalSectionAboveContent.tsx index 1c217b3f986..df64c62bda8 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerAdditionalSectionAboveContent.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerAdditionalSectionAboveContent.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -12,8 +12,8 @@ import { } from '@patternfly/react-core'; export const DrawerAdditionalSectionAboveContent: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -44,7 +44,7 @@ export const DrawerAdditionalSectionAboveContent: React.FunctionComponent = () = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -54,6 +54,6 @@ export const DrawerAdditionalSectionAboveContent: React.FunctionComponent = () = {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerBasic.tsx b/packages/react-core/src/components/Drawer/examples/DrawerBasic.tsx index 134bfdf098d..e792e32a058 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerBasic.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerBasic.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -13,8 +13,8 @@ import { } from '@patternfly/react-core'; export const DrawerBasic: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -47,7 +47,7 @@ export const DrawerBasic: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -56,6 +56,6 @@ export const DrawerBasic: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerBasicInline.tsx b/packages/react-core/src/components/Drawer/examples/DrawerBasicInline.tsx index b948452b7b6..a9ceb86666e 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerBasicInline.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerBasicInline.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerBasicInline: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerBasicInline: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerBasicInline: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerBreakpoint.tsx b/packages/react-core/src/components/Drawer/examples/DrawerBreakpoint.tsx index 961706d8fda..74eb0eb514f 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerBreakpoint.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerBreakpoint.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerBreakpoint: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerBreakpoint: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerBreakpoint: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerFocusTrap.tsx b/packages/react-core/src/components/Drawer/examples/DrawerFocusTrap.tsx index e8fde64ed44..5f5f44422e7 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerFocusTrap.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerFocusTrap.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,7 +11,7 @@ import { } from '@patternfly/react-core'; export const DrawerFocusTrap: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); + const [isExpanded, setIsExpanded] = useState(false); const onClick = () => { setIsExpanded(!isExpanded); @@ -44,7 +44,7 @@ export const DrawerFocusTrap: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -53,6 +53,6 @@ export const DrawerFocusTrap: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelEnd.tsx b/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelEnd.tsx index 721ba69ad81..9574c6a5360 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelEnd.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelEnd.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerInlinePanelEnd: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerInlinePanelEnd: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerInlinePanelEnd: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelStart.tsx b/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelStart.tsx index 0331478d321..c1ed8445748 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelStart.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerInlinePanelStart.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerInlinePanelStart: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerInlinePanelStart: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerInlinePanelStart: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerModifiedContentPadding.tsx b/packages/react-core/src/components/Drawer/examples/DrawerModifiedContentPadding.tsx index d81a87a8a77..218f7b44889 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerModifiedContentPadding.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerModifiedContentPadding.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerModifiedContentPadding: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerModifiedContentPadding: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -54,6 +54,6 @@ export const DrawerModifiedContentPadding: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerModifiedPanelPadding.tsx b/packages/react-core/src/components/Drawer/examples/DrawerModifiedPanelPadding.tsx index 2ee41112dea..5f28bd3e451 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerModifiedPanelPadding.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerModifiedPanelPadding.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerModifiedPanelPadding: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerModifiedPanelPadding: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerModifiedPanelPadding: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerPanelBottom.tsx b/packages/react-core/src/components/Drawer/examples/DrawerPanelBottom.tsx index f52b0d72acb..c89f7f13e1f 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerPanelBottom.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerPanelBottom.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerPanelBottom: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerPanelBottom: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -54,6 +54,6 @@ export const DrawerPanelBottom: React.FunctionComponent = () => {
    -
    + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerPanelEnd.tsx b/packages/react-core/src/components/Drawer/examples/DrawerPanelEnd.tsx index c763fce6b22..852b9eff4c1 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerPanelEnd.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerPanelEnd.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerPanelEnd: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerPanelEnd: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerPanelEnd: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerPanelStart.tsx b/packages/react-core/src/components/Drawer/examples/DrawerPanelStart.tsx index 3d9ab12a799..60c8cc515e0 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerPanelStart.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerPanelStart.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerPanelStart: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerPanelStart: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerPanelStart: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerResizableAtEnd.tsx b/packages/react-core/src/components/Drawer/examples/DrawerResizableAtEnd.tsx index 88dec2ed23e..252c683ce33 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerResizableAtEnd.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerResizableAtEnd.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerResizableAtEnd: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -48,7 +48,7 @@ export const DrawerResizableAtEnd: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -57,6 +57,6 @@ export const DrawerResizableAtEnd: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerResizableAtStart.tsx b/packages/react-core/src/components/Drawer/examples/DrawerResizableAtStart.tsx index f0b8aae5cf9..b5d2ef2da8f 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerResizableAtStart.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerResizableAtStart.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerResizableAtStart: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -43,7 +43,7 @@ export const DrawerResizableAtStart: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -52,6 +52,6 @@ export const DrawerResizableAtStart: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerResizableOnBottom.tsx b/packages/react-core/src/components/Drawer/examples/DrawerResizableOnBottom.tsx index 9f033b26924..86da473b620 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerResizableOnBottom.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerResizableOnBottom.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerResizableOnBottom: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -42,7 +42,7 @@ export const DrawerResizableOnBottom: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -53,6 +53,6 @@ export const DrawerResizableOnBottom: React.FunctionComponent = () => {
    - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerResizableOnInline.tsx b/packages/react-core/src/components/Drawer/examples/DrawerResizableOnInline.tsx index ee13637e567..e4dd4a57bd5 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerResizableOnInline.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerResizableOnInline.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const DrawerResizableOnInline: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -42,7 +42,7 @@ export const DrawerResizableOnInline: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -51,6 +51,6 @@ export const DrawerResizableOnInline: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerSecondaryBackground.tsx b/packages/react-core/src/components/Drawer/examples/DrawerSecondaryBackground.tsx index 3ad6042666b..485dff0dcbf 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerSecondaryBackground.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerSecondaryBackground.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Checkbox, Drawer, @@ -15,12 +15,12 @@ import { } from '@patternfly/react-core'; export const DrawerSecondaryBackground: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const [panelSecondary, setPanelSecondary] = React.useState(true); - const [contentSecondary, setContentSecondary] = React.useState(false); - const [sectionSecondary, setSectionSecondary] = React.useState(false); + const [isExpanded, setIsExpanded] = useState(false); + const [panelSecondary, setPanelSecondary] = useState(true); + const [contentSecondary, setContentSecondary] = useState(false); + const [sectionSecondary, setSectionSecondary] = useState(false); - const drawerRef = React.useRef(null); + const drawerRef = useRef(null); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -63,7 +63,7 @@ export const DrawerSecondaryBackground: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerStackedContentBodyElements.tsx b/packages/react-core/src/components/Drawer/examples/DrawerStackedContentBodyElements.tsx index 6b5ae20a70e..c4f55ddb862 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerStackedContentBodyElements.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerStackedContentBodyElements.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -13,8 +13,8 @@ import { } from '@patternfly/react-core'; export const DrawerStackedContentBodyElements: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -44,7 +44,7 @@ export const DrawerStackedContentBodyElements: React.FunctionComponent = () => { ); return ( - + @@ -55,6 +55,6 @@ export const DrawerStackedContentBodyElements: React.FunctionComponent = () => { content-body - + ); }; diff --git a/packages/react-core/src/components/Drawer/examples/DrawerStatic.tsx b/packages/react-core/src/components/Drawer/examples/DrawerStatic.tsx index 599e16458f1..773d693207b 100644 --- a/packages/react-core/src/components/Drawer/examples/DrawerStatic.tsx +++ b/packages/react-core/src/components/Drawer/examples/DrawerStatic.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useRef, useState } from 'react'; import { Drawer, DrawerPanelContent, @@ -12,8 +12,8 @@ import { import accessibility from '@patternfly/react-styles/css/utilities/Accessibility/accessibility'; export const DrawerStatic: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(false); - const drawerRef = React.useRef(undefined); + const [isExpanded, setIsExpanded] = useState(false); + const drawerRef = useRef(undefined); const onExpand = () => { drawerRef.current && drawerRef.current.focus(); @@ -44,7 +44,7 @@ export const DrawerStatic: React.FunctionComponent = () => { 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus pretium est a porttitor vehicula. Quisque vel commodo urna. Morbi mattis rutrum ante, id vehicula ex accumsan ut. Morbi viverra, eros vel porttitor facilisis, eros purus aliquet erat,nec lobortis felis elit pulvinar sem. Vivamus vulputate, risus eget commodo eleifend, eros nibh porta quam, vitae lacinia leo libero at magna. Maecenas aliquam sagittis orci, et posuere nisi ultrices sit amet. Aliquam ex odio, malesuada sed posuere quis, pellentesque at mauris. Phasellus venenatis massa ex, eget pulvinar libero auctor pretium. Aliquam erat volutpat. Duis euismod justo in quam ullamcorper, in commodo massa vulputate.'; return ( - + @@ -53,6 +53,6 @@ export const DrawerStatic: React.FunctionComponent = () => { {drawerContent} - + ); }; diff --git a/packages/react-core/src/components/Dropdown/Dropdown.tsx b/packages/react-core/src/components/Dropdown/Dropdown.tsx index 0c4481624a4..9ad39d49477 100644 --- a/packages/react-core/src/components/Dropdown/Dropdown.tsx +++ b/packages/react-core/src/components/Dropdown/Dropdown.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { forwardRef, useEffect, useRef } from 'react'; import { css } from '@patternfly/react-styles'; import { Menu, MenuContent, MenuProps } from '../Menu'; import { Popper } from '../../helpers/Popper/Popper'; @@ -47,7 +47,7 @@ export interface DropdownProps extends MenuProps, OUIAProps { /** Function callback called when user selects item. */ onSelect?: (event?: React.MouseEvent, value?: string | number) => void; /** Callback to allow the dropdown component to change the open state of the menu. - * Triggered by clicking outside of the menu, or by pressing any keys specificed in onOpenChangeKeys. */ + * Triggered by clicking outside of the menu, or by pressing any keys specified in onOpenChangeKeys. */ onOpenChange?: (isOpen: boolean) => void; /** Keys that trigger onOpenChange, defaults to tab and escape. It is highly recommended to include Escape in the array, while Tab may be omitted if the menu contains non-menu items that are focusable. */ onOpenChangeKeys?: string[]; @@ -103,8 +103,8 @@ const DropdownBase: React.FunctionComponent = ({ focusTimeoutDelay = 0, ...props }: DropdownProps) => { - const localMenuRef = React.useRef(undefined); - const localToggleRef = React.useRef(undefined); + const localMenuRef = useRef(undefined); + const localToggleRef = useRef(undefined); const ouiaProps = useOUIAProps(Dropdown.displayName, ouiaId, ouiaSafe); const menuRef = (innerRef as React.RefObject) || localMenuRef; @@ -113,8 +113,8 @@ const DropdownBase: React.FunctionComponent = ({ ? localToggleRef : (toggle?.toggleRef as React.RefObject); - const prevIsOpen = React.useRef(isOpen); - React.useEffect(() => { + const prevIsOpen = useRef(isOpen); + useEffect(() => { // menu was opened, focus on first menu item if (prevIsOpen.current === false && isOpen === true && shouldFocusFirstItemOnOpen) { setTimeout(() => { @@ -129,7 +129,7 @@ const DropdownBase: React.FunctionComponent = ({ // eslint-disable-next-line react-hooks/exhaustive-deps }, [isOpen]); - React.useEffect(() => { + useEffect(() => { const handleMenuKeys = (event: KeyboardEvent) => { // Close the menu on tab or escape if onOpenChange is provided if ( @@ -213,7 +213,7 @@ const DropdownBase: React.FunctionComponent = ({ ); }; -export const Dropdown = React.forwardRef((props: DropdownProps, ref: React.Ref) => ( +export const Dropdown = forwardRef((props: DropdownProps, ref: React.Ref) => ( )); Dropdown.displayName = 'Dropdown'; diff --git a/packages/react-core/src/components/Dropdown/DropdownGroup.tsx b/packages/react-core/src/components/Dropdown/DropdownGroup.tsx index 721e6216071..ea1f63fd98b 100644 --- a/packages/react-core/src/components/Dropdown/DropdownGroup.tsx +++ b/packages/react-core/src/components/Dropdown/DropdownGroup.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { css } from '@patternfly/react-styles'; import { MenuGroupProps, MenuGroup } from '../Menu'; diff --git a/packages/react-core/src/components/Dropdown/DropdownItem.tsx b/packages/react-core/src/components/Dropdown/DropdownItem.tsx index d6cf6e127c1..0c973f45e9e 100644 --- a/packages/react-core/src/components/Dropdown/DropdownItem.tsx +++ b/packages/react-core/src/components/Dropdown/DropdownItem.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { forwardRef } from 'react'; import { css } from '@patternfly/react-styles'; import { MenuItemProps, MenuItem } from '../Menu'; import { TooltipProps } from '../Tooltip'; @@ -65,7 +65,7 @@ const DropdownItemBase: React.FunctionComponent = ({ ); }; -export const DropdownItem = React.forwardRef( +export const DropdownItem = forwardRef( (props: DropdownItemProps, ref: React.Ref) => ( ) diff --git a/packages/react-core/src/components/Dropdown/DropdownList.tsx b/packages/react-core/src/components/Dropdown/DropdownList.tsx index e591d1ae3f0..8f9b8fac4f0 100644 --- a/packages/react-core/src/components/Dropdown/DropdownList.tsx +++ b/packages/react-core/src/components/Dropdown/DropdownList.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { css } from '@patternfly/react-styles'; import { MenuListProps, MenuList } from '../Menu'; diff --git a/packages/react-core/src/components/Dropdown/__tests__/Dropdown.test.tsx b/packages/react-core/src/components/Dropdown/__tests__/Dropdown.test.tsx index 09951f3ee11..73e6d5068d5 100644 --- a/packages/react-core/src/components/Dropdown/__tests__/Dropdown.test.tsx +++ b/packages/react-core/src/components/Dropdown/__tests__/Dropdown.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Dropdown } from '../../Dropdown'; import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; diff --git a/packages/react-core/src/components/Dropdown/__tests__/DropdownGroup.test.tsx b/packages/react-core/src/components/Dropdown/__tests__/DropdownGroup.test.tsx index d7dd551e3a4..789e8a86b6e 100644 --- a/packages/react-core/src/components/Dropdown/__tests__/DropdownGroup.test.tsx +++ b/packages/react-core/src/components/Dropdown/__tests__/DropdownGroup.test.tsx @@ -1,7 +1,5 @@ import { DropdownGroup } from '../../Dropdown'; import { render, screen } from '@testing-library/react'; -import React from 'react'; - jest.mock('../../Menu'); const dropdownGroupChildren =
    Dropdown Group children
    ; diff --git a/packages/react-core/src/components/Dropdown/__tests__/DropdownItem.test.tsx b/packages/react-core/src/components/Dropdown/__tests__/DropdownItem.test.tsx index a016915e514..e70b5ca8667 100644 --- a/packages/react-core/src/components/Dropdown/__tests__/DropdownItem.test.tsx +++ b/packages/react-core/src/components/Dropdown/__tests__/DropdownItem.test.tsx @@ -1,7 +1,5 @@ import { DropdownItem } from '../../Dropdown'; import { render, screen } from '@testing-library/react'; -import React from 'react'; - jest.mock('../../Menu'); const dropdownItemChildren =
    Dropdown Item children
    ; diff --git a/packages/react-core/src/components/Dropdown/__tests__/DropdownList.test.tsx b/packages/react-core/src/components/Dropdown/__tests__/DropdownList.test.tsx index ba9a61ee650..be2cdf8316a 100644 --- a/packages/react-core/src/components/Dropdown/__tests__/DropdownList.test.tsx +++ b/packages/react-core/src/components/Dropdown/__tests__/DropdownList.test.tsx @@ -1,7 +1,5 @@ import { DropdownList } from '../../Dropdown'; import { render, screen } from '@testing-library/react'; -import React from 'react'; - jest.mock('../../Menu'); const dropdownListChildren =
    Dropdown List children
    ; diff --git a/packages/react-core/src/components/Dropdown/examples/DropdownBasic.tsx b/packages/react-core/src/components/Dropdown/examples/DropdownBasic.tsx index d5948281fe2..adfbe3080e5 100644 --- a/packages/react-core/src/components/Dropdown/examples/DropdownBasic.tsx +++ b/packages/react-core/src/components/Dropdown/examples/DropdownBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Dropdown, DropdownItem, DropdownList, Divider, MenuToggle, MenuToggleElement } from '@patternfly/react-core'; export const DropdownBasic: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Dropdown/examples/DropdownWithDescriptions.tsx b/packages/react-core/src/components/Dropdown/examples/DropdownWithDescriptions.tsx index 751dccbf546..3cb1f12e9d6 100644 --- a/packages/react-core/src/components/Dropdown/examples/DropdownWithDescriptions.tsx +++ b/packages/react-core/src/components/Dropdown/examples/DropdownWithDescriptions.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Dropdown, DropdownItem, DropdownList, MenuToggle, MenuToggleElement } from '@patternfly/react-core'; export const DropdownWithDescriptions: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Dropdown/examples/DropdownWithGroups.tsx b/packages/react-core/src/components/Dropdown/examples/DropdownWithGroups.tsx index 5664eb5a8f3..cdd53aed518 100644 --- a/packages/react-core/src/components/Dropdown/examples/DropdownWithGroups.tsx +++ b/packages/react-core/src/components/Dropdown/examples/DropdownWithGroups.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Dropdown, DropdownGroup, diff --git a/packages/react-core/src/components/Dropdown/examples/DropdownWithKebabToggle.tsx b/packages/react-core/src/components/Dropdown/examples/DropdownWithKebabToggle.tsx index 1ab5f49442b..c195359b0c2 100644 --- a/packages/react-core/src/components/Dropdown/examples/DropdownWithKebabToggle.tsx +++ b/packages/react-core/src/components/Dropdown/examples/DropdownWithKebabToggle.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Dropdown, DropdownItem, DropdownList, Divider, MenuToggle, MenuToggleElement } from '@patternfly/react-core'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; diff --git a/packages/react-core/src/components/DualListSelector/DualListSelector.tsx b/packages/react-core/src/components/DualListSelector/DualListSelector.tsx index 2663f3fc74e..0487e89e813 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelector.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelector.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Component } from 'react'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { css } from '@patternfly/react-styles'; import { GenerateId, PickOptional } from '../../helpers'; @@ -19,7 +19,7 @@ export interface DualListSelectorProps { children?: React.ReactNode; } -class DualListSelector extends React.Component { +class DualListSelector extends Component { static displayName = 'DualListSelector'; static defaultProps: PickOptional = { children: '', diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorContext.ts b/packages/react-core/src/components/DualListSelector/DualListSelectorContext.ts index 3eccc9a0dc6..ae05d7cdc01 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorContext.ts +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorContext.ts @@ -1,10 +1,9 @@ -import * as React from 'react'; - -export const DualListSelectorContext = React.createContext<{ +import { createContext } from 'react'; +export const DualListSelectorContext = createContext<{ isTree?: boolean; }>({ isTree: false }); -export const DualListSelectorListContext = React.createContext<{ +export const DualListSelectorListContext = createContext<{ setFocusedOption?: (id: string) => void; isTree?: boolean; ariaLabelledBy?: string; @@ -16,6 +15,6 @@ export const DualListSelectorListContext = React.createContext<{ isDisabled?: boolean; }>({}); -export const DualListSelectorPaneContext = React.createContext<{ +export const DualListSelectorPaneContext = createContext<{ isChosen: boolean; }>({ isChosen: false }); diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorControl.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorControl.tsx index 94c90eafb46..1781fa3d664 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorControl.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorControl.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { forwardRef, useRef } from 'react'; import { css } from '@patternfly/react-styles'; import { Button, ButtonVariant } from '../Button'; import { Tooltip } from '../Tooltip'; @@ -41,7 +41,7 @@ export const DualListSelectorControlBase: React.FunctionComponent { - const privateRef = React.useRef(null); + const privateRef = useRef(null); const ref = innerRef || privateRef; return (
    @@ -63,7 +63,7 @@ export const DualListSelectorControlBase: React.FunctionComponent) => ( +export const DualListSelectorControl = forwardRef((props: DualListSelectorControlProps, ref: React.Ref) => ( )); diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorControlsWrapper.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorControlsWrapper.tsx index 8a6ab82363e..3f9fcba50d7 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorControlsWrapper.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorControlsWrapper.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { forwardRef, useEffect, useRef } from 'react'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { css } from '@patternfly/react-styles'; import { handleArrows } from '../../helpers'; @@ -23,7 +23,7 @@ export const DualListSelectorControlsWrapperBase: React.FunctionComponent { - const ref = React.useRef(null); + const ref = useRef(null); const wrapperRef = innerRef || ref; // Adds keyboard navigation to the dynamically built dual list selector controls. Works when controls are dynamically built // as well as when they are passed in via children. @@ -55,7 +55,7 @@ export const DualListSelectorControlsWrapperBase: React.FunctionComponent { + useEffect(() => { window.addEventListener('keydown', handleKeys); return () => { window.removeEventListener('keydown', handleKeys); @@ -78,7 +78,7 @@ export const DualListSelectorControlsWrapperBase: React.FunctionComponent) => ( } role="group" {...props} /> ) diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorList.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorList.tsx index d799e4751b8..96287bdc7b8 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorList.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorList.tsx @@ -1,7 +1,7 @@ +import { forwardRef, useContext } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { DualListSelectorListItem } from './DualListSelectorListItem'; -import * as React from 'react'; import { DualListSelectorListContext } from './DualListSelectorContext'; /** Acts as the container for DualListSelectorListItem sub-components. */ @@ -19,7 +19,7 @@ export const DualListSelectorListBase: React.FunctionComponent { const { isTree, ariaLabelledBy, focusedOption, displayOption, selectedOptions, id, options, isDisabled } = - React.useContext(DualListSelectorListContext); + useContext(DualListSelectorListContext); const hasOptions = () => options.length !== 0 || (children !== undefined && (children as React.ReactNode[]).length !== 0); @@ -60,10 +60,8 @@ export const DualListSelectorListBase: React.FunctionComponent) => ( - } {...props} /> - ) -); +export const DualListSelectorList = forwardRef((props: DualListSelectorListProps, ref: React.Ref) => ( + } {...props} /> +)); DualListSelectorList.displayName = 'DualListSelectorList'; diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorListItem.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorListItem.tsx index ed7cff94192..427ce035cab 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorListItem.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorListItem.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { forwardRef, useContext, useRef } from 'react'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { css } from '@patternfly/react-styles'; import { getUniqueId } from '../../helpers'; @@ -47,9 +47,9 @@ export const DualListSelectorListItemBase: React.FunctionComponent { - const privateRef = React.useRef(null); + const privateRef = useRef(null); const ref = innerRef || privateRef; - const { setFocusedOption } = React.useContext(DualListSelectorListContext); + const { setFocusedOption } = useContext(DualListSelectorListContext); return (
  • ) => ( } {...props} /> ) diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorListWrapper.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorListWrapper.tsx index f7f79aeed37..be6e9f535dd 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorListWrapper.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorListWrapper.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { forwardRef, useContext, useEffect, useRef, useState } from 'react'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { css } from '@patternfly/react-styles'; import { getUniqueId, handleArrows } from '../../helpers'; @@ -38,10 +38,10 @@ export const DualListSelectorListWrapperBase: React.FunctionComponent { - const [focusedOption, setFocusedOption] = React.useState(''); - const ref = React.useRef(null); + const [focusedOption, setFocusedOption] = useState(''); + const ref = useRef(null); const menuRef = innerRef || ref; - const { isTree } = React.useContext(DualListSelectorContext); + const { isTree } = useContext(DualListSelectorContext); // Sets up keyboard focus handling for the dual list selector menu child of the pane. const handleKeys = (event: KeyboardEvent) => { @@ -85,7 +85,7 @@ export const DualListSelectorListWrapperBase: React.FunctionComponent { + useEffect(() => { window.addEventListener('keydown', handleKeys); return () => { window.removeEventListener('keydown', handleKeys); @@ -115,7 +115,7 @@ export const DualListSelectorListWrapperBase: React.FunctionComponent) => ( } {...props} /> ) diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorPane.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorPane.tsx index 8011cee0a5d..c3fecbda502 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorPane.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorPane.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { css } from '@patternfly/react-styles'; import { getUniqueId } from '../../helpers'; diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorTree.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorTree.tsx index 8fb28a289b9..4555fb29b0b 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorTree.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorTree.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { DualListSelectorTreeItem } from './DualListSelectorTreeItem'; diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx index 1db39984828..b8769641d0a 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { memo, useContext, useEffect, useRef, useState } from 'react'; import styles from '@patternfly/react-styles/css/components/DualListSelector/dual-list-selector'; import { css } from '@patternfly/react-styles'; import { DualListSelectorTreeItemData } from './DualListSelectorTree'; @@ -57,11 +57,11 @@ const DualListSelectorTreeItemBase: React.FunctionComponent { - const ref = React.useRef(null); - const [isExpanded, setIsExpanded] = React.useState(defaultExpanded || false); - const { setFocusedOption } = React.useContext(DualListSelectorListContext); + const ref = useRef(null); + const [isExpanded, setIsExpanded] = useState(defaultExpanded || false); + const { setFocusedOption } = useContext(DualListSelectorListContext); - React.useEffect(() => { + useEffect(() => { setIsExpanded(defaultExpanded); }, [defaultExpanded]); @@ -161,7 +161,7 @@ const DualListSelectorTreeItemBase: React.FunctionComponent { +export const DualListSelectorTreeItem = memo(DualListSelectorTreeItemBase, (prevProps, nextProps) => { if (!nextProps.useMemo) { return false; } diff --git a/packages/react-core/src/components/DualListSelector/__tests__/DualListSelector.test.tsx b/packages/react-core/src/components/DualListSelector/__tests__/DualListSelector.test.tsx index 373aa0e993d..58ab92913eb 100644 --- a/packages/react-core/src/components/DualListSelector/__tests__/DualListSelector.test.tsx +++ b/packages/react-core/src/components/DualListSelector/__tests__/DualListSelector.test.tsx @@ -1,8 +1,6 @@ import { render } from '@testing-library/react'; import { DualListSelectorPane } from '../DualListSelectorPane'; import { SearchInput } from '../../SearchInput'; -import React from 'react'; - describe('DualListSelector', () => { test('basic', () => { const { asFragment } = render(); diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md b/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md index 8cb78306441..1ff7084efec 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md @@ -15,6 +15,7 @@ propComponents: ] --- +import { Fragment, useEffect, useMemo, useState } from 'react'; import AngleDoubleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-left-icon'; import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon'; import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon'; diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx index ec14a043dc2..b1e77ed2a6a 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { DualListSelector, DualListSelectorPane, @@ -19,13 +19,13 @@ interface Option { } export const DualListSelectorBasic: React.FunctionComponent = () => { - const [availableOptions, setAvailableOptions] = React.useState([ + const [availableOptions, setAvailableOptions] = useState([ { text: 'Option 1', selected: false, isVisible: true }, { text: 'Option 2', selected: false, isVisible: true }, { text: 'Option 3', selected: false, isVisible: true }, { text: 'Option 4', selected: false, isVisible: true } ]); - const [chosenOptions, setChosenOptions] = React.useState([]); + const [chosenOptions, setChosenOptions] = useState([]); // callback for moving selected options between lists const moveSelected = (fromAvailable: boolean) => { diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx index e395b2bc8bc..3610893e173 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { Button, DualListSelector, @@ -27,16 +27,16 @@ interface Option { } export const DualListSelectorSearch: React.FunctionComponent = () => { - const [availableOptions, setAvailableOptions] = React.useState([ + const [availableOptions, setAvailableOptions] = useState([ { text: 'Option 1', selected: false, isVisible: true }, { text: 'Option 2', selected: false, isVisible: true }, { text: 'Option 3', selected: false, isVisible: true }, { text: 'Option 4', selected: false, isVisible: true } ]); - const [chosenOptions, setChosenOptions] = React.useState([]); - const [availableFilter, setAvailableFilter] = React.useState(''); - const [chosenFilter, setChosenFilter] = React.useState(''); + const [chosenOptions, setChosenOptions] = useState([]); + const [availableFilter, setAvailableFilter] = useState(''); + const [chosenFilter, setChosenFilter] = useState(''); // callback for moving selected options between lists const moveSelected = (fromAvailable: boolean) => { diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsx b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsx index aac0b2f9c45..96ed69cd375 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsx +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { DualListSelector, DualListSelectorPane, @@ -19,13 +19,13 @@ interface Option { } export const DualListSelectorBasic: React.FunctionComponent = () => { - const [availableOptions, setAvailableOptions] = React.useState([ + const [availableOptions, setAvailableOptions] = useState([ { text: 'Option 1', selected: false, isVisible: true }, { text: 'Option 2', selected: false, isVisible: true }, { text: 'Option 3', selected: false, isVisible: true }, { text: 'Option 4', selected: false, isVisible: true } ]); - const [chosenOptions, setChosenOptions] = React.useState([]); + const [chosenOptions, setChosenOptions] = useState([]); // callback for moving selected options between lists const moveSelected = (fromAvailable: boolean) => { diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx index 5de70ac21e5..c07c4b33ea9 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment, useState } from 'react'; import { Button, ButtonVariant, @@ -36,19 +36,19 @@ interface Option { } export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent = () => { - const [availableOptions, setAvailableOptions] = React.useState([ + const [availableOptions, setAvailableOptions] = useState([ { text: 'Option 1', selected: false, isVisible: true }, { text: 'Option 2', selected: false, isVisible: true }, { text: 'Option 3', selected: false, isVisible: true }, { text: 'Option 4', selected: false, isVisible: true } ]); - const [chosenOptions, setChosenOptions] = React.useState([]); - const [isAvailableKebabOpen, setIsAvailableKebabOpen] = React.useState(false); - const [isChosenKebabOpen, setIsChosenKebabOpen] = React.useState(false); - const [availableFilter, setAvailableFilter] = React.useState(''); - const [chosenFilter, setChosenFilter] = React.useState(''); - const [isDisabled, setIsDisabled] = React.useState(false); + const [chosenOptions, setChosenOptions] = useState([]); + const [isAvailableKebabOpen, setIsAvailableKebabOpen] = useState(false); + const [isChosenKebabOpen, setIsChosenKebabOpen] = useState(false); + const [availableFilter, setAvailableFilter] = useState(''); + const [chosenFilter, setChosenFilter] = useState(''); + const [isDisabled, setIsDisabled] = useState(false); // callback for moving selected options between lists const moveSelected = (fromAvailable: boolean) => { @@ -233,7 +233,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent ); return ( - + setIsDisabled(!isDisabled)} /> - + ); }; diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx index 9da2cda7645..e0ffd23cd0d 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useMemo, useState } from 'react'; import { DualListSelector, DualListSelectorPane, @@ -32,10 +32,10 @@ interface ExampleProps { } export const DualListSelectorComposableTree: React.FunctionComponent = ({ data }: ExampleProps) => { - const [checkedLeafIds, setCheckedLeafIds] = React.useState([]); - const [chosenLeafIds, setChosenLeafIds] = React.useState(['beans', 'beef', 'chicken', 'tofu']); - const [chosenFilter, setChosenFilter] = React.useState(''); - const [availableFilter, setAvailableFilter] = React.useState(''); + const [checkedLeafIds, setCheckedLeafIds] = useState([]); + const [chosenLeafIds, setChosenLeafIds] = useState(['beans', 'beef', 'chicken', 'tofu']); + const [chosenFilter, setChosenFilter] = useState(''); + const [availableFilter, setAvailableFilter] = useState(''); // helper function to build memoized lists const buildTextById = (node: FoodNode): { [key: string]: string } => { @@ -80,7 +80,7 @@ export const DualListSelectorComposableTree: React.FunctionComponent { + const { memoizedLeavesById, memoizedAllLeaves, memoizedNodeTexts } = useMemo(() => { let leavesById = {}; let allLeaves: string[] = []; let nodeTexts = {}; diff --git a/packages/react-core/src/components/EmptyState/EmptyState.tsx b/packages/react-core/src/components/EmptyState/EmptyState.tsx index 9fe0fd02a1f..f39ca81e911 100644 --- a/packages/react-core/src/components/EmptyState/EmptyState.tsx +++ b/packages/react-core/src/components/EmptyState/EmptyState.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/EmptyState/empty-state'; import { EmptyStateHeader } from './EmptyStateHeader'; diff --git a/packages/react-core/src/components/EmptyState/EmptyStateActions.tsx b/packages/react-core/src/components/EmptyState/EmptyStateActions.tsx index aa448d976b5..e6a10d7cf9d 100644 --- a/packages/react-core/src/components/EmptyState/EmptyStateActions.tsx +++ b/packages/react-core/src/components/EmptyState/EmptyStateActions.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/EmptyState/empty-state'; diff --git a/packages/react-core/src/components/EmptyState/EmptyStateBody.tsx b/packages/react-core/src/components/EmptyState/EmptyStateBody.tsx index c80b90a49cf..7fd4250d6a5 100644 --- a/packages/react-core/src/components/EmptyState/EmptyStateBody.tsx +++ b/packages/react-core/src/components/EmptyState/EmptyStateBody.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/EmptyState/empty-state'; diff --git a/packages/react-core/src/components/EmptyState/EmptyStateFooter.tsx b/packages/react-core/src/components/EmptyState/EmptyStateFooter.tsx index 71d21e3a75f..44f3e90052b 100644 --- a/packages/react-core/src/components/EmptyState/EmptyStateFooter.tsx +++ b/packages/react-core/src/components/EmptyState/EmptyStateFooter.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/EmptyState/empty-state'; diff --git a/packages/react-core/src/components/EmptyState/EmptyStateHeader.tsx b/packages/react-core/src/components/EmptyState/EmptyStateHeader.tsx index a6d45ecd330..a0aa6658c44 100644 --- a/packages/react-core/src/components/EmptyState/EmptyStateHeader.tsx +++ b/packages/react-core/src/components/EmptyState/EmptyStateHeader.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/EmptyState/empty-state'; import { EmptyStateIcon } from './EmptyStateIcon'; diff --git a/packages/react-core/src/components/EmptyState/EmptyStateIcon.tsx b/packages/react-core/src/components/EmptyState/EmptyStateIcon.tsx index dd9234e168d..4364fb5e321 100644 --- a/packages/react-core/src/components/EmptyState/EmptyStateIcon.tsx +++ b/packages/react-core/src/components/EmptyState/EmptyStateIcon.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/EmptyState/empty-state'; import { Spinner } from '../Spinner'; diff --git a/packages/react-core/src/components/EmptyState/__tests__/EmptyState.test.tsx b/packages/react-core/src/components/EmptyState/__tests__/EmptyState.test.tsx index bbeb4cdeff2..7c5dd1933be 100644 --- a/packages/react-core/src/components/EmptyState/__tests__/EmptyState.test.tsx +++ b/packages/react-core/src/components/EmptyState/__tests__/EmptyState.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import AddressBookIcon from '@patternfly/react-icons/dist/esm/icons/address-book-icon'; diff --git a/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateActions.test.tsx b/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateActions.test.tsx index dbfae3b5d6c..e5406b2b366 100644 --- a/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateActions.test.tsx +++ b/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateActions.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { EmptyStateActions } from '../../EmptyStateActions'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateBody.test.tsx b/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateBody.test.tsx index f0a3fee5e27..617ebf88ac3 100644 --- a/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateBody.test.tsx +++ b/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateBody.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { EmptyStateBody } from '../../EmptyStateBody'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateIcon.test.tsx b/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateIcon.test.tsx index 1a9e8cc9a6d..ff74157220e 100644 --- a/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateIcon.test.tsx +++ b/packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateIcon.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import UserIcon from '@patternfly/react-icons/dist/esm/icons/user-icon'; import { EmptyStateIcon } from '../../EmptyStateIcon'; diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateBasic.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateBasic.tsx index 907b6ff9d22..5d9ec5f69aa 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateBasic.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, EmptyState, EmptyStateBody, EmptyStateActions, EmptyStateFooter } from '@patternfly/react-core'; import CubesIcon from '@patternfly/react-icons/dist/esm/icons/cubes-icon'; diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraLarge.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraLarge.tsx index cb09ceb73a6..df77962cc9d 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraLarge.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraLarge.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, EmptyState, diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraSmall.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraSmall.tsx index ee483448546..68394ae4481 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraSmall.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateExtraSmall.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, EmptyState, diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateLarge.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateLarge.tsx index 062f66a9845..a978914053a 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateLarge.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateLarge.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, EmptyState, diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateNoMatchFound.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateNoMatchFound.tsx index ebc08c8d641..3c5e91d6161 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateNoMatchFound.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateNoMatchFound.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, EmptyState, EmptyStateBody, EmptyStateFooter, EmptyStateActions } from '@patternfly/react-core'; import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateSmall.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateSmall.tsx index eae0cc8e481..faa4bce82ba 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateSmall.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateSmall.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Button, EmptyState, diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateSpinner.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateSpinner.tsx index 6acd843b291..c9e0632e839 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateSpinner.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateSpinner.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { EmptyState, Spinner } from '@patternfly/react-core'; export const EmptyStateSpinner: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/EmptyState/examples/EmptyStateWithStatus.tsx b/packages/react-core/src/components/EmptyState/examples/EmptyStateWithStatus.tsx index fe4f1e716ea..81765806961 100644 --- a/packages/react-core/src/components/EmptyState/examples/EmptyStateWithStatus.tsx +++ b/packages/react-core/src/components/EmptyState/examples/EmptyStateWithStatus.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { EmptyState, EmptyStateBody, diff --git a/packages/react-core/src/components/ExpandableSection/ExpandableSection.tsx b/packages/react-core/src/components/ExpandableSection/ExpandableSection.tsx index 330d98d19f9..384c5ca79e5 100644 --- a/packages/react-core/src/components/ExpandableSection/ExpandableSection.tsx +++ b/packages/react-core/src/components/ExpandableSection/ExpandableSection.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Component, createRef } from 'react'; import styles from '@patternfly/react-styles/css/components/ExpandableSection/expandable-section'; import { css } from '@patternfly/react-styles'; import lineClamp from '@patternfly/react-tokens/dist/esm/c_expandable_section_m_truncate__content_LineClamp'; @@ -21,7 +21,7 @@ export interface ExpandableSectionProps extends React.HTMLProps /** Additional classes added to the expandable section. */ className?: string; /** Id of the content of the expandable section. When passing in the isDetached property, this - * property's value should match the contenId property of the expandable section toggle sub-component. + * property's value should match the contentId property of the expandable section toggle sub-component. */ contentId?: string; /** Id of the toggle of the expandable section, which provides an accessible name to the @@ -80,7 +80,7 @@ const setLineClamp = (lines: number, element: HTMLDivElement) => { element.style.setProperty(lineClamp.name, lines.toString()); }; -class ExpandableSection extends React.Component { +class ExpandableSection extends Component { static displayName = 'ExpandableSection'; constructor(props: ExpandableSectionProps) { super(props); @@ -92,7 +92,7 @@ class ExpandableSection extends React.Component(); + expandableContentRef = createRef(); observer: any = () => {}; static defaultProps: PickOptional = { diff --git a/packages/react-core/src/components/ExpandableSection/ExpandableSectionToggle.tsx b/packages/react-core/src/components/ExpandableSection/ExpandableSectionToggle.tsx index 98377bc64ce..d1e4f83d3ab 100644 --- a/packages/react-core/src/components/ExpandableSection/ExpandableSectionToggle.tsx +++ b/packages/react-core/src/components/ExpandableSection/ExpandableSectionToggle.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/ExpandableSection/expandable-section'; import { css } from '@patternfly/react-styles'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; diff --git a/packages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsx b/packages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsx index 2392923267c..833107ee2b5 100644 --- a/packages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsx +++ b/packages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsx @@ -1,5 +1,4 @@ -import * as React from 'react'; - +import { Fragment } from 'react'; import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; @@ -45,14 +44,14 @@ test('Renders Uncontrolled ExpandableSection', () => { test('Detached ExpandableSection renders successfully', () => { const { asFragment } = render( - + test Toggle text - + ); expect(asFragment()).toMatchSnapshot(); }); diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSection.md b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSection.md index 8fefe685bae..65c02320e96 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSection.md +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSection.md @@ -5,6 +5,7 @@ cssPrefix: pf-v6-c-expandable-section propComponents: ['ExpandableSection', 'ExpandableSectionToggle'] --- +import { useState } from 'react'; import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon'; ## Examples diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionBasic.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionBasic.tsx index 60246ffcaca..ff77ba98af2 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionBasic.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ExpandableSection } from '@patternfly/react-core'; export const ExpandableSectionBasic: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsx index f7a74adfdbb..7c6b5f99a83 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ExpandableSection, Badge } from '@patternfly/react-core'; import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon'; diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDetached.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDetached.tsx index bcba03935c2..21d17d0e74a 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDetached.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDetached.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ExpandableSection, ExpandableSectionToggle, Stack, StackItem } from '@patternfly/react-core'; export const ExpandableSectionDetached: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDisclosure.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDisclosure.tsx index 9aca30644eb..2990fe52bf5 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDisclosure.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionDisclosure.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ExpandableSection } from '@patternfly/react-core'; export const ExpandableSectionDisclosure: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionIndented.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionIndented.tsx index e0905d73dcf..f556ae705d9 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionIndented.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionIndented.tsx @@ -1,9 +1,9 @@ -import React, { FormEvent } from 'react'; +import { FormEvent, useState } from 'react'; import { ExpandableSection, Checkbox } from '@patternfly/react-core'; export const ExpandableSectionIndented: React.FunctionComponent = () => { - const [isExpanded, setIsExpanded] = React.useState(true); - const [isDisplayLgChecked, setIsDisplayLgChecked] = React.useState(false); + const [isExpanded, setIsExpanded] = useState(true); + const [isDisplayLgChecked, setIsDisplayLgChecked] = useState(false); const onToggle = (_event: React.MouseEvent, isExpanded: boolean) => { setIsExpanded(isExpanded); diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionTruncateExpansion.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionTruncateExpansion.tsx index eaa4082186a..83de90fb416 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionTruncateExpansion.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionTruncateExpansion.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ExpandableSection, ExpandableSectionVariant } from '@patternfly/react-core'; export const ExpandableSectionTruncateExpansion: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolled.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolled.tsx index 627940fc6d6..d8ecba22f0f 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolled.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolled.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ExpandableSection } from '@patternfly/react-core'; export const ExpandableSectionUncontrolled: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolledDynamicToggleText.tsx b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolledDynamicToggleText.tsx index 0883285a878..e4d9a624f72 100644 --- a/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolledDynamicToggleText.tsx +++ b/packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionUncontrolledDynamicToggleText.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { ExpandableSection } from '@patternfly/react-core'; export const ExpandableSectionUncontrolledDynamicToggle: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/FileUpload/FileUpload.tsx b/packages/react-core/src/components/FileUpload/FileUpload.tsx index 08d48c50a80..d7e7cc09043 100644 --- a/packages/react-core/src/components/FileUpload/FileUpload.tsx +++ b/packages/react-core/src/components/FileUpload/FileUpload.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { DropzoneInputProps, DropzoneOptions, FileRejection, useDropzone, ErrorCode } from 'react-dropzone'; import { FileUploadField, FileUploadFieldProps } from './FileUploadField'; import { readFile, fileReaderType } from '../../helpers/fileUtils'; diff --git a/packages/react-core/src/components/FileUpload/FileUploadField.tsx b/packages/react-core/src/components/FileUpload/FileUploadField.tsx index 1d093a4e9d9..edbfc5d2cad 100644 --- a/packages/react-core/src/components/FileUpload/FileUploadField.tsx +++ b/packages/react-core/src/components/FileUpload/FileUploadField.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/FileUpload/file-upload'; import { css } from '@patternfly/react-styles'; import { InputGroup, InputGroupItem } from '../InputGroup'; diff --git a/packages/react-core/src/components/FileUpload/FileUploadHelperText.tsx b/packages/react-core/src/components/FileUpload/FileUploadHelperText.tsx index 9a045fb1071..7b12e3be4dd 100644 --- a/packages/react-core/src/components/FileUpload/FileUploadHelperText.tsx +++ b/packages/react-core/src/components/FileUpload/FileUploadHelperText.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/FileUpload/file-upload'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/FileUpload/__tests__/FileUpload.test.tsx b/packages/react-core/src/components/FileUpload/__tests__/FileUpload.test.tsx index 369ab6c089b..fe7bd06d254 100644 --- a/packages/react-core/src/components/FileUpload/__tests__/FileUpload.test.tsx +++ b/packages/react-core/src/components/FileUpload/__tests__/FileUpload.test.tsx @@ -1,5 +1,4 @@ import { FileUpload } from '../FileUpload'; -import * as React from 'react'; import { render } from '@testing-library/react'; test('simple fileupload', () => { diff --git a/packages/react-core/src/components/FileUpload/__tests__/FileUploadField.test.tsx b/packages/react-core/src/components/FileUpload/__tests__/FileUploadField.test.tsx index 30cc28db40e..f073b8498c7 100644 --- a/packages/react-core/src/components/FileUpload/__tests__/FileUploadField.test.tsx +++ b/packages/react-core/src/components/FileUpload/__tests__/FileUploadField.test.tsx @@ -1,5 +1,4 @@ import { FileUploadField } from '../FileUploadField'; -import * as React from 'react'; import { render, screen } from '@testing-library/react'; import '@testing-library/jest-dom'; diff --git a/packages/react-core/src/components/FileUpload/__tests__/FileUploadHelperText.test.tsx b/packages/react-core/src/components/FileUpload/__tests__/FileUploadHelperText.test.tsx index 566d62bff07..8f269d6832b 100644 --- a/packages/react-core/src/components/FileUpload/__tests__/FileUploadHelperText.test.tsx +++ b/packages/react-core/src/components/FileUpload/__tests__/FileUploadHelperText.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { FileUploadHelperText } from '../FileUploadHelperText'; import { render, screen } from '@testing-library/react'; import styles from '@patternfly/react-styles/css/components/FileUpload/file-upload'; diff --git a/packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx b/packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx index 845ee9df96d..c0aa86c7e67 100644 --- a/packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx +++ b/packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FileUpload } from '@patternfly/react-core'; import FileUploadIcon from '@patternfly/react-icons/dist/esm/icons/file-upload-icon'; diff --git a/packages/react-core/src/components/FileUpload/examples/FileUploadCustomUpload.tsx b/packages/react-core/src/components/FileUpload/examples/FileUploadCustomUpload.tsx index a8366fae76e..27e4d3bffe8 100644 --- a/packages/react-core/src/components/FileUpload/examples/FileUploadCustomUpload.tsx +++ b/packages/react-core/src/components/FileUpload/examples/FileUploadCustomUpload.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FileUploadField, FileUploadHelperText, HelperText, HelperTextItem, Checkbox } from '@patternfly/react-core'; export const CustomPreviewFileUpload: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleFile.tsx b/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleFile.tsx index f6388a51034..d8d5fae2610 100644 --- a/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleFile.tsx +++ b/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleFile.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FileUpload } from '@patternfly/react-core'; export const SimpleFileUpload: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleText.tsx b/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleText.tsx index 5d9f57ad030..876d6f773ee 100644 --- a/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleText.tsx +++ b/packages/react-core/src/components/FileUpload/examples/FileUploadSimpleText.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FileUpload, DropEvent } from '@patternfly/react-core'; export const SimpleTextFileUpload: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithEdits.tsx b/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithEdits.tsx index 8abbea53552..18e3a368019 100644 --- a/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithEdits.tsx +++ b/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithEdits.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FileUpload, DropEvent } from '@patternfly/react-core'; export const TextFileWithEditsAllowed: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithRestrictions.tsx b/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithRestrictions.tsx index c32904f687f..d0284856406 100644 --- a/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithRestrictions.tsx +++ b/packages/react-core/src/components/FileUpload/examples/FileUploadTextWithRestrictions.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FileUpload, DropzoneErrorCode, diff --git a/packages/react-core/src/components/FileUpload/examples/FileUploadWithHelperText.tsx b/packages/react-core/src/components/FileUpload/examples/FileUploadWithHelperText.tsx index 9757bc0b7b8..ddeb124b14e 100644 --- a/packages/react-core/src/components/FileUpload/examples/FileUploadWithHelperText.tsx +++ b/packages/react-core/src/components/FileUpload/examples/FileUploadWithHelperText.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FileUpload, FileUploadHelperText, HelperText, HelperTextItem, DropEvent } from '@patternfly/react-core'; export const FileUploadWithHelperText: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Form/ActionGroup.tsx b/packages/react-core/src/components/Form/ActionGroup.tsx index acf4d479840..f01e78a3074 100644 --- a/packages/react-core/src/components/Form/ActionGroup.tsx +++ b/packages/react-core/src/components/Form/ActionGroup.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Form/form'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Form/Form.tsx b/packages/react-core/src/components/Form/Form.tsx index 0d28c8ca495..eae7a974c0f 100644 --- a/packages/react-core/src/components/Form/Form.tsx +++ b/packages/react-core/src/components/Form/Form.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { forwardRef } from 'react'; import styles from '@patternfly/react-styles/css/components/Form/form'; import { css } from '@patternfly/react-styles'; import cssMaxWidth from '@patternfly/react-tokens/dist/esm/c_form_m_limit_width_MaxWidth'; @@ -48,6 +48,6 @@ const FormBase: React.FunctionComponent = ({ ); -export const Form = React.forwardRef((props: FormProps, ref: React.Ref) => ); +export const Form = forwardRef((props: FormProps, ref: React.Ref) => ); Form.displayName = 'Form'; diff --git a/packages/react-core/src/components/Form/FormAlert.tsx b/packages/react-core/src/components/Form/FormAlert.tsx index 89cffcf234c..9b9f8dae409 100644 --- a/packages/react-core/src/components/Form/FormAlert.tsx +++ b/packages/react-core/src/components/Form/FormAlert.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Form/form'; diff --git a/packages/react-core/src/components/Form/FormContext.tsx b/packages/react-core/src/components/Form/FormContext.tsx index 0e82fa14a96..5b1df6a4914 100644 --- a/packages/react-core/src/components/Form/FormContext.tsx +++ b/packages/react-core/src/components/Form/FormContext.tsx @@ -1,4 +1,4 @@ -import React, { Dispatch, SetStateAction } from 'react'; +import { createContext, Dispatch, SetStateAction, useContext, useState } from 'react'; export interface FormContextProps { /** Record of values for all fieldIds */ @@ -35,7 +35,7 @@ export interface FormContextProps { setValidator(fieldId: string, validate: (value: string) => string | null): void; } -const FormContext = React.createContext({} as FormContextProps); +const FormContext = createContext({} as FormContextProps); export const FormContextConsumer = FormContext.Consumer; @@ -47,10 +47,10 @@ export interface FormContextProviderProps { } export const FormContextProvider: React.FC = ({ initialValues, children }) => { - const [values, setValues] = React.useState>(initialValues || {}); - const [errors, setErrors] = React.useState>({}); - const [validators, setValidators] = React.useState>({}); - const [touched, setTouched] = React.useState>({}); + const [values, setValues] = useState>(initialValues || {}); + const [errors, setErrors] = useState>({}); + const [validators, setValidators] = useState>({}); + const [touched, setTouched] = useState>({}); const isValid = Object.keys(errors)?.length === 0; const getValue = (fieldId: string) => @@ -127,4 +127,4 @@ export const FormContextProvider: React.FC = ({ initia }; FormContextProvider.displayName = 'FormContextProvider'; -export const useFormContext = () => React.useContext(FormContext); +export const useFormContext = () => useContext(FormContext); diff --git a/packages/react-core/src/components/Form/FormFieldGroup.tsx b/packages/react-core/src/components/Form/FormFieldGroup.tsx index aeaef921c06..c42ac40baf9 100644 --- a/packages/react-core/src/components/Form/FormFieldGroup.tsx +++ b/packages/react-core/src/components/Form/FormFieldGroup.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { InternalFormFieldGroup } from './InternalFormFieldGroup'; export interface FormFieldGroupProps extends Omit, 'label'> { diff --git a/packages/react-core/src/components/Form/FormFieldGroupExpandable.tsx b/packages/react-core/src/components/Form/FormFieldGroupExpandable.tsx index 995e1d06e87..cd52fc31ff1 100644 --- a/packages/react-core/src/components/Form/FormFieldGroupExpandable.tsx +++ b/packages/react-core/src/components/Form/FormFieldGroupExpandable.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { useState } from 'react'; import { InternalFormFieldGroup } from './InternalFormFieldGroup'; diff --git a/packages/react-core/src/components/Form/FormFieldGroupHeader.tsx b/packages/react-core/src/components/Form/FormFieldGroupHeader.tsx index 637e485ab46..594371056ca 100644 --- a/packages/react-core/src/components/Form/FormFieldGroupHeader.tsx +++ b/packages/react-core/src/components/Form/FormFieldGroupHeader.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Form/form'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Form/FormFieldGroupToggle.tsx b/packages/react-core/src/components/Form/FormFieldGroupToggle.tsx index 8c3ce28ab18..f659108d90c 100644 --- a/packages/react-core/src/components/Form/FormFieldGroupToggle.tsx +++ b/packages/react-core/src/components/Form/FormFieldGroupToggle.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Form/form'; import { css } from '@patternfly/react-styles'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; diff --git a/packages/react-core/src/components/Form/FormGroup.tsx b/packages/react-core/src/components/Form/FormGroup.tsx index 7e2394932ac..8c308779da0 100644 --- a/packages/react-core/src/components/Form/FormGroup.tsx +++ b/packages/react-core/src/components/Form/FormGroup.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Fragment, isValidElement } from 'react'; import styles from '@patternfly/react-styles/css/components/Form/form'; import { ASTERISK } from '../../helpers/htmlConstants'; import { css } from '@patternfly/react-styles'; @@ -62,7 +62,7 @@ export const FormGroup: React.FunctionComponent = ({ )} <>   - {React.isValidElement(labelHelp) && {labelHelp}} + {isValidElement(labelHelp) && {labelHelp}} ); @@ -85,10 +85,10 @@ export const FormGroup: React.FunctionComponent = ({ {...(isGroupOrRadioGroup && { id: `${fieldId || randomId}-legend` })} > {labelInfo && ( - +
    {labelContent}
    {labelInfo}
    -
    + )} {!labelInfo && labelContent}
  • diff --git a/packages/react-core/src/components/Form/FormGroupLabelHelp.tsx b/packages/react-core/src/components/Form/FormGroupLabelHelp.tsx index f8bba50758c..0f14870d671 100644 --- a/packages/react-core/src/components/Form/FormGroupLabelHelp.tsx +++ b/packages/react-core/src/components/Form/FormGroupLabelHelp.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { forwardRef, useRef } from 'react'; import { Button, ButtonProps } from '../Button'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import { KeyTypes } from '../../helpers/constants'; @@ -21,7 +21,7 @@ const FormGroupLabelHelpBase: React.FunctionComponent = innerRef, ...props }) => { - const ref = React.useRef(null); + const ref = useRef(null); const buttonRef = innerRef || ref; const isMutableRef = (ref: React.Ref): ref is React.MutableRefObject => @@ -50,7 +50,7 @@ const FormGroupLabelHelpBase: React.FunctionComponent = ); }; -export const FormGroupLabelHelp = React.forwardRef((props: FormGroupLabelHelpProps, ref: React.Ref) => ( +export const FormGroupLabelHelp = forwardRef((props: FormGroupLabelHelpProps, ref: React.Ref) => ( )); diff --git a/packages/react-core/src/components/Form/FormHelperText.tsx b/packages/react-core/src/components/Form/FormHelperText.tsx index 2807886eac9..31933732fe5 100644 --- a/packages/react-core/src/components/Form/FormHelperText.tsx +++ b/packages/react-core/src/components/Form/FormHelperText.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Form/form'; diff --git a/packages/react-core/src/components/Form/FormSection.tsx b/packages/react-core/src/components/Form/FormSection.tsx index ac2fe359a65..e0d9cc5e647 100644 --- a/packages/react-core/src/components/Form/FormSection.tsx +++ b/packages/react-core/src/components/Form/FormSection.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Form/form'; import { css } from '@patternfly/react-styles'; import { GenerateId } from '../../helpers/GenerateId/GenerateId'; diff --git a/packages/react-core/src/components/Form/InternalFormFieldGroup.tsx b/packages/react-core/src/components/Form/InternalFormFieldGroup.tsx index 36a412f93ea..6daaec42fc3 100644 --- a/packages/react-core/src/components/Form/InternalFormFieldGroup.tsx +++ b/packages/react-core/src/components/Form/InternalFormFieldGroup.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Form/form'; import { css } from '@patternfly/react-styles'; import { FormFieldGroupToggle } from './FormFieldGroupToggle'; diff --git a/packages/react-core/src/components/Form/__tests__/ActionGroup.test.tsx b/packages/react-core/src/components/Form/__tests__/ActionGroup.test.tsx index fa24a2fb0b8..ed595ce2017 100644 --- a/packages/react-core/src/components/Form/__tests__/ActionGroup.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/ActionGroup.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render } from '@testing-library/react'; import { ActionGroup } from '../ActionGroup'; import { Form } from '../Form'; diff --git a/packages/react-core/src/components/Form/__tests__/Form.test.tsx b/packages/react-core/src/components/Form/__tests__/Form.test.tsx index 34188e8eb98..9caf53ff004 100644 --- a/packages/react-core/src/components/Form/__tests__/Form.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/Form.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render } from '@testing-library/react'; import { Form } from '../Form'; diff --git a/packages/react-core/src/components/Form/__tests__/FormAlert.test.tsx b/packages/react-core/src/components/Form/__tests__/FormAlert.test.tsx index df0e75d2b57..86c3a418983 100644 --- a/packages/react-core/src/components/Form/__tests__/FormAlert.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/FormAlert.test.tsx @@ -1,7 +1,5 @@ import { render } from '@testing-library/react'; import { FormAlert } from '../FormAlert'; -import React from 'react'; - describe('Form Alert component', () => { test('should render form group required variant', () => { const { asFragment } = render(); diff --git a/packages/react-core/src/components/Form/__tests__/FormContext.test.tsx b/packages/react-core/src/components/Form/__tests__/FormContext.test.tsx index 647c9320466..bcf099f6488 100644 --- a/packages/react-core/src/components/Form/__tests__/FormContext.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/FormContext.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { FormContextConsumer, FormContextProvider } from '../FormContext'; diff --git a/packages/react-core/src/components/Form/__tests__/FormFieldGroup.test.tsx b/packages/react-core/src/components/Form/__tests__/FormFieldGroup.test.tsx index 3ddf4674ad7..b7b09c64141 100644 --- a/packages/react-core/src/components/Form/__tests__/FormFieldGroup.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/FormFieldGroup.test.tsx @@ -1,5 +1,3 @@ -import * as React from 'react'; - import { render, screen } from '@testing-library/react'; import { FormFieldGroup } from '../FormFieldGroup'; diff --git a/packages/react-core/src/components/Form/__tests__/FormGroup.test.tsx b/packages/react-core/src/components/Form/__tests__/FormGroup.test.tsx index 5c3a4153340..bd5d1ce56b2 100644 --- a/packages/react-core/src/components/Form/__tests__/FormGroup.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/FormGroup.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; @@ -54,7 +52,7 @@ describe('FormGroup', () => { expect(asFragment()).toMatchSnapshot(); }); - test('should render form group with additonal label info', () => { + test('should render form group with additional label info', () => { const { asFragment } = render( Header} labelInfo="more info"> diff --git a/packages/react-core/src/components/Form/__tests__/FormHelperText.test.tsx b/packages/react-core/src/components/Form/__tests__/FormHelperText.test.tsx index 1f8c1c547de..80bed220b45 100644 --- a/packages/react-core/src/components/Form/__tests__/FormHelperText.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/FormHelperText.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { FormHelperText } from '../FormHelperText'; diff --git a/packages/react-core/src/components/Form/__tests__/FormSection.test.tsx b/packages/react-core/src/components/Form/__tests__/FormSection.test.tsx index f56813e27fd..353cfc6fe20 100644 --- a/packages/react-core/src/components/Form/__tests__/FormSection.test.tsx +++ b/packages/react-core/src/components/Form/__tests__/FormSection.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { FormSection } from '../FormSection'; import { render, screen } from '@testing-library/react'; diff --git a/packages/react-core/src/components/Form/__tests__/__snapshots__/FormGroup.test.tsx.snap b/packages/react-core/src/components/Form/__tests__/__snapshots__/FormGroup.test.tsx.snap index d928dd27011..35f5452a5a7 100644 --- a/packages/react-core/src/components/Form/__tests__/__snapshots__/FormGroup.test.tsx.snap +++ b/packages/react-core/src/components/Form/__tests__/__snapshots__/FormGroup.test.tsx.snap @@ -154,7 +154,7 @@ exports[`FormGroup should render form group variant without label 1`] = ` `; -exports[`FormGroup should render form group with additonal label info 1`] = ` +exports[`FormGroup should render form group with additional label info 1`] = `
    { - const [name, setName] = React.useState(''); - const [email, setEmail] = React.useState(''); - const [phone, setPhone] = React.useState(''); - const labelHelpRef = React.useRef(null); + const [name, setName] = useState(''); + const [email, setEmail] = useState(''); + const [phone, setPhone] = useState(''); + const labelHelpRef = useRef(null); const handleNameChange = (_event, name: string) => { setName(name); diff --git a/packages/react-core/src/components/Form/examples/FormFieldGroups.tsx b/packages/react-core/src/components/Form/examples/FormFieldGroups.tsx index 5a860605e9b..b216b76e340 100644 --- a/packages/react-core/src/components/Form/examples/FormFieldGroups.tsx +++ b/packages/react-core/src/components/Form/examples/FormFieldGroups.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { Form, FormGroup, @@ -36,7 +36,7 @@ export const FormFieldGroups: React.FunctionComponent = () => { '0-label4': '' }; - const [inputValues, setInputValues] = React.useState(initialValues); + const [inputValues, setInputValues] = useState(initialValues); const handleChange = (event, value: string) => { const { name } = event.currentTarget; diff --git a/packages/react-core/src/components/Form/examples/FormGrid.tsx b/packages/react-core/src/components/Form/examples/FormGrid.tsx index fd937405890..85ac0181409 100644 --- a/packages/react-core/src/components/Form/examples/FormGrid.tsx +++ b/packages/react-core/src/components/Form/examples/FormGrid.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { Form, FormGroup, @@ -11,9 +11,9 @@ import { } from '@patternfly/react-core'; export const FormGrid: React.FunctionComponent = () => { - const [name, setName] = React.useState(''); - const [email, setEmail] = React.useState(''); - const [phone, setPhone] = React.useState(''); + const [name, setName] = useState(''); + const [email, setEmail] = useState(''); + const [phone, setPhone] = useState(''); const handleNameChange = (_event, name: string) => { setName(name); diff --git a/packages/react-core/src/components/Form/examples/FormGroupLabelInfo.tsx b/packages/react-core/src/components/Form/examples/FormGroupLabelInfo.tsx index 9491659d507..4ea8f1bf4b5 100644 --- a/packages/react-core/src/components/Form/examples/FormGroupLabelInfo.tsx +++ b/packages/react-core/src/components/Form/examples/FormGroupLabelInfo.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useRef, useState } from 'react'; import { Form, FormGroup, @@ -11,8 +11,8 @@ import { } from '@patternfly/react-core'; export const FormGroupLabelInfo: React.FunctionComponent = () => { - const [name, setName] = React.useState(''); - const labelHelpRef = React.useRef(null); + const [name, setName] = useState(''); + const labelHelpRef = useRef(null); const handleNameChange = (_event, name: string) => { setName(name); diff --git a/packages/react-core/src/components/Form/examples/FormHorizontal.tsx b/packages/react-core/src/components/Form/examples/FormHorizontal.tsx index 6ef67f48119..aaf4b02b43f 100644 --- a/packages/react-core/src/components/Form/examples/FormHorizontal.tsx +++ b/packages/react-core/src/components/Form/examples/FormHorizontal.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { Form, FormGroup, @@ -16,10 +16,10 @@ import { } from '@patternfly/react-core'; export const FormHorizontal: React.FunctionComponent = () => { - const [name, setName] = React.useState(''); - const [email, setEmail] = React.useState(''); - const [experience, setExperience] = React.useState(''); - const [option, setOption] = React.useState('please choose'); + const [name, setName] = useState(''); + const [email, setEmail] = useState(''); + const [experience, setExperience] = useState(''); + const [option, setOption] = useState('please choose'); const handleNameChange = (_event, name: string) => { setName(name); diff --git a/packages/react-core/src/components/Form/examples/FormHorizontalHelper.tsx b/packages/react-core/src/components/Form/examples/FormHorizontalHelper.tsx index 1561865e59d..e06dece189d 100644 --- a/packages/react-core/src/components/Form/examples/FormHorizontalHelper.tsx +++ b/packages/react-core/src/components/Form/examples/FormHorizontalHelper.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Form, FormGroup, Checkbox, HelperText, HelperTextItem, FormHelperText } from '@patternfly/react-core'; export const FormHorizontalFormHelperText: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Form/examples/FormHorizontalStacked.tsx b/packages/react-core/src/components/Form/examples/FormHorizontalStacked.tsx index a9b5549b8d5..115d240c975 100644 --- a/packages/react-core/src/components/Form/examples/FormHorizontalStacked.tsx +++ b/packages/react-core/src/components/Form/examples/FormHorizontalStacked.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Form, FormGroup, Checkbox } from '@patternfly/react-core'; export const FormHorizontalStacked: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/Form/examples/FormInvalid.tsx b/packages/react-core/src/components/Form/examples/FormInvalid.tsx index 23bbab072d7..a7475ccf8e3 100644 --- a/packages/react-core/src/components/Form/examples/FormInvalid.tsx +++ b/packages/react-core/src/components/Form/examples/FormInvalid.tsx @@ -1,12 +1,12 @@ -import React from 'react'; +import { useState } from 'react'; import { Form, FormGroup, TextInput, HelperText, HelperTextItem, FormHelperText } from '@patternfly/react-core'; import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon'; export const FormInvalid: React.FunctionComponent = () => { type validate = 'success' | 'warning' | 'error' | 'default'; - const [age, setAge] = React.useState('Five'); - const [validated, setValidated] = React.useState('error'); + const [age, setAge] = useState('Five'); + const [validated, setValidated] = useState('error'); const handleAgeChange = (_event, age: string) => { setAge(age); diff --git a/packages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsx b/packages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsx index aba3441b39e..9ec2a9f4419 100644 --- a/packages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsx +++ b/packages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { Alert, Form, @@ -14,8 +14,8 @@ import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclam export const FormInvalidWithAlert: React.FunctionComponent = () => { type validate = 'success' | 'warning' | 'error' | 'default'; - const [age, setAge] = React.useState('Five'); - const [validated, setValidated] = React.useState('error'); + const [age, setAge] = useState('Five'); + const [validated, setValidated] = useState('error'); const handleAgeChange = (_event, age: string) => { setAge(age); diff --git a/packages/react-core/src/components/Form/examples/FormLimitWidth.tsx b/packages/react-core/src/components/Form/examples/FormLimitWidth.tsx index 11b10786dcc..ac3cfe2faf2 100644 --- a/packages/react-core/src/components/Form/examples/FormLimitWidth.tsx +++ b/packages/react-core/src/components/Form/examples/FormLimitWidth.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useRef, useState } from 'react'; import { Form, FormGroup, @@ -15,10 +15,10 @@ import { } from '@patternfly/react-core'; export const FormLimitWidth: React.FunctionComponent = () => { - const [name, setName] = React.useState(''); - const [email, setEmail] = React.useState(''); - const [phone, setPhone] = React.useState(''); - const labelHelpRef = React.useRef(null); + const [name, setName] = useState(''); + const [email, setEmail] = useState(''); + const [phone, setPhone] = useState(''); + const labelHelpRef = useRef(null); const handleNameChange = (_event, name: string) => { setName(name); diff --git a/packages/react-core/src/components/Form/examples/FormSections.tsx b/packages/react-core/src/components/Form/examples/FormSections.tsx index b6c195f121d..a3dd6877157 100644 --- a/packages/react-core/src/components/Form/examples/FormSections.tsx +++ b/packages/react-core/src/components/Form/examples/FormSections.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { useState } from 'react'; import { Form, FormGroup, FormSection, TextInput } from '@patternfly/react-core'; export const FormSections: React.FunctionComponent = () => { - const [input1, setInput1] = React.useState(''); - const [input2, setInput2] = React.useState(''); + const [input1, setInput1] = useState(''); + const [input2, setInput2] = useState(''); const handleInputChange1 = (_event, input1: string) => { setInput1(input1); diff --git a/packages/react-core/src/components/Form/examples/FormState.tsx b/packages/react-core/src/components/Form/examples/FormState.tsx index b3cbd9f53e5..efbf6de8288 100644 --- a/packages/react-core/src/components/Form/examples/FormState.tsx +++ b/packages/react-core/src/components/Form/examples/FormState.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { useState } from 'react'; import { ActionGroup, Button, @@ -21,8 +21,8 @@ import { import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon'; export const FormState = () => { - const [isSelectOpen, setIsSelectOpen] = React.useState(false); - const [formStateExpanded, setFormStateExpanded] = React.useState(false); + const [isSelectOpen, setIsSelectOpen] = useState(false); + const [formStateExpanded, setFormStateExpanded] = useState(false); return ( diff --git a/packages/react-core/src/components/Form/examples/FormValidated.tsx b/packages/react-core/src/components/Form/examples/FormValidated.tsx index 19991464371..7725f415870 100644 --- a/packages/react-core/src/components/Form/examples/FormValidated.tsx +++ b/packages/react-core/src/components/Form/examples/FormValidated.tsx @@ -1,13 +1,13 @@ -import React from 'react'; +import { useEffect, useState } from 'react'; import { Form, FormGroup, FormHelperText, HelperText, HelperTextItem, TextInput } from '@patternfly/react-core'; import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon'; export const FormValidated: React.FunctionComponent = () => { type validate = 'success' | 'warning' | 'error' | 'default'; - const [age, setAge] = React.useState('Five'); - const [validated, setValidated] = React.useState('default'); - const [helperText, setHelperText] = React.useState('Enter your age to continue'); + const [age, setAge] = useState('Five'); + const [validated, setValidated] = useState('default'); + const [helperText, setHelperText] = useState('Enter your age to continue'); const handleAgeChange = (_event, age: string) => { setAge(age); @@ -16,7 +16,7 @@ export const FormValidated: React.FunctionComponent = () => { }; // useEffect is used to simulate a server call to validate the age 2000ms after the user has entered a value, preventing calling the server on every keystroke - React.useEffect(() => { + useEffect(() => { const timer = setTimeout(() => { if (/^\d+$/.test(age)) { if (parseInt(age) >= 21) { diff --git a/packages/react-core/src/components/FormControl/FormControlIcon.tsx b/packages/react-core/src/components/FormControl/FormControlIcon.tsx index 5275ab01d53..424baec7ce3 100644 --- a/packages/react-core/src/components/FormControl/FormControlIcon.tsx +++ b/packages/react-core/src/components/FormControl/FormControlIcon.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/FormControl/form-control'; import { css } from '@patternfly/react-styles'; import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon'; diff --git a/packages/react-core/src/components/FormSelect/FormSelect.tsx b/packages/react-core/src/components/FormSelect/FormSelect.tsx index 82f33c6f1b0..7e008b84530 100644 --- a/packages/react-core/src/components/FormSelect/FormSelect.tsx +++ b/packages/react-core/src/components/FormSelect/FormSelect.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { Children, Component } from 'react'; import styles from '@patternfly/react-styles/css/components/FormControl/form-control'; import { css } from '@patternfly/react-styles'; import { PickOptional } from '../../helpers/typeUtils'; @@ -39,7 +39,7 @@ export interface FormSelectProps ouiaSafe?: boolean; } -class FormSelect extends React.Component { +class FormSelect extends Component { static displayName = 'FormSelect'; constructor(props: FormSelectProps) { super(props); @@ -71,7 +71,7 @@ class FormSelect extends React.Component option.props.value === value) as any; + const selectedOption = Children.toArray(children).find((option: any) => option.props.value === value) as any; const isSelectedPlaceholder = selectedOption && selectedOption.props.isPlaceholder; const hasStatusIcon = ['success', 'error', 'warning'].includes(validated); diff --git a/packages/react-core/src/components/FormSelect/FormSelectOption.tsx b/packages/react-core/src/components/FormSelect/FormSelectOption.tsx index 4b015629da9..a0d304b1c57 100644 --- a/packages/react-core/src/components/FormSelect/FormSelectOption.tsx +++ b/packages/react-core/src/components/FormSelect/FormSelectOption.tsx @@ -1,5 +1,3 @@ -import * as React from 'react'; - export interface FormSelectOptionProps extends Omit, 'disabled'> { /** additional classes added to the Select Option */ className?: string; diff --git a/packages/react-core/src/components/FormSelect/FormSelectOptionGroup.tsx b/packages/react-core/src/components/FormSelect/FormSelectOptionGroup.tsx index c12ae0c1b3f..afe92ccce80 100644 --- a/packages/react-core/src/components/FormSelect/FormSelectOptionGroup.tsx +++ b/packages/react-core/src/components/FormSelect/FormSelectOptionGroup.tsx @@ -1,5 +1,3 @@ -import * as React from 'react'; - export interface FormSelectOptionGroupProps extends Omit, 'disabled'> { /** content rendered inside the Select Option Group */ children?: React.ReactNode; diff --git a/packages/react-core/src/components/FormSelect/__tests__/FormSelect.test.tsx b/packages/react-core/src/components/FormSelect/__tests__/FormSelect.test.tsx index fec53d588fc..347a086492c 100644 --- a/packages/react-core/src/components/FormSelect/__tests__/FormSelect.test.tsx +++ b/packages/react-core/src/components/FormSelect/__tests__/FormSelect.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; diff --git a/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOption.test.tsx b/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOption.test.tsx index 8592d0a9dfc..ddc9db33843 100644 --- a/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOption.test.tsx +++ b/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOption.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { FormSelectOption } from '../../FormSelectOption'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOptionGroup.test.tsx b/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOptionGroup.test.tsx index fcb1a57b6f7..afa3cefaceb 100644 --- a/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOptionGroup.test.tsx +++ b/packages/react-core/src/components/FormSelect/__tests__/Generated/FormSelectOptionGroup.test.tsx @@ -1,7 +1,6 @@ /** * This test was generated */ -import * as React from 'react'; import { render } from '@testing-library/react'; import { FormSelectOptionGroup } from '../../FormSelectOptionGroup'; // any missing imports can usually be resolved by adding them here diff --git a/packages/react-core/src/components/FormSelect/examples/FormSelectBasic.tsx b/packages/react-core/src/components/FormSelect/examples/FormSelectBasic.tsx index 0f63f953c0d..cf70afb039d 100644 --- a/packages/react-core/src/components/FormSelect/examples/FormSelectBasic.tsx +++ b/packages/react-core/src/components/FormSelect/examples/FormSelectBasic.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FormSelect, FormSelectOption } from '@patternfly/react-core'; export const FormSelectBasic: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/FormSelect/examples/FormSelectDisabled.tsx b/packages/react-core/src/components/FormSelect/examples/FormSelectDisabled.tsx index 913d5640d29..257a8e8cd4a 100644 --- a/packages/react-core/src/components/FormSelect/examples/FormSelectDisabled.tsx +++ b/packages/react-core/src/components/FormSelect/examples/FormSelectDisabled.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FormSelect, FormSelectOption } from '@patternfly/react-core'; export const FormSelectDisabled: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/FormSelect/examples/FormSelectGrouped.tsx b/packages/react-core/src/components/FormSelect/examples/FormSelectGrouped.tsx index 238ce1836e8..9aafd8a6c5c 100644 --- a/packages/react-core/src/components/FormSelect/examples/FormSelectGrouped.tsx +++ b/packages/react-core/src/components/FormSelect/examples/FormSelectGrouped.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { FormSelect, FormSelectOption, FormSelectOptionGroup } from '@patternfly/react-core'; export const FormSelectGrouped: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/FormSelect/examples/FormSelectValidated.tsx b/packages/react-core/src/components/FormSelect/examples/FormSelectValidated.tsx index 548444aa126..0ccd5624d33 100644 --- a/packages/react-core/src/components/FormSelect/examples/FormSelectValidated.tsx +++ b/packages/react-core/src/components/FormSelect/examples/FormSelectValidated.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Form, FormGroup, diff --git a/packages/react-core/src/components/HelperText/HelperText.tsx b/packages/react-core/src/components/HelperText/HelperText.tsx index 4ba22cdc46f..31276b61968 100644 --- a/packages/react-core/src/components/HelperText/HelperText.tsx +++ b/packages/react-core/src/components/HelperText/HelperText.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/HelperText/helper-text'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/HelperText/HelperTextItem.tsx b/packages/react-core/src/components/HelperText/HelperTextItem.tsx index 328390ca4b3..5595c0dd3b6 100644 --- a/packages/react-core/src/components/HelperText/HelperTextItem.tsx +++ b/packages/react-core/src/components/HelperText/HelperTextItem.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/HelperText/helper-text'; import { css } from '@patternfly/react-styles'; import MinusIcon from '@patternfly/react-icons/dist/esm/icons/minus-icon'; diff --git a/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx b/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx index 354ec0a4206..ce769fdae96 100644 --- a/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx +++ b/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render, screen } from '@testing-library/react'; import { HelperText } from '../HelperText'; diff --git a/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx b/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx index 8bf3a0d7cfe..0213ffbbd9f 100644 --- a/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx +++ b/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render, screen } from '@testing-library/react'; import { HelperTextItem } from '../HelperTextItem'; diff --git a/packages/react-core/src/components/HelperText/examples/HelperText.md b/packages/react-core/src/components/HelperText/examples/HelperText.md index e96cad7b859..d7fb3bb2f1c 100644 --- a/packages/react-core/src/components/HelperText/examples/HelperText.md +++ b/packages/react-core/src/components/HelperText/examples/HelperText.md @@ -5,6 +5,7 @@ cssPrefix: pf-v6-c-helper-text propComponents: ['HelperText', 'HelperTextItem'] --- +import { Fragment } from 'react'; import InfoIcon from '@patternfly/react-icons/dist/esm/icons/info-icon'; import QuestionIcon from '@patternfly/react-icons/dist/esm/icons/question-icon'; import CheckIcon from '@patternfly/react-icons/dist/esm/icons/check-icon'; diff --git a/packages/react-core/src/components/HelperText/examples/HelperTextBasic.tsx b/packages/react-core/src/components/HelperText/examples/HelperTextBasic.tsx index 0ef67cced25..fbb168c8de2 100644 --- a/packages/react-core/src/components/HelperText/examples/HelperTextBasic.tsx +++ b/packages/react-core/src/components/HelperText/examples/HelperTextBasic.tsx @@ -1,8 +1,8 @@ -import React from 'react'; +import { Fragment } from 'react'; import { HelperText, HelperTextItem } from '@patternfly/react-core'; export const HelperTextBasic: React.FunctionComponent = () => ( - + This is default helper text @@ -18,5 +18,5 @@ export const HelperTextBasic: React.FunctionComponent = () => ( This is error helper text - + ); diff --git a/packages/react-core/src/components/HelperText/examples/HelperTextMultipleItems.tsx b/packages/react-core/src/components/HelperText/examples/HelperTextMultipleItems.tsx index b8fc8b2afc8..0512e8c4e3f 100644 --- a/packages/react-core/src/components/HelperText/examples/HelperTextMultipleItems.tsx +++ b/packages/react-core/src/components/HelperText/examples/HelperTextMultipleItems.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { HelperText, HelperTextItem } from '@patternfly/react-core'; export const HelperTextMultipleItems: React.FunctionComponent = () => ( diff --git a/packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx b/packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx index 162f573a655..04dbb3c0a67 100644 --- a/packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx +++ b/packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { HelperText, HelperTextItem } from '@patternfly/react-core'; import InfoIcon from '@patternfly/react-icons/dist/esm/icons/info-icon'; import QuestionIcon from '@patternfly/react-icons/dist/esm/icons/question-icon'; @@ -7,7 +7,7 @@ import CheckIcon from '@patternfly/react-icons/dist/esm/icons/check-icon'; import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon'; export const HelperTextWithCustomIcon: React.FunctionComponent = () => ( - + }>This is default helper text @@ -31,5 +31,5 @@ export const HelperTextWithCustomIcon: React.FunctionComponent = () => ( This is error helper text - + ); diff --git a/packages/react-core/src/components/Hint/Hint.tsx b/packages/react-core/src/components/Hint/Hint.tsx index 9a665a63bf0..5547c609a0f 100644 --- a/packages/react-core/src/components/Hint/Hint.tsx +++ b/packages/react-core/src/components/Hint/Hint.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Hint/HintBody.tsx b/packages/react-core/src/components/Hint/HintBody.tsx index 0bd1b7e843e..2abdde1560a 100644 --- a/packages/react-core/src/components/Hint/HintBody.tsx +++ b/packages/react-core/src/components/Hint/HintBody.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Hint/HintFooter.tsx b/packages/react-core/src/components/Hint/HintFooter.tsx index e019157cae5..d3f1a022a2c 100644 --- a/packages/react-core/src/components/Hint/HintFooter.tsx +++ b/packages/react-core/src/components/Hint/HintFooter.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Hint/HintTitle.tsx b/packages/react-core/src/components/Hint/HintTitle.tsx index 93f9a1a52e5..126888e25be 100644 --- a/packages/react-core/src/components/Hint/HintTitle.tsx +++ b/packages/react-core/src/components/Hint/HintTitle.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/Hint/__tests__/Hint.test.tsx b/packages/react-core/src/components/Hint/__tests__/Hint.test.tsx index ed816111064..44e84a7fb12 100644 --- a/packages/react-core/src/components/Hint/__tests__/Hint.test.tsx +++ b/packages/react-core/src/components/Hint/__tests__/Hint.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render, screen } from '@testing-library/react'; import { Hint } from '../Hint'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; diff --git a/packages/react-core/src/components/Hint/__tests__/HintBody.test.tsx b/packages/react-core/src/components/Hint/__tests__/HintBody.test.tsx index 8c2c72b7b78..e2a2565655e 100644 --- a/packages/react-core/src/components/Hint/__tests__/HintBody.test.tsx +++ b/packages/react-core/src/components/Hint/__tests__/HintBody.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import '@testing-library/jest-dom'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; diff --git a/packages/react-core/src/components/Hint/__tests__/HintFooter.test.tsx b/packages/react-core/src/components/Hint/__tests__/HintFooter.test.tsx index 1e8e6daac33..855bb4f0c56 100644 --- a/packages/react-core/src/components/Hint/__tests__/HintFooter.test.tsx +++ b/packages/react-core/src/components/Hint/__tests__/HintFooter.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import '@testing-library/jest-dom'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; diff --git a/packages/react-core/src/components/Hint/__tests__/HintTitle.test.tsx b/packages/react-core/src/components/Hint/__tests__/HintTitle.test.tsx index 62164522f20..40bbbc917ce 100644 --- a/packages/react-core/src/components/Hint/__tests__/HintTitle.test.tsx +++ b/packages/react-core/src/components/Hint/__tests__/HintTitle.test.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { render, screen } from '@testing-library/react'; import '@testing-library/jest-dom'; import styles from '@patternfly/react-styles/css/components/Hint/hint'; diff --git a/packages/react-core/src/components/Hint/examples/Hint.md b/packages/react-core/src/components/Hint/examples/Hint.md index dae8524c1e6..57aa3740de1 100644 --- a/packages/react-core/src/components/Hint/examples/Hint.md +++ b/packages/react-core/src/components/Hint/examples/Hint.md @@ -5,6 +5,7 @@ cssPrefix: pf-v6-c-hint propComponents: ['Hint', 'HintTitle', 'HintBody', 'HintFooter'] --- +import { Fragment } from 'react'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; ## Examples diff --git a/packages/react-core/src/components/Hint/examples/HintActionsWithNoOffset.tsx b/packages/react-core/src/components/Hint/examples/HintActionsWithNoOffset.tsx index abc220e5d61..96e8259a5af 100644 --- a/packages/react-core/src/components/Hint/examples/HintActionsWithNoOffset.tsx +++ b/packages/react-core/src/components/Hint/examples/HintActionsWithNoOffset.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Hint, HintTitle, HintBody, Button, Checkbox } from '@patternfly/react-core'; export const HintActionsWithNoOffset: React.FunctionComponent = () => { diff --git a/packages/react-core/src/components/Hint/examples/HintBasicWithTitle.tsx b/packages/react-core/src/components/Hint/examples/HintBasicWithTitle.tsx index 94f7a9d6f68..1d7997114b2 100644 --- a/packages/react-core/src/components/Hint/examples/HintBasicWithTitle.tsx +++ b/packages/react-core/src/components/Hint/examples/HintBasicWithTitle.tsx @@ -1,4 +1,3 @@ -import React from 'react'; import { Hint, HintTitle, diff --git a/packages/react-core/src/components/Hint/examples/HintBasicWithoutTitle.tsx b/packages/react-core/src/components/Hint/examples/HintBasicWithoutTitle.tsx index 9c2f5cf82fd..7884dc245fa 100644 --- a/packages/react-core/src/components/Hint/examples/HintBasicWithoutTitle.tsx +++ b/packages/react-core/src/components/Hint/examples/HintBasicWithoutTitle.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Hint, HintBody, @@ -70,7 +70,7 @@ export const HintBasicWithoutTitle: React.FunctionComponent = () => { ); return ( - + Welcome to the new documentation experience. @@ -90,6 +90,6 @@ export const HintBasicWithoutTitle: React.FunctionComponent = () => { - + ); }; diff --git a/packages/react-core/src/components/Icon/Icon.tsx b/packages/react-core/src/components/Icon/Icon.tsx index 26304588e2a..01e051515f5 100644 --- a/packages/react-core/src/components/Icon/Icon.tsx +++ b/packages/react-core/src/components/Icon/Icon.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Icon/icon'; import { css } from '@patternfly/react-styles'; import { Spinner } from '../Spinner'; diff --git a/packages/react-core/src/components/Icon/__tests__/Icon.test.tsx b/packages/react-core/src/components/Icon/__tests__/Icon.test.tsx index 115340e045d..d76fe4b6334 100644 --- a/packages/react-core/src/components/Icon/__tests__/Icon.test.tsx +++ b/packages/react-core/src/components/Icon/__tests__/Icon.test.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import { render, screen } from '@testing-library/react'; import { kebabCase } from 'case-anything'; import { Icon, IconSize } from '../Icon'; diff --git a/packages/react-core/src/components/Icon/examples/BodyIconSizes.tsx b/packages/react-core/src/components/Icon/examples/BodyIconSizes.tsx index 97cfd0d9cad..e73b3a38326 100644 --- a/packages/react-core/src/components/Icon/examples/BodyIconSizes.tsx +++ b/packages/react-core/src/components/Icon/examples/BodyIconSizes.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon } from '@patternfly/react-core'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; export const BodyIconSizes: React.FunctionComponent = () => ( - + {' '} @@ -13,5 +13,5 @@ export const BodyIconSizes: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/Icon/examples/HeadingIconSizes.tsx b/packages/react-core/src/components/Icon/examples/HeadingIconSizes.tsx index a7ad0d280c0..ecfd754b517 100644 --- a/packages/react-core/src/components/Icon/examples/HeadingIconSizes.tsx +++ b/packages/react-core/src/components/Icon/examples/HeadingIconSizes.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon } from '@patternfly/react-core'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; export const HeadingIconSizes: React.FunctionComponent = () => ( - + {' '} @@ -22,5 +22,5 @@ export const HeadingIconSizes: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/Icon/examples/Icon.md b/packages/react-core/src/components/Icon/examples/Icon.md index ec9cdb9030d..fcdef78bfb5 100644 --- a/packages/react-core/src/components/Icon/examples/Icon.md +++ b/packages/react-core/src/components/Icon/examples/Icon.md @@ -5,6 +5,7 @@ cssPrefix: pf-v6-c-icon propComponents: ['Icon'] --- +import { Fragment } from 'react'; import LongArrowAltDownIcon from '@patternfly/react-icons/dist/esm/icons/long-arrow-alt-down-icon'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; import AngleDownIcon from '@patternfly/react-icons/dist/esm/icons/angle-down-icon'; diff --git a/packages/react-core/src/components/Icon/examples/IconBasic.tsx b/packages/react-core/src/components/Icon/examples/IconBasic.tsx index d5b4cb9f523..fb6ad36afb6 100644 --- a/packages/react-core/src/components/Icon/examples/IconBasic.tsx +++ b/packages/react-core/src/components/Icon/examples/IconBasic.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon } from '@patternfly/react-core'; import LongArrowAltDownIcon from '@patternfly/react-icons/dist/esm/icons/long-arrow-alt-down-icon'; import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; @@ -6,7 +6,7 @@ import AngleDownIcon from '@patternfly/react-icons/dist/esm/icons/angle-down-ico import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; export const IconBasic: React.FunctionComponent = () => ( - + {' '} @@ -19,5 +19,5 @@ export const IconBasic: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/Icon/examples/IconContentSizes.tsx b/packages/react-core/src/components/Icon/examples/IconContentSizes.tsx index 5267cac37be..26b78557a58 100644 --- a/packages/react-core/src/components/Icon/examples/IconContentSizes.tsx +++ b/packages/react-core/src/components/Icon/examples/IconContentSizes.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon } from '@patternfly/react-core'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; export const IconContentSizes: React.FunctionComponent = () => ( - + {' '} @@ -16,5 +16,5 @@ export const IconContentSizes: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/Icon/examples/IconCustomProgress.tsx b/packages/react-core/src/components/Icon/examples/IconCustomProgress.tsx index faa64ccec9d..9e319fc0191 100644 --- a/packages/react-core/src/components/Icon/examples/IconCustomProgress.tsx +++ b/packages/react-core/src/components/Icon/examples/IconCustomProgress.tsx @@ -1,11 +1,11 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon, Spinner, Checkbox } from '@patternfly/react-core'; import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon'; export const IconProgress: React.FunctionComponent = () => { const [isInProgress, setIsInProgress] = React.useState(false); return ( - +
    { }> - + ); }; diff --git a/packages/react-core/src/components/Icon/examples/IconInline.tsx b/packages/react-core/src/components/Icon/examples/IconInline.tsx index 19b3a273b39..db07fb69ec8 100644 --- a/packages/react-core/src/components/Icon/examples/IconInline.tsx +++ b/packages/react-core/src/components/Icon/examples/IconInline.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon, Content } from '@patternfly/react-core'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; export const IconInline: React.FunctionComponent = () => ( - +

    Heading @@ -56,5 +56,5 @@ export const IconInline: React.FunctionComponent = () => ( extra large - + ); diff --git a/packages/react-core/src/components/Icon/examples/IconProgress.tsx b/packages/react-core/src/components/Icon/examples/IconProgress.tsx index 892f4768cdc..b9889989a84 100644 --- a/packages/react-core/src/components/Icon/examples/IconProgress.tsx +++ b/packages/react-core/src/components/Icon/examples/IconProgress.tsx @@ -1,11 +1,11 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon, Checkbox } from '@patternfly/react-core'; import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon'; export const IconProgress: React.FunctionComponent = () => { const [isInProgress, setIsInProgress] = React.useState(false); return ( - +
    { - + ); }; diff --git a/packages/react-core/src/components/Icon/examples/IconStatus.tsx b/packages/react-core/src/components/Icon/examples/IconStatus.tsx index 3995b578695..01728bf3e47 100644 --- a/packages/react-core/src/components/Icon/examples/IconStatus.tsx +++ b/packages/react-core/src/components/Icon/examples/IconStatus.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon } from '@patternfly/react-core'; import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon'; import ExclamationTriangleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-triangle-icon'; @@ -7,7 +7,7 @@ import InfoCircleIcon from '@patternfly/react-icons/dist/esm/icons/info-circle-i import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon'; export const IconStatus: React.FunctionComponent = () => ( - + {' '} @@ -23,5 +23,5 @@ export const IconStatus: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/Icon/examples/StandaloneIconSizes.tsx b/packages/react-core/src/components/Icon/examples/StandaloneIconSizes.tsx index 87ab0a5375a..874c3490bf0 100644 --- a/packages/react-core/src/components/Icon/examples/StandaloneIconSizes.tsx +++ b/packages/react-core/src/components/Icon/examples/StandaloneIconSizes.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Icon } from '@patternfly/react-core'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; export const StandaloneIconSizes: React.FunctionComponent = () => ( - + {' '} @@ -22,5 +22,5 @@ export const StandaloneIconSizes: React.FunctionComponent = () => ( - + ); diff --git a/packages/react-core/src/components/InputGroup/InputGroup.tsx b/packages/react-core/src/components/InputGroup/InputGroup.tsx index e116eb465b7..2e5916926bd 100644 --- a/packages/react-core/src/components/InputGroup/InputGroup.tsx +++ b/packages/react-core/src/components/InputGroup/InputGroup.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import { forwardRef, useRef } from 'react'; import styles from '@patternfly/react-styles/css/components/InputGroup/input-group'; import { css } from '@patternfly/react-styles'; @@ -17,7 +17,7 @@ export const InputGroupBase: React.FunctionComponent = ({ innerRef, ...props }: InputGroupProps) => { - const ref = React.useRef(null); + const ref = useRef(null); const inputGroupRef = innerRef || ref; return ( @@ -28,7 +28,7 @@ export const InputGroupBase: React.FunctionComponent = ({ }; InputGroupBase.displayName = 'InputGroupBase'; -export const InputGroup = React.forwardRef((props: InputGroupProps, ref: React.Ref) => ( +export const InputGroup = forwardRef((props: InputGroupProps, ref: React.Ref) => ( )); InputGroup.displayName = 'InputGroup'; diff --git a/packages/react-core/src/components/InputGroup/InputGroupItem.tsx b/packages/react-core/src/components/InputGroup/InputGroupItem.tsx index 2426a5d9e7d..accd5842196 100644 --- a/packages/react-core/src/components/InputGroup/InputGroupItem.tsx +++ b/packages/react-core/src/components/InputGroup/InputGroupItem.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/InputGroup/input-group'; import { css } from '@patternfly/react-styles'; diff --git a/packages/react-core/src/components/InputGroup/InputGroupText.tsx b/packages/react-core/src/components/InputGroup/InputGroupText.tsx index 7b3ac759110..10a8338be85 100644 --- a/packages/react-core/src/components/InputGroup/InputGroupText.tsx +++ b/packages/react-core/src/components/InputGroup/InputGroupText.tsx @@ -1,4 +1,3 @@ -import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/InputGroup/input-group'; import { css } from '@patternfly/react-styles'; import { InputGroupItem } from './InputGroupItem'; diff --git a/packages/react-core/src/components/InputGroup/__tests__/InputGroup.test.tsx b/packages/react-core/src/components/InputGroup/__tests__/InputGroup.test.tsx index 0c9b1534937..f6b5f0cd645 100644 --- a/packages/react-core/src/components/InputGroup/__tests__/InputGroup.test.tsx +++ b/packages/react-core/src/components/InputGroup/__tests__/InputGroup.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { InputGroup } from '../InputGroup'; diff --git a/packages/react-core/src/components/InputGroup/__tests__/InputGroupText.test.tsx b/packages/react-core/src/components/InputGroup/__tests__/InputGroupText.test.tsx index 76405bffb9a..bfa530e10f2 100644 --- a/packages/react-core/src/components/InputGroup/__tests__/InputGroupText.test.tsx +++ b/packages/react-core/src/components/InputGroup/__tests__/InputGroupText.test.tsx @@ -1,5 +1,3 @@ -import React from 'react'; - import { render, screen } from '@testing-library/react'; import { InputGroupText } from '../InputGroupText'; diff --git a/packages/react-core/src/components/InputGroup/examples/InputGroup.md b/packages/react-core/src/components/InputGroup/examples/InputGroup.md index f9067c9a668..6d0d89210e6 100644 --- a/packages/react-core/src/components/InputGroup/examples/InputGroup.md +++ b/packages/react-core/src/components/InputGroup/examples/InputGroup.md @@ -5,6 +5,7 @@ cssPrefix: pf-v6-c-input-group propComponents: ['InputGroup', 'InputGroupItem', 'InputGroupText'] --- +import { Fragment } from 'react'; import AtIcon from '@patternfly/react-icons/dist/esm/icons/at-icon'; import DollarSignIcon from '@patternfly/react-icons/dist/esm/icons/dollar-sign-icon'; import CalendarAltIcon from '@patternfly/react-icons/dist/esm/icons/calendar-alt-icon'; diff --git a/packages/react-core/src/components/InputGroup/examples/InputGroupBasic.tsx b/packages/react-core/src/components/InputGroup/examples/InputGroupBasic.tsx index c2db8ff8e3e..79290d4a4ba 100644 --- a/packages/react-core/src/components/InputGroup/examples/InputGroupBasic.tsx +++ b/packages/react-core/src/components/InputGroup/examples/InputGroupBasic.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import AtIcon from '@patternfly/react-icons/dist/esm/icons/at-icon'; import { InputGroup, InputGroupText, InputGroupItem, TextInput, ValidatedOptions } from '@patternfly/react-core'; export const InputGroupBasic: React.FunctionComponent = () => ( - + @@ -33,5 +33,5 @@ export const InputGroupBasic: React.FunctionComponent = () => ( % - + ); diff --git a/packages/react-core/src/components/InputGroup/examples/InputGroupWithDropdown.tsx b/packages/react-core/src/components/InputGroup/examples/InputGroupWithDropdown.tsx index c71847a6803..a74d789c126 100644 --- a/packages/react-core/src/components/InputGroup/examples/InputGroupWithDropdown.tsx +++ b/packages/react-core/src/components/InputGroup/examples/InputGroupWithDropdown.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import { Button, InputGroup, @@ -23,7 +23,7 @@ export const InputGroupWithDropdown: React.FunctionComponent = () => { }; return ( - + { - + ); }; diff --git a/packages/react-core/src/components/InputGroup/examples/InputGroupWithPopover.tsx b/packages/react-core/src/components/InputGroup/examples/InputGroupWithPopover.tsx index 20e95a97ea3..4f4927e7042 100644 --- a/packages/react-core/src/components/InputGroup/examples/InputGroupWithPopover.tsx +++ b/packages/react-core/src/components/InputGroup/examples/InputGroupWithPopover.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import { Fragment } from 'react'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import { Button, InputGroup, InputGroupItem, TextInput, Popover, PopoverPosition } from '@patternfly/react-core'; @@ -6,7 +6,7 @@ export const InputGroupWithPopover: React.FunctionComponent = () => { const inputGroupRef1 = React.useRef(null); const inputGroupRef2 = React.useRef(null); return ( - + { - + ); }; diff --git a/packages/react-core/src/components/InputGroup/examples/InputGroupWithSiblings.tsx b/packages/react-core/src/components/InputGroup/examples/InputGroupWithSiblings.tsx index 1a3ff7bc887..432cb630edf 100644 --- a/packages/react-core/src/components/InputGroup/examples/InputGroupWithSiblings.tsx +++ b/packages/react-core/src/components/InputGroup/examples/InputGroupWithSiblings.tsx @@ -1,9 +1,9 @@ -import React from 'react'; +import { Fragment } from 'react'; import DollarSignIcon from '@patternfly/react-icons/dist/esm/icons/dollar-sign-icon'; import { Button, TextArea, InputGroup, InputGroupText, InputGroupItem, TextInput } from '@patternfly/react-core'; export const InputGroupWithSiblings: React.FunctionComponent = () => ( - +