From 4002b599810545586c92f36cfda2087f9497d68f Mon Sep 17 00:00:00 2001 From: Boaz Shuster Date: Tue, 5 Mar 2019 00:14:07 +0200 Subject: [PATCH] chore(inputgroup): add input group to react-integration Signed-off-by: Boaz Shuster --- .../src/components/InputGroup/InputGroup.js | 12 ++++++---- .../components/InputGroup/InputGroupText.d.ts | 2 +- .../components/InputGroup/InputGroupText.js | 16 ++++++------- .../InputGroup/examples/SimpleInputGroups.js | 24 +++++++++++++------ .../react-integration/demo-app-ts/src/App.tsx | 11 ++++++++- 5 files changed, 42 insertions(+), 23 deletions(-) diff --git a/packages/patternfly-4/react-core/src/components/InputGroup/InputGroup.js b/packages/patternfly-4/react-core/src/components/InputGroup/InputGroup.js index 2f85f0dc1ad..ef9a5e7acaa 100644 --- a/packages/patternfly-4/react-core/src/components/InputGroup/InputGroup.js +++ b/packages/patternfly-4/react-core/src/components/InputGroup/InputGroup.js @@ -14,11 +14,13 @@ const InputGroup = ({ className, children, ...props }) => { return (
{idItem - ? React.Children.map(children, child => { - return formCtrls.includes(child.type.toString()) - ? React.cloneElement(child, { 'aria-describedby': idItem.props.id }) - : child; - }) + ? React.Children.map( + children, + child => + formCtrls.includes(child.type.toString()) + ? React.cloneElement(child, { 'aria-describedby': idItem.props.id }) + : child + ) : children}
); diff --git a/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.d.ts b/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.d.ts index eecc2c4ffe0..6bc6fef94f7 100644 --- a/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.d.ts +++ b/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.d.ts @@ -3,7 +3,7 @@ import { Omit } from '../../typeUtils' export interface InputGroupTextProps extends Omit, 'children'> { children: ReactNode; - component?: ReactType | ReactType; + component?: ReactType; } declare const InputGroupText: SFC; diff --git a/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.js b/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.js index 61f5c660455..eb123710b1d 100644 --- a/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.js +++ b/packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.js @@ -4,13 +4,11 @@ import { css } from '@patternfly/react-styles'; import PropTypes from 'prop-types'; import { componentShape } from '../../helpers/componentShape'; -const InputGroupText = ({ component: Component, className, children, ...props }) => { - return ( - - {children} - - ); -}; +const InputGroupText = ({ component: Component, className, children, ...props }) => ( + + {children} + +); InputGroupText.propTypes = { /** Additional classes added to the input group text. */ @@ -18,12 +16,12 @@ InputGroupText.propTypes = { /** Content rendered inside the input group text. */ children: PropTypes.node.isRequired, /** Component that wraps the input group text. */ - component: componentShape, + component: componentShape }; InputGroupText.defaultProps = { className: '', - component: 'span', + component: 'span' }; export default InputGroupText; diff --git a/packages/patternfly-4/react-core/src/components/InputGroup/examples/SimpleInputGroups.js b/packages/patternfly-4/react-core/src/components/InputGroup/examples/SimpleInputGroups.js index 0b08bfa7d9a..c2c853d01ad 100644 --- a/packages/patternfly-4/react-core/src/components/InputGroup/examples/SimpleInputGroups.js +++ b/packages/patternfly-4/react-core/src/components/InputGroup/examples/SimpleInputGroups.js @@ -26,10 +26,10 @@ class SimpleInputGroups extends React.Component { }); }; - onSelect = (event) => { + onSelect = event => { this.setState({ isOpen: false, - selected: event.currentTarget.value, + selected: event.currentTarget.value }); }; render() { @@ -65,12 +65,22 @@ class SimpleInputGroups extends React.Component { {this.state.selected ? this.state.selected : 'Dropdown' }} + toggle={ + + {this.state.selected ? this.state.selected : 'Dropdown'} + + } isOpen={this.state.isOpen} dropdownItems={[ - Option 1, - Option 2, - Option 3, + + Option 1 + , + + Option 2 + , + + Option 3 + ]} > Dropdown @@ -124,7 +134,7 @@ class SimpleInputGroups extends React.Component {