diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2d6aedcf78b..cb3c5edf68f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -141,6 +141,7 @@ when possible and accept [props](https://facebook.github.io/react/docs/component * Provide a storybook with your component named on the parent component with a `.stories.js` suffix (e.g., `ListGroup.stories.js`) * When your stories contain multiple files, put them in a subfolder named `Stories` * `src/**/*.stories.js` and `src/**/Stories/` are excluded from the package build output +* When writing a component and you want to use the classnames package, be sure to import and name it `classNames`. For example - ` import classNames from 'classnames' ` * Exporting components from other libraries (without manipulating them) to consumers is a common task, use: ```js diff --git a/src/components/AboutModal/AboutModalVersions.js b/src/components/AboutModal/AboutModalVersions.js index 4e938c9ebc3..337db5cd89b 100644 --- a/src/components/AboutModal/AboutModalVersions.js +++ b/src/components/AboutModal/AboutModalVersions.js @@ -1,9 +1,9 @@ -import cx from 'classnames'; +import classNames from 'classnames'; import React from 'react'; import PropTypes from 'prop-types'; const AboutModalVersions = ({ children, className, ...rest }) => { - const classes = cx('product-versions-pf', className); + const classes = classNames('product-versions-pf', className); return (
diff --git a/src/components/EmptyState/EmptyStateIcon.js b/src/components/EmptyState/EmptyStateIcon.js index 943fa7fecd1..7e0e647f5fb 100644 --- a/src/components/EmptyState/EmptyStateIcon.js +++ b/src/components/EmptyState/EmptyStateIcon.js @@ -1,4 +1,4 @@ -import ClassNames from 'classnames'; +import classNames from 'classnames'; import React from 'react'; import PropTypes from 'prop-types'; import { Icon } from '../Icon'; @@ -7,7 +7,7 @@ import { Icon } from '../Icon'; * EmptyStateIcon renders element */ const EmptyStateIcon = ({ className, type, name, ...props }) => { - const classes = ClassNames('blank-slate-pf-icon', className); + const classes = classNames('blank-slate-pf-icon', className); return (
diff --git a/src/components/EmptyState/EmptyStateTitle.js b/src/components/EmptyState/EmptyStateTitle.js index 636bef3935b..36f0eaf90f6 100644 --- a/src/components/EmptyState/EmptyStateTitle.js +++ b/src/components/EmptyState/EmptyStateTitle.js @@ -1,4 +1,4 @@ -import ClassNames from 'classnames'; +import classNames from 'classnames'; import React from 'react'; import PropTypes from 'prop-types'; @@ -6,7 +6,7 @@ import PropTypes from 'prop-types'; * EmptyStateTitle renders contents of the element */ const EmptyStateTitle = ({ children, className, ...props }) => { - const classes = ClassNames('h1', 'blank-slate-pf-title', className); + const classes = classNames('h1', 'blank-slate-pf-title', className); return (
{children}
; }; diff --git a/src/components/Filter/FilterCategorySelector.js b/src/components/Filter/FilterCategorySelector.js index 1ec0e3c21b6..d38c6e8121d 100644 --- a/src/components/Filter/FilterCategorySelector.js +++ b/src/components/Filter/FilterCategorySelector.js @@ -1,6 +1,6 @@ import React from 'react'; import PropTypes from 'prop-types'; -import cx from 'classnames'; +import classNames from 'classnames'; import { DropdownButton } from '../Button'; import { MenuItem } from '../MenuItem'; import { noop } from '../../common/helpers'; @@ -15,7 +15,7 @@ const FilterCategorySelector = ({ onFilterCategorySelected, ...rest }) => { - const classes = cx('filter-pf-category-select', className); + const classes = classNames('filter-pf-category-select', className); if (placeholder || (filterCategories && filterCategories.length > 1)) { let title; diff --git a/src/components/Filter/FilterCategoryValueSelector.js b/src/components/Filter/FilterCategoryValueSelector.js index b1f4b4183de..762cc78773a 100644 --- a/src/components/Filter/FilterCategoryValueSelector.js +++ b/src/components/Filter/FilterCategoryValueSelector.js @@ -1,6 +1,6 @@ import React from 'react'; import PropTypes from 'prop-types'; -import cx from 'classnames'; +import classNames from 'classnames'; import { DropdownButton } from '../Button'; import { MenuItem } from '../MenuItem'; import { noop } from '../../common/helpers'; @@ -14,7 +14,7 @@ const FilterCategoryValueSelector = ({ onCategoryValueSelected, ...rest }) => { - const classes = cx('filter-pf-select', className); + const classes = classNames('filter-pf-select', className); if (placeholder || (categoryValues && categoryValues.length > 1)) { let title; diff --git a/src/components/Filter/FilterItem.js b/src/components/Filter/FilterItem.js index e86b1143304..0bd69131d88 100644 --- a/src/components/Filter/FilterItem.js +++ b/src/components/Filter/FilterItem.js @@ -1,11 +1,11 @@ -import ClassNames from 'classnames'; +import classNames from 'classnames'; import React from 'react'; import PropTypes from 'prop-types'; import { noop } from '../../common/helpers'; import { DisposableLabel } from '../Label'; const FilterItem = ({ children, className, onRemove, filterData, ...rest }) => { - const classes = ClassNames(className); + const classes = classNames(className); return (