From a1212cc62c4a932fe608f19ebedcbc4c640776fc Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Thu, 7 Apr 2022 14:23:28 -0400 Subject: [PATCH 1/7] fix(Pagination): make items per page text in toggle clickable --- .../components/Pagination/OptionsToggle.tsx | 64 +++++++++---------- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/packages/react-core/src/components/Pagination/OptionsToggle.tsx b/packages/react-core/src/components/Pagination/OptionsToggle.tsx index bb797b828ad..8d3c26f19b0 100644 --- a/packages/react-core/src/components/Pagination/OptionsToggle.tsx +++ b/packages/react-core/src/components/Pagination/OptionsToggle.tsx @@ -59,41 +59,37 @@ export const OptionsToggle: React.FunctionComponent = ({ toggleTemplate: ToggleTemplate, onEnter = null }: OptionsToggleProps) => ( -
+ <> {showToggle && ( - - - {typeof ToggleTemplate === 'string' ? ( - fillTemplate(ToggleTemplate, { firstIndex, lastIndex, ofWord, itemCount, itemsTitle }) - ) : ( - - )} - - - + + {typeof ToggleTemplate === 'string' ? ( + fillTemplate(ToggleTemplate, { firstIndex, lastIndex, ofWord, itemCount, itemsTitle }) + ) : ( + + )} + )} -
+ ); OptionsToggle.displayName = 'OptionsToggle'; From c55ad2048a7a4bc6e92186c81f595714ca96a645 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Thu, 7 Apr 2022 14:27:50 -0400 Subject: [PATCH 2/7] Update snapshots --- .../__snapshots__/OptionsToggle.test.tsx.snap | 57 +- .../__snapshots__/Pagination.test.tsx.snap | 202 +++++ .../PaginationOptionsMenu.test.tsx.snap | 6 +- .../__snapshots__/Pagination.test.tsx.snap | 806 +++++++++--------- 4 files changed, 609 insertions(+), 462 deletions(-) create mode 100644 packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/Pagination.test.tsx.snap diff --git a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/OptionsToggle.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/OptionsToggle.test.tsx.snap index 294ac5dbf4c..5c9b9236c94 100644 --- a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/OptionsToggle.test.tsx.snap +++ b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/OptionsToggle.test.tsx.snap @@ -2,40 +2,35 @@ exports[`OptionsToggle should match snapshot (auto-generated) 1`] = `
- + + + +
`; diff --git a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/Pagination.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/Pagination.test.tsx.snap new file mode 100644 index 00000000000..4cb5f2cfbd9 --- /dev/null +++ b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/Pagination.test.tsx.snap @@ -0,0 +1,202 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`Pagination should match snapshot (auto-generated) 1`] = ` +
+
+
+ string +
+
+ +
+ + ReactNode +
+
+`; diff --git a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap index c657b4a112f..53521992ce8 100644 --- a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap +++ b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap @@ -6,10 +6,6 @@ exports[`PaginationOptionsMenu should match snapshot (auto-generated) 1`] = ` class="pf-c-options-menu pf-m-top" data-ouia-component-type="PF4/PaginationOptionsMenu" data-ouia-safe="true" - > -
-
+ /> `; diff --git a/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap index 6d92aa8ffda..06e21811abb 100644 --- a/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap +++ b/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap @@ -20,43 +20,40 @@ exports[`Pagination component render custom pagination toggle 1`] = ` data-ouia-component-type="PF4/PaginationOptionsMenu" data-ouia-safe="true" > - + + +