From b0f6d3fd7c482ffd7ee312a5bcf0334047206869 Mon Sep 17 00:00:00 2001
From: Jon Koops <jonkoops@gmail.com>
Date: Thu, 5 May 2022 12:55:54 +0200
Subject: [PATCH] Add missing 'children' prop in several places

---
 packages/react-core/src/components/Select/SelectMenu.tsx        | 2 +-
 .../react-topology/src/components/ComputeElementDimensions.tsx  | 1 +
 .../react-topology/src/components/contextmenu/ContextMenu.tsx   | 2 +-
 packages/react-topology/src/components/decorators/Decorator.tsx | 1 +
 packages/react-topology/src/components/edges/DefaultEdge.tsx    | 1 +
 .../src/components/groups/DefaultGroupCollapsed.tsx             | 1 +
 packages/react-topology/src/components/nodes/DefaultNode.tsx    | 1 +
 packages/react-topology/src/components/popper/Popper.tsx        | 1 +
 packages/react-topology/src/components/popper/Portal.tsx        | 1 +
 9 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/packages/react-core/src/components/Select/SelectMenu.tsx b/packages/react-core/src/components/Select/SelectMenu.tsx
index 761b4c07ff2..678be2a0f52 100644
--- a/packages/react-core/src/components/Select/SelectMenu.tsx
+++ b/packages/react-core/src/components/Select/SelectMenu.tsx
@@ -268,7 +268,7 @@ class SelectMenuWithRef extends React.Component<SelectMenuProps> {
   }
 }
 
-export const SelectMenu = React.forwardRef((props, ref) => (
+export const SelectMenu = React.forwardRef<unknown, React.PropsWithChildren<unknown>>((props, ref) => (
   <SelectMenuWithRef innerRef={ref} {...props}>
     {props.children}
   </SelectMenuWithRef>
diff --git a/packages/react-topology/src/components/ComputeElementDimensions.tsx b/packages/react-topology/src/components/ComputeElementDimensions.tsx
index 72661f02e55..a1d179853a2 100644
--- a/packages/react-topology/src/components/ComputeElementDimensions.tsx
+++ b/packages/react-topology/src/components/ComputeElementDimensions.tsx
@@ -5,6 +5,7 @@ import Dimensions from '../geom/Dimensions';
 import { Node } from '../types';
 
 interface ComputeElementDimensionsProps {
+  children?: React.ReactNode;
   element: Node;
 }
 
diff --git a/packages/react-topology/src/components/contextmenu/ContextMenu.tsx b/packages/react-topology/src/components/contextmenu/ContextMenu.tsx
index b67717ea4e3..6f2dc3c66f2 100644
--- a/packages/react-topology/src/components/contextmenu/ContextMenu.tsx
+++ b/packages/react-topology/src/components/contextmenu/ContextMenu.tsx
@@ -8,7 +8,7 @@ import Popper from '../popper/Popper';
 
 type ContextMenuProps = Pick<
   React.ComponentProps<typeof Popper>,
-  'container' | 'className' | 'open' | 'reference' | 'onRequestClose'
+  'children' | 'container' | 'className' | 'open' | 'reference' | 'onRequestClose'
 >;
 
 const ContextMenu: React.FunctionComponent<ContextMenuProps> = ({
diff --git a/packages/react-topology/src/components/decorators/Decorator.tsx b/packages/react-topology/src/components/decorators/Decorator.tsx
index dd7feaac9aa..3ef9f6dd0e2 100644
--- a/packages/react-topology/src/components/decorators/Decorator.tsx
+++ b/packages/react-topology/src/components/decorators/Decorator.tsx
@@ -6,6 +6,7 @@ import { createSvgIdUrl, useHover } from '../../utils';
 import { DEFAULT_DECORATOR_PADDING } from '../nodes';
 
 interface DecoratorTypes {
+  children?: React.ReactNode;
   className?: string;
   x: number;
   y: number;
diff --git a/packages/react-topology/src/components/edges/DefaultEdge.tsx b/packages/react-topology/src/components/edges/DefaultEdge.tsx
index 6b91e2a176e..fb776d4a960 100644
--- a/packages/react-topology/src/components/edges/DefaultEdge.tsx
+++ b/packages/react-topology/src/components/edges/DefaultEdge.tsx
@@ -21,6 +21,7 @@ import { Point } from '../../geom';
 import { getConnectorStartPoint } from './terminals/terminalUtils';
 
 type BaseEdgeProps = {
+  children?: React.ReactNode;
   element: Edge;
   dragging?: boolean;
   className?: string;
diff --git a/packages/react-topology/src/components/groups/DefaultGroupCollapsed.tsx b/packages/react-topology/src/components/groups/DefaultGroupCollapsed.tsx
index e42e0ca993e..00b3ead3196 100644
--- a/packages/react-topology/src/components/groups/DefaultGroupCollapsed.tsx
+++ b/packages/react-topology/src/components/groups/DefaultGroupCollapsed.tsx
@@ -21,6 +21,7 @@ import LabelBadge from '../nodes/labels/LabelBadge';
 import { CollapsibleGroupProps } from './types';
 
 type DefaultGroupCollapsedProps = {
+  children?: React.ReactNode;
   className?: string;
   element: Node;
   droppable?: boolean;
diff --git a/packages/react-topology/src/components/nodes/DefaultNode.tsx b/packages/react-topology/src/components/nodes/DefaultNode.tsx
index 50f702deb6c..c1499f38562 100644
--- a/packages/react-topology/src/components/nodes/DefaultNode.tsx
+++ b/packages/react-topology/src/components/nodes/DefaultNode.tsx
@@ -37,6 +37,7 @@ const getStatusIcon = (status: NodeStatus) => {
 };
 
 type DefaultNodeProps = {
+  children?: React.ReactNode;
   className?: string;
   element: Node;
   droppable?: boolean;
diff --git a/packages/react-topology/src/components/popper/Popper.tsx b/packages/react-topology/src/components/popper/Popper.tsx
index ad45d650f29..7a70eea74a2 100644
--- a/packages/react-topology/src/components/popper/Popper.tsx
+++ b/packages/react-topology/src/components/popper/Popper.tsx
@@ -50,6 +50,7 @@ const getReference = (reference: Reference): PopperJSReference =>
   'getBoundingClientRect' in reference ? reference : new VirtualReference(reference);
 
 interface PopperProps {
+  children?: React.ReactNode;
   closeOnEsc?: boolean;
   closeOnOutsideClick?: boolean;
   container?: React.ComponentProps<typeof Portal>['container'];
diff --git a/packages/react-topology/src/components/popper/Portal.tsx b/packages/react-topology/src/components/popper/Portal.tsx
index 0df2a615962..c42be825696 100644
--- a/packages/react-topology/src/components/popper/Portal.tsx
+++ b/packages/react-topology/src/components/popper/Portal.tsx
@@ -5,6 +5,7 @@ import { useIsomorphicLayoutEffect } from '@patternfly/react-core';
 type GetContainer = Element | null | undefined | (() => Element);
 
 interface PortalProps {
+  children?: React.ReactNode;
   container?: GetContainer;
 }