From c97ab757b244e715853c1c814c590e010446b757 Mon Sep 17 00:00:00 2001 From: jenny-s51 Date: Wed, 18 May 2022 15:31:09 -0400 Subject: [PATCH 1/3] add fullscreen demo for error state --- packages/react-table/src/demos/Table.md | 54 ++++++++++++++++--------- 1 file changed, 35 insertions(+), 19 deletions(-) diff --git a/packages/react-table/src/demos/Table.md b/packages/react-table/src/demos/Table.md index 5ea15866b44..6bc74c07a7d 100644 --- a/packages/react-table/src/demos/Table.md +++ b/packages/react-table/src/demos/Table.md @@ -3107,20 +3107,28 @@ class LoadingStateDemo extends React.Component { ### Error -```js +```js isFullscreen import React from 'react'; -import { EmptyState, EmptyStateBody, EmptyStateVariant, Title } from '@patternfly/react-core'; +import { + Bullseye, + Card, + EmptyState, + EmptyStateBody, + EmptyStateVariant, + PageSection, + Title +} from '@patternfly/react-core'; import { Table, TableHeader, TableBody } from '@patternfly/react-table'; +import DashboardWrapper from '@patternfly/react-core/src/demos/examples/DashboardWrapper'; class ErrorStateDemo extends React.Component { render() { const columns = [ - { title: 'Servers' }, - { title: 'Threads' }, - { title: 'Applications' }, + { title: 'Repositories' }, + { title: 'Branches' }, + { title: 'Pull requests' }, { title: 'Workspaces' }, - { title: 'Status' }, - { title: 'Location' } + { title: 'Last commit' } ]; const rows = [ { @@ -3129,14 +3137,16 @@ class ErrorStateDemo extends React.Component { { props: { colSpan: 8 }, title: ( - - - Unable to connect - - - There was an error retrieving data. Check your connection and reload the page. - - + + + + Unable to connect + + + There was an error retrieving data. Check your connection and reload the page. + + + ) } ] @@ -3144,10 +3154,16 @@ class ErrorStateDemo extends React.Component { ]; return ( - - - -
+ + + + + + +
+
+
+
); } } From a12d5f1f785ebb96660510205cba795cffcbe704 Mon Sep 17 00:00:00 2001 From: jenny-s51 Date: Wed, 25 May 2022 16:47:15 -0400 Subject: [PATCH 2/3] remove bullseye and add error icon --- packages/react-table/src/demos/Table.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/react-table/src/demos/Table.md b/packages/react-table/src/demos/Table.md index 6bc74c07a7d..e64fae5ece6 100644 --- a/packages/react-table/src/demos/Table.md +++ b/packages/react-table/src/demos/Table.md @@ -3110,9 +3110,9 @@ class LoadingStateDemo extends React.Component { ```js isFullscreen import React from 'react'; import { - Bullseye, Card, EmptyState, + EmptyStateIcon, EmptyStateBody, EmptyStateVariant, PageSection, @@ -3120,6 +3120,7 @@ import { } from '@patternfly/react-core'; import { Table, TableHeader, TableBody } from '@patternfly/react-table'; import DashboardWrapper from '@patternfly/react-core/src/demos/examples/DashboardWrapper'; +import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon'; class ErrorStateDemo extends React.Component { render() { @@ -3137,16 +3138,15 @@ class ErrorStateDemo extends React.Component { { props: { colSpan: 8 }, title: ( - - - - Unable to connect - - - There was an error retrieving data. Check your connection and reload the page. - - - + + + + Unable to connect + + + There was an error retrieving data. Check your connection and reload the page. + + ) } ] From 2889630908cbdec965d082c23da6c8ce27bd5841 Mon Sep 17 00:00:00 2001 From: jenny-s51 Date: Wed, 25 May 2022 16:48:59 -0400 Subject: [PATCH 3/3] sentence case --- packages/react-table/src/demos/Table.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-table/src/demos/Table.md b/packages/react-table/src/demos/Table.md index e64fae5ece6..d513bee493c 100644 --- a/packages/react-table/src/demos/Table.md +++ b/packages/react-table/src/demos/Table.md @@ -3157,7 +3157,7 @@ class ErrorStateDemo extends React.Component { - +