From 9b6864d0c12fd25bc5106c1a6a61ca21d7b6dd94 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Wed, 12 Oct 2022 15:51:21 -0400 Subject: [PATCH 1/6] chore(dropdown-like components): updated isFlipEnabled to true by default --- .../src/components/ContextSelector/ContextSelector.tsx | 10 ++-------- .../react-core/src/components/Dropdown/Dropdown.tsx | 2 +- .../src/components/Dropdown/DropdownWithContext.tsx | 6 ++---- packages/react-core/src/components/Select/Select.tsx | 6 ++---- 4 files changed, 7 insertions(+), 17 deletions(-) diff --git a/packages/react-core/src/components/ContextSelector/ContextSelector.tsx b/packages/react-core/src/components/ContextSelector/ContextSelector.tsx index 307c81ddfc1..4a5c2f1b6f4 100644 --- a/packages/react-core/src/components/ContextSelector/ContextSelector.tsx +++ b/packages/react-core/src/components/ContextSelector/ContextSelector.tsx @@ -95,7 +95,7 @@ export class ContextSelector extends React.Component +
{isOpen && ( = ({ alignments, contextProps, menuAppendTo = 'inline', - isFlipEnabled = false, + isFlipEnabled = true, removeFindDomNode = false, ...props }: DropdownProps) => ( diff --git a/packages/react-core/src/components/Dropdown/DropdownWithContext.tsx b/packages/react-core/src/components/Dropdown/DropdownWithContext.tsx index 7cca3a3a111..9f42a5f1972 100644 --- a/packages/react-core/src/components/Dropdown/DropdownWithContext.tsx +++ b/packages/react-core/src/components/Dropdown/DropdownWithContext.tsx @@ -30,7 +30,7 @@ export class DropdownWithContext extends React.Component undefined, autoFocus: true, menuAppendTo: 'inline', - isFlipEnabled: false + isFlipEnabled: true }; constructor(props: DropdownProps & OUIAProps) { @@ -99,9 +99,7 @@ export class DropdownWithContext extends React.Component Date: Wed, 12 Oct 2022 16:27:00 -0400 Subject: [PATCH 2/6] Updated snapshots --- .../ApplicationLauncher.test.tsx.snap | 6 ++--- .../ContextSelector.test.tsx.snap | 4 +-- .../__snapshots__/Dropdown.test.tsx.snap | 12 ++++----- .../__snapshots__/OptionsMenu.test.tsx.snap | 4 +-- .../__snapshots__/Select.test.tsx.snap | 26 +++++++++---------- .../__snapshots__/Toolbar.test.tsx.snap | 2 +- 6 files changed, 27 insertions(+), 27 deletions(-) diff --git a/packages/react-core/src/components/ApplicationLauncher/__tests__/__snapshots__/ApplicationLauncher.test.tsx.snap b/packages/react-core/src/components/ApplicationLauncher/__tests__/__snapshots__/ApplicationLauncher.test.tsx.snap index 478ec5517a2..72ef3dc8a54 100644 --- a/packages/react-core/src/components/ApplicationLauncher/__tests__/__snapshots__/ApplicationLauncher.test.tsx.snap +++ b/packages/react-core/src/components/ApplicationLauncher/__tests__/__snapshots__/ApplicationLauncher.test.tsx.snap @@ -37,7 +37,7 @@ exports[`ApplicationLauncher Renders in strict mode 1`] = `