From 6b84eab2f5c393b1bf758d2cd66a5a8da86b550d Mon Sep 17 00:00:00 2001 From: gitdallas Date: Thu, 13 Oct 2022 13:40:55 -0500 Subject: [PATCH 1/3] fix(ClipboardCopy): remove popoverposition --- .../react-core/src/components/ClipboardCopy/ClipboardCopy.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx index 08fe93a5c01..a7f30286025 100644 --- a/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx +++ b/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx @@ -2,7 +2,6 @@ import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy'; import { css } from '@patternfly/react-styles'; import { PickOptional } from '../../helpers/typeUtils'; -import { PopoverPosition } from '../Popover'; import { TooltipPosition } from '../Tooltip'; import { TextInput } from '../TextInput'; import { GenerateId } from '../../helpers/GenerateId/GenerateId'; @@ -55,7 +54,6 @@ export interface ClipboardCopyProps extends Omit variant?: typeof ClipboardCopyVariant | 'inline' | 'expansion' | 'inline-compact'; /** Copy button popover position. */ position?: - | PopoverPosition | TooltipPosition | 'auto' | 'top' @@ -109,7 +107,7 @@ export class ClipboardCopy extends React.Component Date: Thu, 13 Oct 2022 13:45:02 -0500 Subject: [PATCH 2/3] edit doc comment --- .../react-core/src/components/ClipboardCopy/ClipboardCopy.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx index a7f30286025..b53ac9c18fc 100644 --- a/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx +++ b/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx @@ -52,7 +52,7 @@ export interface ClipboardCopyProps extends Omit isBlock?: boolean; /** Adds Clipboard Copy variant styles. */ variant?: typeof ClipboardCopyVariant | 'inline' | 'expansion' | 'inline-compact'; - /** Copy button popover position. */ + /** Copy button tooltip position. */ position?: | TooltipPosition | 'auto' From 947c2faaa119d7e8a1a65c01dc6b8c226c803799 Mon Sep 17 00:00:00 2001 From: gitdallas Date: Thu, 13 Oct 2022 14:06:47 -0500 Subject: [PATCH 3/3] remove popover type from clipboardcopybutton --- .../src/components/ClipboardCopy/ClipboardCopyButton.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx index 43c5718be9f..8fe22538bea 100644 --- a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx +++ b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx @@ -2,7 +2,6 @@ import * as React from 'react'; import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon'; import { Button } from '../Button'; import { Tooltip, TooltipPosition } from '../Tooltip'; -import { PopoverPosition } from '../Popover'; export interface ClipboardCopyButtonProps extends Omit, HTMLButtonElement>, 'ref'> { @@ -25,7 +24,6 @@ export interface ClipboardCopyButtonProps /** Position of the copy button tooltip */ position?: | TooltipPosition - | PopoverPosition | 'auto' | 'top' | 'bottom'