From 599a8f3e1d528f2f600a7e5f075b7eed4d9d1ee0 Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Thu, 30 Mar 2023 21:49:36 -0400 Subject: [PATCH 1/2] feat(Table): deprecate Table and associated components --- .../CodeEditor/__test__/CodeEditor.test.tsx | 14 + .../__snapshots__/CodeEditor.test.tsx.snap | 35 +- packages/react-core/src/demos/CardDemos.md | 8 +- .../src/demos/Filters/FilterDemos.md | 2 +- .../examples/FilterAttributeSearch.tsx | 6 +- .../Filters/examples/FilterCheckboxSelect.tsx | 6 +- .../demos/Filters/examples/FilterFaceted.tsx | 6 +- .../examples/FilterMixedSelectGroup.tsx | 6 +- .../examples/FilterSameSelectGroup.tsx | 6 +- .../Filters/examples/FilterSearchInput.tsx | 6 +- .../Filters/examples/FilterSingleSelect.tsx | 6 +- .../src/demos/examples/Tabs/TabsAndTable.tsx | 10 +- packages/react-docs/package.json | 2 +- .../patternfly-docs/patternfly-docs.source.js | 2 +- .../demos/MastheadDemo/MastheadDemo.tsx | 2 + .../demos/SwitchDemo/SwitchDemo.tsx | 2 +- .../demos/TableDemo/TableCollapsibleDemo.tsx | 3 +- .../demos/TableDemo/TableComposableDemo.tsx | 58 +- .../TableDemo/TableCompoundExpandableDemo.tsx | 5 +- .../TableEditableCompoundExpandableDemo.tsx | 5 +- .../demos/TableDemo/TableEditableDemo.tsx | 6 +- .../demos/TableDemo/TableEmptyStateDemo.tsx | 4 +- .../demos/TableDemo/TableFavoritesDemo.tsx | 3 +- .../demos/TableDemo/TableRowClickDemo.tsx | 5 +- .../demos/TableDemo/TableRowWrapperDemo.tsx | 4 +- .../demos/TableDemo/TableSelectableDemo.tsx | 6 +- .../TableDemo/TableSimpleActionsDemo.tsx | 3 +- .../demos/TableDemo/TableSimpleDemo.tsx | 3 +- .../demos/TableDemo/TableSortableDemo.tsx | 5 +- ...TableSortableForCompoundExpandableDemo.tsx | 7 +- .../{TableComposable => Table}/Caption.tsx | 0 .../components/Table/DraggableRowWrapper.tsx | 2 +- .../Table/EditableSelectInputCell.tsx | 2 +- .../src/components/Table/EditableTextCell.tsx | 2 +- .../InnerScrollContainer.tsx | 0 .../OuterScrollContainer.tsx | 0 .../src/components/Table/RowWrapper.tsx | 2 +- .../src/components/Table/Table.tsx | 439 +++-- .../src/components/Table/TableTypes.tsx | 4 +- .../{TableComposable => Table}/Tbody.tsx | 0 .../{TableComposable => Table}/Td.tsx | 32 +- .../{TableComposable => Table}/Th.tsx | 28 +- .../{TableComposable => Table}/Thead.tsx | 0 .../{TableComposable => Table}/Tr.tsx | 4 +- .../src/components/Table/TreeRowWrapper.tsx | 2 +- .../src/components/Table/base/index.ts | 10 - .../src/components/Table/base/types.tsx | 14 +- .../examples/Table.md | 32 +- .../examples/TableActions.tsx | 6 +- .../examples/TableActionsOverflow.tsx | 6 +- .../examples/TableBasic.tsx | 6 +- .../examples/TableCellWidth.tsx | 6 +- .../examples/TableCompoundExpandable.tsx | 6 +- .../examples/TableControllingText.tsx | 6 +- .../examples/TableDraggable.tsx | 6 +- .../examples/TableEmptyState.tsx | 6 +- .../examples/TableExpandable.tsx | 6 +- .../examples/TableFavoritable.tsx | 6 +- .../examples/TableHoverable.tsx | 6 +- .../examples/TableMisc.tsx | 6 +- .../examples/TableMultipleStickyColumns.tsx | 6 +- .../examples/TableNestedExpandable.tsx | 6 +- .../examples/TableNestedHeaders.tsx | 6 +- .../examples/TableNestedStickyHeader.tsx | 6 +- .../examples/TableNestedTableExpandable.tsx | 10 +- .../examples/TableSelectable.tsx | 6 +- .../examples/TableSelectableRadio.tsx | 6 +- .../examples/TableSortable.tsx | 6 +- .../examples/TableSortableCustom.tsx | 6 +- .../examples/TableStickyColumn.tsx | 6 +- .../examples/TableStickyColumnsAndHeader.tsx | 6 +- .../examples/TableStriped.tsx | 6 +- .../examples/TableStripedExpandable.tsx | 6 +- .../examples/TableStripedMultipleTbody.tsx | 6 +- .../examples/TableStripedTr.tsx | 6 +- .../examples/TableTextModifiers.tsx | 6 +- .../examples/TableTree.tsx | 6 +- .../react-table/src/components/Table/index.ts | 16 +- .../TableComposable/TableComposable.tsx | 226 --- .../examples/TableRightStickyColumn.tsx | 153 -- .../src/components/TableComposable/index.ts | 9 - packages/react-table/src/components/index.ts | 1 - .../components/Table/Body.tsx | 5 +- .../components/Table/BodyCell.tsx | 2 +- .../components/Table/BodyWrapper.tsx | 6 +- .../components/Table/Header.tsx | 4 +- .../components/Table/HeaderCell.tsx | 2 +- .../src/deprecated/components/Table/Table.tsx | 299 ++++ .../components/Table/TableContext.ts | 4 +- .../components/Table/__tests__/Table.test.tsx | 14 +- .../__snapshots__/Table.test.tsx.snap | 0 .../components/Table/base/body-row.tsx | 17 +- .../components/Table/base/body.tsx | 4 +- .../components/Table/base/header-row.tsx | 16 +- .../components/Table/base/header.tsx | 10 +- .../deprecated/components/Table/base/index.ts | 4 + .../components/Table/base/resolve-row-key.ts | 2 +- .../Table/examples/LegacyTableActions.tsx | 8 +- .../Table/examples/LegacyTableBasic.tsx | 4 +- .../Table/examples/LegacyTableCellWidth.tsx | 3 +- .../LegacyTableCompoundExpandable.tsx | 3 +- .../examples/LegacyTableControllingText.tsx | 7 +- .../Table/examples/LegacyTableEmptyState.tsx | 2 +- .../Table/examples/LegacyTableExpandable.tsx | 3 +- .../Table/examples/LegacyTableFavoritable.tsx | 3 +- .../Table/examples/LegacyTableHoverable.tsx | 3 +- .../Table/examples/LegacyTableMisc.tsx | 2 +- .../Table/examples/LegacyTableSelectable.tsx | 3 +- .../examples/LegacyTableSelectableRadio.tsx | 3 +- .../Table/examples/LegacyTableSortable.tsx | 12 +- .../examples/LegacyTableSortableCustom.tsx | 3 +- .../Table/examples/LegacyTableStriped.tsx | 2 +- .../examples/LegacyTableStripedCustomTr.tsx | 2 +- .../examples/LegacyTableStripedExpandable.tsx | 3 +- .../examples/LegacyTableTextModifiers.tsx | 3 +- .../Table/examples/LegacyTableTree.tsx | 16 +- .../src/deprecated/components/Table/index.ts | 4 +- .../src/deprecated/components/index.ts | 2 +- packages/react-table/src/docs/demos/Table.md | 51 +- .../demos/table-demos/ColumnManagement.jsx | 5 +- .../src/docs/demos/table-demos/Compact.jsx | 6 +- .../demos/table-demos/CompoundExpansion.jsx | 10 +- .../demos/table-demos/ExpandCollapseAll.jsx | 6 +- .../demos/table-demos/SortableResponsive.jsx | 6 +- .../table-demos/StaticBottomPagination.jsx | 6 +- .../demos/table-demos/StickyFirstColumn.jsx | 6 +- yarn.lock | 1451 ++++++----------- 127 files changed, 1395 insertions(+), 2024 deletions(-) rename packages/react-table/src/components/{TableComposable => Table}/Caption.tsx (100%) rename packages/react-table/src/components/{TableComposable => Table}/InnerScrollContainer.tsx (100%) rename packages/react-table/src/components/{TableComposable => Table}/OuterScrollContainer.tsx (100%) rename packages/react-table/src/components/{TableComposable => Table}/Tbody.tsx (100%) rename packages/react-table/src/components/{TableComposable => Table}/Td.tsx (91%) rename packages/react-table/src/components/{TableComposable => Table}/Th.tsx (90%) rename packages/react-table/src/components/{TableComposable => Table}/Thead.tsx (100%) rename packages/react-table/src/components/{TableComposable => Table}/Tr.tsx (96%) delete mode 100644 packages/react-table/src/components/Table/base/index.ts rename packages/react-table/src/components/{TableComposable => Table}/examples/Table.md (90%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableActions.tsx (98%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableActionsOverflow.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableBasic.tsx (95%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableCellWidth.tsx (91%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableCompoundExpandable.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableControllingText.tsx (91%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableDraggable.tsx (95%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableEmptyState.tsx (90%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableExpandable.tsx (97%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableFavoritable.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableHoverable.tsx (92%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableMisc.tsx (95%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableMultipleStickyColumns.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableNestedExpandable.tsx (97%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableNestedHeaders.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableNestedStickyHeader.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableNestedTableExpandable.tsx (97%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableSelectable.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableSelectableRadio.tsx (93%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableSortable.tsx (96%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableSortableCustom.tsx (97%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableStickyColumn.tsx (95%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableStickyColumnsAndHeader.tsx (97%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableStriped.tsx (90%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableStripedExpandable.tsx (97%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableStripedMultipleTbody.tsx (95%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableStripedTr.tsx (91%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableTextModifiers.tsx (85%) rename packages/react-table/src/components/{TableComposable => Table}/examples/TableTree.tsx (97%) delete mode 100644 packages/react-table/src/components/TableComposable/TableComposable.tsx delete mode 100644 packages/react-table/src/components/TableComposable/examples/TableRightStickyColumn.tsx delete mode 100644 packages/react-table/src/components/TableComposable/index.ts rename packages/react-table/src/{ => deprecated}/components/Table/Body.tsx (97%) rename packages/react-table/src/{ => deprecated}/components/Table/BodyCell.tsx (98%) rename packages/react-table/src/{ => deprecated}/components/Table/BodyWrapper.tsx (86%) rename packages/react-table/src/{ => deprecated}/components/Table/Header.tsx (88%) rename packages/react-table/src/{ => deprecated}/components/Table/HeaderCell.tsx (95%) create mode 100644 packages/react-table/src/deprecated/components/Table/Table.tsx rename packages/react-table/src/{ => deprecated}/components/Table/TableContext.ts (60%) rename packages/react-table/src/{ => deprecated}/components/Table/__tests__/Table.test.tsx (98%) rename packages/react-table/src/{ => deprecated}/components/Table/__tests__/__snapshots__/Table.test.tsx.snap (100%) rename packages/react-table/src/{ => deprecated}/components/Table/base/body-row.tsx (85%) rename packages/react-table/src/{ => deprecated}/components/Table/base/body.tsx (94%) rename packages/react-table/src/{ => deprecated}/components/Table/base/header-row.tsx (88%) rename packages/react-table/src/{ => deprecated}/components/Table/base/header.tsx (87%) create mode 100644 packages/react-table/src/deprecated/components/Table/base/index.ts rename packages/react-table/src/{ => deprecated}/components/Table/base/resolve-row-key.ts (92%) diff --git a/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx b/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx index f8927aa6e3a..544d5451ea7 100644 --- a/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/__test__/CodeEditor.test.tsx @@ -2,6 +2,20 @@ import React from 'react'; import { render } from '@testing-library/react'; import { CodeEditor, Language } from '../CodeEditor'; +Object.defineProperty(window, 'matchMedia', { + writable: true, + value: jest.fn().mockImplementation(query => ({ + matches: false, + media: query, + onchange: null, + addListener: jest.fn(), // Deprecated + removeListener: jest.fn(), // Deprecated + addEventListener: jest.fn(), + removeEventListener: jest.fn(), + dispatchEvent: jest.fn(), + })), +}); + describe('CodeEditor', () => { beforeAll(() => { window.HTMLCanvasElement.prototype.getContext = () => ({} as any); diff --git a/packages/react-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap b/packages/react-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap index 3edfa6df0dd..395479988f5 100644 --- a/packages/react-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap +++ b/packages/react-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap @@ -142,7 +142,7 @@ exports[`CodeEditor matches snapshot with all props 1`] = ` >
@@ -199,6 +199,11 @@ exports[`CodeEditor matches snapshot with all props 1`] = ` class="view-rulers" role="presentation" /> +