From 916b85c9541b708201cd997bea06a4b5f0763e34 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Wed, 7 Jun 2023 13:53:04 -0400 Subject: [PATCH 1/3] fix(Popover): reverted appendTo to document body --- packages/react-core/src/components/Popover/Popover.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-core/src/components/Popover/Popover.tsx b/packages/react-core/src/components/Popover/Popover.tsx index 093e569f456..ee87b1e44c2 100644 --- a/packages/react-core/src/components/Popover/Popover.tsx +++ b/packages/react-core/src/components/Popover/Popover.tsx @@ -233,7 +233,7 @@ export const Popover: React.FunctionComponent = ({ alertSeverityVariant, alertSeverityScreenReaderText, footerContent = null, - appendTo = 'inline', + appendTo = () => document.body, hideOnOutsideClick = true, onHide = (): void => null, onHidden = (): void => null, From 0629597cf733fae90b5f202d8b1fb10610217c4f Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Wed, 7 Jun 2023 14:00:59 -0400 Subject: [PATCH 2/3] Updated verbiage in example file --- .../react-core/src/components/Popover/examples/Popover.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/react-core/src/components/Popover/examples/Popover.md b/packages/react-core/src/components/Popover/examples/Popover.md index 7eaa02398c3..dd3479fdc16 100644 --- a/packages/react-core/src/components/Popover/examples/Popover.md +++ b/packages/react-core/src/components/Popover/examples/Popover.md @@ -14,10 +14,7 @@ import BullhornIcon from '@patternfly/react-icons/dist/esm/icons/bullhorn-icon'; ## Examples -By default, the `appendTo` prop of the popover will append it to the parent element. However, in some cases, the popover might be too big for the parent and not fully visible. To solve this issue, users have two options: - -1. Add the prop `appendTo={() => document.body}` to append the popover to the document body instead of the parent element. -2. Increase the z-index of the parent element to be higher than the z-index of the element that is hiding the popover. +By default, the `appendTo` prop of the popover will append to the document body in order to avoid the popover content not being fully visible. Another option is to increase the z-index of the element the popover is appended to to be higher than the z-index of the element that is hiding the popover. ### Basic From 221654891e7eb4b0a21cd99f4d0ef7e3c6d5da0d Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Thu, 8 Jun 2023 09:10:16 -0400 Subject: [PATCH 3/3] Bumped reactcore version --- packages/react-integration/demo-app-ts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-integration/demo-app-ts/package.json b/packages/react-integration/demo-app-ts/package.json index 0803747d73c..2c39c7a34ff 100644 --- a/packages/react-integration/demo-app-ts/package.json +++ b/packages/react-integration/demo-app-ts/package.json @@ -9,7 +9,7 @@ "serve:demo-app": "node scripts/serve" }, "dependencies": { - "@patternfly/react-core": "^5.0.0-prerelease.2", + "@patternfly/react-core": "^5.0.0-prerelease.3", "react": "^18", "react-dom": "^18", "react-router": "^5.3.3",